Fix nil tray title crash (#12352)

* Add check for title_ being nil * remove print stub
2018-03-19 10:49:39 -05:00 · 2018-03-19 10:49:39 -05:00 · 9599615b23
commit 9599615b23
parent 6b80865bfe
1 changed files with 6 additions and 1 deletions
--- a/atom/browser/ui/tray_icon_cocoa.mm
+++ b/atom/browser/ui/tray_icon_cocoa.mm
@ -230,8 +230,13 @@ const CGFloat kVerticalTitleMargin = 2;
    return;
  }

+  // check title_ being nil
+  NSString *title = @"";
+  if (title_)
+    title = title_;
+
  attributedTitle_.reset([[NSMutableAttributedString alloc]
-                             initWithString:title_
+                             initWithString:title
                                 attributes:attributes]);

  //NSFontAttributeName:[NSFont menuBarFontOfSize:0],