mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #11981 from electron/set-tray-highlightmode

Browse source 
no longer support bool param for setHighlightMode
This commit is contained in:
John Kleinschmidt 2018-02-20 12:57:52 -05:00 committed by GitHub
commit dcaff20cfd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
atom/browser/api/atom_api_tray.cc
View file

@ -39,18 +39,6 @@ struct Converter<atom::TrayIcon::HighlightMode> {
return true;
}
}
// Support old boolean parameter
// TODO(kevinsawicki): Remove in 2.0, deprecate before then with warnings
bool highlight;
if (ConvertFromV8(isolate, val, &highlight)) {
if (highlight)
*out = atom::TrayIcon::HighlightMode::SELECTION;
else
*out = atom::TrayIcon::HighlightMode::NEVER;
return true;
}
return false;
}
};