Commit graph

10375 commits

Author SHA1 Message Date
Adomas Venčkauskas
6d82ac3970 Fix window.name being unset when loading include.js. Closes #1645 2019-02-25 11:45:42 +02:00
Dan Stillman
6929125708 Updates locales from Transifex and merge new English strings 2019-02-24 00:11:27 -05:00
Dan Stillman
df494415d7 Add "Move to Top" option in creator type menu
Drag-and-drop will be a better solution, but this should be useful in
some situations (and, unlike drag-and-drop, can be accessible).
2019-02-24 00:01:58 -05:00
Dan Stillman
945c413c42 Closes #1644, Allow selecting multiple items with zotero://select
This adds selectItems() to ZoteroPane and collectionTreeView and removes
the ancient, unused 'expand' argument to selectItem(), which didn't
really make sense there. It also includes a new
itemTreeView::ensureRowsAreVisible() that tries to scroll to an
appropriate place (or, better yet, not scroll at all) given the
specified rows and page size.
2019-02-23 17:35:09 -05:00
Dan Stillman
4d3625f101 Fix tests after removing RECOGNIZE_URL 2019-02-19 04:37:22 -05:00
Dan Stillman
663acccbc2 Tweak debugging for missing-key sync error 2019-02-19 04:10:25 -05:00
Dan Stillman
1061893998 "Attachment Content" search improvements
- Fix incorrect results for ANY search with multiple "Attachment
  Content" conditions and no other conditions
- Dramatically speed up single-word searches by avoiding unnecessary
  text scans (which probably addresses #1595)
- Clean up code
2019-02-19 04:10:25 -05:00
Dan Stillman
977eb8d965 Fix "Show Automatic Tags" in tag selector 2019-02-18 15:00:18 -05:00
Dan Stillman
950e9de80f Make starting from Mac disk image fatal 2019-02-18 14:36:53 -05:00
Dan Stillman
0ea03ce72c Switch to services domain for recognizer requests
The recognizer endpoint can be customized by setting either
recognize.url (used directly) or services.url (used with a 'recognizer/'
suffix).
2019-02-18 14:30:54 -05:00
Adomas Venčkauskas
4a61cffc99 Merge branch 'Juris-M-zmaster-test-implicit-update' 2019-02-13 10:18:26 +02:00
Frank Bennett
2c136ffbb0 Add test of multiple new insertions with implicit update on the first 2019-02-13 10:18:05 +02:00
Frank Bennett
bffbe00399 Test of implicit citation update 2019-02-13 10:17:58 +02:00
Adomas Venčkauskas
6e0c66a1ee Merge pull request #1642 from Juris-M/zmaster-set-process-indices 2019-02-13 08:44:19 +02:00
Frank Bennett
30b6bf6da7 Set processIndices for each processor return 2019-02-13 08:40:50 +02:00
Adomas Ven
9ddd4dda3a
Merge pull request #1639 from Juris-M/zmaster-test-bib-update
Test for bibliography sort update on change to item
2019-02-12 10:32:04 +02:00
Adomas Venčkauskas
6672efef0a Revert "Revert "Update citeproc-js to 1.1.215""
This reverts commit db56f002a5.
2019-02-12 10:30:33 +02:00
Adomas Venčkauskas
9410094ad8 Update citeproc usage logic. See #1638 2019-02-12 10:30:24 +02:00
Adomas Venčkauskas
a931c2ba51 Tidy up Integration.Session.addCitation() 2019-02-11 11:01:53 +02:00
Adomas Venčkauskas
0539deb58b Make sure citation edits are not treated as citation duplication 2019-02-11 11:01:01 +02:00
Adomas Venčkauskas
6ee87056b1 Fix integration previewFn providing wrong citationsPost data
See #1638
2019-02-11 10:45:07 +02:00
Frank Bennett
0e18c5f1de Test for bibliography sort update on change to item 2019-02-10 11:07:10 +09:00
Adomas Venčkauskas
de4ce57768 Fix wrong httpIntegrationClient #convert call signature 2019-02-08 13:03:27 +02:00
Dan Stillman
db56f002a5 Revert "Update citeproc-js to 1.1.215"
This reverts commit d301fb6e43.
2019-02-06 14:59:27 -05:00
Dan Stillman
ff008d4bc1 Update locales from Transifex 2019-02-05 21:36:51 -05:00
Dan Stillman
d301fb6e43 Update citeproc-js to 1.1.215 2019-02-03 05:08:13 -05:00
Dan Stillman
98aa71655b RunJS tweaks
- Display result string directly instead of running through varDump()
- Better detect use of `await`
- Fix ESLint error
2019-02-02 14:17:14 -05:00
Dan Stillman
3942b0e0d5 Fix a tag selector test after b1fad505d7 2019-01-30 04:44:16 -05:00
Dan Stillman
b1fad505d7 Fix sorting of colored tags after Reactification
Regressed to alphabetic sorting instead of number-key sorting
2019-01-29 22:18:49 -05:00
Dan Stillman
2d71b13ce0 Fix some spurious failures in PDF retrieval test 2019-01-29 07:35:39 -05:00
Dan Stillman
c2a637472e Fix foreign key constraint error for collections with all-numeric keys
This was like a lottery where instead of winning something your library
stopped syncing.
2019-01-29 05:09:00 -05:00
Adomas Venčkauskas
8bd35ee0d4 Fixes tag selector toggling via hotkey leaving gray area. Closes #1629 2019-01-28 16:35:20 +02:00
Dan Stillman
8b4bb62efc Don't load linked URLs during import
Regression from 5a6a772ca2, I think
2019-01-26 00:20:26 -05:00
Dan Stillman
ff579d411a Update issue template 2019-01-25 17:07:14 -05:00
Dan Stillman
59a7017dad
Merge pull request #1628 from wbt/patch-1
Create ISSUE_TEMPLATE.md
2019-01-25 16:56:02 -05:00
wbt
b1ead25135
Create ISSUE_TEMPLATE.md 2019-01-25 16:52:56 -05:00
Adomas Venčkauskas
a532af6114 Fix sync client tests that depend on stubbing concurrentCaller Promise.
Regression since f5c4fb06
2019-01-22 13:49:00 +02:00
Adomas Venčkauskas
f59f3c5f7e Fix a failing /connector/updateSession test (regr 90a70f7) 2019-01-22 12:25:15 +02:00
Dan Stillman
8f58560751 Run JavaScript: Automatically switch to async mode if await is used
This will allow examples from the documentation to work without the
async option being explicitly chosen.
2019-01-22 04:44:32 -05:00
Dan Stillman
39eb2962a6 Run JavaScript: Support await and show errors
Adds a "Run as async function" checkbox that wraps the code in an async
function and displays the value returned by a `return` statement.

This also properly catches errors and displays them in the results pane.
2019-01-22 01:29:05 -05:00
Dan Stillman
f918e27e46 Add window for running arbitrary privileged JavaScript
This is a replacement for the Execute JS extension that could be used
with Zotero for Firefox.

To enable, go to the Config Editor in the Advanced pane of the
preferences and set devtools.chrome.enabled to true, and then restart
Zotero. A "Run JavaScript" option will appear in the Tools menu.
2019-01-22 00:12:34 -05:00
Dan Stillman
eb5d28b626
Merge pull request #1606 from adomasven/feature/reactify
Reactified Tag Selector
2019-01-21 04:07:28 -05:00
Adomas Venčkauskas
0e8788aca1 Update tag selector styling for Windows 2019-01-21 11:01:33 +02:00
Adomas Venčkauskas
fc41326319 Update tag selector styling for macOS 2019-01-21 11:01:33 +02:00
Adomas Venčkauskas
f5c4fb06e1 Ensure high-dpi icons are loaded in React components 2019-01-21 11:01:32 +02:00
Adomas Venčkauskas
90a70f7c31 Fix a /saveItems session management race condition bug 2019-01-21 11:01:32 +02:00
Adomas Venčkauskas
a24cada451 React Tag Selector polish, i18n and tests
- Added icon-button UI code for the menubutton
- Upgrade to React 16 to allow non-standard attrs, such as `tooltiptext`
to support XUL tooltips
- Add i18n support for React UI elements
- Update tests for reactified tag selector
2019-01-21 11:01:27 +02:00
Dan Stillman
18054c4bc4 Add preliminary eslint config
None of our existing files match these rules perfectly, but they're
something to aspire to. I've only checked a handful of files, so there
may be some unwanted or missing rules, and there are definitely some
missing globals.

Some of our more common spacing inconsistencies are currently set as
warnings rather than errors so they can be easily disabled to see more
dangerous stuff.

At some point we can use --fix to correct many problems in existing
files, but we should go through existing pull requests before doing that
to avoid conflicts. Eventually, we'll want to enforce linting as part of
a pre-push hook and CI.
2019-01-21 03:36:16 -05:00
Philipp Zumstein
97e53c5230 Fix some typos found by codespell (#1570)
$ codespell --skip="./.git,./styles,./translators,./chrome/locale,./resource,./chrome/content/zotero/xpcom/xregexp,./chrome/content/zotero/xpcom/rdf,./chrome/content/zotero/xpcom/citeproc.js,./test/resource,./node_modules" -q 2 -i 3 -w
2019-01-20 20:39:27 -05:00
Dan Stillman
4861b2e841 Update citeproc-js to 1.1.212 2019-01-19 02:38:56 -05:00