Commit graph

15007 commits

Author SHA1 Message Date
Abe Jellinek
bc2c7956db FeedProcessor: Handle dc:creator in Atom feeds
Fixes #4857
2024-11-20 10:05:39 -05:00
windingwind
f5b653e7fd
Add item tree and info box refresh API (#4850)
For APIs that have lifecycle control, e.g. item
pane section, the `update` is passed in the init
hook.
For APIs without lifecycle, we can't pass a value.
Instead, we provide a method to refresh in the API
instance.
2024-11-20 08:35:56 -05:00
windingwind
8e2ec86e56
Fix duplicate item pane when switching to library tab before reader is loaded (#4838)
fix: #4531
2024-11-20 08:09:42 -05:00
Abe Jellinek
e3f2f4455b
Fix sidenav buttons not getting :active state (#4853) 2024-11-20 07:46:37 -05:00
Dan Stillman
dc39ca3756 Don't detect MP3 with embedded image as JPEG
https://forums.zotero.org/discussion/119725/z-imports-mp3s-as-images-if-image-is-embedded-in-the-file

We were looking for "JFIF" anywhere in the sample, which could include
the ID3 tag.

(An upcoming change will also have it just trust the file extension when
one is available.)
2024-11-19 07:12:52 -05:00
Martynas Bagdonas
75fb301f0a
Add pref to control auto-turnoff of note, text, image annotation tools (#4851) 2024-11-19 05:47:43 -05:00
Dan Stillman
ddacfc0b8a Strip invalid quotes around charset in feed responses
E.g., https://bmcmedethics.biomedcentral.com/articles/most-recent/rss.xml
2024-11-19 05:03:36 -05:00
Dan Stillman
dc47650eb3 Update locales from Transifex 2024-11-15 03:54:01 -05:00
Dan Stillman
1a4ecff347 Update English strings for Transifex 2024-11-15 03:48:52 -05:00
Dan Stillman
3284cb461e Update reader submodule 2024-11-15 03:47:15 -05:00
abaevbog
7f57a43f27
context pane notes list focus handling edits (#4837)
- fix the issue of focus not landing on search field of the notes
pane when it is opened on tab from the reader
- shift-tab from the sidenav when notes pane is opened will focus
the search input as well, instead of the last focusable
node in the pane
- tab from a note-row in the list of notes will focus the sidenav
- shift-tab from a note-row will focus the header of the collapsible-section
of the row

Per https://github.com/zotero/zotero/pull/4235#issuecomment-2472397642
2024-11-15 03:29:01 -05:00
abaevbog
e3c18ee1c7
fix "anyField" conflicting with other conditions (#4845)
Fix the glitch where having anyField search condition
along with any other condition would return an empty
result set if joinMode="any".
This would happen due to a conflict between conditions
caused by wrapping "anyField" condition set into a quickSearch
block, which enforces "AND" operator between conditions.

Fixes: #4830
2024-11-15 02:07:11 -05:00
abaevbog
14c2d58e91
qf: remove sizetopopup from locator popup (#4846)
This may help with the issue of locator popup sometimes
not being properly rendered.

Also, it allows the popup to have a proper width on
windows when "Always show scrollbar" setting is on.

Addresses: #4814
Addresses: #4805
2024-11-15 01:11:15 -05:00
Abe Jellinek
f001123c9b
Libraries and Collections: Fix Add button in reader tabs (#4844)
And:

- Rework a few ZP functions to take items arrays instead of always
  acting on selected items
- Move string to Fluent
- Build entire Add to Collection menu programmatically
2024-11-15 01:08:37 -05:00
windingwind
5b89ceb15e Fix attachment preview unnecessary background color 2024-11-15 00:19:00 -05:00
windingwind
6270311b24 Fix attachment preview button background color 2024-11-15 00:19:00 -05:00
Dan Stillman
a6c178dfe8 Update reader submodule 2024-11-13 00:24:07 -05:00
Dan Stillman
c1bef57123 "Ctrl-Enter" → "Ctrl-Return" in macOS comment 2024-11-13 00:23:23 -05:00
abaevbog
e94789c8db
Make sidenav buttons keyboard accessible (#4235)
- Section buttons, Locate, and Notes in the sidenav are focusable
- itemPane section buttons are combined into one focusable
group. Those buttons by themselves don't mean anything in
the context of keyboard navigation as they just scroll
to the section in the itemPane. In fact, having info,
abstract, attachments, etc. focusable and announceable by
screen readers is just confusing. However, we do want the group
of those buttons to be focusable to switch back to
zotero-context-pane-item-deck from zotero-context-pane-notes-deck
if the notes button in the sidenav is pressed.
- sidenav can be reached by tabbing into it from the end of itemPane
or via shift-tab from the focused tab
- sidenav buttons can be navigated with up/down arrows
- notes list in the context pane can be activated via the button in the
sidenav and navigated via up/down arrows
- use command vs onclick listener for notes list context menus to work
with keyboard-triggered clicks as well
- focus itemPane when tabs are switched in sidenav
2024-11-13 00:20:21 -05:00
Abe Jellinek
d75d638337 Update ISBN ranges 2024-11-12 11:45:12 -05:00
Abe Jellinek
5e84944cd6 Ctrl-Enter handler: Don't intercept two-finger taps
Fixes #4834
2024-11-12 10:33:00 -05:00
abaevbog
7fa00d1cfd
Don't clear quick search after removal from collection (#4618)
Do not try to re-select a previously selected item
if it was filtered out from itemTree, e.g. after
it was removed from currently selected collection.
Otherwise, quick search gets cleared in an attempt to
re-select the item.

Fixes: #4616
2024-11-12 00:28:08 -05:00
windingwind
c937b36e25
Fix child attachment shows up in item pane after being moved to trash (#4777)
fix: #4770
2024-11-12 00:14:15 -05:00
Tom Najdek
055fbb68fc
Import Mendeley notebooks (#4829) 2024-11-12 00:13:17 -05:00
Franklin Pezzuti Dyer
a4e89e62f2
Add ellipsis to 'Install Browser Connector' menu item (#4826)
fixes #4693
2024-11-11 11:29:16 -05:00
windingwind
aec6e61cb3 Add ItemPaneManager.registerInfoRow API
Unify plugin API classes

Add info box custom row API tests

Refactor itemBox.js create element

Wrap hooks in API for safe call

Add test for item tree api and hook error handling

Remove try/catch from #4816

Move plugin API definitions to xpcom/pluginAPI
2024-11-11 11:27:47 -05:00
windingwind
347caaff4c Rename itemBox > infoBox
Following the discussion in #4114
2024-11-11 11:27:47 -05:00
windingwind
28e3c7b47f Fix notifier.js eslint errors 2024-11-11 11:27:47 -05:00
Abe Jellinek
5152d2c7ff Update reader submodule 2024-11-08 11:49:24 -05:00
Dan Stillman
4ca3843ce7 Prevent auth failures for Zotero Storage requests after relinking
If you unlinked your sync account and then relinked, the ZFS storage
controller would still have the old API key and file-sync requests would
fail. Since that was never supposed to be possible, it resulted in
"Group with libraryID 1 does not exist" errors during file syncing until
you restarted the app.
2024-11-08 03:19:41 -05:00
Dan Stillman
7c91f37348 Set new API key on each setCredentials() call in sync preferences tests 2024-11-08 03:18:44 -05:00
abaevbog
e9a19cb7a1
Update tab titles independently of the reader (#4813)
Move handling of tabs' renaming when an item is
modified from Reader into Zotero_Tabs, so that the titles of
unloaded tabs can get properly renamed.

Have the Reader and Zotero_Tabs share Zotero.Item#getTabTitle()
to handle title updates in both tabs and standalone reader windows.

Fixes: #4646
2024-11-08 02:01:43 -05:00
Abe Jellinek
9f8c5c8581
Add support for importing KOReader & Calibre annotations (#4780) 2024-11-08 01:16:10 -05:00
abaevbog
d3456b050a
Allow quicksearch to stretch when there is space in the middle pane (#4828)
Per https://forums.zotero.org/discussion/119312/search-window-in-zotero-7-is-too-small

Also, have spinner always occupy space, so that it does not
push quickSearch out of the bounds of the middle pane
when it is very narrow. Respectively,
make min-width of quicksearch a bit smaller.
2024-11-08 00:56:16 -05:00
abaevbog
5b2e666f4f
scroll to pivot row on arrowUp/Down in duplicates (#4822)
When items are selected, itemTree scrolls to them. Depending on the
arrangement of items, it will often default to scrolling to
the top-most item in the selection, which is not the focused row
in case of duplicates view. To scroll to focused row without
unnecessary scrolling or items visibly jumping to one row and then
another, added option to skip scrolling in itemTree.selectItems.
2024-11-08 00:13:57 -05:00
abaevbog
bc62bbfdda
do not handle tab out of reader iframe in window (#4824)
Only move focus out of the reader iframe on tab/shift-tab
if the reader instance is opened within a tab, meaning the
sync button and the contextPane exist. If the reader
is opened in a standalone window, do nothing.

Fixes: #4823
2024-11-08 00:13:36 -05:00
Dan Stillman
913c500733 Update version 2024-11-07 01:11:13 -05:00
Dan Stillman
1b43521786 Update reader submodule 2024-11-07 01:05:55 -05:00
abaevbog
e2905b22ad
arrowUp/down in duplicates view will select the set (#4800)
When duplicates collectionTreeRow is selected, arrowUp/down within
itemTree will select the entire previous/next set of duplicate items.

Per discussion based on https://forums.zotero.org/discussion/119217/bug-zotero-7-beta-duplicates-collection-navigation-via-arrow-keys
2024-11-06 23:08:16 -05:00
Abe Jellinek
682cceca2d Pass imported-URL attachment URL to reader (#4820) 2024-11-06 23:02:50 -05:00
Abe Jellinek
7f26f246e7 ZoteroPrintChild: Forward zoteroPrint() options (#4820) 2024-11-06 23:02:43 -05:00
abaevbog
c567905bf6
fix color scheme getting reset during printing (#4807)
LightweightThemeConsumer interacts with the color scheme,
so disabling it prevents the color scheme from changing
whenever zoteroPrint runs.

Fixes: #4782
2024-11-06 23:00:44 -05:00
Abe Jellinek
67505f3960 Don't show '0000' on invalid date in reader title
Same logic used for attachment renaming and the item tree Year column.

Fixes #4817
2024-11-06 13:54:03 -05:00
abaevbog
bd8cae6fdd
qf: show recently modified notes when empty input (#4797)
Fixes: #4771
2024-11-06 08:38:05 -05:00
Abe Jellinek
17f003df0f
Item box: Wrap all fields (#4802) 2024-11-06 08:37:38 -05:00
windingwind
51f2c76d82 Ensure custom column renderCell returns element 2024-11-06 07:23:53 -05:00
windingwind
0db1bae009 Fix item tree custom dataProvider break interface 2024-11-06 07:23:53 -05:00
Martynas Bagdonas
30024487f3 Work around contenteditable not updating Edit menu in reader and notes
This seems to be a Firefox bug that exists even in Firefox 132.0a1 (2024-09-29).
Note that right-clicking to open the context menu on a contenteditable element also triggers an update to the Edit menu.

The fix updates all Edit menu options except Redo, which cannot be enabled due to ProseMirror modifying the contenteditable state after each change.

Partial fix for #3398
2024-10-31 11:12:03 +00:00
Martynas Bagdonas
7c8e672f2f Enable text actions context menu across all note-editor text inputs 2024-10-31 11:09:04 +00:00
Martynas Bagdonas
e202924324 Add File, Edit and Window menus to note editor window 2024-10-31 11:06:29 +00:00