mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Prevent auth failures for Zotero Storage requests after relinking

Browse source 
If you unlinked your sync account and then relinked, the ZFS storage
controller would still have the old API key and file-sync requests would
fail. Since that was never supposed to be possible, it resulted in
"Group with libraryID 1 does not exist" errors during file syncing until
you restarted the app.
This commit is contained in:
Dan Stillman 2024-11-08 03:15:21 -05:00
parent 7c91f37348
commit 4ca3843ce7
2 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
chrome/content/zotero/xpcom/sync/syncRunner.js
View file

@ -837,7 +837,6 @@ Zotero.Sync.Runner_Module = function (options = {}) {
},
// TODO: Call on API key change
this.resetStorageController = function (mode) {
delete _storageControllers[mode];
},
@ -1672,6 +1671,7 @@ Zotero.Sync.Runner_Module = function (options = {}) {
this.deleteAPIKey = Zotero.Promise.coroutine(function* (){
this.resetStorageController('zfs');
var apiKey = yield Zotero.Sync.Data.Local.getAPIKey();
var client = this.getAPIClient({apiKey});
Zotero.Sync.Data.Local.setAPIKey();

20
test/tests/preferences_syncTest.js
View file

@ -90,6 +90,26 @@ describe("Sync Preferences", function () {
assert.equal(doc.getElementById('sync-authorized').getAttribute('hidden'), 'true');
});
it("should reset the storage controller when unlinking", async function () {
await setCredentials("Username", "correctPassword");
await assert.eventually.equal(Zotero.Sync.Data.Local.getAPIKey(), apiKey);
var options = {
apiClient: Zotero.Sync.Runner.getAPIClient({ apiKey })
};
var controller = Zotero.Sync.Runner.getStorageController('zfs', options);
var apiKey1 = controller.apiClient.apiKey;
await win.Zotero_Preferences.Sync.unlinkAccount(false);
await setCredentials("Username", "correctPassword");
options = {
apiClient: Zotero.Sync.Runner.getAPIClient({ apiKey })
};
controller = Zotero.Sync.Runner.getStorageController('zfs', options);
assert.notEqual(controller.apiClient.apiKey, apiKey1);
});
it("should not unlink on pressing cancel", function* () {
yield setCredentials("Username", "correctPassword");