Commit graph

8158 commits

Author SHA1 Message Date
Dan Stillman
3829f12603 Speed up renaming of colored tags 2019-03-30 10:35:03 -04:00
Dan Stillman
6a2611c9c6 Additional logging for teleporting collections
https://forums.zotero.org/discussion/comment/328917/#Comment_328917
2019-03-30 07:58:15 -04:00
Dan Stillman
ee3955f6f7 Fix font size in search bars when set to non-small sizes
Reactification regression
2019-03-29 06:35:35 -04:00
Dan Stillman
038119c481
Merge pull request #1668 from Juris-M/zmaster
Handle handingindent return from citeproc-js as boolean
2019-03-29 02:53:06 -04:00
Dan Stillman
732cd01073 Update citeproc-js to 1.1.228 2019-03-29 02:23:51 -04:00
Dan Stillman
3126c58d30 Tag selector UI tweaks
- Don't cut off bottom of tags on Windows
- Fix appearance of search bar on Windows/Linux
- Fix cancel button on Windows/Linux
- Don't cut off right-hand pane of bottom bar when narrowing pane
2019-03-29 01:46:54 -04:00
Dan Stillman
d9cee322cd Tag selector performance overhaul
- Use react-virtualized to render tags on demand, reducing the number
  of DOM elements from potentially tens of thousands to <100. This
  requires tags to be absolutely positioned, so sizing and
  positioning need to be precomputed rather than relying on CSS.
- Avoid unnecessary refreshes, speed up tag retrieval, and optimize
  sorting
- Debounce reflowing when resizing tag selector

Also:

- Scroll to top when changing collections
- Allow tags to take up full width of tag selector without truncation

Closes #1649
Closes #281
2019-03-28 06:28:34 -04:00
Dan Stillman
69ff8ac1b6 Search anywhere within tag for tag selector filter
Follow-up to 62ea7e970a, and I think in line with the pre-React
behavior
2019-03-27 07:49:59 -04:00
Dan Stillman
b248d28992 Revert "Update citeproc-js to 1.1.226"
This reverts commit a5c7955670.

We need to push out a release to fix some bugs, so let's leave this out
for now.
2019-03-27 07:26:15 -04:00
Dan Stillman
197397ff7a Fix error dragging items if tag selector was closed at startup 2019-03-27 07:23:41 -04:00
Dan Stillman
71f9420cff Fix linked-file rename pref when retrieving metadata
Due to a typo in d0f7fd6df7, linked files were still being renamed even
with the pref off if metadata was found for the file. The test I added
was only for adding a file to an existing item, which didn't trigger
metadata retrieval.

This also adds a hook for stubbing the actual PDF recognition process so
we can test certain behaviors without making HTTP requests.
2019-03-27 06:43:07 -04:00
Dan Stillman
a5c7955670 Update citeproc-js to 1.1.226 2019-03-27 03:45:03 -04:00
Frank Bennett
0036e0a1e1 Assume citeproc-js returns hangingindent as a boolean 2019-03-21 21:27:28 +09:00
Dan Stillman
6c86121120 Use onChange instead of onInput for Search component
React uses onChange for form elements (and complains if it's absent)
even when the underlying event is oninput.
2019-03-21 04:51:32 -04:00
Dan Stillman
09b7fa8a6d Fix time zone handling of CSL JSON export of date-only access date
Since 9c0f5998a3, depending on your timezone the day could be off by
one if the access date didn't have a timestamp (so only for manual
entries or imports).
2019-03-20 21:52:57 -04:00
Dan Stillman
62ea7e970a Don't use RegExp for tag filter (Reactification regression)
Using a regexp meant that an invalid regexp pattern would crash the tag
selector, and even if we caught that it would produce unexpected results
for some searches (e.g., anything with a period).
2019-03-20 07:15:55 -04:00
Dan Stillman
42667e7090 Switch to Search component in tag selector and support X/Esc to clear
This moves debouncing into the search component and adds cancel behavior
from the XUL search textbox. For now, this uses the X button from
Firefox.
2019-03-20 07:15:55 -04:00
Dan Stillman
bf4deeff8f Map podcast to CSL broadcast
Closes citation-style-language/zotero-bits#83
2019-03-19 20:08:17 -04:00
Dan Stillman
67febb2f45 Clarify debug lines for tag selector updating 2019-03-18 04:52:48 -04:00
Dan Stillman
b2d5b9a2f3 Fix incorrect call in 3463e3b5ab 2019-03-17 19:15:34 -04:00
Dan Stillman
3463e3b5ab Don't initialize tag selector if closed at startup (React regression)
Even after cdf9d7ff32, the tag selector was still being initialized if
it was closed at startup, which meant that keeping it closed didn't fix
performance problems in large libraries. This hopefully finally brings
the tag selector in line with pre-Reactification behavior.

This also moves initIntlStrings() logic to Zotero.Intl so that strings
are accessible from React components in separate windows, and it moves
container initialization to ZoteroPane since most of what it does will
need to interact with ZoteroPane anyway.
2019-03-17 05:11:07 -04:00
Dan Stillman
c44b864923 Fix error switching creator field mode if a creator is open 2019-03-16 03:21:10 -04:00
Dan Stillman
9d564f022d Fix creator overwrite using move option on open field
https://forums.zotero.org/discussion/76423/bug-when-moving-authors-to-top-in-beta
2019-03-16 01:53:35 -04:00
Dan Stillman
cdf9d7ff32 Unregister tag selector when closed
This restores the pre-Reactification behavior.
2019-03-15 15:42:22 -04:00
Dan Stillman
94ccba45b9 Avoid unnecessary tag queries (regression from React tag selector) 2019-03-15 12:46:27 -04:00
Dan Stillman
cd55aebbc0 Fix detection of WebDAV settings on Windows and Linux
Fixes #1291, hopefully for real this time
2019-03-13 02:45:31 -04:00
Dan Stillman
435e628973 Fix high CPU during file syncing (regression from React tag selector) 2019-03-12 06:45:25 -04:00
Dan Stillman
99cfddaf18 Add separator above "Delete All Automatic Tags in This Library…" 2019-03-09 16:28:20 -05:00
Dan Stillman
c735423996 Don't show PDF icon for linked-URL PDFs (regression from 8cd5b09053) 2019-03-08 20:23:00 -05:00
Dan Stillman
c7698a2324 Restore disabling of automatic tag deletion option when no such tags 2019-03-07 04:08:45 -05:00
Dan Stillman
85c6ec0ca4 Actually change code that deletes automatic tags
Follow-up to d7dc5670d5
2019-03-07 03:35:37 -05:00
Adomas Venčkauskas
72fb67d15b Restore "Delete All Automatic Tags" menu option for tag selector. Closes #1660 2019-03-06 16:22:05 +02:00
Adomas Venčkauskas
d01038b13b Fix missing react localization in tests. Closes #1661 2019-03-06 14:35:38 +02:00
Adomas Venčkauskas
e8f186479f Address tag selector tests race conditions. Addresses #1659 2019-03-06 13:13:40 +02:00
Dan Stillman
9cdfe8e01c Update submodules 2019-03-05 21:17:14 -05:00
Dan Stillman
123f82571e Update locales from Transifex 2019-03-05 21:15:27 -05:00
Dan Stillman
ae9c54b76d Fix "Move to Top" logic for creators 2019-03-05 19:15:50 -05:00
Dan Stillman
d7dc5670d5 When clearing automatic tags, don't delete manual tags with same name 2019-03-05 07:55:00 -05:00
Dan Stillman
fc43514ff0 Deselect tags when deleted (regression from Reactification) 2019-03-05 07:55:00 -05:00
Dan Stillman
3c6ab77e44 Update locales from Transifex 2019-03-04 07:31:36 -05:00
Dan Stillman
8cd5b09053 Add icon for linked PDF files 2019-03-04 03:20:37 -05:00
Dan Stillman
e2c4e3e86a Use "PDF" attachment title for all individual PDFs from Mendeley import
https://forums.zotero.org/discussion/comment/327390/#Comment_327390
2019-03-03 04:52:39 -05:00
Dan Stillman
88f39cba80 Merge new English strings 2019-03-02 06:24:33 -05:00
Dan Stillman
04779d8d1c Add import option for storing or linking files
This allows files in Mendeley imports to be stored and files in
RIS/BibTeX/etc. to be linked.

Closes #329
2019-03-02 06:24:33 -05:00
Martynas Bagdonas
ca859e7aa4 Fix unescapeHTML on node.js 2019-03-01 09:59:21 +02:00
Dan Stillman
ad27e0c5fa Update locales from Transifex and merge new English strings 2019-02-26 22:30:29 -05:00
Dan Stillman
d0f7fd6df7 Add separate "Rename linked files" pref for auto-renaming
Defaulting to false

People who've been relying on auto-renaming of linked files for the last
year will have to turn this back on.
2019-02-26 22:23:43 -05:00
Adomas Venčkauskas
caac984345 Fix this.collectionTreeRow undefined errors in tag selector 2019-02-25 12:21:26 +02:00
Adomas Venčkauskas
891524b4ed Fix selected tags not clearing when switching collections. Closes #1646 2019-02-25 12:20:35 +02:00
Adomas Venčkauskas
6d82ac3970 Fix window.name being unset when loading include.js. Closes #1645 2019-02-25 11:45:42 +02:00