mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
13701 commits 9 branches 362 tags 278 MiB
Commit graph

9429 commits

Author SHA1 Message Date
Adomas Venčkauskas
f4284a3579 Returns the translators hash on Connector ping. 
Part of zotero/zotero-connectors#452
 2023-12-11 13:44:26 +02:00
Adomas Venčkauskas
9971f15e61 Use url of the page if no title available in /connector/saveSnapshot 2023-12-07 13:38:56 +02:00
Adomas Venčkauskas
5a0f369f0b Do not activate item on twisty dblclick. Closes #3507 2023-12-07 11:15:08 +02:00
Dan Stillman
8a66fc02fe Add cloud-storage warning for "BaiduSyncdisk" 
https://forums.zotero.org/discussion/109845/
 2023-12-01 02:34:35 -05:00
Abe Jellinek
0f447c87dc Fix ZP View -> Reset Zoom 
Fixes #3510
 2023-11-30 15:58:52 -05:00
Dan Stillman
8a620c3a7c Remove "Create Timeline" from Tools menu 
Addresses #3463 and, well, fixes #3462
 2023-11-30 06:52:18 -05:00
Dan Stillman
04b87e4db7 Fix NS_ERROR_MALFORMED_URI if WebDAV URL has leading or trailing space 2023-11-30 02:47:36 -05:00
Martynas Bagdonas
52c219c8b9 Switch to Library tab when dragging over EPUB or HTML files as well 2023-11-28 11:05:13 +00:00
Martynas Bagdonas
3eb1c3fb4f Fix reader PDF view iframes not receiving mouseup event 2023-11-28 08:44:25 +00:00
abaevbog
436b19d64c
Fix inconsistent ESC behavior on text edit when reader is opened (#3417) 
This is needed to let itemBox, tagBox, etc. to handle ESC
events to revent any edits made to textfields. Only applied
if the currently focused element is input or textarea.

Fixes: #3246
 2023-11-21 07:42:33 -05:00
Adomas Venčkauskas
9d710ea135 Be less aggressive about sending Zotero to back after http integration commands 
Report https://forums.zotero.org/discussion/109479/bug-after-adding-citation-main-window-is-hidden-76
 2023-11-21 10:34:36 +02:00
Dan Stillman
2c50749ab3 Add "GoogleDrive" as cloud storage path 2023-11-18 01:34:41 -05:00
Martynas Bagdonas
94070e1b7c Fix navigation to specific annotation when using zotero://open-pdf 
Fixes #3487
 2023-11-15 21:54:59 +00:00
abaevbog
7c5600913b
fix to collections highlight bugs (#3412) 
1. Trigger ZoteroPane.handleBlur on focusout instead of blur
to remove highlight when itemTree entries loose focus
even if ctrl/alt is still being held.
2. Prevent default event on Alt click on linux to avoid moving
focus to menubar
3. Avoid re-triggering focus multiple times
when ctrl is being held on windows to prevent highlight from becoming
stuck and not going away.

Fixes: zotero#3410
 2023-11-10 19:17:01 -05:00
Abe Jellinek
cdc59e6a29 Remove debug logging from search routine 
Way too slow and noisy.
 2023-11-10 16:40:12 -05:00
Abe Jellinek
835542bb6f Preferences search: Match Fluent strings 2023-11-10 16:40:12 -05:00
Dan Stillman
b6d8571860 Update Z.File.getSample() signature to match getBinaryContentsAsync() 
Not updated with 2b41b0127c
 2023-11-10 16:30:10 -05:00
Dan Stillman
f1373652e6 Fix file:// URI handling in getBinaryContentsAsync() 2023-11-10 15:58:53 -05:00
Adomas Venčkauskas
5efd181e5b Fix Zotero 2.1 and earlier citation upgrade code 2023-11-08 09:53:39 +02:00
Dan Stillman
bf478392ce Block most resource loading in reports 2023-11-02 17:50:16 -04:00
Dan Stillman
47e55286f7 Add Baidu Netdisk and MEGA to cloud-storage-folder checks 
Closes #3465
 2023-10-31 05:31:06 -04:00
Martynas Bagdonas
4266df4d3a Propagate annotation deletion between reader instances of the same file 
Fixes #3375
Fixes #3241
 2023-10-27 18:28:43 +01:00
Adomas Venčkauskas
b71012689f Updates translate submodule. Fixes #3182 2023-10-26 13:03:00 +03:00
Adomas Venčkauskas
011dabd372 Fix corner case after #3460. Closes #3461 2023-10-24 14:24:38 +03:00
Adomas Ven
3b9d0ac1bb
Allow the collection tree rows to have custom row heights (#3460) 
- The underlying changes are in windowed-list, which the item tree and
  all virtualized tables are based on, so if there are bugs they might
  show up outside of the collection tree.
- The expensive operation is adding/removing rows, since row offsets
  have to be recalculated (this includes collapsing/expanding rows).
- The cost on further drawing while scrolling is constant and shouldn't
  affect performance much.
 2023-10-24 03:56:07 -04:00
Martynas Bagdonas
7e82cc5ffd Fix recursion error when toggling/resizing sidebar in reader window 
Fixes #3379
 2023-10-19 18:15:51 +01:00
Dan Stillman
fc088bc1f3 Update utilities submodule 
Includes https://github.com/zotero/utilities/pull/30
 2023-10-06 06:58:50 -04:00
Dan Stillman
a1f6821fe1 Fix attachment-title renaming bug on Windows 
https://forums.zotero.org/discussion/comment/444399/#Comment_444399
 2023-10-06 04:56:19 -04:00
Adomas Venčkauskas
195ea69b19 Fix tiny Quick Format dialog before text entry. Closes #3443 2023-10-03 10:24:20 +03:00
Dan Stillman
e3c64fb047 Don't migrate prefs in new profile 2023-09-29 04:06:04 -04:00
Adomas Venčkauskas
2db19ad4ca Fix http word integration word path unicode issues. 2023-09-27 12:19:38 +03:00
Dan Stillman
aef49da233 Fix nsIZipReader.close error after invalid ZIP file download 2023-09-26 05:09:40 -04:00
abaevbog
bbfc6ed817
activate collection tree row only if it's focused (#3431) 
Fixes: #3426
 2023-09-24 05:34:00 -04:00
Abe Jellinek
79ef266f2f
Detect more EPUBs in viewAttachment() content type fixer (#3433) 2023-09-23 03:09:23 -04:00
Abe Jellinek
c45405190a importFromFile: Remove duplicate and unused declarations 
Apparently a var doesn't shadow a parameter with the same name, but that wasn't
obvious.
 2023-09-22 12:20:12 -04:00
abaevbog
399baf0d73
disable "Find available PDF" if files not editable (#3430) 
For example, in a public group files are not editable,
so this menu item is disabled.

Fixes: #3428
 2023-09-22 09:13:36 -04:00
Abe Jellinek
f28873382d Preferences: Highlight parent of selected pane in navigation 
Also, fix help and back buttons not hiding when starting a search.

Closes #3425
 2023-09-21 13:39:06 -04:00
Abe Jellinek
9779c70915 Reports: Don't strip valid surrogate pairs 
Without the /u (Unicode) flag, [\ud800-\udfff] matches *all* surrogate pair code
points, even when they're in a valid position in the string.

Fixes #3421
 2023-09-21 13:19:22 -04:00
Adomas Venčkauskas
220eba8c63 Fix bibliography editor dialog (regression c89590c7) 2023-09-21 10:34:11 +03:00
Adomas Venčkauskas
a8ccab78f5 Fix classic citation and bibliography dialogs not persisting dimensions 
The persisting logic doesn't work without an id on the root element
 2023-09-21 10:34:11 +03:00
Adomas Venčkauskas
f8c3a3a31e Fix citation dialog being moved to the wrong location sometimes 2023-09-21 10:34:11 +03:00
Dan Stillman
98c1a6ca1b Fix "Export PDFs…" stopping if attachment file isn't found 2023-09-21 02:47:48 -04:00
Abe Jellinek
540a174dab TranslationChild: Make "interactive" count as readyEnough 
Some pages (notably the first DOI.js test case) never get to "complete". I don't
know why! But for practically all translators that don't use defer: true,
"interactive" is ready enough.
 2023-09-20 12:56:02 -04:00
Abe Jellinek
6740b2644d Make relevant prefs available in RemoteTranslate 2023-09-20 12:09:37 -04:00
Abe Jellinek
667f940a6c Reader: Use url (was baseURI) for all reader types 2023-09-15 12:33:53 -04:00
Martynas Bagdonas
1b23838d37 Load PDF file from URI to avoid keeping extra file copy in memory 2023-09-15 11:05:31 +02:00
windingwind
78fe68164f Remove reader events when plugin is disabled 2023-09-14 07:54:29 +02:00
Martynas Bagdonas
96652ea9e8 Enable plugins adding custom content to reader UI and context menus 
#3373
 2023-09-13 14:16:28 +02:00
Abe Jellinek
87286ca776 Remove tab content immediately 
Amends 30c70a6ecd.
On some machines, the callback added in that change would never actually run, so
memory usage would grow quickly when switching between tabs. By wrapping in
setTimeout() instead of requestIdleCallback(), we keep the performance gains
from removing once the element is no longer visible (so we can avoid repaints,
rebuilding the layout tree, etc.), but we make sure that the callback gets
called nearly immediately.

#3321
 2023-09-07 13:38:55 -04:00
Dan Stillman
8d93fd4c8c Fix test breakage after f68818387 2023-09-06 07:38:14 -04:00
Dan Stillman
f688183878 Fix keyboard accessibility in conflict-resolution dialog 
It's now possible to tab through the panes and the buttons, and
left/right-arrow also change the selection, so you can use Left/Right +
Return to move through multiple conflicts.

Fixes #3395
 2023-09-06 06:40:59 -04:00
windingwind
b91ae86079 Mark ItemTreeColumnOptions.renderCell as optional 2023-09-06 14:02:18 +08:00
Dan Stillman
b4c3c0c7f9 Don't require unused date field in retractions list 2023-09-03 18:43:44 -04:00
Dan Stillman
b918ad2892 Fix error closing ZIP reader during file sync on Windows 
In Z7 on Windows 10 (but not 11 for me), nsIZipReader doesn't properly
close the file after `findEntries()` is called (as discovered by
@abaevbog), so a `remove()` on the downloaded ZIP file during file
syncing triggers an access-denied error. Setting the zip-reader variable
to null and forcing garbage collection seems to fix it. Doing this
everywhere we use nsIZipReader just to be safe.

I found the `forceGC()` in only one test file in fx102, but setting the
reader to null is done more widely, so maybe they just don't try to
delete ZIP files before GC happens and manage to avoid this bug.

Fixes #3369
 2023-08-31 06:17:18 -04:00
windingwind
794e89d307
Add itemTree render cell option (#3342) 2023-08-30 00:11:25 -04:00
Martynas Bagdonas
b72894d874 Fix still broken reader view focusing after tab switch 2023-08-29 13:47:11 +03:00
abaevbog
ae1c8bd059
set opened reader tab index on state restore (#3357) 
Fixes: #3353
 2023-08-28 23:29:41 -04:00
Abe Jellinek
85cade3fb2
Make preferences less janky, preload panes on hover, allow panes to delay visibility until promise resolves (#3363) 
Prevents flashes of unlocalized labels and controls without values set.
Makes switching panes feel speedier overall because of preloading.

I thought there was an issue for the flashes of uninitialized content but can't
find it now.
 2023-08-26 05:57:38 -04:00
Abe Jellinek
6cd44f19fe Fix more Z6/Z7 inconsistencies in Advanced Search 
- Prevent row height from changing when switching between text input conditions
  and menulist conditions
   - Replace some of (far from all of) the XUL layout with flexbox
- Restore groupbox appearance
   - A little retro? We probably want some kind of border like we used to have
- Replace some duplicate IDs with classes for styling
 2023-08-24 11:14:59 -04:00
Dan Stillman
075457be45 Use REPLACE instead of INSERT for ebook schema changes 
Follow-up to bdea760 (#3360), which I changed incorrectly
 2023-08-24 05:13:42 -04:00
Abe Jellinek
bdea76024b
Add EPUB to Attachment File Type in Advanced Search (#3360) 2023-08-24 03:06:33 -04:00
Abe Jellinek
8f4cb5002a
Fix progress queue segfault (#3359) 2023-08-23 04:56:21 -04:00
Abe Jellinek
30c70a6ecd Defer removing tab content 
Improves EPUB close performance.

By wrapping with requestIdleCallback(), we ensure:

  1. remove() won't be called right away, so the DOM elements being removed
     won't be visible and won't trigger a relayout.
  2. remove() won't be called while there are pending UI events, so it
     shouldn't cause the UI to hang/lag/stutter.

Combined, these two improvements make the UI hang when closing a large EPUB
mostly imperceptible on my machine.

Addresses #3321; doesn't completely fix it because there's likely more to be
done on the reader side to optimize the DOM.
 2023-08-21 12:20:57 -04:00
Dan Stillman
38d0750dd3 Don't include parent title in tab title for secondary attachments 
As suggested in https://github.com/zotero/zotero/issues/2731#issuecomment-1201382522
 2023-08-20 02:26:58 -04:00
Tom Najdek
4f19b1d13e
Improve file renaming preview in preferences (#3343) 2023-08-19 05:06:08 -04:00
Dan Stillman
4dbd52782c Better fixing of tab-title logic 
Follow-up to 3eef4284d1, which wasn't totally correct, and adds the
attachment title before the parent metadata for secondary attachments.

https://forums.zotero.org/discussion/comment/441362/#Comment_441362
 2023-08-19 04:51:04 -04:00
Dan Stillman
3eef4284d1 Fix "Filename" tab title option 
https://forums.zotero.org/discussion/comment/441259/#Comment_441259
 2023-08-19 04:00:49 -04:00
Martynas Bagdonas
b05ef8ed04 Properly focus reader iframe when opening a new reader instance 2023-08-18 18:33:52 +02:00
Abe Jellinek
17daf9fe8d Fix EPUB attachments with wrong MIME type on view 
Fixes #3320
 2023-08-15 17:54:37 -04:00
Abe Jellinek
7b26dab2f2 Show spread mode menu items in EPUB reader 
Fixes #3318 (only odd spreads supported right now because of CSS grid
limitations)
 2023-08-15 17:54:36 -04:00
Northword
dcca56d6c3
preferenceOptions.helpurl should be string instead string[] (#3310) 2023-08-11 07:13:58 -04:00
Dan Stillman
9dd182e9ca Collection tree selection fixes 
Fixes various logic around what gets selected when collections and
searches are moved to or restored from the trash (which has never been
exposed) or when they're erased
 2023-08-11 04:16:42 -04:00
Dan Stillman
c4eb9df716 Update utilities submodule 2023-08-09 18:09:03 -04:00
Dan Stillman
5e27a75010 Switch to better sentence-caser from zotero/utilities#26 
Closes #293
 2023-08-09 07:51:16 -04:00
Martynas Bagdonas
879109336a Rename pdf-reader paths to reader 2023-08-08 11:28:00 +03:00
Martynas Bagdonas
07e4d68760 Suppress noisy "dead object" error after each click inside reader tab 2023-08-07 16:07:56 -04:00
Dan Stillman
7e481e3e5f Move Language to the bottom of the General prefpane 2023-08-07 16:07:55 -04:00
Dan Stillman
38b9457ea9 Move new string to Fluent 2023-08-07 16:07:55 -04:00
Dan Stillman
caee5f29ca Update reader prefs 
- Move open-in prefs into reader prefs
- Move reader prefs up below File Handling
- Move new strings to Fluent
- Fix clicking on labels to focus open-in drop-downs
- Tweak text
 2023-08-07 16:07:55 -04:00
Abe Jellinek
deb6acaab1 Add preferences for ebook & snapshot file handling 2023-08-07 16:07:55 -04:00
Abe Jellinek
2ef560f7d8 Extract ISBNs and DOIs from EPUB content (#64) 
And move EPUB functionality to class.
 2023-08-07 16:07:55 -04:00
Abe Jellinek
cab0fa93e7 Extend Retrieve Metadata to support EPUBs (#57) 2023-08-07 16:07:55 -04:00
Martynas Bagdonas
80da0fbb56 Remove the unnecessary buf to Uint8Array conversion 2023-08-07 16:07:55 -04:00
Abe Jellinek
b0b11cfcf5 Use data option to initialize reader 2023-08-07 16:07:55 -04:00
Martynas Bagdonas
e031509966 Fix Reader 2.0 merge caused regressions 2023-08-07 16:07:55 -04:00
Martynas Bagdonas
c62ed29de9 Fix text annotation dragging error 2023-08-07 16:07:55 -04:00
Martynas Bagdonas
f18411c151 Properly trigger annotation position split if server says it's too long 2023-08-07 16:07:54 -04:00
Martynas Bagdonas
12fde2dd4a Fix reader error handling and properly display critical errors 2023-08-07 16:07:54 -04:00
Martynas Bagdonas
46d066394f Temporary fix for tab crashes caused by tab loading racing conditions 2023-08-07 16:07:54 -04:00
Martynas Bagdonas
7e28973f3a Fix reader focusing 2023-08-07 16:07:54 -04:00
Abe Jellinek
b408b43394 Support pre-SingleFile snapshots 2023-08-07 16:07:54 -04:00
Martynas Bagdonas
3c08604770 Fix PDF file printing 2023-08-07 16:07:54 -04:00
Martynas Bagdonas
17deb16779 Add partial underline annotation support for note-editor 
(changes to note-editor have to be merged to have full support)
 2023-08-07 16:07:54 -04:00
Abe Jellinek
e199f35006 Fix _getColorIcon(), update stroke color, use for selected menuitems 
- Need to set width/height for macOS native menu
- CSS named grays are too light to show well on the background, so use #555
- type="checkbox" menuitems don't show their icons, so use the icon stroke
  instead
 2023-08-07 16:07:54 -04:00
Abe Jellinek
3443d065a3 Use native context menus on macOS 2023-08-07 16:07:53 -04:00
Abe Jellinek
1740e5f1aa Call uninit() in close() 
This properly unregisters pref observers and flushes the reader's state.
 2023-08-07 16:07:53 -04:00
Abe Jellinek
0ee54b4a7e Use IOUtils instead of OS.File 2023-08-07 16:07:53 -04:00
Abe Jellinek
bdb444371f Debounce writing EPUB/snapshot state to disk 2023-08-07 16:07:53 -04:00
Abe Jellinek
6a4715c324 Enable "Add Note from Annotations" for EPUBs and snapshots 2023-08-07 16:07:53 -04:00
Abe Jellinek
db6ff88ad1 Add full-text indexer for EPUBs 2023-08-07 16:07:53 -04:00
Martynas Bagdonas
e8c5c22d05 Fix pdf-worker CMaps and standard fonts paths 2023-08-07 16:07:53 -04:00
Martynas Bagdonas
7fa05bc463 Properly handle reader window closing 2023-08-07 16:07:53 -04:00
Martynas Bagdonas
9d2d655039 Avoid memory leaks caused by never removed event listeners 2023-08-07 16:07:53 -04:00
Abe Jellinek
7791779289 Fix unloaded tab context menu actions 
Show in Library and Move to New Window.

Will fix zotero/zotero#2685
 2023-08-07 16:07:53 -04:00
Abe Jellinek
a729297f6b Add menu items to switch EPUB flow modes (paginated/scrolled) 2023-08-07 16:07:52 -04:00
Abe Jellinek
61f21f48e8 Fix browser-custom-element.js event handler error 
Send real mouse/pointer events so that the CE can call, e.g.,
preventClickEvent().
 2023-08-07 16:07:52 -04:00
Abe Jellinek
ba1b1b0639 Add EPUB format to Zotero.MIME 2023-08-07 16:07:52 -04:00
Abe Jellinek
1d89360765 Persist snapshot scroll position 2023-08-07 16:07:52 -04:00
Abe Jellinek
60f8d11c2d Persist EPUB CFI with setAttachmentLastPageIndex() 2023-08-07 16:07:52 -04:00
Martynas Bagdonas
3105bb9ff3 Fix add to note 2023-08-07 16:07:52 -04:00
Martynas Bagdonas
110f29b766 Save reader state into .zotero-reader-state file 2023-08-07 16:07:52 -04:00
Martynas Bagdonas
572cd3655e Fix reader context menu positioning in RTL mode 2023-08-07 16:07:51 -04:00
Abe Jellinek
f5381403c0 Add ebook font to preferences 
Choose from a list of preset font stacks, or any font on your system.
 2023-08-07 16:07:51 -04:00
Abe Jellinek
378277206a Add Reset Zoom to EPUB/snapshot reader View menu 2023-08-07 16:07:51 -04:00
Abe Jellinek
3be3d8ebef Zotero.Items: Support EPUB and snapshot annotations 2023-08-07 16:07:51 -04:00
Martynas Bagdonas
681cdd809f Reader 2.0 2023-08-07 16:07:51 -04:00
Tom Najdek
19382a061f
Remove unnecessary code in getFileBaseNameFromItem 2023-08-07 17:03:27 +02:00
Dan Stillman
4e3977e9ce Update file-renaming prefs (#3228) 
- Move file-renaming prefs to separate prefs section
- Fix template preview not updating on paste
- Update documentation URL
- Tweak text, styling, and ids
- Change "Automatically rename attachment files using parent metadata"
  to "Automatically rename locally added files" to reflect that
  downloaded files are always renamed, and add an intro saying so
 2023-08-06 17:50:13 -04:00
Tom Najdek
d32b061c95 Add UI for editing attachment rename format pref (#3228) 2023-08-06 17:48:56 -04:00
Dan Stillman
af91173734 Look up PubMed IDs in batches of 200 
https://forums.zotero.org/discussion/comment/440245/#Comment_440245
 2023-08-05 00:01:55 -04:00
Dan Stillman
fcc68d6d80 Serialize lookup requests 
These were switched to parallel in 86b77cc45, resulting in blocks:

https://forums.zotero.org/discussion/106658/limited-amount-of-articles-that-can-be-added-through-pmid
 2023-08-04 23:21:35 -04:00
Abe Jellinek
251da0a148 Add SCSS styles to note.xhtml 
Fixes #3193
 2023-08-04 10:08:30 -04:00
Dan Stillman
3a43a98f10 Add IOUtils and PathUtils to plugin sandbox 2023-08-04 06:18:52 -04:00
Dan Stillman
9b0ce9558c
attachmentRenameFormatString → attachmentRenameTemplate (#3249) 2023-08-04 05:58:15 -04:00
windingwind
e44e3edef9
Fix itemBox.js eslint errors (#3244) 2023-08-04 04:15:08 -04:00
Dan Stillman
07309d7c25
Add Zotero.getMainWindows() 2023-08-03 05:11:26 -04:00
windingwind
1ca34261d3 Update ItemTreeManager.unregisterColumns example 2023-08-03 11:08:55 +08:00
Dan Stillman
fb4f55e809 Restore Word → LibreOffice order in Cite prefpane 2023-08-02 06:36:38 -04:00
Adomas Venčkauskas
b261d10b89 Fix Return not accepting citation dialog after pasting. Closes #3240 2023-08-01 09:47:42 +03:00
Adomas Venčkauskas
4b16269b7f Prefs: Add an event on pane switch 
Fixes an issue with incomplete Style Manager tree rendering when
switching panes. Closes #3239
 2023-08-01 09:18:30 +03:00
windingwind
836c8718b0 Fix itemTreeManager typo 2023-07-31 21:48:20 +08:00
windingwind
76c1db33e9 Fix itemTreeManager typo 2023-07-31 21:47:38 +08:00
Abe Jellinek
345bbcf50c Scaffold: Prompt to save before resetting 
Now that Scaffold remembers and automatically loads the last edited translator
(65048fd624), it needs to be easier to create a
new translator without saving (and bumping the lastModified date on) the
translator you had open.
 2023-07-31 09:44:20 -04:00
windingwind
ef7916b320
Add main window hooks for plugins (#3238) 2023-07-31 05:09:33 -04:00
Abe Jellinek
6dcc70f531 Zotero.PreferencePanes.register: Set default values for scripts/stylesheets 
Without this, the calls to .map() below throw when one or both of those options
aren't set.
 2023-07-29 22:28:10 -04:00
Abe Jellinek
8a7f3645bc
Item box: Add DOI menu listeners once, disable when DOI is invalid (#3237) 
Fixes #3221

Co-authored-by: Dan Stillman <dstillman@zotero.org>
 2023-07-29 04:25:34 -04:00
Dan Stillman
02198b12fe Fix dragging to My Publications 
Also:

  - Don't show file options if only linked files
  - Don't set Rights field to "All Rights Reserved" if no files
 2023-07-29 02:22:20 -04:00
Abe Jellinek
cbece42fb9 Fix merge pane overflow behavior 
The item box CE can't be the scroll container, so it needs a wrapper element.

Fixes #3233
 2023-07-28 15:06:02 -04:00
Abe Jellinek
7036073ed1
Resolve plugin-provided URIs relative to rootURI (#3235) 2023-07-28 00:16:58 -04:00
Abe Jellinek
e271b4e494 copyToUnique: Fail if source contains destination 
To prevent unbounded recursion as in 16547f64c2.
 2023-07-27 12:24:51 -04:00
Abe Jellinek
16547f64c2 renameAttachmentFile: Check rename() return value 
And actually return -1 if it returns false.

Before this fix, attempting to rename an attachment file to a name that already
exists on disk would never return -1 as the docs say it should. Instead:

1. rename() would fail and return false
2. newName would be set to false
3. renameAttachmentFile() would pass false as the second argument to
   OS.Path.join()
4. OS.Path.join() would ignore it because it was falsy and return the attachment
   directory path without any modification
5. relinkAttachmentFile() would be called with path set to the attachment
   directory
6. relinkAttachmentFile() would notice that path's dirname wasn't the attachment
   directory - it was the attachment directory's parent - and attempt to copy it
   and its contents, recursively, into itself, using copyToFollowingLinks()

...which created a directory structure on disk over 100 directories deep -
not deeper only because the OS started returning errors due to paths exceeding
32,767 characters (the limit on my filesystem).
 2023-07-27 12:24:32 -04:00
Dan Stillman
00683732d8 Make XMLSerializer available in plugins 
https://groups.google.com/g/zotero-dev/c/ZKoDSBniSXs/m/VDhPpjNqAAAJ
 2023-07-26 23:01:23 -04:00
Dan Stillman
0d70925816 Fix error loading plugin scope after 6a2fcd6898 
`AddonManager.getActiveAddons(["extension"])` doesn't return fully
loaded addon objects if `getAllAddons()` hasn't been called
 2023-07-26 23:01:17 -04:00
Dan Stillman
6a2fcd6898 Remove loadExtensionDefaults() in prefs.js 
We now handle this in prefs.js.
 2023-07-26 07:25:21 -04:00
Dan Stillman
a1f49e11d5 Fix low-res webpage icon 2023-07-25 07:35:03 -04:00
Adomas Venčkauskas
d96afa4499 Fix split-menu-button dropmarker triggering the button click event 
Regression in fa31956d
 2023-07-25 14:23:34 +03:00
Dan Stillman
630c6d0d97 Fix tags not being saved in item tags box when pressing Enter 
SyntaxError: Element.querySelector: '[ztabindex=1]' is not a valid selector

https://forums.zotero.org/discussion/106405/zotero-7-changes-to-item-tag-do-not-persist
 2023-07-25 05:51:41 -04:00
Dan Stillman
fb59345637 Fix "Check for Update" buttons in error dialogs 
Fixes #3213
 2023-07-25 01:53:22 -04:00
Dan Stillman
ed2cae9236 Adjust attachment-title handling on Rename File from Parent Metadata 
Don't change the attachment title on a manual rename from metadata if it
doesn't match the current filename, with or without the extension

Closes #3220
 2023-07-25 01:48:23 -04:00
windingwind
c89590c7b7
Add ItemTree column API (#3186) 2023-07-25 00:47:12 -04:00
Abe Jellinek
676f820f87
Strip bidi control characters in filenames and elsewhere (#3208) 
Passing unformatted = true to Item#getField() now returns a bidi control
character-less result, and we use that in Reader#updateTitle() and
getFileBaseNameFromItem() to prevent bidi control characters from showing up in
filenames and window titles (the former everywhere, the latter on Windows only).

We also strip bidi control characters in getValidFileName() to be extra safe.
 2023-07-22 03:30:28 -04:00
Abe Jellinek
1217710234 PDFWorker manager: OS.File -> IOUtils 2023-07-21 18:36:38 +03:00
Abe Jellinek
5aaf368149 Use pdf-worker for hasEmbeddedAnnotations() 2023-07-21 18:36:38 +03:00
Dan Stillman
2fad3d89ff Use getDisplayTitle() for titles in timelines 
https://forums.zotero.org/discussion/106290/zotero-timeline-does-not-display-email-subject
 2023-07-21 06:23:02 -04:00
windingwind
97235d2dea
Fix selectitems.xhtml persist bug (#3219) 
See https://groups.google.com/g/zotero-dev/c/OscDKuO9Rao
 2023-07-21 04:43:52 -04:00
Tom Najdek
0ba766f2e0
Customizable renaming rules #1413 (#2297) 2023-07-20 06:50:34 -04:00
Dan Stillman
96e2510165 Fix missing return in previous commit 2023-07-20 06:42:32 -04:00
Dan Stillman
590460cea4 Add Zotero.Prefs.prefHasUserValue(pref, global) 2023-07-20 06:41:23 -04:00
Dan Stillman
51c70eb925 Use system temp directory by default 
Might help for something like
https://forums.zotero.org/discussion/106337/zotero-7-sync-error
 2023-07-20 05:43:39 -04:00
Adomas Venčkauskas
75c46e1e5c Enable FAYT in document preferences. Closes #3214 2023-07-20 11:10:14 +03:00
Adomas Venčkauskas
1b30c8b2b5 Add a comment for bib style caching. Closes #3211 2023-07-18 10:58:12 +03:00
Adomas Venčkauskas
f61826281b Revert "Merge pull request #3195 from CommonLoon102/cl102/fix-bib-indent" 
This reverts commit aca86967bf, reversing
changes made to 1a850d58c4.
 2023-07-18 10:55:14 +03:00
abaevbog
9599d1712c
disable file > close for library if 1+ tabs open (#3210) 
When there are multiple tabs opened, menuitem File > Close is disabled for the library tab.

Fixes: #3198
 2023-07-18 03:40:19 -04:00
Martynas Bagdonas
e37eaac8d1 Fix panes overflowing in stacked view mode 
Fixes #3180
 2023-07-17 17:07:38 +03:00
Dan Stillman
c425f71ac4 fx-compat: Fix error passing cookieSandbox to Zotero.HTTP.request() 
https://groups.google.com/g/zotero-dev/c/UgP_kZvrEjA/m/KjimYREGAgAJ

getInterface() seems to exist on XHR and nsIWBP without QIing to
nsIInterfaceRequestor, and XHR no longer has QueryInterface().
 2023-07-17 06:42:14 -04:00
Dan Stillman
65fe50d11f Clear startup cache when uninstalling/upgrading plugins 
https://groups.google.com/g/zotero-dev/c/0nfU-F2q1uI/m/1jBVmMZxBAAJ

Removed by Mozilla in
https://bugzilla.mozilla.org/show_bug.cgi?id=1445739, since
WebExtensions don't put anything in the startup cache
 2023-07-15 18:39:59 -04:00
Dan Stillman
838152155e Log warning when not setting createdByUser/lastModifiedByUser 
(I encountered this in a test when trying to set createdByUserID without
`Zotero.Users.setName()`.)
 2023-07-14 05:48:48 -04:00
Dan Stillman
dc321ce643 Fix startup error on Windows 
Regression from 8d3f874e64, which included this unfinished code by mistake.

Fixes #3196
 2023-07-14 05:48:48 -04:00
abaevbog
0cd94555d5
prevent incorrect jumpback (#3204) 
Fixes: #3152
 2023-07-14 05:29:43 -04:00
Dan Stillman
d7449b4d78 Fix merging of group attachments with annotations created by another user 
https://forums.zotero.org/discussion/106197/merge-in-group-library-fails-despite-having-edit-permissions
 2023-07-13 19:58:47 -04:00
Adomas Venčkauskas
e5d25f3d66 Fix /connector/saveSnapshot still not including info about snapshots 2023-07-12 10:21:46 +03:00
Abe Jellinek
2aa34a6346 Merge: Remove spacing from annotation regex, delete external annotation items 
- `/Subtype` isn't necessarily preceded or followed by a space
- Annotation items with `isExternal: true` are for display only and should be
  deleted on merge

https://forums.zotero.org/discussion/105960/external-annotations-ignored-when-merging
 2023-07-11 11:12:58 -04:00
Adomas Venčkauskas
a0cdf11096 Fix failing test from 02ba9ca7 2023-07-11 15:57:35 +03:00
Adomas Venčkauskas
02ba9ca7f0 Include information about saved snapshots in /saveSnapshot 2023-07-11 15:45:51 +03:00
Martynas Bagdonas
5928147f26 Fix middle-click selecting tab that is being closed 2023-07-11 14:02:12 +03:00
Dan Stillman
8d3f874e64 Remove all uses of Zotero.isStandalone 
(View diff with -w)
 2023-07-11 05:35:32 -04:00
Dan Stillman
b98efe0b67 Remove ZoteroPane.updateTagsBoxSize() 
Disabled several years ago in bb5075e8b8
 2023-07-11 05:35:32 -04:00
Dan Stillman
071162f914 Remove styled-textbox XBL binding 2023-07-11 05:35:32 -04:00
Dan Stillman
af892e5cbd Make annotation sortIndex more flexible 2023-07-11 05:35:32 -04:00
Abe Jellinek
b6d0ad3e05 Accept non-integer attachmentLastPageIndex 2023-07-11 05:35:32 -04:00
Martynas Bagdonas
89adf56eed Add support for text annotations 2023-07-11 05:35:32 -04:00
Martynas Bagdonas
cb14034c46 Add support for underline annotations 2023-07-11 05:35:32 -04:00
Dan Stillman
81ec8287f8 Disable attachmentContentType check to prevent sync errors 2023-07-11 05:35:32 -04:00
Dan Stillman
4a8935eefd Guidance panel fixes 
- Fix missing styling in Quick Format dialog
- Fix Book Section panel being immediately hidden
- Remove low-res Zotero icon
- Increase font size and tweak padding
 2023-07-11 05:35:32 -04:00
Dan Stillman
fb3466b392 Fix Ctrl-Q on Linux 
Fixes #3199
 2023-07-06 19:21:52 -04:00
windingwind
a2e8be2af5
Fix extremely slow binary to base64 (#3201) 2023-07-06 01:56:38 -04:00
Martynas Bagdonas
8017b2ab1b Fix extremely slow note editor image ArrayBuffer to data URL conversion 2023-07-05 19:41:32 +03:00
abaevbog
04496fadcd
only save username to prefs on successful login (#3192) 
Failing to login does not update the username in prefs.

Fixes #2901
 2023-07-05 04:11:56 -04:00
abaevbog
13571f9fd2
making toolbar accessible to the keyboard - initial conversion (#3188) 
Port of d866a10a2b

Fixes #3001
 2023-07-05 03:17:07 -04:00
Adomas Ven
aca86967bf
Merge pull request #3195 from CommonLoon102/cl102/fix-bib-indent 
Fix indentation in bibliography
 2023-07-03 15:19:01 +03:00
Adomas Venčkauskas
1a850d58c4 Fix the column picker not working outside of zotero pane. Closes #3162 2023-07-03 14:54:50 +03:00
CommonLoon102
b60fb28313
Fix indentation in bibliography 
Fix indentation in bibliography when a new item is added and therefore the recalculation of indents are needed.

https://forums.zotero.org/discussion/23689/bibliography-indentation
 2023-07-01 13:15:44 +02:00
Dan Stillman
1766f8bb53 Plugin lifecycle fixes 
- Call `shutdown()`/`uninstall()` with `ADDON_UPGRADE`/`ADDON_DOWNGRADE`
  during plugin upgrade/downgrade
- Actually call new version's bootstrap.js, not cached old version
- Create new scope for new version
- Don't call `shutdown()` on uninstall if not active

Fixes #3159
 2023-07-01 06:19:04 -04:00
Martynas Bagdonas
fcb30b5e5d Fix not working context menu options to create note from annotations 2023-06-30 10:54:52 +03:00
Adomas Venčkauskas
1274f5f602 Fix citation reordering by dragging in the citation dialog. Closes #3183 2023-06-28 13:36:38 +03:00
Martynas Bagdonas
abfe96fcaa Temporary fix for context-pane item deck selection when closing a tab 
Fixes #3175
Related to bb85e11a
 2023-06-27 18:34:15 +03:00
Abe Jellinek
65048fd624 Scaffold: Automatically load last opened translator 2023-06-24 15:00:57 -07:00
Abe Jellinek
9b6d6c109c RemoteTranslate: Support cross-origin XMLHttpRequest 
By creating our Sandbox under the system principal and giving it privileged XHR.
Bonus: no more `wrappedJSObject` required because sandbox code and actor code
are at the same privilege level now.

Fixes #3176
 2023-06-23 22:19:46 -07:00
Dan Stillman
3454c321e7 Fix sw_vers call on older macOS versions 
Apparently it didn't used to allow two hyphens before flags
 2023-06-23 02:01:27 -04:00
Dan Stillman
f8d8fb5e11 Fix item-type-menu breakage after canceling item-type change on Windows 
https://forums.zotero.org/discussion/105739/zotero-7-beta-bug-changing-item-type
 2023-06-22 14:18:23 -04:00
Dan Stillman
4b581ad07b Don't call plugin startup() on upgrade if disabled 
Fixes #3177

https://forums.zotero.org/discussion/105692/z7-beta-disabled-add-on-suddenly-active
 2023-06-22 05:05:05 -04:00
Dan Stillman
f62cef9c12 Remove DOMLocalization from plugin sandbox 
That can just be retrieved directly from document.l10n on the
appropriate window, and Mozilla doesn't use it directly.
 2023-06-18 16:55:30 -04:00
Dan Stillman
c7304b9fb0 Fix plugin localization handling 
Pass Localization and DOMLocalization to plugins and fix locale
registration so that it occurs before startup() is called.
 2023-06-18 16:50:04 -04:00
Abe Jellinek
0a94e8fdf0
fx-compat: Make color picker CE accessible via keyboard and VoiceOver (#2933) 2023-06-17 02:43:24 -04:00
Abe Jellinek
c37e327330 Fix clicky sizing and appearance 
- Set min-width and min-height to width and height so buttons never shrink
- Remove defunct .zotero-clicky-* styles from 2x block in zotero.css
- Include zotero-platform/content/zotero.css in searchDialog.xhtml
   - It seems only the defunct 2x styles from zotero.css were being applied, so
     the buttons would have been unstyled on a non-hiDPI display
 2023-06-17 02:33:59 -04:00
Abe Jellinek
1a2950ae34 Automatically adjust height of multiline/long fields in edit mode 
Fixes #3170
 2023-06-16 12:17:29 -07:00
Adomas Venčkauskas
9668270017 Fix the integration template check for unknown agents 2023-06-16 12:40:13 +03:00
Adomas Venčkauskas
6efa55ffdf Update Word for Mac submodule. Update template version check 2023-06-16 03:24:03 -04:00
Adomas Venčkauskas
e3e607a6d4 Add support for macWord transaction initialization via HTTP 2023-06-16 03:24:03 -04:00
Abe Jellinek
c124ca9738 Scaffold: Fix test creation 
Fixes #3167
 2023-06-15 16:18:57 -07:00
Abe Jellinek
2639981dda
Block remote content when indexing HTML file (#3157) 2023-06-12 23:43:18 -04:00
Abe Jellinek
30624c6aba Preferences: Remove extraDTD pane option 
Include FTL localizations directly in your pane XHTML fragment:

    <linkset>
        <html:link rel="localization" href="make-it-red.ftl"/>
    </linkset>

Fixes #3161
 2023-06-12 13:25:20 -04:00
Abe Jellinek
75df7bcbdd Item Pane: Allow "long" fields to wrap 
Aligns with Z6 behavior.

Fixes #3163
 2023-06-12 12:38:30 -04:00
Dan Stillman
ffd6a988e1 Await plugin bootstrap methods 2023-06-12 01:39:57 -04:00
Dan Stillman
027060ba86 Log reason when calling bootstrap methods 2023-06-07 01:58:18 -04:00
Abe Jellinek
6106e379c9 Plugins: Uninstall immediately but allow undo 
When you uninstall a plugin through the UI, XPIInstall:
1. Sets the plugin's `pendingUninstall` to true
2. Calls our onUninstalling() method
3. Waits for the Add-ons window to be closed
4. Actually uninstalls the plugin
5. Calls our onUninstalled() method

If you undo the uninstallation between steps 2 and 3, the remaining steps
instead look like:
3. Sets the plugin's `pendingUninstall` to false
4. Calls our onOperationCancelled() method

This commit changes our implementation of the bootstrapped plugin lifecycle so
that the shutdown and uninstall hooks are called from onUninstalling() (step 2).
If you close the Add-ons window without undoing, nothing more happens. The
plugin remains uninstalled. If you undo before closing, though, we call the
plugin's lifestyle hooks just as if it had been newly installed (unless it was
disabled before uninstallation, in which case we call install but not startup).

This mirrors the behavior of Firefox WebExtensions and makes things work more
like you'd expect: uninstalling a plugin immediately deactivates it, and undoing
activates it again.
 2023-06-06 16:14:33 -04:00
Abe Jellinek
a28b949dc1 Preferences: Attach preferences to all added nodes in tree 
mutation.addedNodes only contains the top-level nodes, so we need to query for
all nodes with preference attributes in their trees.
 2023-06-06 14:00:57 -04:00
Martynas Bagdonas
bb85e11a92 Fix tab selection when closing a tab nearby 
Fixes #3151
 2023-06-06 19:42:34 +03:00
Martynas Bagdonas
785dcb30c3 Ensure that note is created when inserting an image 
Fixes #3155
 2023-06-06 16:22:19 +03:00
Abe Jellinek
5e41b3ab4d Place word processor plugin installers under heading and fix spacing 
Fixes #3147
 2023-06-05 10:52:04 -04:00
Abe Jellinek
d077388616 Fix WebDAV settings 
- Fix mistaken reference to event.target (instead of currentTarget) in sync
  function
- Move sync functions to fields for easier debugging - can't set a breakpoint
  inside an inner function in the Firefox debugger

Fixes #3142
 2023-06-05 10:32:37 -04:00
Dan Stillman
ea1e28c7b7 Update translate submodule 2023-06-01 06:08:40 -04:00
Dan Stillman
fd7cf71043 fx-compat: Fix Page textbox in classic citation dialog 2023-05-30 17:32:21 -04:00
Dan Stillman
d5a584c28b Don't close window with Cmd-W on first tab if other tabs are open 
Closes #2572
 2023-05-29 06:00:31 -04:00
Dan Stillman
7c902d40a9 Timer updates 
- Switch to Mozilla's Timer.jsm for timer functions in XPCOM scope
- Add setInterval/clearInterval/requestIdleCallback/cancelIdleCallback
- Add all timer functions to plugins sandbox
 2023-05-28 04:51:21 -04:00
Dan Stillman
773a89b0f3 Fix title of import wizard 2023-05-27 06:42:11 -04:00
Dan Stillman
77241d1c71 Fix test in collection tree selectLibrary() 
getRowIndexByID() can only return an integer or false
 2023-05-27 02:34:03 -04:00
Dan Stillman
cd20df8d74 Fix sw_vers being run repeatedly in View Output window on macOS 
Fixes #3136
 2023-05-26 06:45:23 -04:00
Dan Stillman
3f739fc1b4 "Capitalize" → "Fix Case" for creator context menu 
https://forums.zotero.org/discussion/105117/zotero-7-thank-you-for-adding-right-click-case-change-for-author-names
 2023-05-25 21:56:31 -04:00
Dan Stillman
b2b768cd4b Fix fileQuitItemUnix is null error in PDF reader window 2023-05-25 21:56:31 -04:00
Abe Jellinek
4cfe682367
Remove outdated startup error messages (#3138) 2023-05-25 21:38:12 -04:00
Abe Jellinek
42572efca9 Fix error when adding link attachment with unparseable URL 
https://forums.zotero.org/discussion/105158/zotero-7-beta-attach-link-to-uri-logosres-does-not-work-any-longer
 2023-05-25 18:45:48 +03:00
Abe Jellinek
a4c3f5267b Fix ScienceDirect PDF downloads 
ScienceDirect sometimes puts the `name` directive at the end of the Content-Type
header instead of in Content-Disposition. That isn't strictly spec-approved, but
there are other directives (`charset` and `boundary`) that can also be appended
to Content-Type per the spec. We want to strip them before looking for handlers.

https://forums.zotero.org/discussion/105194/sciencedirect-pdf-downloads-not-working-zotero-7
 2023-05-25 17:57:32 +03:00
Dan Stillman
6e2ec2300d Fix checking for Firefox profiles high up in filesystem 
This was triggering an erroneous warning dialog about a failure to check
for Firefox profiles during Linux tests (where the profile is at
something like /tmp/tmp.l5phnqSxBH/Zotero), but it could also affect a
custom profile directory location.
 2023-05-25 03:37:06 -04:00
Abe Jellinek
6405997723 Use Zotero.appName in window title 2023-05-25 09:13:42 +03:00
Abe Jellinek
91fec9024c Bidi: Fix control characters appearing in reader window titles on Windows 
Fix in 6d5ce578e4 only affected tabs.

Fixes #3135
 2023-05-25 09:05:36 +03:00
Abe Jellinek
087a9859b4 Fix preference binding issues and "Include Zotero Links" checkboxes 
- Set zotero-noteQuickCopy-menu's preference attribute to the correct key
- Warn about all ID-ish preference attribute values
  - zotero-noteQuickCopy-menu's preference attribute was being set to the ID of
    a now-nonexistent <preference> element. preference attribute values should
    be preference keys now, but we were only warning if the associated
    <preference> element was actually there
  - We can't warn in all cases where the preference doesn't yet exist, because
    some preferences don't have default values, and we shouldn't limit to
    preferences that don't exist, because then the warning will stop showing
    after the preference is persisted once
- When a <preference> ID is replaced by the associated key, update the
  preference attribute so future syncFromPref() and syncToPrefOnModify() calls
  will set the correct preference
- Listen to a range of events on all bound nodes, no matter their type
- Don't resolve _firstPaneLoadDeferred until actually done loading

Fixes #3131.
 2023-05-24 20:46:00 +03:00
Martynas Bagdonas
26068a855c Make note editor iframe an XUL element to avoid focus anomalies 
Fixes #3128
 2023-05-24 17:38:15 +01:00
Dan Stillman
0b1d958a86 Fix erroneous warning if Firefox profile directory can't be found 
`Zotero.File.getContentsAsync()` now uses IOUtils rather than OS.File
 2023-05-24 06:53:23 -04:00
Dan Stillman
f5433f04e6 Update searchfox link to permalink 2023-05-24 02:25:20 -04:00
Abe Jellinek
caa1036da2 Remote translation: Don't use wantGlobalProperties 
Not necessary - just use the properties we inherit from contentWindow. This
fixes the DOMParser constructor, which fails if called without a window context
from a non-system principal.

https://forums.zotero.org/discussion/105163/zotero-7-doi-translator-broken-in-scaffold
 2023-05-23 22:30:24 +03:00
Abe Jellinek
fd6ea99967 Item box: Always save current item when switching items 
Fixes #3125
 2023-05-23 19:40:09 +03:00
Abe Jellinek
61749d39a6 Item box: Populate both fields on creator autocomplete click 
Fixes #3129
 2023-05-23 19:06:56 +03:00
Dan Stillman
8440501ad2 Remove unused Zotero.isBigSurOrLater property 2023-05-23 01:55:31 -04:00
Dan Stillman
f9dab9b041 Show correct OS info in error reports 2023-05-23 01:55:31 -04:00
Dan Stillman
478dcc4f0f Add Zotero.Utilities.Internal.subprocess(command, args) 
To run a short-lived command and return stdout

The Subprocess module can also start long-running process and
communicate with them, but we'll implement something different for that
if we need it.
 2023-05-23 01:46:25 -04:00
Dan Stillman
522de4ad92 Add 32/64-bit info after version number in about dialog on Windows/Linux 2023-05-22 23:58:00 -04:00
Dan Stillman
66623b945e Temporary fix for context-menu options getting triggered on Windows 
https://forums.zotero.org/discussion/105103/right-click-on-collections-or-items-not-functioning-properly-in-zotero-7
 2023-05-22 06:16:53 -04:00
Dan Stillman
55fe6f33f5 fx-compat: Fix XMLSerializer calls 
https://forums.zotero.org/discussion/105118/zotero-7-error-upon-exporting-in-mods-format
 2023-05-22 01:34:41 -04:00
Dan Stillman
c653449cc0 Increase active tabs count from 2 to 3 on <=8 GB systems 
To match current Zotero 6 behavior on non-Windows systems
 2023-05-20 19:12:19 -04:00