mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Temporary fix for tab crashes caused by tab loading racing conditions

Browse source
This commit is contained in:
Martynas Bagdonas 2023-07-26 17:08:42 +03:00 committed by Dan Stillman
parent 7e28973f3a
commit 46d066394f
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
chrome/content/zotero/tabs.js
View file

@ -87,6 +87,9 @@ var Zotero_Tabs = new function () {
const multipleTabsOpen = this._tabs.length > 1;
document.getElementById('cmd_close').setAttribute('disabled', multipleTabsOpen);
var { tab } = this._getTab(this._selectedID);
if (!tab) {
return;
}
document.title = (tab.title.length ? tab.title + ' - ' : '') + Zotero.appName;
this._updateTabBar();
// Hide any tab `title` tooltips that might be open
@ -276,6 +279,7 @@ var Zotero_Tabs = new function () {
if (tab.id == this._prevSelectedID) {
this._prevSelectedID = null;
}
tabIndex = this._tabs.findIndex(x => x.id === id);
this._tabs.splice(tabIndex, 1);
document.getElementById(tab.id).remove();
// For unknown reason fx102, unlike 60, sometimes doesn't automatically update selected index
@ -364,7 +368,9 @@ var Zotero_Tabs = new function () {
}
if (this._selectedID) {
let { tab: selectedTab } = this._getTab(this._selectedID);
selectedTab.timeUnselected = Zotero.Date.getUnixTimestamp();
if (selectedTab) {
selectedTab.timeUnselected = Zotero.Date.getUnixTimestamp();
}
}
if (tab.type === 'reader-unloaded') {
this.close(tab.id);