Fix citation reordering by dragging in the citation dialog. Closes #3183

This commit is contained in:
Adomas Venčkauskas 2023-06-28 13:36:38 +03:00
parent abfe96fcaa
commit 1274f5f602

View file

@ -1396,15 +1396,23 @@ var Zotero_QuickFormat = new function () {
var _onBubbleDrop = Zotero.Promise.coroutine(function* (event) {
event.preventDefault();
event.stopPropagation();
if (!dragging) return;
// Find old position in list
var oldPosition = _getBubbleIndex(dragging);
// Move bubble
var range = document.createRange();
range.setStartAfter(event.rangeParent);
// Prevent dragging out of qfe
if (event.target === qfe) {
range.setStartAfter(qfe.childNodes[qfe.childNodes.length-1]);
}
else {
range.setStartAfter(event.target);
}
dragging.parentNode.removeChild(dragging);
var bubble = _insertBubble(JSON.parse(dragging.dataset.citationItem), range);
dragging = null;
// If moved out of order, turn off "Keep Sources Sorted"
if(io.sortable && keepSorted && keepSorted.hasAttribute("checked") && oldPosition !== -1 &&