Commit graph

12688 commits

Author SHA1 Message Date
Dan Stillman
5a82aa952d Don't allow note on embedded-image attachments
https://github.com/windingwind/zotero-better-notes/issues/212
2022-11-21 01:14:07 -05:00
Dan Stillman
7ffc509ee6 Fix response content type in Find Available PDF test 2022-11-21 01:14:07 -05:00
Dan Stillman
c6df0b586c Use clearer name for Find Available PDF tests 2022-11-21 01:14:07 -05:00
Dan Stillman
b5862ba780 Handle relative PDF links when using custom PDF resolver 2022-11-21 01:14:07 -05:00
Dan Stillman
1f0a721101 Fix focus stealing in item box (#2885)
Port of #2895
2022-11-21 01:14:07 -05:00
Adomas Venčkauskas
0e4cdda8c7 Prevent citation merging from being always enabled after refreshing the doc 2022-11-21 01:14:07 -05:00
PChemGuy
48d81c7d47 Fixed double-quoted string literals in SQL files (#2892)
Replaced double quotes around string literals with single quotes.
2022-11-21 01:14:07 -05:00
Abe Jellinek
00b387afc2
fx-compat: Toolbar fixes (#2922)
- Don't rely on Zotero.hiDPISuffix being initialized in menuToolbarbutton.js --
  it probably hasn't been at the time that the code that creates the dropmarker
  is running
- Fix merge mistake that created a duplicate block of CSS
2022-11-21 00:07:59 -05:00
Abe Jellinek
74492e40c4
Improve bidi & RTL support (#2415)
- Render cell text in its native direction
- Fix context menu positioning
- Fix item box (localizations needed)
- Fix column resizing
- Fix bidi text in collection tree
- Always right-align in RTL, always left-align in LTR.
  I'm going off advice from this excellent guide for RTL website design
  by Ahmad Shadeed: https://rtlstyling.com/posts/rtl-styling#tables
- Join creators in the tree ("Smith and Jones") using a format string to
  support languages like Arabic and Hebrew where there shouldn't be a
  space after the "and".
- Fix tabs
- Fix toolbar on Mac, flip icons on other platforms
2022-11-20 18:23:17 -05:00
Adomas Venčkauskas
93bba41dd5 Don't throw when getting potential proxies with invalid URL 2022-11-15 13:54:33 +02:00
Adomas Venčkauskas
ed46d8c53c Deproxify homepage URLs without trailing slash. Closes #2884 2022-11-15 13:22:52 +02:00
Dan Stillman
039142e50d Fix clearing of active quick search after annotation change
https://forums.zotero.org/discussion/90727/search-results-disappear
2022-11-14 22:55:17 -05:00
Abe Jellinek
a7b605f0cc
Add "Open PDF reader in new window" preference (#2868)
When enabled:
- Double-clicking a PDF or choosing "Open PDF" opens a new window
- Shift-double-clicking opens a new tab
- "Open in New Window" locate option becomes "Open in New Tab" and has the
  reverse behavior
2022-11-14 17:12:48 -05:00
Abe Jellinek
b6591dba5a
Make Feeds row into a selectable global view of feed items (#2800) 2022-11-14 16:55:28 -05:00
Abe Jellinek
318ec4074e
fx-compat: Style Editor: Validate inline (#2745) 2022-11-12 05:31:29 -05:00
Adomas Venčkauskas
e789872efe Improve cookie-sandbox behavior when getting attachments via WBP
Previously cookies only got attached on the initial request but not on
any redirect and subsequent request. This may have been the cause for
many reports of import failures behind proxies in the past.
2022-11-11 12:56:12 +02:00
Abe Jellinek
cda0e0cf6d
Add "Any Field" advanced search condition (#2902) 2022-11-10 21:55:09 -05:00
Abe Jellinek
177da5937e
Add "Add to Dictionary" to note editor context menu (#2897)
As well as "Undo Add to Dictionary", as in Firefox.
2022-11-10 17:50:40 -05:00
Adomas Venčkauskas
eaeb144c3b Fix a cookie sandbox regression e537018 2022-11-10 14:58:27 +02:00
Adomas Venčkauskas
56229136be Adjust tests to not use the dotsToHyphens proxy option 2022-11-10 12:46:14 +02:00
Adomas Venčkauskas
26f1d6125b Fix proxied urls not unproxifying (regression 1116b05f)
Technically this code has been wrong for a long time, but it only
manifest now. It seems that the equivalent code in translate module
was fixed when that code was extracted into a separate repo
2022-11-10 12:45:31 +02:00
Adomas Venčkauskas
249fbfad15 Update translate submodule 2022-11-10 12:28:44 +02:00
Adomas Venčkauskas
1116b05f1d Always replace dots to hyphens for https proxy schemes 2022-11-10 12:28:44 +02:00
Abe Jellinek
9cc2993e70 fx-compat: Fix Locate Manager appearance
- Correct padding and don't use Mozilla preferences styles
- Fixed v-t issue that applied the wrong class names to columns, giving them
  incorrect widths
2022-11-07 16:05:21 -05:00
Abe Jellinek
3af5976aa2 fx-compat: Preferences: Manage pref observers for elements added later 2022-11-03 11:52:54 -04:00
Abe Jellinek
e4b290a394 fx-compat: Replace more XUL createElement() calls 2022-11-02 16:01:48 -04:00
Abe Jellinek
76f844da2f Scaffold: Autocomplete translator IDs in setTranslator() calls 2022-11-01 16:36:44 -04:00
Abe Jellinek
ac8db7a376 fx-compat: Scaffold: Fix type-to-find not receiving ' ' 2022-11-01 16:05:17 -04:00
Abe Jellinek
1aebad3c19 Scaffold: Fix copying JSON test data
Previously only copied '[object Object]'.
2022-11-01 16:04:24 -04:00
Dan Stillman
b5ce8b655a Fix error copying from note if note Quick Copy format is "HTML"
In this case, Note Markdown wouldn't be preloaded, but it's always used
for copying from the note editor, and since the note editor uses
`noWait`, this would result in "Code promise is not resolved in noWait
mode".
2022-11-01 03:56:25 -04:00
Dan Stillman
cbb1ebad33 Fix Quick Copy drag after reiniting translators
Zotero.Translators.reinit() didn't reinit Quick Copy, so if an export
translator was selected it wouldn't be preloaded again and dragging
would fail with "Code promise is not resolved in noWait mode".
2022-11-01 03:19:22 -04:00
Adomas Venčkauskas
228e8407a7 Make colored tagging via keyboard layout independent
Report https://forums.zotero.org/discussion/100717/tag-number-shortcut-with-mac-raccourci-clavier-pour-marqueurs-avec-un-mac
2022-10-31 09:45:27 +02:00
Dan Stillman
8e59e49d29 Avoid infinite/excessive loops in Find Available PDF
https://forums.zotero.org/discussion/100634/potential-infinite-loop-when-trying-to-find-available-pdf

Closes #2883
2022-10-30 04:44:31 -04:00
Dan Stillman
4722366b42 Update Mac Word automation settings instructions for Ventura 2022-10-29 16:42:28 -04:00
Dan Stillman
7a45047f8f Fix comment for Zotero.Attachments.getPDFResolvers() 2022-10-29 04:41:16 -04:00
Dan Stillman
59cb33d231 Retry only twice on error in Find Available PDF
Not three times
2022-10-29 04:41:10 -04:00
Dan Stillman
06b23cca94 Fix hang on 500 from site during Find Available PDF
Find Available PDF has its own domain-based retry logic that predated
automatic 5xx retries in Zotero.HTTP, so disable the latter and fix some
bugs in the former.

Fixes #2700
2022-10-29 04:38:57 -04:00
Adomas Venčkauskas
d658e05363 Truncate long citation text in citation dialog. Closes #2879 2022-10-28 15:08:26 +03:00
Abe Jellinek
57916c032f
Attachment box: Add ability to copy URL of snapshot/link (#2748)
Fixes #2747
2022-10-27 16:54:50 -04:00
Dan Stillman
9869eb4bc8 Restore cell.csl for style tests
Removed in a28908f0b4
2022-10-27 05:07:46 -04:00
Dan Stillman
d850a8be7d Don't localize "Markdown" in Quick Copy settings 2022-10-27 05:06:55 -04:00
Dan Stillman
c6448bd9c1 Add Zotero.Utilities.Internal.stringWithColon() for localized colons
Generally just a colon, but, e.g., French adds a space before it. We'll
want to replace uses of `punctuation.colon` with this.
2022-10-27 05:05:47 -04:00
Dan Stillman
146d50c8d1 Update translators 2022-10-27 05:05:35 -04:00
Dan Stillman
c51cb88c97 Adjust layout of Quick Copy note format options
Also:

- Hide format options until translators are loaded (since otherwise
  the checkboxes don't have labels and the layout is messed up)
- Remove unnecessary "zotero-" prefix from the new elements
2022-10-27 05:04:16 -04:00
Dan Stillman
a95a2937c1 Reset note Quick Copy pref on upgrade if set to Markdown + Rich Text
The default JSON pref value used spaces, but changing the drop-down
resulted in a version without spaces, so simply changing the default to
include the new link options wouldn't change all existing installs and
the "Include App Links" checkbox wouldn't show as enabled for Markdown.
This adds a pref migration step to reset the pref to the new default if
it's set to Markdown + Rich Text, regardless of whitespace differences.
2022-10-27 04:50:04 -04:00
Martynas Bagdonas
da7c73b662 Add "Include Zotero Links" option for note export and QuickCopy
Fixes #2349
2022-10-27 04:49:11 -04:00
Dan Stillman
09f0f74104 Fix error message for invalid field in Item.setField()
The error message was showing a field instead of an item type.

https://forums.zotero.org/discussion/100598/error-1533410729-impossible-to-correct-date-field-in-items-added-with-zotero-conector-ver-6-0-15
2022-10-27 03:47:54 -04:00
Dan Stillman
3a77eb85ed Don't match all attachments with annotations for "not" search conditions
Fixes #2867
2022-10-27 03:46:18 -04:00
Dan Stillman
fe016edf33 PDF reader: Hide "Rotate Page 180°" menu option for now
Rotating will speed up with Zotero 7, so maybe we can do without this.
2022-10-27 03:43:34 -04:00
Dan Stillman
ff3a74064b PDF reader: Add "Page" to rotate menu options for clarity 2022-10-27 03:41:28 -04:00