mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't allow note on embedded-image attachments

Browse source 
https://github.com/windingwind/zotero-better-notes/issues/212
This commit is contained in:
Dan Stillman 2022-11-19 04:54:55 -05:00
parent 7ffc509ee6
commit 5a82aa952d
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
chrome/content/zotero/xpcom/data/item.js
View file

@ -2240,6 +2240,10 @@ Zotero.Item.prototype.setNote = function(text) {
throw ("updateNote() can only be called on notes and attachments");
}
if (this.isEmbeddedImageAttachment()) {
throw new Error("setNote() cannot be called on embedded-image attachments");
}
if (typeof text != 'string') {
throw ("text must be a string in Zotero.Item.setNote() (was " + typeof text + ")");
}
@ -5219,7 +5223,7 @@ Zotero.Item.prototype.fromJSON = function (json, options = {}) {
let parentKey = json.parentItem;
this.parentKey = parentKey ? parentKey : false;
if (!this.isAnnotation()) {
if (!this.isAnnotation() && !this.isEmbeddedImageAttachment()) {
let note = json.note;
this.setNote(note !== undefined ? note : "");
}