Commit graph

5543 commits

Author SHA1 Message Date
Dan Stillman
1f1c6d16ff Quit rather than restart when changing data directory 2013-03-20 16:45:09 -04:00
Simon Kornblith
5f2f120a98 Don't truncate text in Add Item by Identifier box at less than the full box width 2013-03-20 16:33:05 -04:00
Dan Stillman
7c3d6a54e8 Adjust bottom padding of prefpanes 2013-03-20 13:06:53 -04:00
Dan Stillman
ddd7cdf431 Use nicer alert for PDF tools download error 2013-03-20 05:10:48 -04:00
Dan Stillman
49a97d104b Fix strict mode error downloading PDF tools 2013-03-20 05:10:48 -04:00
Dan Stillman
a417c9ef59 Fix window height bug in Zotero preferences, and reorganize code
Prefpanes are now in separate overlays, which fixes the age-old resizing
bug when switching between panes (at least on OS X) that varied
depending on the initial pane. Code has also been moved into
pane-specific files and objects, with strict mode enabled. When calling
code from another pane (e.g., for a UI update in another pane), first
check whether the Zotero_Preferences.[Pane] object exists--if it doesn't
then nothing needs to be called.

This change breaks the word integration plugin pref overlays, which
hopefully can be rewritten to work with either overlay format.

There is a good chance that this breaks some other things in the
preferences too.

Fixes #243
2013-03-20 05:10:38 -04:00
Dan Stillman
41e2f3008e Sort empty titles last when title isn't primary sort
When sorting by Title, empty titles get sorted to the top of the items
list for visibility, but when sorting by another column and using the
title as a secondary/tertiary sort, empty titles should get sorted last
so that new empty items go to the end of the list rather than the
middle.

This is a little weird, and the alternative would be to just always sort
empty titles last even when sorting by Title, but this preserves the
current behavior for Title sorting. (Before f0f6772b01 titles weren't
used for secondary sorting at all, so there's no precedent for
title-sorting behavior when sorting by another column.)

Addresses #275
2013-03-19 15:59:40 -04:00
Dan Stillman
d69dc3d5a7 If Year column is visible and not Date, don't sort by full date
Otherwise use full date, even if Date column is hidden

Addresses #275
2013-03-19 15:42:39 -04:00
Dan Stillman
1647f28135 Fix error selecting separator above Group Libraries
This is super annoying, but I can't seem to stop the separator row from
being selected in seltype="single" mode (where isSelectable() isn't
called). Until we have a better solution, at least clear the items list
and avoid an error.
2013-03-19 06:53:48 -04:00
Dan Stillman
78618ff88b Fix collections-containing-an-item highlighting in Fx22+ 2013-03-19 06:16:11 -04:00
Dan Stillman
b1f80a3615 Use dateAdded rather than dateModified for final fallback sort
Addresses #275
2013-03-19 06:00:11 -04:00
Dan Stillman
f0f6772b01 Sort by title after creator and date, if not primary sort
Addresses #275
2013-03-19 05:16:31 -04:00
Dan Stillman
8bd7536c2c Remove reference to missing .dtd file 2013-03-19 02:25:58 -04:00
Dan Stillman
4717e3497f Fix missing "Deleted" in CR window
Addresses #273
2013-03-19 02:25:25 -04:00
Dan Stillman
cf54a5da34 Fix code style
Refs #274
2013-03-19 02:22:33 -04:00
Simon Kornblith
69d35f97b0 Merge pull request #274 from aurimasv/newItem-fix
Unbreak adding new items
2013-03-18 23:08:39 -07:00
Aurimas Vinckevicius
cc93a0c7b8 Unbreak adding new items. Broken by dbf6bc0ee1. 2013-03-19 01:05:53 -05:00
Simon Kornblith
67bccfc9fe Only show annotation toolbar on pages that already have annotations 2013-03-18 20:37:27 -04:00
Simon Kornblith
946c754ae7 Remove redundant line 2013-03-18 20:33:09 -04:00
Dan Stillman
22f9fc04a8 Fix update marking for uploaded file versions that exist remotely
If a file version existed on the server, the uploaded attachment wasn't
marked as updated until the next sync.
2013-03-18 20:28:16 -04:00
Dan Stillman
47299c9e85 Remove debug line and update error message 2013-03-18 20:27:54 -04:00
Dan Stillman
8e1b8022ad Download locally existing remotely modified files in on-demand mode
If a file doesn't exist locally it won't be downloaded until opened, but
if a file does exist locally and has been modified remotely the latest
version will be downloaded at sync time regardless of the file sync
mode. (If a locally existing file has been updated remotely, just
opening it won't currently download the latest version. You have to
sync. This may change in the future.)
2013-03-18 20:21:48 -04:00
Dan Stillman
0853dbc070 Fix problem with items list scrollbar size between views
Caused by 2cd45be191, though not sure why it's happening.
2013-03-17 16:12:46 -04:00
Simon Kornblith
c457139573 Merge pull request #270 from aurimasv/RDFimport
Fix RDF import for large notes
2013-03-17 13:05:14 -07:00
Dan Stillman
9796e60617 Don't update item when tabbing through empty Date field 2013-03-17 03:49:31 -04:00
aurimasv
f3bda1643d Normalize DOM nodes after parsing 2013-03-17 02:43:41 -05:00
aurimasv
d974c78cef Add $rdf.log.error for rdflib.js 2013-03-17 02:43:41 -05:00
aurimasv
dbf6bc0ee1 Don't attempt to mark changes when creating new item. 2013-03-17 02:43:41 -05:00
Dan Stillman
147f325e40 Merge locales from Transifex 2013-03-17 03:34:42 -04:00
Dan Stillman
36eae6ad00 Update child attachment order when renaming attachment
Also show "1" next to child attachments with embedded notes
2013-03-17 03:14:29 -04:00
Dan Stillman
9bddef21b7 Fix collection row selection issue on Windows 2013-03-17 02:41:43 -04:00
Dan Stillman
5a863d97c8 Context-menu string cleanup
- Remove all "Selected" from "Selected Item", because that's how a context menu works
- Change "Remove Selected Item" to "Remove Item from Collection" (fixes #122)
- Change "Delete Selected Item from Library" to "Move Item to Trash")
- Change "Remove" on Duplicate/Unfiled Items to "Hide" (fixes #122)
- Change "Create Parent Item from Selected Item" to "Create Parent Item"
2013-03-17 01:22:47 -04:00
Simon Kornblith
3c6728e30f Remove unnecessary version checking code 2013-03-16 23:51:34 -04:00
Dan Stillman
022ee4481b Add "Delete Collection and Items..." context-menu option
Also update collection/search deletion dialogs with better button text and no more "[JavaScript Application]"
2013-03-16 22:55:50 -04:00
Dan Stillman
5f283a6b7f Fix tag selector glitch after removing last tag, again
Better fix than 4e1fbf9747
2013-03-16 16:25:58 -04:00
Dan Stillman
edfdbdec1c Keep tag selector label heights consistent
Use a transparent border so that the height is the same with or without
zotero-clicky being set
2013-03-16 16:25:58 -04:00
Dan Stillman
0f87772b97 Fix broken checkboxes in tag selector context menu (OS X only?)
On OS X, the checked state of <menuitem type="checkbox"/> still doesn't
work right if set before the menu is opened. To get around this, the
state is now set manually in onpopupshown(). There's an annoying delay
before the UI update, but this is better than nothing.
2013-03-16 16:25:58 -04:00
Dan Stillman
fec159f969 Fix error on tag change without a selected item (from 1e59c5ab7) 2013-03-16 16:25:58 -04:00
Dan Stillman
6dbe1d1e19 Show colored tags in tag selector in all views
Always show colored tags at the top of the tag selector, regardless of
whether they're in the current scope. If not, they're shown with reduced
opacity (as an equivalent to the gray style for out-of-scope tags in
Display All Tags mode). As a corollary, colored tags are now shown even
if they have no associated items and will remain until they're
explicitly deleted.

Also:

- Don't show outline on out-of-scope tags in "Display All Tags" mode
2013-03-16 16:25:51 -04:00
Dan Stillman
2b7d7ebfbf Don't rely on object property order to sort tags
It works, but in theory it's not guaranteed in JS.
2013-03-15 17:44:07 -04:00
Dan Stillman
2b4f2e3a0f Merge branch '3.0' into 4.0 2013-03-15 17:01:44 -04:00
Dan Stillman
d726ce41fa Fixes incorrect post-edit scrolling
Fixes #268, broken in 2cd45be191

Post-edit scrolling can probably be smarter, but this fixes the brokenness.
2013-03-15 16:56:55 -04:00
Dan Stillman
a1197883bb Disable key navigation on 1-6 keys if any tag colors are assigned
Previously any unused numbers were still available for key navigation, but I
think it's too easy hit the wrong key that way, and getting moved to another
part of the items list is annoying.
2013-03-15 14:09:31 -04:00
Dan Stillman
3faa8949ef Fix glitch entering tag with whitespace
If an existing colored tag was added to an item with whitespace around it, the
tag didn't immediately show up with a color.
2013-03-15 04:39:57 -04:00
Dan Stillman
1e59c5ab7e More tags box fixes (follow-up to f932f312eb)
Use the Notifier for all tags box updates to ensure that it always updates.

Also fix the tag count and some other things.

Post-tab focus still isn't 100% correct in all situations, but it's real close.
2013-03-15 04:13:14 -04:00
Dan Stillman
4e1fbf9747 Fix clearing selected tag when removed from last item in view
I somehow broke this in d2f028d797, though
I'm not sure how.
2013-03-14 20:06:34 -04:00
Dan Stillman
d60b0221db Fix error trying to toggle colored tag with no tag
(This should be fixed so that the setting is always removed, though.)
2013-03-14 19:03:20 -04:00
Dan Stillman
e20bd35756 Don't clear other tag colors when rename colored tag 2013-03-14 19:00:52 -04:00
Dan Stillman
e68f87fc83 Update translators and repotime 2013-03-14 02:42:01 -04:00
Dan Stillman
0f85b07aad 3.1 is now 4.0 2013-03-14 01:27:54 -04:00