Commit graph

8264 commits

Author SHA1 Message Date
Adomas Venčkauskas
0f9b073073 Ensure retracted item suppression is saved on any integration operation 2019-07-03 13:55:16 +03:00
Dan Stillman
0beddb9680 Add flags to disable retraction warnings
Separate flags for hiding the retraction altogether and for hiding
citation warnings for it

New functions:

Zotero.Retractions.hideRetraction(item)
Zotero.Retractions.shouldShowCitationWarning(item)
Zotero.Retractions.disableCitationWarningsForItem(item)

Addresses #1710
2019-07-03 01:23:02 -04:00
Dan Stillman
f49d5805cd Apply subtitle capitalization to additional styles
This also fixes a style initialization error when the style id is
invalid, which was a regression in a0be2da42c.
2019-07-01 22:39:12 -04:00
Dan Stillman
d13ffcd9a3 Revert "Temporarily disable "Export Document…" button for 5.0.69"
This reverts commit a6e9d76c41.
2019-06-25 23:53:47 -04:00
Dan Stillman
fb101e8fe6 Fix hanging indent in HTML output after citeproc-js 1.2.2 (5.0.57)
The patch in 0036e0a1e for the change in citeproc-js behavior was
incomplete.
2019-06-25 23:36:57 -04:00
Dan Stillman
317983fc7a Update locales from Transifex 2019-06-24 22:43:06 -04:00
Dan Stillman
a6e9d76c41 Temporarily disable "Export Document…" button for 5.0.69 2019-06-24 21:22:34 -04:00
Dan Stillman
aba37b31e4 Fix error from retractions notifier handler on group modification 2019-06-23 20:01:26 -04:00
Dan Stillman
d0f976f6bd Update locales from Transifex 2019-06-22 05:45:16 -04:00
Dan Stillman
99613b0cbe "Restore to Online Library" → "Replace Online Library"
Without an accompanying "Restore from Online Library" option, which
doesn't currently exist, "Restore to Online Library" can be interpreted
two ways. It's clear if you read the text below or the confirmation
prompt, but if you don't you might accidentally do something very bad.

This was almost certainly also translated in misleading ways in other
locales.
2019-06-22 05:44:50 -04:00
Dan Stillman
ead93b6ccc Stop uploading files on quota error until next manual sync or restart 2019-06-22 05:29:47 -04:00
Dan Stillman
94795095f2 Fix potential error on retracted item modification
If a retracted item was in the trash at startup or when detected and
there were no other retracted items in the library, an error would occur
if the item was modified.
2019-06-20 18:18:10 -04:00
Dan Stillman
c1ab361c92 Revert "Temporarily disable "Export Document…" button for 5.0.68"
This reverts commit f38ae94259.
2019-06-20 16:25:41 -04:00
Dan Stillman
f38ae94259 Temporarily disable "Export Document…" button for 5.0.68 2019-06-19 17:24:34 -04:00
Dan Stillman
288ad93422 Fix startup error due to missing retractedItems table
This shouldn't be possible, but there've been a couple reports of people
ending up on version 103 without the table, so create it again with IF
NOT EXISTS. This is obviously a bad fix, but until we know how this
happened it's the best we can do.
2019-06-19 17:06:05 -04:00
Dan Stillman
50a4308514 Remove retraction flag from items that no longer match 2019-06-19 06:41:33 -04:00
Dan Stillman
48c3fc33df Update locales from Transifex 2019-06-19 02:17:53 -04:00
Dan Stillman
8589aae7bc Fix retracted items in unloaded libraries not being flagged correctly 2019-06-19 02:11:37 -04:00
Dan Stillman
7306fe910d Fix updating of Next button in RTFScan (regression from 269e2f8bff)
And fix a logged warning
2019-06-16 02:33:24 -04:00
Dan Stillman
e3e6b8ef9c Revert "Temporarily disable "Export Document…" button for 5.0.67"
This reverts commit 487d675783.
2019-06-16 02:33:24 -04:00
Dan Stillman
e06f531dae Update locales from Transifex 2019-06-14 11:26:28 -04:00
Dan Stillman
dc670938a4 Update submodules 2019-06-14 11:18:04 -04:00
Dan Stillman
487d675783 Temporarily disable "Export Document…" button for 5.0.67 2019-06-14 11:16:14 -04:00
Dan Stillman
75712ed42d Remove "Move to Trash" button in item retraction banner
There can be situations where people legitimately want to keep the item,
so encouraging deletion is a bit presumptuous.
2019-06-13 12:22:54 -04:00
Dan Stillman
afd5b2f993 Update locales from Transifex and merge new English strings 2019-06-13 00:09:04 -04:00
Dan Stillman
ae7a262592 Don't switch to Retracted Items for single item from banner View button
Only for multiple items
2019-06-13 00:09:04 -04:00
Dan Stillman
45f6492494 Adjustments to citation retraction warning (#1704)
- Fix don't-show-again checkbox for non-DB items
- Tweak warning text
- Don't show comma after year if year is missing (which it shouldn't be)
- Remove redundant try/catch
2019-06-13 00:08:49 -04:00
Adomas Venčkauskas
4337362a1b Add a checks and prompts for retracted items within an existing doc 2019-06-13 00:57:56 +03:00
Dan Stillman
b4b19c4811 Add Zotero.Retractions.getRetractionsFromJSON()
Addresses #1703
2019-06-12 01:05:49 -04:00
Dan Stillman
d353439980 Add retractions.enabled hidden pref to disable retraction checking 2019-06-11 21:24:17 -04:00
Dan Stillman
e69786bd69 Fix error and show File Not Found dialog opening attachment with empty path 2019-06-11 06:46:46 -04:00
Dan Stillman
ccc4dccffd Fix error copying attachment without path to another library 2019-06-11 06:46:09 -04:00
Dan Stillman
f7f55f05ad Percent-encode " character in DOIs when opening/copying as link
I'm not sure a double-quote actually appears in any DOIs, but it's
technically valid and would result in an invalid URL.

Follow-up to 782c2a1d1

Addresses #295
2019-06-10 17:06:59 -04:00
Dan Stillman
5e1beed6fd Update locales from Transifex 2019-06-10 15:52:20 -04:00
Dan Stillman
d7417af83e Update submodules 2019-06-10 15:00:55 -04:00
Dan Stillman
782c2a1d15 Don't URL-encode most characters in DOIs when opening/copying as link
Only #, ?, and % are now encoded.

Addresses #295
2019-06-10 14:56:28 -04:00
Dan Stillman
98d2b69020 Update locales from Transifex and merge new English strings 2019-06-10 02:50:47 -04:00
Dan Stillman
5c03813d81 Add Retracted Items virtual collection
Shown automatically when retracted items are detected
2019-06-10 02:38:42 -04:00
Dan Stillman
502f5fe491 Run notifier observers in tests after all others
This ensures that main functionality will have already run if a test
waits on the same event.
2019-06-10 02:20:11 -04:00
Dan Stillman
e807f98e02 Retracted items: Fix "Move to Trash" button not appearing 2019-06-10 02:18:49 -04:00
Dan Stillman
cf8d383027 Add "Show Item in Library" button to retracted citation warning 2019-06-07 23:05:25 -04:00
Dan Stillman
368b057104 Use toJSON() if available when running Zotero.debug() on objects 2019-06-07 21:22:52 -04:00
Dan Stillman
b793c0c406 Hard-code short PMID to avoid sending
The PMID prefix length is 5 and there are no other PMIDs under 5 digits,
so a 3-digit PMID would be identifiable.
2019-06-07 10:20:33 -04:00
Dan Stillman
4939dd49a8 Update locales from Transifex and merge new English strings 2019-06-07 08:45:06 -04:00
Dan Stillman
47164edea6 Retraction improvements
- Fix list download logic
- Close bar when clicking "View Item"
- Don't show "Move to Trash" if item isn't editable
- Download new list if cached version differs from client
- Reduce height of notification bar
- Switch to a slightly darker red
2019-06-07 08:21:15 -04:00
Adomas Venčkauskas
75b38caf6f Add a warning when citing a retracted item 2019-06-07 12:59:42 +03:00
Dan Stillman
30849303a4 Remove unnecessary title for retracted-item cite warning 2019-06-07 04:33:02 -04:00
Dan Stillman
d0412e1fbb Add "Move to Trash" button in item retraction header 2019-06-07 04:20:55 -04:00
Dan Stillman
faf9e7002c Strings for retraction warnings when citing 2019-06-07 04:00:33 -04:00
Dan Stillman
28326cd4cd Add license block to file 2019-06-07 02:24:23 -04:00