Commit graph

14662 commits

Author SHA1 Message Date
abaevbog
0352fa35b4
OpenURL resolver pref: Fix glitchy drop-down keyboard navigation (#4506)
- minor refactoring to avoid deleting the first ("Custom") menuitem
of the resolver menulist. It is the first item that is selected when
popup opens and deleting it confuses keyboard navigation, so that
arrowDown/Up won't navigate the menu (unless the menu is hovered
over with a mouse)
- explicitly re-select the first item when the menulist closes.
Otherwise, in case of having navigated the menus with arrows
without changing selection and closing the popup, next time
resolver selector appears, arrowUp/Down will not navigate the list.
Only occurs on Windows.
- clear the resolver menus (except for the 1st item) when the popup closes
so that arrowUp/Down on focused dropdown don't select invalid
top-level menus (e.g. "North America").
- make sure that if the URL has been edited, the resolver dropdown's
value will switch to "Custom" even if the resolvers were not loaded

fixes: #4491
2024-08-06 01:31:47 -04:00
Dan Stillman
802210a6bc Quick Format: Use 450px for max-width 2024-08-06 01:21:56 -04:00
Bogdan Abaev
d446fc3c6f Quick Format: wrap description text of citation properties
- set max-width on the actual citation properties popup
- refactor _buildItemDescription to construct item description
as an array of spans, instead of labels, so that the
text can properly wrap.
2024-08-06 01:21:52 -04:00
Abe Jellinek
36e499c259
ExternalLinkHandler actor: Open some links internally, incl. styles (#4505) 2024-08-06 01:12:41 -04:00
windingwind
129938c8fe
Fix quick search styling (#4501)
fix: #4497
fix: #4498
2024-08-05 05:01:59 -04:00
abaevbog
c5027106c2
fix keyboard focus not landing on feeds itemTree (#4495)
Do not use specific "#item-tree-main-default" selector to
find the itemTree node to focus since a different id
can be set for the table, e.g for the list of feeds.

Use a more general "zotero-items-tree .virtualized-table"
selector to focus the itemTree on tab from quickSearch
and on Escape keypress from an editable-text of itemPane.

Fixes: #4494
2024-08-05 00:39:39 -04:00
Dan Stillman
256efd3195 Update utilities submodule
For zotero/utilities#28
2024-08-05 00:28:42 -04:00
Dan Stillman
e307b5e4d8 Update English strings for Transifex 2024-08-04 08:35:26 -04:00
Dan Stillman
4e889934b9 Use 28px tree row height in Comfortable mode at default font size
In line with design
2024-08-04 08:34:39 -04:00
Dan Stillman
71d2cbd66a Clarify 32-bit upgrade message 2024-08-04 08:33:31 -04:00
Dan Stillman
b4f6c050e5 Update reader submodule 2024-08-03 02:20:06 -04:00
Dan Stillman
17c0aa9ef3 Update locales from Transifex 2024-08-03 02:19:09 -04:00
Dan Stillman
833b85d33a Use 22px tree row height in Compact mode at default font size
In line with design

Tested on macOS and Windows
2024-08-03 02:08:17 -04:00
Abe Jellinek
30cb2e1721
Retrieve Metadata & Create Parent: Use autoRenameFiles.fileTypes (#4488) 2024-08-03 01:30:07 -04:00
Abe Jellinek
8209ee6279
File Renaming: Rearrange prefs (#4487) 2024-08-03 01:28:28 -04:00
Kassian Sun
aa19153ebc
Setting - Feeds fix misaligned unread/read cleanup option (#4489) 2024-08-03 00:27:30 -04:00
Tom Najdek
144f2caed8
Use production builds of react libraries (#4482)
And remove patching that doesn't seem to be required anymore
2024-08-02 03:43:02 -04:00
Abe Jellinek
11a5853657
Auto-rename file and set automatic title after Create Parent Item (#4474) 2024-08-02 02:44:41 -04:00
Abe Jellinek
e40cf686bc Remove duplicate CSS rule 2024-08-02 02:01:34 -04:00
Abe Jellinek
56bcd8e69c lookup.js: Code style fixes
Should look into updating our ESLint config so it doesn't yell so much
about multiline comments at the beginning of blocks.
2024-08-02 02:01:34 -04:00
Abe Jellinek
1ca243fa8c Add by Identifier: Fix popup positioning 2024-08-02 02:01:34 -04:00
Abe Jellinek
41031bc995 Update reader submodule 2024-08-01 13:13:30 -04:00
Abe Jellinek
6cb6dd3bb5 File renaming: Fix empty value being added when all types are disabled
And filter out empty values in isRenameAllowedForType() in order to
handle bad pref values set before this commit.

Follow-up to aab90527ec
2024-08-01 10:30:21 -04:00
Abe Jellinek
aab90527ec isRenameAllowedForType(): Handle empty autoRenameFiles.fileTypes
Previously, an empty value for the pref would be treated as matching
*every* MIME type, because s.startsWith('') is true for any string. That
meant that unchecking all the file type checkboxes would actually enable
renaming for all files.
2024-08-01 10:21:18 -04:00
Martynas Bagdonas
61d6ef8d3d Fix context pane leak keeping reader and note-editor iframes in memory
Fixes #4447
2024-08-01 16:04:15 +03:00
Dan Stillman
687399d9b0 Update styles submodule 2024-08-01 01:45:28 -04:00
Dan Stillman
f93718d0af Update reader submodule 2024-08-01 01:45:28 -04:00
windingwind
9a9f11c5e3
Fix attachment annotation box render on non-PDF items (#4478) 2024-08-01 01:45:03 -04:00
Tom Najdek
7c3d04e03a
Warn users running non-ARM version on ARM CPU (#4473) 2024-08-01 01:22:03 -04:00
Abe Jellinek
41fe1e4aea
Create Parent Item: Only call ReactDOM.createRoot() once (#4472)
Also applied to Zotero.AnnotationBox
2024-08-01 00:44:34 -04:00
Abe Jellinek
255de649ca
Autofocus input in Create Parent Item dialog (#4476) 2024-08-01 00:28:53 -04:00
Abe Jellinek
804b2d1216
Tests: Fix importFileAttachment() logic, update outdated test (#4475)
After dd16017
2024-07-31 16:24:19 -04:00
Dan Stillman
374dab2cb4 Update translators 2024-07-31 03:33:31 -04:00
Dan Stillman
93c4fd346f Update locales from Transifex
And fix some whitespace issues
2024-07-31 03:32:47 -04:00
windingwind
98d1f84263 Fix banner style on Windows (#4466)
fix: #4449
2024-07-31 03:23:51 -04:00
windingwind
ed983484d1
Fix note editor tooltip (#4436) 2024-07-31 03:19:26 -04:00
Dan Stillman
072cf33de2 Update locales from Transifex 2024-07-31 03:18:45 -04:00
Dan Stillman
3d85eb663c Merge new English strings 2024-07-31 03:18:45 -04:00
Dan Stillman
fd232e8ac5 Update reader submodule and add new reader strings 2024-07-31 03:18:45 -04:00
Abe Jellinek
dd1601793c
Don't set default attachment title if not renaming file (#4459)
Except from Rename File from Parent Metadata.
2024-07-31 01:39:25 -04:00
windingwind
06f359df23 Fix merge window style (#4430) 2024-07-31 01:37:37 -04:00
windingwind
99a2b83cb6 Fix CR attachment box (#4430) 2024-07-31 01:37:31 -04:00
Abe Jellinek
15fa86410d Update Advanced Search styles (#4464) 2024-07-31 01:35:48 -04:00
Abe Jellinek
fbcadd06ba Update progress queue dialog styles (#4464) 2024-07-31 01:35:43 -04:00
Abe Jellinek
74b86a7033 Make macOS control normalization into a mixin (#4464)
And include in stylesheets that have been updated.

Have to make sure not to include this mixin in the global scope in
stylesheets that are themselves imported elsewhere (i.e., filename
begins with an underscore).
2024-07-31 01:35:31 -04:00
windingwind
c7757131a6
Fix Prefs window style on Windows (#4465) 2024-07-31 01:28:05 -04:00
windingwind
6530ccd101
Fix Zotero.Item.fileExists calling on unsaved item (#4468) 2024-07-31 01:19:31 -04:00
Tom Najdek
a538a5588e
Reset file renaming preference if input left empty (#4462) 2024-07-30 23:08:41 +02:00
Dan Stillman
1d5971c48f Windows: Change Zotero version in "Add or remove programs" after update
Fixes #4454
2024-07-30 02:20:04 -04:00
Abe Jellinek
73a317b8d8 Add gap between file type checkboxes on macOS (#4458) 2024-07-30 01:29:12 -04:00