This commit adds a badge to the tray icon that displays the number of
unread messages, if there is any. It is implemented by providing
alternative versions of the icon, that replace the default image when a
message is received.
The badge is rendered graphically as a red circle containing the number
of unread messages. Since a different icon file is needed for each
possible number of unread messages, but this number is clearly
unbounded, only the numbers from 1 to 9 are provided. If there are 10 or
more unread messages, a single badge (depicted as "9+") is used.
Resolves#1917
* api.js: HttpError now preserves more of original error info
* Allow invalid conversation to be added to ConversationController
If a number we don't believe is valid comes in as part of a group, we
fall apart. We event prevent display of that conversation. Because we
have 'isValid()' protections in place for the places we create contacts
from user input in desktop (the search bar), we can temporarily add an
invalid contact to our collection (not saving it to the database) to
unblock this group scenario.
Still investigating what kind of phone number is valid in a mobile app
but not valid for us.
* Finish the debuggable error support
* Fix logging in the case of an invalid number
* A number of fixes required for successful build after upgrades
- extract now takes an absolute directory only
- something changed, so we now need to force NODE_ENV=production; we use
electron-is-dev for this
- electron-builder, electron-publisher-s3, and electron-updater are now
updated to their latest available versions
* Add direct dependency on extract-zip, since we use it directly
* Load 'config' module after we've modified NODE_ENV
* Downgrade electron-builder due to bug, downgrade icon-maker too
The latest electron-builder came with a fix for one of our bugs as well
as a new bug that blocks builds on Windows: https://github.com/electron-userland/electron-builder/issues/2462
There's no good reason to upgrade icon-maker. And a good reason to keep at the version on github: https://github.com/jaretburkett/electron-icon-maker/issues/7
Update to Electron 1.7.10 (#1919)
Fix issue where clicking Windows notification breaks window out of
aero-snap location (#1918)
Fix issue where old log data would persist in logs dir (#1945)
Fix issue where disabled send field (in the middle of send) could be
edited after click (#1937)
Update strings (#1921)
Dev:
- Fix error to console when verifying contact in standalone mode
(#1961)
- Remove all built assets from repo (#1955)
- Log out information from DOMException when import fails (#1923)
- Log clearer messages regarding prekey/signed prekey fetches (#1961)
- Make errors more debuggable; capture correct stack, include name
(#1944)
- Add eslint/mocha with code coverage for non-browser code (#1945)
- Revamped github issue and pull request templates, updates to
contributing.md/readme.md (#1955 and #1956)
- Document building/testing releases in Contributing.md,
thanks @veggiedefender (#1867)
- Update a number of dependencies to the latest: builder, websocket,
spellcheck (#1920)
* Revamp issue and pull request templates, other docs tweaks
`yarn test` now runs all of our tests.
* Remove generated files from the repository
* Update to new Signal support URL
* Prevent the 'Test failed 2 == 1' from test-release in CI
* Another attempt to fix grunt test-release on Appveyor
* grunt test-release: Fail build if test fails
* Lint fix, and move jshint earlier in CI process
* Clean logs on startup; install server-side testing/linting
* Add eslint config, make all of app/ conform to its demands
* Add Node.js testing and linting to CI
* Lock project to Node.js 7.9.0, used by Electron 1.7.10
* New eslint error: trailing commas in function argumensts
Node 7.9.0 doesn't like trailing commas, but Electron does
* Move electron to devDependency, tell eslint it's built-in
No more errors like this in the logs!
```
INFO 2018-01-05T18:33:15.942Z Message.saveErrors: null Error
at file:///C:/Users/Test/AppData/Local/Programs/signal-desktop/resources/app.asar/js/libtextsecure.js:30:33
at file:///C:/Users/Test/AppData/Local/Programs/signal-desktop/resources/app.asar/js/libtextsecure.js:138:3
at file:///C:/Users/Test/AppData/Local/Programs/signal-desktop/resources/app.asar/js/libtextsecure.js:40718:3
```
It has no information in the title, and then the callstack points to
the `new Error()` line in the old `errors.js`.
This change will include the actual error name and message details in
the stack, and will include the original http error stack as well if
provided.
* Preserve disabled state in send-message field on click
Also: get consistent in treatment of 'disabled' property.
* Add some comments explaining how audio recording dismissal works
Note: This release is the same thing as https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v1.1.0-beta.6
Listed below are the changes from the previous production release: https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v1.0.41
Update to electron 1.7.9 (#1736)
Support the latest phone number formats via libphonenumber update (#1899)
Reduce download size by ~25MB over the previous production build (#1869)
Emoji - thanks @liliakai:
- Emoji picker (#1608)
- Add support for Emoji 5 (#1797)
Notifications:
- Windows 7: Use an alternate mechanism for notifications (#1812)
- Prevent drawAttention() when notifications are turned off - thanks @canerelci! (#1612)
Linux:
- Support for current (artful) and previous (xenial) ubuntu versions (#1856)
- Fix missing application icon on some Linux distributions (#1735)
- Fix issue where window would not show new message alerts on some Linux systems - thanks @cornerman (#1820)
- Add .deb specific dependencies - thanks @veggiedefender (#1858)
The default button is now 'later', not 'restart' in the 'update available' dialog (#1894)
Make the window minimum width a little smaller - thanks @emptyflask (#1863)
Intl-friendly sort order for contact lists (#1900)
Fix issue where update would restore deleted windows shortcut (#1804)
Fix issue where .tif file attachments could not be sent or received (#1901)
(in testing) Add a tray icon to the application behind command-line argument - thanks @m-pilia (#1676)
--use-tray-icon enables the tray icon
--start-in-tray enables the tray icon and the application starts minimized in the tray bar
(in testing) Support pass-through proxies with HTTPS_PROXY environment variable (#1878)
Dev:
- Display of environment and app instance in title bar/about window (#1606)
- Support for beta releases installed beside production versions (#1606)
- Fix json parsing exceptions obscuring server errors (#1605)
- Be resilient to thrown non-errors in import process (#1737)
Fix issue where .tif file attachments could not be sent or received
(#1901)
Support the latest phone number formats via libphonenumber update
(#1899)
Intl-friendly sort order for contact lists (#1900)
Show window if hidden to tray when second instance attempts to start
(#1897)
Make the window minimum width a little smaller - thanks @emptyflask
(#1863)
Fix issue where duplicate emoji were listed in the emoji panel (#1893)
The default button is now 'later', not 'restart' in the
'update available' dialog (#1894)
Dev:
- Add .deb specific dependencies - thanks @veggiedefender (#1858)
Some barebones debian-based systems (e.g. Docker containers) don't come with the libasound2 and libxss1 libraries, which electron-builder does not include by default.
This prevents the user from restarting the app by pressing space on
MacOS, which happens frequently during the course of normal typing of a
message.
In the future we'll move to a less-obtrusive system a little
more like Chrome, where you choose to do the restart when it is
convenient for you. For now, we minimize the chance of accidental
restart in the middle of typing a message.
We've simplified; HTTPS_PROXY or https_proxy is used for all requests.
We also require that only our self-signed certificates are used for
secure traffic. That rules out all SSL-terminating MITM proxies, since
we don't trust their root certificate.
Once we're sure that this system works for people, we'll improve config
on MacOS and Windows.
Reduce download size by ~125MB versus the previous beta build, about
~25MB over the previous production build (#1869)
Dev:
- Update to v1.0.41 equivalence
(5bc70c35e7)
- This update to match production includes update fixes for OSX.
Note: The transition v1.1.0-beta.3->v1.1.0-beta.4 will still have
upgrade difficulties. When v1.1.0-beta.4 updates to the next release
version, the behavior will be fixed.
Fix issue where 'upgrade to new version' dialog would not restart app on
OSX (#1866)
Note: The transition v1.0.40->v1.0.41 will still exhibit this problem.
When v1.0.41 updates to the next release version, the behavior will be
fixed.
Add proxy support based on environment variables (#1855)
Fix issue where window would not show new message alerts on some Linux
systesm - thanks @cornerman (#1820)
Add a tray icon to the application behind command-line argument -
thanks @m-pilia (#1676)
Emoji:
- Fix issue where clicks in emoji panel wouldn't do anything (#1849)
- Add support for Emoji 5 - thanks @liliakai (#1797)
- Eliminate unused emoji images from production package (#1849)
Deployment:
- aptly.sh: support for current and previous ubuntu versions (#1856)
- deployment: update electron-publisher-s3 to match builder update
(17f0bb42bc)
Dev:
- Update development branch to include everything up to v1.0.40
(f013eed9d1
and 3ac29a4ba3)
- Update readme.md to use signal.org URLs - thanks @scienmind (#1814)
Fix bug where previously-deleted contacts are re-added to left pane on
contact import (#1811)
Fix bug where the main window would be created off-screen, inaccessible
(#1830)
Fix issue where certain sync messages to iOS would result in a new
message alert (#1843 and #1857))
Key rotation updates (#1833 and #1846):
- Save prekeys optimistically after generation, even if upload appears
to fail
- Track confirmations from server in prekey
- New prekey cleanup behavior: favoring confirmed keys, but always
keeping three
- Log all failures resulting from signed prekey rotation
- Retry rotation if we run into a failure
- Force rotation when starting up new version, to fix Chrome
interference (https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v0.44.13)
Dev:
- Verify that saved window location/size data is valid before creating
window (#1830)
- A variety of logging improvements to help track down bugs (#1832 and
#1836)
We pull proxy settings from environment variables:
- HTTPS_PROXY for sending, profile pulls, and attachment download/upload
- WSS_PROXY for connecting to the websocket for receiving messages
- ALL_PROXY to provide one server for both
More details on our proxy handling:
- https://github.com/Rob--W/proxy-from-env#environment-variables
- https://github.com/TooTallNate/node-proxy-agent
This is the natural way of things for Linux. My understanding is that
most proxies on MacOS are system-wide and transparent, so it's not so
urgent. But Windows will likely require further UI for configuration.
Will need to do some testing with Windows users.
* Emoji: Ensure that all clicks work by using emoji data directly
* Eliminate a number of unused emoji images from final build
* Re-add the generic sheets directory, which we partially filter
* Re-enable libtextsecure unit tests, get passing, run in CI
* Save prekeys optimistically, track confirmed, new clean behavior
* Eliminate potential conflicts when rotating on startup
* Remove last symlink: get libtextsecure tests running on windows
* Validate config-provided locatio against available screens
* Increase buffer around screen from 10px to 100px
* Protect against null mainWindow, fix height/width typo
* Properly handle missing x and y
* Move to _.isNumber for checking x and y
* Use greater than or less than to allow for y = 0, exactly 100px
