Delay our call to quitAndInstall(); doesn't work inside callback (#1866)

This commit is contained in:
Scott Nonnenberg 2017-12-06 12:44:23 -08:00 committed by GitHub
parent 1432d9853b
commit e96502ba5e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -40,8 +40,13 @@ function showUpdateDialog(mainWindow, messages) {
dialog.showMessageBox(mainWindow, options, function(response) {
if (response == RESTART_BUTTON) {
windowState.markShouldQuit();
autoUpdater.quitAndInstall();
// We delay these update calls because they don't seem to work in this
// callback - but only if the message box has a parent window.
// Fixes this bug: https://github.com/WhisperSystems/Signal-Desktop/issues/1864
setTimeout(function() {
windowState.markShouldQuit();
autoUpdater.quitAndInstall();
}, 200);
}
showingDialog = false;