Commit graph

19152 commits

Author SHA1 Message Date
Joey Hess
c705df5651 remove windows-specific rsync.net code, no longer necessary thanks to ssh password handling
Since ssh password prompting no longer happens on stdin, the
authorized_keys line can be sent on stdin. Yay!
2014-05-15 12:30:29 -04:00
Joey Hess
f41b585c29 force strict host key checking when host is known
Avoid any possibilty of prompting in ssh setup in webapp.

Prticularly on Windows this was a problem, it seemed to enter an infinite
loop. I think that ssh can sometimes use SSH_ASKPASS for y/n prompting,
when no controlling TTY is available, and since git-annex always answers
back with the host's password, not y/n, it looped.

This commit was sponsored by Simon Michael.
2014-05-14 18:13:53 -04:00
Joey Hess
a66c942645 refactor 2014-05-14 17:31:20 -04:00
Joey Hess
74f937cc55 this will hopefully make the ssh askpass work on windows 2014-05-14 17:13:20 -04:00
Joey Hess
a11176bab3 avoid clobbering existing env
This is necessary on windows, ssh couldn't resolve hostnames without env
for whatever reason.
2014-05-14 16:36:03 -04:00
Joey Hess
740de08461 fix windows build 2014-05-14 15:54:41 -04:00
Joey Hess
85e9e8c0cf webapp: Better ssh password prompting.
When setting up a remote on a ssh server, prompt for a password inside the
webapp, rather than relying on ssh's own password prompting in the terminal
the webapp was started from, or ssh-askpass.

Avoids double prompting for the ssh password (and triple-prompting on
windows for rsync.net), since the entered password is cached for 10 minutes
and this cached password is reused when setting up the repository, after
the initial probe.

When the user has an existing ssh key set up, they can choose to use it,
rather than entering a password. The webapp used to probe for this case
automatically, so this is a little harder, but it's an advanced user thing.

Note that this commit is known to break enabling existing rsync
repositories. It hs not been tested with gcrypt repositories. It's not been
successfully tested yet on Windows.

This commit was sponsored by Ralph Mayer.
2014-05-14 15:38:32 -04:00
Joey Hess
e391224516 setsid when running webapp in foreground too
This avoids ssh prompting for passwords on stdin, ever.

It may also change other behavior of other programs, as there is no
controlling terminal now. However, setsid was already done when running the
assistant in daemon mode, so any behavior changes should not be really new.
2014-05-14 14:26:28 -04:00
Joey Hess
db8590791f Merge branch 'master' into sshpassword 2014-05-14 12:43:34 -04:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
551aa32c3b Added a comment: partially solved 2014-05-11 09:32:33 +00:00
divB
65f1240c41 2014-05-10 21:29:57 +00:00
divB
ac6fe34486 Added a comment 2014-05-10 21:20:36 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
aa44a9efa3 2014-05-10 19:47:08 +00:00
Joey Hess
fe37af5b2e
fixed 2014-05-10 12:40:37 -03:00
Joey Hess
4e987d05a8 work around an EvilSplicer bug
This should fix the android build. The EvilSplicer cannot fix up ghc's
misformatting of a case expression with a construstor with a lot of
parameters, which spans multiple lines.
2014-05-10 12:27:21 -03:00
Joey Hess
7c4c7bd05b Merge branch 'master' of ssh://git-annex.branchable.com 2014-05-10 11:33:52 -03:00
Joey Hess
2427832bed relicense general utility library code to BSD
Omitted a couple of files what have had significant contributions from
others.
2014-05-10 11:01:27 -03:00
divB
0e936b36c6 2014-05-10 02:29:41 +00:00
divB
9c5bd871c0 2014-05-10 00:51:04 +00:00
Joey Hess
a5bf11513d Merge branch 'master' of ssh://git-annex.branchable.com 2014-05-09 19:22:10 -03:00
Joey Hess
4956920ece
bugs 2014-05-09 19:21:56 -03:00
divB
b7d640182a 2014-05-09 20:51:27 +00:00
divB
3eafd21e56 2014-05-09 20:38:25 +00:00
Joey Hess
d4ea4324ce Merge branch 'master' of ssh://git-annex.branchable.com 2014-05-09 17:28:06 -03:00
Joey Hess
6abc6fe9d6 keep track of satisfied requests, and summarize 2014-05-09 16:41:05 -03:00
Joey Hess
4a99d835ba example preferred content expressions 2014-05-09 13:34:36 -03:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
65853a1369 2014-05-09 16:05:13 +00:00
Joey Hess
309fd966e7 update 2014-05-09 12:47:08 -03:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
f10f68ce7b Added a comment 2014-05-09 13:28:38 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
db00384dcc Added a comment: spoke too soon 2014-05-09 13:23:52 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
34b0f88b91 Added a comment: fixed 2014-05-09 13:13:00 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
757c7a38db Added a comment: Still having this problem 2014-05-09 12:53:03 +00:00
divB
b891720284 Added a comment 2014-05-09 06:06:54 +00:00
divB
40f4be4335 2014-05-09 06:03:59 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
1d0ad11617 2014-05-09 05:57:36 +00:00
divB
5df8fac5ad Added a comment 2014-05-09 01:02:23 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
5c51a913dc 2014-05-08 23:17:22 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
df751206c0 Added a comment: How to do this on Mac OSX 2014-05-08 22:46:49 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnAcBGyS3cOMs7i3XsN9CtkPT6CDmwArO4
0b1d9f0431 2014-05-08 22:30:09 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkAUMhKOSkh9JaBA6xst3XxQIIsDEq5Zd4
36397cd0a3 Added a comment: Keen to see this happen too! 2014-05-08 21:44:30 +00:00
https://www.google.com/accounts/o8/id?id=AItOawnkXKIAfgPsuV-EJpXm3jCc3q9IZwzvCcw
191fb89fd9 Added a comment: Default pathdepth 2014-05-08 21:36:00 +00:00
http://xlogon.net/yminus
35bf67ef73 Added a comment 2014-05-08 21:12:50 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmNu4V5fvpLlBhaCUfXXOB0MI5NXwh8SkU
a410817784 Added a comment 2014-05-08 16:56:34 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmNu4V5fvpLlBhaCUfXXOB0MI5NXwh8SkU
2a1291c410 2014-05-08 16:54:11 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmNu4V5fvpLlBhaCUfXXOB0MI5NXwh8SkU
1e4eb5653c 2014-05-08 16:53:04 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmNu4V5fvpLlBhaCUfXXOB0MI5NXwh8SkU
0510c17c0a 2014-05-08 16:51:52 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmNu4V5fvpLlBhaCUfXXOB0MI5NXwh8SkU
5b35c76f72 Added a comment: Many months later... 2014-05-08 16:49:26 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmNu4V5fvpLlBhaCUfXXOB0MI5NXwh8SkU
850523f2dd removed 2014-05-08 16:48:57 +00:00
https://www.google.com/accounts/o8/id?id=AItOawmNu4V5fvpLlBhaCUfXXOB0MI5NXwh8SkU
3b7bca3bc2 Added a comment 2014-05-08 16:48:25 +00:00
https://www.google.com/accounts/o8/id?id=AItOawkYmMFDdf3GJ9Oba6NCVkzGc4JyB9WavMs
6aa14d8d1f 2014-05-08 15:17:34 +00:00