Commit graph

3112 commits

Author SHA1 Message Date
Joey Hess
b97d8030f3
respond and close 2020-06-22 14:44:14 -04:00
Joey Hess
d4d0951c07
followup and break out todo item to prioritize 2020-06-16 14:25:51 -04:00
Ilya_Shlyakhter
c003237871 Added a comment: separate processes for parallel transfers 2020-06-12 15:47:28 +00:00
Joey Hess
0017d9a347
Merge branch 'master' of ssh://git-annex.branchable.com 2020-06-11 15:44:28 -04:00
Joey Hess
e15ab727eb
comment and todo 2020-06-11 14:05:01 -04:00
branchable@bafd175a4b99afd6ed72501042e364ebd3e0c45e
512f77fe2a Added a comment: I've hacked up a Python script for policy-based automatic commits 2020-06-11 10:10:52 +00:00
Joey Hess
266ec93237
ugh 2020-06-09 17:39:03 -04:00
Joey Hess
e0d8ab75dd
Merge branch 'master' of ssh://git-annex.branchable.com 2020-06-09 16:20:45 -04:00
Joey Hess
24766125d9
update 2020-06-09 16:20:08 -04:00
Joey Hess
8a824147e4
horrible realization 2020-06-09 16:10:27 -04:00
yarikoptic
02ee2d0e47 2020-06-07 19:38:34 +00:00
yarikoptic
8e3cdfa90e Added a comment 2020-06-05 22:15:09 +00:00
yarikoptic
04aa8360a9 Added a comment: reply to Joey's comments 2020-06-05 22:11:48 +00:00
Joey Hess
0210e81d83
async exception safety for openFd
Audited for openFile and openFd, and this fixes all the ones I found
where an async exception could prevent the file getting closed.

Except for the lock pool, which is a whole other can of worms.
2020-06-05 15:48:00 -04:00
Joey Hess
dca19099a9
async exception safety
Masking ensures that EndStderrHandler gets written, so the helper
threads shut down.

However, nothing currently guarantees that calls to closeP2PSshConnection
are async exception safe, so made a note about it.

At this point, I've audited all calls to async, and made them all async
exception safe, except for ones in the assistant, and a few in leaf
commands (remotedaemon, enable-tor, multicast, p2p) which don't need to
be.
2020-06-05 14:56:41 -04:00
Joey Hess
42756b972e
few more things 2020-06-05 11:15:29 -04:00
Joey Hess
db270bd6ba
Merge branch 'master' of ssh://git-annex.branchable.com 2020-06-05 11:13:15 -04:00
Joey Hess
2bff3b7c49
init: When annex.pidlock is set, skip lock probing. 2020-06-05 11:12:16 -04:00
Joey Hess
1d41ae5d2a
init warning on stalled lock probe
init: If lock probing stalls for a long time (eg a broken NFS server),
display a message to let the user know what's taking so long.
2020-06-05 11:06:19 -04:00
Ilya_Shlyakhter
1d189cd08e Added a comment 2020-06-05 14:51:08 +00:00
Joey Hess
e998e4a29a
Merge branch 'master' of ssh://git-annex.branchable.com 2020-06-05 10:41:30 -04:00
yarikoptic
8d3ffe50a1 initial whining about long pidlock need detection time 2020-06-05 02:18:31 +00:00
Joey Hess
a3d1f967a8
almost forgot 2020-06-04 16:22:45 -04:00
Joey Hess
2670890b17
convert to withCreateProcess for async exception safety
This handles all createProcessSuccess callers, and aside from process
pools, the complete conversion of all process running to async exception
safety should be complete now.

Also, was able to remove from Utility.Process the old API that I now
know was not a good idea. And proof it was bad: The code size went *down*,
despite there being a fair bit of boilerplate for some future API to
reduce.
2020-06-04 15:45:52 -04:00
Joey Hess
12e7d52c8b
another wrinkle 2020-06-04 14:46:28 -04:00
Joey Hess
e1fc4f7594
make safeCommand stop the process if the thread gets killed
And a comment on a todo item that this commit is perhaps the start of
solving.
2020-06-03 12:52:11 -04:00
Joey Hess
81a811d935
comment 2020-06-03 12:00:44 -04:00
superhair123
4b0dd1fcb2 2020-06-01 13:47:30 +00:00
superhair123
401f0f7d5a 2020-06-01 13:44:15 +00:00
Joey Hess
89b2542d3c
annex.skipunknown with transition plan
Added annex.skipunknown git config, that can be set to false to change the
behavior of commands like `git annex get foo*`, to not skip over files/dirs
that are not checked into git and are explicitly listed in the command
line.

Significant complexity was needed to handle git-annex add, which uses some
git ls-files calls, but needs to not use --error-unmatch because of course
the files are not known to git.

annex.skipunknown is planned to change to default to false in a
git-annex release in early 2022. There's a todo for that.
2020-05-28 15:55:17 -04:00
Joey Hess
a6271b1323
Merge branch 'master' of ssh://git-annex.branchable.com 2020-05-27 12:46:52 -04:00
mike@2d6d71f56ce2a992244350475251df87c26fe351
311e605c28 Added a comment: .noannex 2020-05-27 15:34:54 +00:00
kyle
3e717128f8 Added a comment 2020-05-27 15:19:13 +00:00
mike@2d6d71f56ce2a992244350475251df87c26fe351
7776691ead 2020-05-27 15:10:57 +00:00
Joey Hess
298fa1c081
done 2020-05-27 11:00:57 -04:00
Joey Hess
fc9833f68d
export: Added options for json output
Just worked, no need to do anything except add the options.
2020-05-26 10:31:10 -04:00
Joey Hess
bbdba72624
Merge branch 'master' of ssh://git-annex.branchable.com 2020-05-26 10:21:21 -04:00
yarikoptic
d30dd6daa4 TODO for export --json* options 2020-05-26 04:14:57 +00:00
Joey Hess
6eea4969d3
close 2020-05-25 12:04:56 -04:00
Joey Hess
234764518a
close 2020-05-25 12:02:23 -04:00
Joey Hess
e46717bf18
close 2020-05-25 11:59:21 -04:00
Joey Hess
133de41e49
close 2020-05-25 11:56:27 -04:00
Joey Hess
5f5a2a6b56
close 2020-05-25 11:52:45 -04:00
Joey Hess
fcb288be13
close dup 2020-05-25 11:48:39 -04:00
Joey Hess
4d87d255ee
comment 2020-05-25 11:47:10 -04:00
Joey Hess
7cc5e955b6
close 2020-05-25 11:31:38 -04:00
https://christian.amsuess.com/chrysn
112d2f8e7b Added a comment: Re: Usefulness of batch key processing 2020-05-15 09:33:22 +00:00
https://christian.amsuess.com/chrysn
340287ef94 Added a comment: Usefulness of batch key processing 2020-05-15 09:21:15 +00:00
Joey Hess
5b5a9aaf92
comment 2020-05-05 12:33:28 -04:00
Joey Hess
d2e78dfc0d
prove this optimisation would not be safe, so close 2020-05-04 14:49:42 -04:00
Joey Hess
9fa940569c
added remote variants
Todo item is done at last.

Might later want to think about testing some other types of remotes that
can be tested locally. The git remote itself is probably already well
enough tested by the test suite that testremote is not needed. Could
test things like bup, or rsync to a local directory. Or even external,
although that would require embedding an external special remote program
into the test suite..
2020-04-30 13:52:03 -04:00
Joey Hess
b41c0edebd
todo 2020-04-28 17:24:53 -04:00
ct.git-annex@230092d9bd3cf09ced2b9605cdb14ad0a3db265d
d3270a8b9a Added a comment 2020-04-26 20:18:48 +00:00
Joey Hess
985dd4f2ad
comment 2020-04-23 16:21:18 -04:00
Joey Hess
957a87b437
fix absolute filenames fed into --batch and git-annex info 2020-04-15 16:04:05 -04:00
Joey Hess
a14168a321
reproduced 2020-04-15 15:06:53 -04:00
Joey Hess
2caf579718
cache annex index filename for 1.5% speedup to queries 2020-04-10 13:37:04 -04:00
Joey Hess
5e4423c058
new optimisation target 2020-04-09 14:13:00 -04:00
Joey Hess
aeca7c2207
Sped up query commands that read the git-annex branch by around 5%
The only price paid is one additional MVar read per write to the journal.
Presumably writing a journal file dominiates over a MVar read time by
several orders of magnitude.

--batch does not get the speedup because then it needs to notice when
another process has made a change. Also made the assistant and other damon
modes bypass the optimisation, which would not help them anyway.
2020-04-09 13:54:43 -04:00
Joey Hess
c0cd07c36b
Ref ByteString conversion done
Test suite passes.
2020-04-07 17:41:09 -04:00
lykos@d125a37d89b1cfac20829f12911656c40cb70018
d27a94eec0 Added a comment 2020-03-26 20:36:28 +00:00
Joey Hess
a0d274fed6
Merge branch 'master' of ssh://git-annex.branchable.com 2020-03-25 13:05:47 -04:00
Joey Hess
357f783edf
add priority tags 2020-03-25 13:05:09 -04:00
spwhitton
79ba17946f Added a comment 2020-03-25 16:31:13 +00:00
Joey Hess
24255b3c96
confirmed, and open todo for something mentioned in this bug 2020-03-20 12:00:07 -04:00
thk
677e5f6e12 Added a comment: sponsoring? 2020-03-19 08:40:32 +00:00
Joey Hess
cb6604814c
close 2020-03-16 14:16:55 -04:00
Joey Hess
94e1f02e0c
comment 2020-03-16 14:15:00 -04:00
Joey Hess
c913f57d05
comment 2020-03-16 14:08:49 -04:00
Ilya_Shlyakhter
05df404212 Added a comment: gsasl dependency 2020-03-11 22:13:47 +00:00
spwhitton
e36d6ebe53 report bug 2020-03-11 21:41:21 +00:00
Joey Hess
b2c4ca6da1
comment 2020-03-09 12:33:35 -04:00
Joey Hess
6eb52cf5f1
Merge branch 'master' of ssh://git-annex.branchable.com 2020-03-09 12:07:03 -04:00
Ilya_Shlyakhter
5dedcc9953 added todo: add option to disable fsck upgradable key warnings 2020-03-07 21:01:41 +00:00
thk
98e7a6078b Added a comment: No clear error message for failing names on NTFS 2020-03-07 12:50:19 +00:00
Joey Hess
e87dc1341e
link to upstream bug report 2020-03-06 13:52:48 -04:00
thk
db9958bfc8 Added a comment: Also no clear error for permission problems 2020-03-06 17:51:20 +00:00
Joey Hess
093fde5abd
completed the createDirectoryIfMissing conversion
Remaining calls in the assistant and Annex.Ssh have been audited and are ok.
2020-03-06 12:55:03 -04:00
Joey Hess
6d58ca94d6
some easy createDirectoryUnder conversions 2020-03-05 15:20:10 -04:00
Joey Hess
5b022eea87
implemented createDirectoryUnder 2020-03-05 14:10:34 -04:00
Ilya_Shlyakhter
aa91792d41 Added a comment 2020-03-04 21:34:42 +00:00
Joey Hess
97a8ce0191
comment 2020-03-04 17:12:10 -04:00
Ilya_Shlyakhter
8f48ebd8c2 added todo: restore original environment when running external special remotes from standalone git-annex? 2020-03-04 17:39:02 +00:00
amerlyq+annex@12121d70a602f094228689a0a24d348d478a8af1
4da2a67bbe Added a comment: re: shorter symlinks 2020-03-04 00:48:02 +00:00
Joey Hess
dd89832700
comment 2020-03-02 15:02:22 -04:00
Joey Hess
701f8cb00b
comment 2020-03-02 14:52:02 -04:00
Ilya_Shlyakhter
54d77e94ba Added a comment: adding dotfiles 2020-02-29 21:35:06 +00:00
spwhitton
a025dc23af Added a comment 2020-02-29 16:34:16 +00:00
Ilya_Shlyakhter
4faf850106 added todo suggestion: trust presence info for specific remotes for specified time 2020-02-28 20:14:26 +00:00
Joey Hess
41cb7e90a6
comment 2020-02-28 15:32:50 -04:00
Ilya_Shlyakhter
02f3abb142 added todo request: restore --include-dotfiles as a no-op for backwards compatibility 2020-02-28 18:29:43 +00:00
Joey Hess
2203b0e910
comment 2020-02-28 14:18:09 -04:00
Ilya_Shlyakhter
957dc80c3f Added a comment: batch presence checking 2020-02-27 20:33:44 +00:00
lykos@d125a37d89b1cfac20829f12911656c40cb70018
2d3ef2c079 Added a comment 2020-02-27 13:12:28 +00:00
lykos@d125a37d89b1cfac20829f12911656c40cb70018
d31fd6cd42 2020-02-27 08:54:34 +00:00
Joey Hess
64639ff9b1
followup and close 2020-02-26 18:29:06 -04:00
Joey Hess
5de1abf3da
todo 2020-02-25 17:44:03 -04:00
Joey Hess
3497e9e510
comment 2020-02-25 16:16:18 -04:00
Joey Hess
9659f1c30f
annex.security.allowed-ip-addresses ports syntax
Extended annex.security.allowed-ip-addresses to let specific ports of an IP
address to be used, while denying use of other ports.
2020-02-25 15:45:52 -04:00
Joey Hess
4316d92b48
comment 2020-02-25 14:38:55 -04:00