Commit graph

28955 commits

Author SHA1 Message Date
https://christian.amsuess.com/chrysn
c592105924 Make change log entry readable on the wiki (previous copy-paste from (debian?) changelog garbled itemization) 2020-11-08 18:14:48 +00:00
Lukey
73bf45a163 Added a comment 2020-11-08 08:25:36 +00:00
yarikoptic
62820a4c30 Added a comment 2020-11-07 23:59:52 +00:00
Joey Hess
c64e95045d
Merge branch 'master' of ssh://git-annex.branchable.com 2020-11-07 14:10:19 -04:00
Joey Hess
3f08c34073
bug 2020-11-07 10:58:43 -04:00
yarikoptic
ea9d3f7d2f FTBFS 2020-11-07 00:45:06 +00:00
jcjgraf
d8e8d145e1 Added a comment 2020-11-06 14:57:52 +00:00
Lukey
1b02a81346 Added a comment 2020-11-06 14:14:18 +00:00
Lukey
9d598265e4 2020-11-05 18:41:25 +00:00
interfect@b151490178830f44348aa57b77ad58c7d18e8fe7
4245fe144e Added a comment 2020-11-05 17:55:31 +00:00
jcjgraf
b7e8a75b8c 2020-11-05 13:31:04 +00:00
a@92214b2eae95307f511e06845d2cb5b5931b00a3
0431c2d067 Added a comment: Re: Moving S3 special remote 2020-11-05 03:44:52 +00:00
a@92214b2eae95307f511e06845d2cb5b5931b00a3
937f84a9ea 2020-11-03 16:38:19 +00:00
Joey Hess
eacfb58eca
Merge branch 'master' of ssh://git-annex.branchable.com 2020-11-03 11:53:52 -04:00
Joey Hess
0cf77eb41c
add news item for git-annex 8.20201103 2020-11-03 11:53:33 -04:00
Joey Hess
664bec4297
comment 2020-11-02 22:34:04 -04:00
yarikoptic
7e24b2587e Added a comment 2020-11-03 02:12:17 +00:00
yarikoptic
2c88c5e258 initial formal report on drop 2020-11-03 02:02:41 +00:00
yarikoptic
7f4e511613 Added a comment 2020-11-02 21:04:35 +00:00
yarikoptic
5b4d5f6d64 Added a comment 2020-11-02 20:37:47 +00:00
Joey Hess
49475eb3d9
rename 2 bug report titles that are too long due to pasting enormous error messages into title entry
So the repo can be cloned on windows.
2020-11-02 15:25:10 -04:00
Joey Hess
e926305221
add maxlength=50 to ikiwiki template used for page title entry 2020-11-02 15:21:24 -04:00
Joey Hess
40679616ed
comment 2020-11-02 15:01:17 -04:00
Joey Hess
15e08bd572
Merge branch 'master' of ssh://git-annex.branchable.com 2020-11-02 14:47:57 -04:00
Joey Hess
9252f86b2e
view: Fix a reversion in 8.20200522 that broke entering or changing views.
Commit 2dc7b5186a messed up indentation.

This commit was sponsored by Noam Kremen on Patreon.
2020-11-02 14:47:08 -04:00
yarikoptic
79874325b8 a plea for more --debug output 2020-11-02 18:04:20 +00:00
Joey Hess
efdb13fca3
comment 2020-11-02 13:55:30 -04:00
Joey Hess
fcdbc892ed
already fixed 2020-11-02 13:25:07 -04:00
Joey Hess
6eca4fc95e
not a bug 2020-11-02 13:24:23 -04:00
Joey Hess
00ff87a09e
Merge branch 'master' of ssh://git-annex.branchable.com 2020-11-02 13:24:02 -04:00
Ilya_Shlyakhter
44948ae342 updated URL of Homebrew formula for git-annex. 2020-11-02 15:56:45 +00:00
nix.zahlen@1211ac6c964ba2d68b70655f747bef1383032e77
617ec1a813 Added a comment: build a CI/CD chain for git-annex 2020-10-31 17:47:15 +00:00
nix.zahlen@1211ac6c964ba2d68b70655f747bef1383032e77
6334665dd2 Added a comment: where and how to submit Windows autobuild related issues? 2020-10-31 17:44:18 +00:00
gschnabel
7c66380163 git-annex-view fails because of "another git process running" 2020-10-30 08:13:25 +00:00
gschnabel
9d2d52ae55 git-annex-view fails 2020-10-30 08:08:18 +00:00
gl@cfc0fd7a693bb7c3a600eb73f462bd504c51cedf
577cd911ee 2020-10-29 11:53:52 +00:00
lyderic
0ab03f3a61 2020-10-29 10:14:28 +00:00
lyderic
468682b6c9 Added a comment: This bug has alreay been raised 2020-10-29 10:13:50 +00:00
lyderic
69acb869ff 2020-10-29 10:08:13 +00:00
Joey Hess
59dbd10f92
note windows versions the builds will work with 2020-10-28 13:21:47 -04:00
yarikoptic
a3bb6f235c Added a comment 2020-10-27 19:44:36 +00:00
yarikoptic
1add9c957e Added a comment 2020-10-27 19:30:24 +00:00
yarikoptic
2bea2c1937 report on possibly PATH related issue on windows 2020-10-27 19:15:38 +00:00
Joey Hess
2dd60ff42a
comment 2020-10-27 14:33:30 -04:00
michael.hanke@c60e12358aa3fc6060531bdead1f530ac4d582ec
0170b5468f Added a comment: Documentation of demand 2020-10-27 14:59:47 +00:00
Lukey
9ecc4ccba3 Added a comment 2020-10-27 09:06:38 +00:00
interfect@b151490178830f44348aa57b77ad58c7d18e8fe7
730f67bcc6 2020-10-26 20:55:16 +00:00
Joey Hess
64e7bac810
view: Avoid using ':' from metadata when generating a view
Because it's a special character on Windows ("c:").

Use same technique already used for '/' and '\'.

I didn't record how I generated their encoded forms before, so am sure
there was a better way, but the way I did it now is to look at

	ghci> encodeFilePath "∕"
	"\226\136\149"

And then the difference from that to "\56546\56456\56469"
is adding 56320 to each, to get up to the escaped code plane.

See comment for why I think handling ':' is ok, but that other illegal
windows filenames won't. Note that, this should be enough to make the
test suite always work. Other windows illegal filenames will fail at
checkout time when it tries to put the illegal filename on the
filesystem.
2020-10-26 15:38:08 -04:00
yarikoptic
2d291bf200 Added a comment 2020-10-26 17:57:12 +00:00
Joey Hess
d9cc73bf9e
Merge branch 'master' of ssh://git-annex.branchable.com 2020-10-26 13:48:00 -04:00
Joey Hess
3baef37caf
make windows installer builder include libmagic files when present, but skip otherwise 2020-10-26 13:42:43 -04:00
Joey Hess
f3070d2d7d
Windows build changed to one done by the datalad-extensions project using Github actions
This is a cleaner build than on Jenkins because the whole environment setup
is handled by the CI config, at least up to the point of "get a random bag
of Windows bytes".

Also, the Jenkins autobuilder has been intermittently failing for a long
time, not due to any problem with git-annex but just a failure to clean up
directories.

Also, this build runs the test suite, and it is (mostly) passing. Test
suite always failed in the jenkins environment.

Also, this build includes libmagic.

Here is the build workflow used by github actions:
https://github.com/datalad/datalad-extensions/blob/master/.github/workflows/build-git-annex-windows.yaml
The libmagic build has its own workflow:
https://github.com/datalad/file-windows/blob/master/.github/workflows/build.yml

(Also cleaned up some windows build cruft I don't use anymore.)

There is no build-version file to link to. I've opened a todo requesting
one: https://github.com/datalad/datalad-extensions/issues/55
2020-10-26 13:17:23 -04:00
Joey Hess
401f734a34
comment 2020-10-26 12:43:19 -04:00
Joey Hess
53b91e0ea7
close 2020-10-26 12:02:35 -04:00
Ilya_Shlyakhter
9f9ac634c0 Added a comment: thanks 2020-10-26 15:37:57 +00:00
Joey Hess
81d798b52e
Merge branch 'master' of ssh://git-annex.branchable.com 2020-10-26 11:35:19 -04:00
Joey Hess
8fda1ef0fa
document version for --force-large/--force-small
also fix the wrong name in the changelog
2020-10-26 11:34:30 -04:00
Joey Hess
5907415380
improve wording 2020-10-26 11:12:17 -04:00
yarikoptic
a8605422b9 initial report on a failing test 2020-10-26 15:02:49 +00:00
ericm
3558ca5d88 2020-10-25 17:32:44 +00:00
Joey Hess
dbbcfd30bd
Merge branch 'master' of ssh://git-annex.branchable.com 2020-10-25 11:30:09 -04:00
nix.zahlen@1211ac6c964ba2d68b70655f747bef1383032e77
f861ce399e Added a comment: where to trace the Windows build errors? 2020-10-25 15:23:01 +00:00
Joey Hess
71ca12ef8c
Merge branch 'master' of ssh://git-annex.branchable.com 2020-10-24 16:26:16 -04:00
achilleas.k@14be77d42a1252fab5ec9dbf4e5ea03c5833e8c8
65c1687430 Added a comment 2020-10-24 14:39:39 +00:00
yarikoptic
def62b49f0 Added a comment 2020-10-24 12:26:02 +00:00
yarikoptic
3be4731315 Added a comment 2020-10-24 01:21:09 +00:00
Joey Hess
92fad0703b
remove dead links to youtube-dl
Presumably most users will get it from their linux distribution, or
whatever. Don't want to need to keep updating links if they're going to
rot like this.
2020-10-23 18:49:14 -04:00
Joey Hess
b2bf099aa3
use removeDirGeneric here too for consistency
And because it might be more robust on windows.
2020-10-23 16:12:47 -04:00
Joey Hess
a108b00b33
testremote: Display exceptions when tests fail, to aid debugging 2020-10-23 15:41:57 -04:00
Joey Hess
681313dfd4
deal with .git pointer file in Git.CurrentRepo
This fixes the bug.

Note, it's only done when GIT_DIR is set. When it's not set,
Git.Construct already handled it. This is why it was only noticed with this
git submodule command.

This commit was sponsored by Brett Eisenberg on Patreon.
2020-10-23 14:56:12 -04:00
Joey Hess
893d7b21e8
comment 2020-10-23 14:21:29 -04:00
Joey Hess
f92b0ef109
analysis 2020-10-23 14:08:06 -04:00
Joey Hess
eece011b00
close 2020-10-23 13:58:40 -04:00
Joey Hess
966dbb518e
Merge remote-tracking branch 'origin/master' 2020-10-23 13:09:41 -04:00
Joey Hess
cb6cf20b9a
analysis 2020-10-23 13:00:55 -04:00
rshalaev@3e2130a1e3cb0aaff7dd80aba7548ad9be0ea2d4
b91845ec5d Added a comment 2020-10-23 16:51:04 +00:00
Joey Hess
0736383e98
Fix bug that prevented linux standalone bundle from working on a fresh install
Bug was introduced in version 8.20201007, lost a necessary mkdir.

This commit was sponsored by Noam Kremen on Patreon.
2020-10-23 12:19:40 -04:00
amindfv@97236fbaab6048ce6805b2737b27dd7f1cd51da4
02d3e58610 Added a comment 2020-10-23 05:37:41 +00:00
rshalaev@3e2130a1e3cb0aaff7dd80aba7548ad9be0ea2d4
990ed1055a Added a comment 2020-10-23 02:00:09 +00:00
rshalaev@3e2130a1e3cb0aaff7dd80aba7548ad9be0ea2d4
83a718dff2 2020-10-23 01:53:33 +00:00
yarikoptic
1c242ca5fd initial report on a failing test on windows about storeKey when already present 2020-10-23 01:49:02 +00:00
Joey Hess
83e570c0cb
this protocol is not draft for some time 2020-10-22 19:55:29 -04:00
Joey Hess
4d063f12c6
turns out this was fixed in 2014 2020-10-22 19:54:26 -04:00
Joey Hess
2f96e15eda
Merge branch 'master' of ssh://git-annex.branchable.com 2020-10-22 19:24:38 -04:00
Joey Hess
9ed32ce62b
urk 2020-10-22 19:23:48 -04:00
yarikoptic
c24480c061 Added a comment: windows build with magic 2020-10-22 19:32:55 +00:00
jwodder
731a982f1b Added a comment 2020-10-22 18:13:40 +00:00
Joey Hess
577af1b679
rename to avoid windows stupididy about legal filenames 2020-10-22 13:58:20 -04:00
Joey Hess
8f3d34da30
add 2020-10-22 13:55:47 -04:00
Joey Hess
5941737074
add 2020-10-22 13:55:41 -04:00
Joey Hess
b62e004c2c
update chunk log after speculated chunks are verified to be present
Only done in checkPresentChunks, although retrieveChunks could also do
it. Does not seem necessary though, because git-annex never retrives
content without first checking if it's present AFAICR. And really this will
only be needed when using fsck. Puttting it here, rather than in fsck
avoids breaking an abstraction boundary, and is nice and inexpensive.
2020-10-22 13:37:09 -04:00
Joey Hess
dad4be97c2
speculatively use remote's configured chunk size as a fallback
When a special remote has chunking enabled, but no chunk sizes are
recorded (or the recorded ones are not found), speculatively try chunks
using the configured chunk size.

This makes eg, git-annex fsck --from remote be able to fix up the
location log of a file that the git-annex branch does not indicate is
stored on the remote.

Note that fsck does *not* fix up the chunk log to indicate the chunk
size. So, changing the chunk config of the remote after that will still
prevent accessing the chunks stored on it. Maybe fsck should, but I
wanted to start with this and see if it's needed.
2020-10-22 13:11:06 -04:00
Joey Hess
b3345eb4ab
close 2020-10-22 12:03:13 -04:00
nix.zahlen@1211ac6c964ba2d68b70655f747bef1383032e77
3b740ac4dc Added a comment: cannot find this mentioned Windows build :| 2020-10-21 20:46:37 +00:00
nix.zahlen@1211ac6c964ba2d68b70655f747bef1383032e77
a9cec7a810 2020-10-21 20:44:23 +00:00
edward
c20be8d09b Fix a broken link 2020-10-21 19:22:57 +00:00
Lukey
d7b95e363e Added a comment 2020-10-21 19:10:01 +00:00
ericm
4816cfc104 2020-10-21 18:18:25 +00:00
Joey Hess
b7835701c8
Merge branch 'master' of ssh://git-annex.branchable.com 2020-10-21 10:32:24 -04:00
Joey Hess
02d5466c23
devblog 2020-10-21 10:32:08 -04:00
Joey Hess
0133b7e5a8
move: Improve resuming a move that was interrupted after the object was transferred
In cases where numcopies checks prevented the resumed move from dropping
the object from the source repository, it now relies on a log of recent
moves to replicate the behavior of the interrupted command.

Performance: Probably noticable impact, since it has to add to the log,
check the log, and remove from the log. Seems worth it to avoid this
annoying edge case. The log functions are pretty well optimised to avoid
unncessary work.

An performance improvement to make later would be to avoid cleanup doing
anything if it's not written to the log file, and has confirmed that the
log file does not contain the log line.

This commit was sponsored by Jake Vosloo on Patreon.
2020-10-21 10:31:56 -04:00
achilleas.k@14be77d42a1252fab5ec9dbf4e5ea03c5833e8c8
9f69a68ed7 removed 2020-10-21 07:51:58 +00:00
achilleas.k@14be77d42a1252fab5ec9dbf4e5ea03c5833e8c8
fd30262fb3 Added a comment 2020-10-21 07:51:37 +00:00
achilleas.k@14be77d42a1252fab5ec9dbf4e5ea03c5833e8c8
bdc7f63c21 Added a comment 2020-10-21 07:51:13 +00:00
yarikoptic
8f261113f3 report/idea on minting chunked keys to try from special remote 2020-10-20 23:31:22 +00:00
yarikoptic
fa686784f1 Added a comment 2020-10-20 16:39:15 +00:00
kyle
7c78321770 Added a comment 2020-10-20 15:59:26 +00:00
ericm
ad86a25c58 Added a comment 2020-10-20 13:45:10 +00:00
achilleas
fb2bd67f76 New bug report 2020-10-20 12:51:55 +00:00
yarikoptic
b6f70c2876 Added a comment 2020-10-20 12:33:29 +00:00
yarikoptic
1a5fc2667f Added a comment 2020-10-20 12:29:19 +00:00
Joey Hess
7036d0a4c1
add, import: Fix a reversion in 7.20191009 that broke handling of --largerthan and --smallerthan
This commit was sponsored by Jochen Bartl on Patreon.
2020-10-19 15:36:18 -04:00
Joey Hess
b390a4012c
bug 2020-10-19 15:24:38 -04:00
Joey Hess
f8b0be1f93
comment 2020-10-19 15:04:52 -04:00
Joey Hess
b9c02b29fe
Merge branch 'master' of ssh://git-annex.branchable.com into master 2020-10-19 14:57:30 -04:00
Joey Hess
15ea0e6c0a
design done 2020-10-19 14:57:02 -04:00
Joey Hess
5009c1ce68
update 2020-10-19 14:49:16 -04:00
ericm
9d70cd5def 2020-10-19 18:33:57 +00:00
Joey Hess
c337b58caf
more thoughts 2020-10-19 14:19:41 -04:00
Joey Hess
b2c5c99506
comment 2020-10-19 13:12:07 -04:00
Joey Hess
f1398a1a92
comment 2020-10-19 13:04:03 -04:00
Joey Hess
bdb6d8581c
comment 2020-10-19 12:37:40 -04:00
Joey Hess
3c6cfacb19
Merge branch 'master' of ssh://git-annex.branchable.com into master 2020-10-19 12:19:33 -04:00
Joey Hess
e408658eaa
close 2020-10-19 12:16:15 -04:00
Ilya_Shlyakhter
1ac3735ac9 Added a comment: copying directly from directory special remote to the cloud 2020-10-18 21:00:59 +00:00
Ilya_Shlyakhter
6ee7ccb7bd Added a comment: building the standalone distribution on CentOS 2020-10-16 14:58:42 +00:00
yarikoptic
4f45051a2f Added a comment 2020-10-16 01:50:39 +00:00
yarikoptic
9910b8a513 Added a comment 2020-10-16 01:29:23 +00:00
edward
fd80a4e43d Fix typo 2020-10-15 19:10:58 +00:00
yarikoptic
361b9d719a initial report 2020-10-15 16:43:06 +00:00
Lukey
3d686af1e1 Added a comment 2020-10-15 14:46:33 +00:00
fbaca1610@41d03d827c5fd52d594eef456b6196c057c0944f
b18130e24b Added a comment: dropunused and copies 2020-10-15 10:19:17 +00:00
Joey Hess
e4a8b7b26f
comment 2020-10-13 18:57:30 -04:00
Joey Hess
e726aee7be
devblog 2020-10-13 18:41:47 -04:00
Joey Hess
c8995b040f
devblog 2020-10-13 16:46:32 -04:00
Joey Hess
9a5cd96f0d
Fix a memory leak introduced in the last release
The problem was this line:

	cleanup = and <$> sequence (map snd v)

That caused all of v to be held onto until the end, when the cleanup action
was run.

I could not seem to find a bang pattern that avoided the leak, so I
resorted to a IORef, rather clunky, but not a performance problem because
it will only be written once per git ls-files, so typically just 1 time.

This commit was sponsored by Mark Reidenbach on Patreon.
2020-10-13 16:31:01 -04:00
Joey Hess
d41795c8ff
blew a day investigating this and still don't understand it fully 2020-10-13 15:33:59 -04:00
Joey Hess
cf0ff9f53d
comment 2020-10-13 12:24:13 -04:00
Joey Hess
b72a5c0680
Merge branch 'master' of ssh://git-annex.branchable.com into master 2020-10-12 16:14:51 -04:00
Joey Hess
21d8660006
comment 2020-10-12 16:12:24 -04:00
Joey Hess
db1def72ee
comment
This commit was sponsored by Ethan Aubin.
2020-10-12 16:07:30 -04:00
Maximilian
c61d282b72 Added a comment 2020-10-12 19:53:27 +00:00
Joey Hess
4124862ae0
comment
This commit was sponsored by Ethan Aubin.
2020-10-12 15:47:46 -04:00
Joey Hess
8e7eeb753d
comment 2020-10-12 15:10:57 -04:00
Joey Hess
61c75eb91e
comment 2020-10-12 15:03:18 -04:00
Joey Hess
53fe434498
close as notabug 2020-10-12 14:50:38 -04:00
Joey Hess
b14eb513a7
Merge branch 'master' of ssh://git-annex.branchable.com into master 2020-10-12 14:49:36 -04:00
Joey Hess
fc16057f99
profiling
Currently a bit stuck, but at least starting to get some clues on this
memory leak.

This commit was sponsored by Ethan Aubin.
2020-10-12 14:48:26 -04:00
Lukey
8dc1f3e7d5 Added a comment 2020-10-12 17:20:37 +00:00
mhauru
b574731682 Added a comment 2020-10-12 17:07:58 +00:00
Joey Hess
81216931c6
comment 2020-10-12 12:32:53 -04:00
yarikoptic
9677814e5d Added a comment 2020-10-12 16:00:32 +00:00
Joey Hess
5157dd8370
comment 2020-10-12 11:41:58 -04:00
Joey Hess
842fc46ee2
Merge branch 'master' of ssh://git-annex.branchable.com into master 2020-10-12 11:35:40 -04:00
Lukey
308e5b3a81 Added a comment 2020-10-11 14:17:47 +00:00
Lukey
19be09d284 Added a comment 2020-10-11 14:08:27 +00:00
Lukey
6db0a18e6f Added a comment 2020-10-11 14:01:35 +00:00
yarikoptic
89396bb710 Added a comment 2020-10-11 13:51:28 +00:00
Joey Hess
a7a1fdc8cd
Merge branch 'master' of ssh://git-annex.branchable.com into master 2020-10-10 10:40:35 -04:00
Maximilian
c45260f843 2020-10-10 09:11:21 +00:00
Joey Hess
c1bfaf29e4
comment 2020-10-09 20:24:56 -04:00
Joey Hess
1be229c6ae
this was closed a long time ago, but a rename made it re-appear 2020-10-08 14:36:36 -04:00
Joey Hess
d54dd0ef9c
Fix build on Windows with network-3
inet_addr was removed, but all this needs is localhost, so hardcoding it
should work fine.

It may be that this windows ifdef is no longer needed. It was added in 2013
with a note that getAddrInfo didn't work on windows, but it seems likely
such a problem would have been fixed since.
2020-10-08 10:50:39 -04:00
Joey Hess
46bb8b90b3
Merge branch 'master' of ssh://git-annex.branchable.com into master 2020-10-08 10:38:15 -04:00
Joey Hess
46371797ec
design for finally slaying this beast
This commit was sponsored by Ethan Aubin.
2020-10-08 10:09:12 -04:00
jwodder
d4cb2e044b 2020-10-08 13:02:20 +00:00
jwodder
37f13dfd58 Added a comment 2020-10-08 12:44:52 +00:00
Joey Hess
7fcbb92dfe
add news item for git-annex 8.20201007 2020-10-07 14:18:57 -04:00
Joey Hess
2d5036e440
renamed some filenames to not end with a period
Windows does not allow such filenames, which prevented cloning git-annex
on windows.
2020-10-07 12:12:53 -04:00
Joey Hess
20f86e43f7
Fix a build failure on Windows. 2020-10-07 12:04:54 -04:00
git-annex.branchable@f45632a8044327f7993eb5b462c37b76ae48cb10
8c6f21c348 2020-10-07 15:01:06 +00:00
git-annex.branchable@f45632a8044327f7993eb5b462c37b76ae48cb10
20c7e6cf94 2020-10-06 19:19:44 +00:00
Joey Hess
995607b6db
response 2020-10-06 10:54:10 -04:00
Joey Hess
a10f2616c4
close 2020-10-06 10:24:09 -04:00
Joey Hess
10ec4aa7cb
Merge branch 'master' of ssh://git-annex.branchable.com into master 2020-10-06 10:07:48 -04:00
Joey Hess
4795bd7238
update 2020-10-06 10:07:27 -04:00
yarikoptic
95d02d6e29 Added a comment 2020-10-06 01:27:01 +00:00
yarikoptic
b98d601bfb Added a comment: FTR 2020-10-06 00:04:38 +00:00
yarikoptic
8035e2073d Added a comment 2020-10-05 23:17:08 +00:00
yarikoptic
ed7a0c9956 Added a comment: just comments 2020-10-05 23:11:32 +00:00
Joey Hess
2daa28c05f
comment 2020-10-05 15:19:48 -04:00
Joey Hess
471bcfaf37
comment 2020-10-05 14:51:19 -04:00
Joey Hess
2c68c60961
comment 2020-10-05 14:38:29 -04:00
Joey Hess
8c9a38a91f
Merge branch 'master' of ssh://git-annex.branchable.com into master 2020-10-05 14:37:33 -04:00
Joey Hess
36ebcd94aa
fix confirmed 2020-10-05 14:36:36 -04:00
kyle
a39f9e8c7f Added a comment 2020-10-05 18:09:07 +00:00
Joey Hess
f0ec725234
include buildid in LOCPATH
This avoids the possibility that the bundle could be updated in place,
leading to LOCPATH existing but containing locales for the old version,
which needed to be tested for with code that was not race-free.

LOCPATH/buildid is still written and checked when cleaning up stale caches.
That is not actually necessary, except old versions of the standalone
bundle expect to see it, and this prevents them cleaning up the locale
cache of a new version. And still checking it prevents the new version
cleaning up the locale cache of the old version while the old version is
still in use.

Added explicit tests before creating LOCPATH and the base and buildid files.

The buildid file no longer needs to be updated every time, because it's
stable for the given LOCPATH directory.

And the base file actually did not need to be updated every time,
because the LOCPATH is derived from base, so if the bundle is moved
elsewhere, a different LOCPATH will be used.

Transitioning to this will mean that two git-annex builds that otherwise
have the same buildid -- the same git-annex md5sum -- will use different
LOCPATH values, but that's handled fine by the cache cleanup code, so at
most it will mean one extra generation of the locale files.
2020-10-05 14:04:49 -04:00
yarikoptic
0bb7569e1c Added a comment 2020-10-05 18:02:51 +00:00
kyle
64ca40e11c Added a comment 2020-10-05 17:42:26 +00:00
Joey Hess
9e12e4c419
comment 2020-10-05 12:57:16 -04:00
Joey Hess
cd9a60bc7d
runshell: Fix a edge case where rm errors were sent to stdout, which could confuse things parsing git-annex output. 2020-10-05 12:44:40 -04:00
Joey Hess
3363cc7515
Merge branch 'master' of ssh://git-annex.branchable.com into master 2020-10-05 12:37:43 -04:00
Joey Hess
8c221eac83
update 2020-10-05 12:36:36 -04:00
yarikoptic
4bb980bfb9 Added a comment 2020-10-05 15:26:10 +00:00
Ilya_Shlyakhter
574d7a7cce Added a comment: standalone build 2020-10-04 15:45:16 +00:00
yarikoptic
77dab95e69 Initial report on hanging batched processes 2020-10-03 04:04:28 +00:00
yarikoptic
3be96e60b0 initial report on rm failing to remove cache/locales 2020-10-03 03:52:33 +00:00
kyle
742ce7ec87 Added a comment 2020-10-01 19:07:48 +00:00
yarikoptic
1bf55a8fc1 Added a comment 2020-10-01 17:26:10 +00:00
Joey Hess
37b1f2f2ed
response 2020-10-01 13:08:09 -04:00