mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/shell/browser
History
Erick Zhao e03a40026a fix: correct triggeredByAccelerator Event property behavior (#18865) 
Fixes #18808

Previously, the triggeredByAccelerator flag would be entirely coupled with whether or not the modifier keys were being used or not.

This PR swaps out the ui::EventFlagsFromModifiers([event modifierFlags])) call in the macOS code to ui::EventFlagsFromNSEventWithModifiers(event, [event modifierFlags])). The latter outputs flags that take into account mouse click events on top of modifier flags (see Chromium documentation).

The business logic to detect triggeredByAccelerator is then changed to exclude any mouse click flags.
2019-06-28 14:38:17 -07:00
..
api fix: correct triggeredByAccelerator Event property behavior (#18865) 2019-06-28 14:38:17 -07:00
lib refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
loader refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
mac refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
media refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
net fix: sanitize invalid custom protocol headers (#18854) 2019-06-21 09:23:57 -07:00
notifications refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
osr refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
printing refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
resources Revert "Bump v7.0.0-nightly.20190628" 2019-06-28 09:07:12 -07:00
ui fix: correct triggeredByAccelerator Event property behavior (#18865) 2019-06-28 14:38:17 -07:00
win refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_blob_reader.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_blob_reader.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_browser_client.cc feat: sandbox renderer processes for cross-origin frames (#18650) 2019-06-20 12:10:56 +02:00
atom_browser_client.h feat: sandbox renderer processes for cross-origin frames (#18650) 2019-06-20 12:10:56 +02:00
atom_browser_context.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_browser_context.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_browser_main_parts.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_browser_main_parts.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_browser_main_parts_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_browser_main_parts_posix.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_download_manager_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_download_manager_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_gpu_client.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_gpu_client.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_javascript_dialog_manager.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_javascript_dialog_manager.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_navigation_throttle.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_navigation_throttle.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_paths.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_permission_manager.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_permission_manager.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_quota_permission_context.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_quota_permission_context.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_speech_recognition_manager_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_speech_recognition_manager_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_web_ui_controller_factory.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_web_ui_controller_factory.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
auto_updater.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
auto_updater.h chore: fix linting after shell rename 2019-06-19 17:33:28 -07:00
auto_updater_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
browser.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
browser.h feat: show optional authors in gtk about panel (#18964) 2019-06-25 11:31:14 -07:00
browser_linux.cc fix: set size of GTK about panel icon (#18957) 2019-06-25 22:17:30 -07:00
browser_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
browser_observer.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
browser_process_impl.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
browser_process_impl.h chore: fix linting after shell rename 2019-06-19 17:33:28 -07:00
browser_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
child_web_contents_tracker.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
child_web_contents_tracker.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
common_web_contents_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
common_web_contents_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
common_web_contents_delegate_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
common_web_contents_delegate_views.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
cookie_change_notifier.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
cookie_change_notifier.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
fake_location_provider.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
fake_location_provider.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
feature_list.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
feature_list.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
font_defaults.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
font_defaults.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
io_thread.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
io_thread.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
javascript_environment.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
javascript_environment.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
login_handler.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
login_handler.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
microtasks_runner.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
microtasks_runner.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view_mac.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view_views.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_browser_view_views.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_window.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_window.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_window_mac.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_window_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_window_observer.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_window_views.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_window_views.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
native_window_views_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
node_debugger.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
node_debugger.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
pref_store_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
pref_store_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
relauncher.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
relauncher.h chore: fix linting after shell rename 2019-06-19 17:33:28 -07:00
relauncher_linux.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
relauncher_mac.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
relauncher_win.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
session_preferences.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
session_preferences.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
special_storage_policy.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
special_storage_policy.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
unresponsive_suppressor.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
unresponsive_suppressor.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_contents_permission_helper.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_contents_permission_helper.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_contents_preferences.cc feat: sandbox renderer processes for cross-origin frames (#18650) 2019-06-20 12:10:56 +02:00
web_contents_preferences.h feat: sandbox renderer processes for cross-origin frames (#18650) 2019-06-20 12:10:56 +02:00
web_contents_zoom_controller.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_contents_zoom_controller.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_dialog_helper.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_dialog_helper.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_view_guest_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_view_guest_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_view_manager.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
web_view_manager.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
window_list.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
window_list.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
window_list_observer.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
zoom_level_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
zoom_level_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00