mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/shell/browser/api
History
Erick Zhao e03a40026a fix: correct triggeredByAccelerator Event property behavior (#18865) 
Fixes #18808

Previously, the triggeredByAccelerator flag would be entirely coupled with whether or not the modifier keys were being used or not.

This PR swaps out the ui::EventFlagsFromModifiers([event modifierFlags])) call in the macOS code to ui::EventFlagsFromNSEventWithModifiers(event, [event modifierFlags])). The latter outputs flags that take into account mouse click events on top of modifier flags (see Chromium documentation).

The business logic to detect triggeredByAccelerator is then changed to exclude any mouse click flags.
2019-06-28 14:38:17 -07:00
..
views refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_app.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_app.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_app_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_app_mas.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_auto_updater.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_auto_updater.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_view.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_view.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_window.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_window.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_window_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_browser_window_views.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_content_tracing.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_cookies.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_cookies.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_debugger.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_debugger.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_desktop_capturer.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_desktop_capturer.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_dialog.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_download_item.cc refactor: make savePath a property on DownloadItem (#18677) 2019-06-20 10:04:57 -07:00
atom_api_download_item.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_event.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
atom_api_global_shortcut.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_global_shortcut.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_in_app_purchase.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_in_app_purchase.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_menu.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_menu.h chore: use ScopedPumpMessagesInPrivateModes in tray (#18977) 2019-06-26 10:18:53 -07:00
atom_api_menu_mac.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_menu_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_menu_views.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_menu_views.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_net.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_net.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_net_log.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_net_log.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_notification.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_notification.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_monitor.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_monitor.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_monitor_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_monitor_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_save_blocker.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_power_save_blocker.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_protocol.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_protocol.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_protocol_ns.cc docs: documentation of NetworkService-based protocol module (#18952) 2019-06-28 16:25:30 +09:00
atom_api_protocol_ns.h docs: documentation of NetworkService-based protocol module (#18952) 2019-06-28 16:25:30 +09:00
atom_api_screen.cc fix: delay emitting screen events by a tick to avoid re-entrancy crash (#19016) 2019-06-27 19:01:28 -07:00
atom_api_screen.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_session.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_session.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_system_preferences.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_system_preferences.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_system_preferences_mac.mm fix: make isDarkMode correctly detect dark mode in the auto setting on catalina (#18949) 2019-06-24 10:17:38 -07:00
atom_api_system_preferences_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_top_level_window.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_top_level_window.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_tray.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_tray.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_url_request.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_url_request.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_view.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_view.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_contents.cc feat: sandbox renderer processes for cross-origin frames (#18650) 2019-06-20 12:10:56 +02:00
atom_api_web_contents.h feat: sandbox renderer processes for cross-origin frames (#18650) 2019-06-20 12:10:56 +02:00
atom_api_web_contents_impl.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_contents_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_contents_view.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_contents_view.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_request.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_request.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_api_web_view_manager.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
event.cc refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
event.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
event_emitter.cc fix: correct triggeredByAccelerator Event property behavior (#18865) 2019-06-28 14:38:17 -07:00
event_emitter.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
frame_subscriber.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
frame_subscriber.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
gpu_info_enumerator.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
gpu_info_enumerator.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
gpuinfo_manager.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
gpuinfo_manager.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
process_metric.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
process_metric.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
save_page_handler.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
save_page_handler.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
stream_subscriber.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
stream_subscriber.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
trackable_object.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
trackable_object.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00