mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/shell/browser/ui
History
Erick Zhao e03a40026a fix: correct triggeredByAccelerator Event property behavior (#18865) 
Fixes #18808

Previously, the triggeredByAccelerator flag would be entirely coupled with whether or not the modifier keys were being used or not.

This PR swaps out the ui::EventFlagsFromModifiers([event modifierFlags])) call in the macOS code to ui::EventFlagsFromNSEventWithModifiers(event, [event modifierFlags])). The latter outputs flags that take into account mouse click events on top of modifier flags (see Chromium documentation).

The business logic to detect triggeredByAccelerator is then changed to exclude any mouse click flags.
2019-06-28 14:38:17 -07:00
..
cocoa fix: correct triggeredByAccelerator Event property behavior (#18865) 2019-06-28 14:38:17 -07:00
views refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
webui refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
win refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
x refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
accelerator_util.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
accelerator_util.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_menu_model.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
atom_menu_model.h chore: use ScopedPumpMessagesInPrivateModes in tray (#18977) 2019-06-26 10:18:53 -07:00
autofill_popup.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
autofill_popup.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
certificate_trust.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
certificate_trust_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
certificate_trust_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
devtools_manager_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
devtools_manager_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
devtools_ui.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
devtools_ui.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
drag_util.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
drag_util_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
drag_util_views.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
file_dialog.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
file_dialog_gtk.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
file_dialog_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
file_dialog_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
inspectable_web_contents.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
inspectable_web_contents.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
inspectable_web_contents_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
inspectable_web_contents_impl.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
inspectable_web_contents_impl.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
inspectable_web_contents_view.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
inspectable_web_contents_view_delegate.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
inspectable_web_contents_view_delegate.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
inspectable_web_contents_view_mac.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
inspectable_web_contents_view_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
message_box.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
message_box_gtk.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
message_box_mac.mm refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
message_box_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
tray_icon.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
tray_icon.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
tray_icon_cocoa.h chore: use ScopedPumpMessagesInPrivateModes in tray (#18977) 2019-06-26 10:18:53 -07:00
tray_icon_cocoa.mm fix: crash when tray popup called twice (#18999) 2019-06-28 08:24:54 -07:00
tray_icon_gtk.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
tray_icon_gtk.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
tray_icon_observer.h refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
tray_icon_win.cc refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00