Cheng Zhao
c2797e1864
Replace extension with the one in filter
2016-03-14 17:08:32 +09:00
Cheng Zhao
81a16b424f
Add extension to filename automatically for GTK+ save dialog
2016-03-14 16:28:01 +09:00
Cheng Zhao
20466bad8f
Fix cpplint warnings
2016-03-10 17:06:23 +09:00
Paul Betts
f4ec369873
More boring fixups
2016-03-10 17:06:22 +09:00
Paul Betts
1c01e4955f
Modifiers moved under UI
2016-03-10 17:06:22 +09:00
Paul Betts
12e9b7ab88
Use assignment operator since both sides are scoped now
2016-03-10 17:06:22 +09:00
Paul Betts
60a2495b30
Update Get() => get(), Set() => reset()
2016-03-10 17:06:22 +09:00
Cheng Zhao
a31cbd24a1
Final pieces of int16 and .Pass()
2016-03-10 17:06:21 +09:00
Cheng Zhao
5fae63a2f5
Fix compilation errors on OS X
2016-03-10 17:06:21 +09:00
Paul Betts
d2944c62a5
basictypes.h => macros.h
2016-03-10 17:06:21 +09:00
Cheng Zhao
549cccfce4
Merge pull request #4715 from dongjoon-hyun/fix_typos_in_comments
...
Fix typos in comments.
2016-03-08 19:45:05 +09:00
Dongjoon Hyun
0c92d44077
Fix typos in comments.
2016-03-07 20:22:03 -08:00
Machisté N. Quintana
2bfc7aa152
Add mapping for performZoom
2016-03-07 16:01:46 -08:00
Machisté N. Quintana
eae5cc9d2c
🎨 [ci skip]
2016-03-07 15:53:09 -08:00
Machisté N. Quintana
4ded709307
Map selectors for delete and pasteAndMatchStyle to roles
2016-03-07 15:42:32 -08:00
Cheng Zhao
2515425cd5
Remove duplicated keyboard code
2016-03-06 15:04:05 +09:00
Dongjoon Hyun
fee56df400
Rename function FilterAccecelator
to FilterAccelerator
in submenu_button.cc
.
2016-02-24 11:15:21 -08:00
Cheng Zhao
49f995925c
Notify the global menu bar when window is mapped
2016-02-23 15:43:32 +08:00
Kevin Sawicki
756aeffe03
Set icon on NSAlert when specified
2016-02-08 15:18:05 -08:00
Heilig Benedek
61e0219e91
Added documentation, restructured the files to fit better with electron's style and fixed a typo in keyboard_util's name.
2016-01-31 02:27:14 +01:00
Robo
65325dc63f
browser: fix crash when switching to sibling menu from submenus
2016-01-20 10:54:12 +05:30
Cheng Zhao
26bd97d6cf
Fix style issues of #4029
2016-01-11 21:12:07 +08:00
leethomas
fee301e768
follow style guidelines
2016-01-10 19:15:40 -08:00
leethomas
803b06b7de
🏁 support defaultId for dialog boxes on Windows
2016-01-10 15:55:26 -08:00
leethomas
ae5c6add11
rename all references to default_button_index -> default_id to keep consistent with cancel_id
2016-01-10 15:33:27 -08:00
leethomas
dfce803045
🏁 update windows message_box function signatures to accept default_button_index....and do nothing with it
2016-01-08 08:23:06 -08:00
leethomas
22c455175a
🐧 add default button index for linux/gtk
2016-01-08 08:22:10 -08:00
leethomas
f1edd5f26f
🍎 add default button index for osx
2016-01-08 08:21:54 -08:00
leethomas
59eda67ba4
🍎 🐛 make displaying alternate tray image depend on mouse down event instead of highlight state
2016-01-05 09:49:27 -08:00
Cheng Zhao
2b6ac966c0
Do not write our own filter code
...
The Win32 API has done everything for us, there is no need to do this
oursevles.
2016-01-05 13:45:34 +08:00
Cheng Zhao
698700716b
Show menu by clicking the menu button
2016-01-05 12:05:27 +08:00
Cheng Zhao
43bfce26a7
Do not behave like bookmarkbar menu
2016-01-05 11:57:58 +08:00
Cheng Zhao
8aced2c31e
Add comment on why checking empty set
2015-12-31 18:58:16 +08:00
Cheng Zhao
b308cd6f96
Merge pull request #3967 from leethomas/fix-osx-crash-when-extensions-empty
...
🍎 fix #3864 where saving a file causes a crash if file extensio…
2015-12-31 18:51:55 +08:00
leethomas
eac2f6fec3
🍎 only add sub menus to Window when they actually have menu items. fixes #3873
2015-12-30 19:38:14 -08:00
leethomas
ba26a4b4e6
🍎 fix #3864 where saving a file causes a crash if file extension array is empty
2015-12-30 13:26:38 -08:00
Nishanth Shanmugham
2bbf86c524
tray: Support file-drop from OS X Dock
...
A long-standing Apple bug does not call `prepareForDragOperation:sender`
for file drag-and-drop operations from the Dock. So we manually
call our custom `handleDrop:sender` for all drag-and-drop cases (that
is, from the Dock and from Finder).
References to the bug in question:
- http://stackoverflow.com/q/9534543/3309046
- http://openradar.appspot.com/radar?id=1745403
However, we still need to return YES from `prepareForDragOperation:sender`,
otherwise the "drag failed" animation occurs. For the same reason, we also
return YES from `performDragOperation:sender`.
2015-12-29 03:27:59 -06:00
Cheng Zhao
e8b5a6dedf
Merge pull request #3718 from atom/chrome47-linux
...
Port Chrome47 on Linux
2015-12-08 10:14:27 +08:00
Paul Betts
af28900189
Fix up Chrome47 changes
2015-12-07 13:27:05 -08:00
Paul Betts
3931ebb7ef
Fix up Windows build errors
2015-12-07 10:02:06 -08:00
Cheng Zhao
73e7773d84
Update to API changes of Chrome 47
2015-12-07 19:56:23 +08:00
Cheng Zhao
615ce45849
win: Implement menu parameter
2015-12-02 19:58:10 +08:00
Cheng Zhao
3cdd0f35c7
mac: Implement menu parameter
2015-12-02 19:05:22 +08:00
Cheng Zhao
2fba05b5e7
Add menu
parameter for Tray.popUpContextMenu
2015-12-02 18:43:11 +08:00
Cheng Zhao
87546bd4f8
Merge pull request #3479 from bengotow/tray-resizing
...
Fix sizing of Mac OS X tray icon after image change
2015-11-18 18:49:15 +08:00
Ben Gotow
9c69416e32
Fix sizing of Mac OS X tray icon after image change
...
- Consolidate logic that applies view dimensions into a function
- Use `NSVariableStatusItemLength` instead of trying to sync status item width
- Use modern Obj-C syntax `@[], @{}` in a few places
- Recompute view bounds after updating image in `setImage:`
2015-11-17 13:43:55 -08:00
Nishanth Shanmugham
d1e8e71e3f
Tray: Add drag-end and drop events
2015-11-10 10:02:50 -06:00
Nishanth Shanmugham
8a296f82a0
Tray: Remove extra qualification in header
2015-11-05 19:02:24 -06:00
Nishanth Shanmugham
818892d474
Tray: Add drag-entered and drag-exited events
2015-11-05 18:46:49 -06:00
mgarciaisaia
4013b652ff
🏁 🐛 Buffer overflows in tooltips
...
Fixes #3290 .
2015-11-04 15:34:58 +08:00