Shelley Vohr
f89c2a0ef4
fix: titlebar showing in content protected window ( #47241 )
...
Closes https://github.com/electron/electron/issues/47152 .
2025-05-26 09:46:04 +02:00
Shelley Vohr
c6f368acc6
chore: debug crash on DevTools SetOwnerWindow ( #47243 )
2025-05-26 09:45:43 +02:00
David Sanders
5e3b5ef04c
chore: update @electron/lint-roller to 3.1.1 ( #47202 )
...
* chore: update @electron/lint-roller to 3.1.1
* docs: fix broken link in breaking-changes.md
* chore: fix for Node.js versions without require(esm)
2025-05-25 07:58:55 -05:00
John Kleinschmidt
ac5e3c76f3
build: migrate to new chromium git auth ( #47230 )
2025-05-25 07:57:20 -05:00
Gellert Hegyi
b9b96a96f7
feat: add menu item role palette and header ( #45538 )
...
* feat: add menu item role `palette` and `header`
* adds comments
* refactors new role items to new item types
* docs: custom type
* docs: note types only available on mac 14+
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2025-05-23 12:43:49 -04:00
Charles Kerr
2248de847d
refactor: use base::fixed_flat_set in NativeWindowViews::SetAlwaysOnTop() ( #47201 )
...
refactor: use base::fixed_flat_set in NativeWindowViews::SetAlwaysOnTop()
2025-05-22 18:20:39 -05:00
Charles Kerr
38e7ff944e
refactor: make NativeWindow::has_frame_ const ( #47200 )
...
* refactor: make NativeWindow::is_modal_ const
* refactor: make NativeWindow::title_bar_style_ const and private
* refactor: make NativeWindow::has_client_frame() protected
refactor: make NativeWindow::transparent() protected
* refactor: make NativeWindow::enable_larger_than_screen() protected
* refactor: make NativeWindow::has_frame_ const
* fixup! refactor: make NativeWindow::has_client_frame() protected
fix: GetExpandedWindowSize()
2025-05-22 17:32:46 -05:00
David Sanders
8f09d7037b
ci: add problem matcher for patch conflict output ( #47183 )
2025-05-22 09:27:23 -04:00
David Sanders
d0102ff392
ci: add problem matcher for clang output ( #46577 )
2025-05-22 09:25:57 -04:00
Keeley Hammond
274e1df1ca
build: revert bump @octokit/rest from 20.1.1 to 21.1.1 ( #47208 )
...
Revert "build(deps-dev): bump @octokit/rest from 20.1.1 to 21.1.1 (#47159 )"
This reverts commit 517f5c15b9
2025-05-21 18:39:24 -07:00
John Kleinschmidt
b2d0074cc6
build: fix depot tool pathing on Windows ( #47194 )
...
build: properly set depot_tools pathing for Windows
2025-05-21 16:05:50 -07:00
Charles Kerr
2e8fc17f07
refactor: pass views::Widget* into constructors of our TreeHosts and NativeWidgets ( #47177 )
...
* refactor: remove unnecessary downcast in MenuViews::PopupAt()
* refactor: pass a views::Widget as an arg to the ElectronDesktopWindowTreeHostLinux ctor
* refactor: pass a views::Widget as an arg to the ElectronDesktopNativeWidgetAura ctor
* refactor: pass a views::Widget as an arg to the ElectronDesktopWindowTreeHostWin ctor
* refactor: create desktop_window_tree_host_ in the ElectronDesktopNativeWidgetAura constructor
* fixup! refactor: create desktop_window_tree_host_ in the ElectronDesktopNativeWidgetAura constructor
fix: tyop
2025-05-21 16:02:55 -05:00
Charles Kerr
4af0c5d762
refactor: make NativeWindow::transparent_ const ( #47172 )
...
* refactor: use in-class member initialization for NativeWindow::widget_
* refactor: make NativeWindow::transparent_ const
refactor: make NativeWindow::enable_larger_than_screen_ const
* chore: make linter happy after rebase
2025-05-21 19:42:08 +02:00
Charles Kerr
a7a3e10300
refactor: prefer base::circular_deque over std::deque ( #47171 )
...
* refactor: use base::circular_deque in ResolveProxyHelper
* refactor: use base::circular_deque in GetExtraCrashKeys()
refactor: reduce visibility of kMaxCrashKeyValueSize
This change is to match Chromium's usage advice from
base/containers/README.md: `base:circular_deque` is preferred over
`std::deque` to provide consistent performance across platforms.
2025-05-21 12:04:36 -05:00
Shelley Vohr
7b77a24211
fix: remove extra 'suspend'/'resume' handling from powerMonitor ( #47162 )
...
fix: remove extra 'suspend'/'resume' handling from powerMonitor
2025-05-21 10:00:38 -05:00
David Sanders
7112c592c9
test: strip color output in ESM spec ( #47185 )
2025-05-21 10:50:06 +02:00
Charles Kerr
d6638f9564
refactor: make NativeWindow::pending_transitions_ a base::queue ( #47157 )
...
refactor: make NativeWindow::pending_transitions a base::queue
Follow the base/containers/README.md advice that "Chromium code should
always use `base::circular_deque` or `base::queue` in preference to
`std::deque` or `std::queue` due to memory usage and platform variation."
2025-05-20 17:35:51 -05:00
Charles Kerr
9f8bcc4d98
refactor: make NativeWindow::has_client_frame_ const ( #47156 )
2025-05-20 17:14:28 -05:00
Charles Kerr
21155679a0
refactor: add NativeWindowViews::GetClientFrameViewLinux() ( #47130 )
...
* refactor: add NativeWindowViews::GetClientFrameViewLinux()
* chore: clarify code comment
2025-05-20 14:15:06 -05:00
Charles Kerr
211faed848
refactor: add NativeWindow::IsActive() ( #47148 )
...
this was already present on macOS; use in NativeWindowViews too
2025-05-20 11:08:44 -04:00
Shelley Vohr
296e39456a
refactor: match upstream macOS a11y handling ( #47144 )
2025-05-20 11:06:57 -04:00
John Kleinschmidt
a19198d784
build: update_depot_tools on initial install ( #47160 )
...
this ensures that python is setup for proper use from depot_tools
2025-05-20 10:40:48 -04:00
reito
263c76df09
fix: prevent gc monitor 2nd pass crash ( #46987 )
2025-05-20 22:54:03 +09:00
dependabot[bot]
517f5c15b9
build(deps-dev): bump @octokit/rest from 20.1.1 to 21.1.1 ( #47159 )
...
Bumps [@octokit/rest](https://github.com/octokit/rest.js ) from 20.1.1 to 21.1.1.
- [Release notes](https://github.com/octokit/rest.js/releases )
- [Commits](https://github.com/octokit/rest.js/compare/v20.1.1...v21.1.1 )
---
updated-dependencies:
- dependency-name: "@octokit/rest"
dependency-version: 21.1.1
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-20 09:57:30 +02:00
dependabot[bot]
d29293556d
build(deps): bump github/codeql-action from 3.28.15 to 3.28.18 ( #47158 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.28.15 to 3.28.18.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](45775bd823...ff0a06e83c
2025-05-20 09:56:54 +02:00
Shelley Vohr
e0ea069859
build: remove fix_linter_error.patch ( #47150 )
...
build: remove fix_linter_error.patch
2025-05-19 22:52:01 +02:00
electron-roller[bot]
7cc76c094a
chore: bump node to v22.15.1 (main) ( #47105 )
...
* chore: bump node in DEPS to v22.15.1
* chore: fixup patch indices
* src: fix error handling on async crypto operations
https://github.com/nodejs-private/node-private/pull/709
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-19 16:12:48 -04:00
Charles Kerr
3660432f42
refactor: NativeWindows should prefer widget() over GetWidget() for internal use ( #47133 )
2025-05-19 21:43:16 +02:00
Charles Kerr
687e50b4f3
refactor: add NativeWindowViews::SetTitleBarOverlay() ( #47126 )
...
* refactor: move SetTitleBarOverlay() impl to NativeWindowViews
* refactor: make NativeWindowViews::set_overlay_button_color() private
refactor: make NativeWindowViews::set_overlay_symbol_color() private
refactor: make NativeWindow::set_titlebar_overlay_height() protected
* refactor: simplify downcasting in NativeWindowViews::SetTitleBarOverlay()
2025-05-19 08:19:03 -05:00
David Sanders
d426667a01
build(dev-deps): update @electron/lint-roller and markdownlint-cli2 ( #47082 )
2025-05-19 14:19:04 +02:00
Charles Kerr
208bbc0504
refactor: add NativeWindow::SetShape() ( #47131 )
...
use NativeWindow::SetShape() in api::BaseWindow
2025-05-19 10:29:29 +02:00
dependabot[bot]
e2f496cfbc
build(deps-dev): bump @typescript-eslint/eslint-plugin from 8.7.0 to 8.32.1 ( #47135 )
...
build(deps-dev): bump @typescript-eslint/eslint-plugin
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin ) from 8.7.0 to 8.32.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases )
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md )
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.32.1/packages/eslint-plugin )
---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
dependency-version: 8.32.1
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-19 10:27:22 +02:00
Charles Kerr
1da150f9a3
chore: remove gclient sync macOS CI hack patch ( #47123 )
...
chore: remove hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch
2025-05-19 10:26:58 +02:00
Calvin
5dd6481e53
fix: explicit microtask scope DCHECK condition ( #47134 )
2025-05-19 12:08:59 +09:00
dependabot[bot]
d72e622a3f
build(deps): bump slackapi/slack-github-action from 2.0.0 to 2.1.0 ( #47060 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](485a9d42d3...b0fa283ad8
2025-05-16 12:55:00 -05:00
Charles Kerr
8efd24c339
perf: don't create unused menuitem icons ( #47100 )
...
GTK >= 3.90.0 removed support for menuitem icons. When Electron is
built with GTK >= 3.90.0, our code builds these icons and then throws
them away unused. Instead, let's just not build them.
Our gtk_util::GdkPixbufFromSkBitmap utility uses BGRAToRGBA and is
expensive to call.
2025-05-16 02:43:03 -05:00
Erick Zhao
dc34e8732c
docs: add note on DIP and DPI ( #47080 )
2025-05-15 16:51:49 -05:00
Charles Kerr
77c58658c5
refactor: decouple NativeWindowViews and GlobalMenuBarX11 ( #47094 )
...
The GlobalMenuBar used to hold a raw_ptr reference to its NativeWindow;
but since it doesn't use it & only wants the gfx::AcceleratedWidget info,
let's remove the NativeWindowViews reference.
AFAICT, GlobalMenuBarX11::window_ has never been used
2025-05-15 16:10:56 -05:00
Charles Kerr
d720aea700
refactor: make TrackableObject::weak_map_id() constexpr ( #47092 )
...
* refactor: make TrackableObject::weak_map_id() constexpr
refactor: make BaseWindow::GetID() inline and constexpr
* refactor: make NativeWindow::window_id() constexpr too
2025-05-15 16:10:33 -05:00
Charles Kerr
e2bcd8f0aa
test: fix desktopCapturer mocha syntax ( #47088 )
...
* test: fix desktopCapturer mocha syntax
do not nest `it` calls in desktopCapturer specs
* empty commit
2025-05-15 16:54:49 -04:00
Robo
99a3e360ec
fix: opening package paths as directory on macOS ( #47077 )
2025-05-15 12:47:46 -05:00
electron-roller[bot]
883f48b9b4
chore: bump chromium to 138.0.7178.0 (main) ( #47086 )
...
* chore: bump chromium in DEPS to 138.0.7178.0
* 6351556: [source-phase-imports] Support Wasm Source Phase Imports
Refs 63515566509682
2025-05-15 12:47:07 -05:00
Charles Kerr
9a7b73b533
refactor: use kKeyModifiers in IsAltModifier() ( #47066 )
...
We probably didn't use this before because IsAltModifier() was written
two years before the KeyModifiers mask was added upstream in 98ec378a.
2025-05-14 11:00:00 -04:00
Charles Kerr
6170a5af40
chore: combine all the "patch out Profiles" changes into a single patch ( #47063 )
...
* chore: fold the profile patches into one patch
* chore: e patches all
* chore: patch out ProfileSelections::ApplyProfileSelection()
Another profile reference. Referenced iff making a debug build.
2025-05-14 09:21:11 -05:00
electron-roller[bot]
d65a856bf3
chore: bump chromium to 138.0.7177.0 (main) ( #47081 )
...
* chore: bump chromium in DEPS to 138.0.7177.0
* 6530423: [WebContents] Fix IsNeverComposited() calls during initialization
Refs 65304236512551
2025-05-14 10:08:31 -04:00
Shelley Vohr
f2639d13cc
refactor: remove CreateViewForWidget patch ( #46981 )
...
* refactor: remove CreateViewForWidget patch
* chore: rm unintended osr change
* Trigger CI
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2025-05-14 21:43:23 +09:00
Charles Kerr
11fa915724
refactor: remove introduce_ozoneplatform_electron_can_call_x11_property.patch ( #47075 )
...
* refactor: use x11_util::IsX11() in BuildSubmenuFromModel()
* refactor: use x11_util::IsX11() in ElectronDesktopWindowTreeHostLinux::OnBoundsChanged()
* refactor: use skia_can_fall_back_to_x11 in x11_util::IsX11()
it is identical in practice to electron_can_call_x11 and does not require a Chromium patch
* chore: remove introduce_ozoneplatform_electron_can_call_x11_property.patch
* refactor: use ui::GetOzonePlatformId() to test for x11
2025-05-14 13:38:35 +09:00
David Sanders
9aacc473e6
build: remove patch that landed upstream ( #47079 )
2025-05-13 20:10:48 -05:00
Charles Kerr
c218128675
chore: remove disable_unload_metrics.patch ( #47059 )
2025-05-13 14:55:59 -04:00
electron-roller[bot]
e3e647d21e
chore: bump chromium to 138.0.7175.0 (main) ( #46986 )
...
* chore: bump chromium in DEPS to 138.0.7166.0
* chore: bump chromium in DEPS to 138.0.7166.2
* 6508373: Add WebContents, Tab getters for future Clank navigation capture rework
650837364709246502977649368864887556428707651412165141216531585651225364287076508373
2025-05-13 14:51:20 -04:00
