mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: prevent gc monitor 2nd pass crash (#46987)

Browse source
This commit is contained in:
reito 2025-05-20 21:54:03 +08:00 • committed by GitHub
parent 517f5c15b9
commit 263c76df09
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

22
shell/common/gin_converters/osr_converter.cc
View file

@ -143,19 +143,21 @@ v8::Local<v8::Value> Converter<electron::OffscreenSharedTextureValue>::ToV8(
// texture, output it in second pass callback.
data.SetSecondPassCallback([](const v8::WeakCallbackInfo<
OffscreenReleaseHolderMonitor>& data) {
auto* iso = data.GetIsolate();
// Emit warning only once
static std::once_flag flag;
std::call_once(flag, [=] {
electron::util::EmitWarning(
iso,
"[OSR TEXTURE LEAKED] When using OSR with "
"`useSharedTexture`, `texture.release()` "
"must be called explicitly as soon as the texture is "
"copied to your rendering system. "
"Otherwise, it will soon drain the underlying "
"framebuffer and prevent future frames from being generated.",
"SharedTextureOSRNotReleased");
base::SingleThreadTaskRunner::GetCurrentDefault()->PostTask(
FROM_HERE, base::BindOnce([] {
electron::util::EmitWarning(
"Offscreen rendering shared texture was garbage "
"collected before calling `release()`. When using OSR "
"with `useSharedTexture: true`, `texture.release()` "
"must be called explicitly as soon as the texture is "
"copied to your rendering system. Otherwise, it will "
"soon drain the underlying frame pool and prevent "
"future frames from being sent.",
"OSRSharedTextureNotReleased");
}));
});
});
}