Robo
2a92d8f962
refactor: only access memory coordinator interface from browser process ( #31295 )
...
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3174305
2021-10-05 15:30:31 -07:00
Milan Burda
d7a7c120d1
fix: "Failed to serialize arguments" when emitting 'context-menu' for webview ( #31259 )
...
* fix: sanitize params for 'context-menu' event sent over IPC for webview
* Revert "fix: sanitize params for 'context-menu' event sent over IPC for webview"
This reverts commit 7fee455138e8470756a677dcca1a830260ba8d97.
* fix: make frame property non-enumerable in params for 'context-menu' event
2021-10-04 14:00:25 -04:00
Jeremy Rose
4fd7c2adcd
feat: make desktopCapturer main-process-only ( #30720 )
...
* feat: make desktopCapturer main-process-only
* remove --enable-api-filtering-logging
* remove test
* merge lib/browser/api/desktop-capturer.ts with lib/browser/desktop-capturer.ts
* remove desktop-capturer-get-sources event
* fix specs
* getSources needs to be async
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2021-10-04 12:16:00 +09:00
Milan Burda
80577a4f08
refactor: use native WeakRef instead of v8util.weaklyTrackValue() ( #31153 )
2021-09-27 16:50:42 -04:00
Milan Burda
98ac0ca52a
fix: running tests with release build ( #31092 )
2021-09-27 16:58:03 +02:00
Keeley Hammond
d88e71f688
chore: remove gin::Wrappable crash keys ( #31075 )
...
* chore: remove gin wrappable crash keys
* chore: remove class headers from crash keys
2021-09-23 21:38:40 -07:00
John Kleinschmidt
6aece4a83d
feat: add support for WebHID ( #30213 )
...
* feat: add support for WebHID
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* Address review feedback
* Address review feedback
* chore: clear granted_devices on navigation
Also added test to verify devices get cleared
* fixup testing for device clear
* make sure navigator.hid.getDevices is run on correct frame
* clear granted devices on RenderFrameHost deletion/change
* manage device permissions per RenderFrameHost
This change makes sure we don't clear device permission prematurely due to child frame navigation
* Update shell/browser/api/electron_api_web_contents.cc
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* apply review feedback from @zcbenz
* Match upstream ObjectMap
This change matches what ObjectPermissionContextBase uses to cache object permissions: https://source.chromium.org/chromium/chromium/src/+/main:components/permissions/object_permission_context_base.h;l=52;drc=8f95b5eab2797a3e26bba299f3b0df85bfc98bf5;bpv=1;bpt=0
The main reason for this was to resolve this crash on Win x64:
ok 2 WebContentsView doesn't crash when GCed during allocation
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
gin::WrappableBase::SecondWeakCallback [0x00007FF6F2AFA005+133] (o:\gin\wrappable.cc:53)
v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacks [0x00007FF6F028F9AB+171] (o:\v8\src\handles\global-handles.cc:1400)
v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacksFromTask [0x00007FF6F028F867+391] (o:\v8\src\handles\global-handles.cc:1387)
node::PerIsolatePlatformData::RunForegroundTask [0x00007FF6F3B4D065+317] (o:\third_party\electron_node\src\node_platform.cc:415)
node::PerIsolatePlatformData::FlushForegroundTasksInternal [0x00007FF6F3B4C424+776] (o:\third_party\electron_node\src\node_platform.cc:479)
uv_run [0x00007FF6F2DDD07C+492] (o:\third_party\electron_node\deps\uv\src\win\core.c:609)
electron::NodeBindings::UvRunOnce [0x00007FF6EEE1E036+294] (o:\electron\shell\common\node_bindings.cc:631)
base::TaskAnnotator::RunTask [0x00007FF6F2318A19+457] (o:\base\task\common\task_annotator.cc:178)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x00007FF6F2E6F553+963] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:361)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x00007FF6F2E6EC69+137] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:266)
base::MessagePumpForUI::DoRunLoop [0x00007FF6F235AA58+216] (o:\base\message_loop\message_pump_win.cc:221)
base::MessagePumpWin::Run [0x00007FF6F235A01A+106] (o:\base\message_loop\message_pump_win.cc:79)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FF6F2E702DA+682] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:470)
base::RunLoop::Run [0x00007FF6F22F95BA+842] (o:\base\run_loop.cc:136)
content::BrowserMainLoop::RunMainMessageLoop [0x00007FF6F14423CC+208] (o:\content\browser\browser_main_loop.cc:990)
content::BrowserMainRunnerImpl::Run [0x00007FF6F144402F+143] (o:\content\browser\browser_main_runner_impl.cc:153)
content::BrowserMain [0x00007FF6F143F911+257] (o:\content\browser\browser_main.cc:49)
content::RunBrowserProcessMain [0x00007FF6EFFA7D18+112] (o:\content\app\content_main_runner_impl.cc:608)
content::ContentMainRunnerImpl::RunBrowser [0x00007FF6EFFA8CF4+1220] (o:\content\app\content_main_runner_impl.cc:1104)
content::ContentMainRunnerImpl::Run [0x00007FF6EFFA87C9+393] (o:\content\app\content_main_runner_impl.cc:971)
content::RunContentProcess [0x00007FF6EFFA73BD+733] (o:\content\app\content_main.cc:394)
content::ContentMain [0x00007FF6EFFA79E1+54] (o:\content\app\content_main.cc:422)
wWinMain [0x00007FF6EECA1535+889] (o:\electron\shell\app\electron_main.cc:291)
__scrt_common_main_seh [0x00007FF6F6F88482+262] (d:\A01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
BaseThreadInitThunk [0x00007FFEC0087034+20]
RtlUserThreadStart [0x00007FFEC1F02651+33]
✗ Electron tests failed with code 0xc0000005.
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-09-23 20:00:11 +09:00
Milan Burda
77579614e0
feat: add width option to dialog.showMessageBox() ( #30474 )
2021-09-23 19:56:14 +09:00
Samuel Maddock
70c534fd14
feat: add frame to context-menu event params ( #30831 )
...
* feat: add frame to context-menu event params
* doc: rephrase frame description
2021-09-22 08:52:49 +09:00
Raymond Zhao
1295ba0ffc
fix: Building on macOS with is_debug true ( #30913 )
...
* fix: Building on macOS with is_debug true
* Change to no-op impl
2021-09-15 09:40:36 +09:00
Samuel Attard
fb539f15d0
chore: fix compile errors ( #30903 )
2021-09-09 19:52:23 -07:00
Samuel Attard
57d088517c
feat: add support for validating asar archives on macOS ( #30667 )
...
* feat: add support for validating asar archives on macOS
* chore: fix lint
* chore: update as per feedback
* feat: switch implementation to asar integrity hash checks
* feat: make ranged requests work with the asar file validator DataSourceFilter
* chore: fix lint
* chore: fix missing log include on non-darwin
* fix: do not pull block size out of missing optional
* fix: match ValidateOrDie symbol on non-darwin
* chore: fix up asar specs by repacking archives
* fix: maintain integrity chain, do not load file integrity if header integrity was not loaded
* debug test
* Update node-spec.ts
* fix: initialize header_validated_
* chore: update PR per feedback
* chore: update per feedback
* build: use final asar module
* Update fuses.json5
2021-09-09 14:49:01 -07:00
Darshan Sen
90a3e7f927
feat: warn when crash key name is longer than 39 bytes ( #30742 )
...
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
2021-09-07 11:09:48 -07:00
Jeremy Rose
55c57808fb
feat: serialize NativeImage over ipc ( #30729 )
2021-09-07 10:37:45 -07:00
Samuel Maddock
4d89174b41
feat: add 'dom-ready' event to WebFrameMain ( #29290 )
2021-09-01 15:21:15 -07:00
electron-roller[bot]
49e62f1261
chore: bump chromium to 95.0.4629.0 (main) ( #30676 )
...
* chore: bump chromium in DEPS to 95.0.4620.0
* chore: update patches
* 3076261: Move args_ to private in ExtensionFunction
https://chromium-review.googlesource.com/c/chromium/src/+/3076261
* [GURL -> SiteForCookies] content/public/browser/content_browser_client.h
https://chromium-review.googlesource.com/c/chromium/src/+/3107759
* chore: fix -Wunreachable-code-return in node
* Tracing to diagnose ContentScriptTracker-related bad message reports
https://chromium-review.googlesource.com/c/chromium/src/+/3057922
* chore: bump chromium in DEPS to 95.0.4621.0
* chore: update patches
* Remove title from the URL format on Windows.
https://chromium-review.googlesource.com/c/chromium/src/+/3108445
* chore: bump chromium in DEPS to 95.0.4623.0
* Revert "chore: disable v8 oilpan"
This reverts commit 5d255cf1d8e8efbb906047937a713279e5f800d0.
(cherry picked from commit ba5cde4da2428020d99b7fb603c702878f95da78)
* Change file paths in network context params to be relative.
https://chromium-review.googlesource.com/c/chromium/src/+/3092927
* Code Health: Rename/replace content::WebUI::RegisterMessageCallback().
https://chromium-review.googlesource.com/c/chromium/src/+/3104691
* Migrate CanExecuteContentScriptSync to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/3108452
* chore: update patches
* remove unreachable code
* Revert "Revert "chore: disable v8 oilpan""
This reverts commit fef495c0294e21760df51bddb5f7bf1ec9ed5f1e.
* fixup mas patch
* Reland "[include] Split out v8.h"
https://chromium-review.googlesource.com/c/v8/v8/+/3113629
* chore: bump chromium in DEPS to 95.0.4624.0
* chore: bump chromium in DEPS to 95.0.4625.0
* chore: bump chromium in DEPS to 95.0.4626.0
* 3033504: Pass NavigationDownloadPolicy in CreateNewWindowParams
https://chromium-review.googlesource.com/c/chromium/src/+/3033504
* 3058038: Introduce TestPrintingContext & test UpdatePrintSettings
https://chromium-review.googlesource.com/c/chromium/src/+/3058038
* 3114943: [Conditional Focus][#4 ] Add tests and remove flag gating
https://chromium-review.googlesource.com/c/chromium/src/+/3114943
* chore: update patch indices
* chore: bump chromium in DEPS to 95.0.4627.0
* chore: update patches
* 3093591: ozone: webpagepopups: calculate anchor for menu bounds. 4/*
https://chromium-review.googlesource.com/c/chromium/src/+/3093591
* 3110414: [PA] Remove the leading cookie
https://chromium-review.googlesource.com/c/chromium/src/+/3110414
* chore: update patches
* 3076261: Move args_ to private in ExtensionFunction
https://chromium-review.googlesource.com/c/chromium/src/+/3076261
* 3113629: Reland "[include] Split out v8.h"
https://chromium-review.googlesource.com/c/v8/v8/+/3113629
* chore: bump chromium in DEPS to 95.0.4628.0
* chore: update patches
* chore: bump chromium in DEPS to 95.0.4629.0
* chore: update patches
* Fix chrome root store codegen for cross-compile builds.
https://chromium-review.googlesource.com/c/chromium/src/+/3133701
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-09-01 15:55:07 -04:00
Shelley Vohr
63b35403ef
fix(linux): OpenURI portal support for shell.showItemInFolder() ( #30716 )
2021-09-01 10:04:28 +09:00
electron-roller[bot]
c1075debf3
chore: bump node to v16.8.0 (main) ( #30714 )
...
* chore: bump node in DEPS to v16.8.0
* build: add option to hide console window
https://github.com/nodejs/node/pull/39712
* chore: fixup patch indices
* stream: duplexify
https://github.com/nodejs/node/pull/39519
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-08-31 10:36:04 -04:00
Samuel Attard
8007d01874
feat: add support for the U2F Web API ( #30438 )
...
* feat: add support for the U2F Web API
* chore: fix lint
* chore: fix tests
* build: disable src caching
* Revert "build: disable src caching"
This reverts commit c4c8a60fc435a10788475ec171399a55ac2dd674.
* chore: update per feedback
* chore: consistent code removal
2021-08-30 11:22:46 -07:00
Jeremy Rose
aa9da78edb
fix: remove ipc wrapper for nativeImage.createThumbnailFromPath ( #30728 )
2021-08-27 14:21:36 -07:00
electron-roller[bot]
5513e66982
chore: bump chromium to 95.0.4612.5 (main) ( #30503 )
...
* chore: bump chromium in DEPS to 94.0.4604.0
* build: 3-way merge of chromium patches
* chore: bump chromium in DEPS to 94.0.4605.0
* build: 3-way merge of chromium patches
* 3076040: Reland Remove delete_children RemoveAllChildViews arg
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3076040
* 3069287: Remove the remaining uses and delete the deprecated API
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3069287
* 2297212: Replace RemoveWithoutPathExpansion(.*, nullptr) with Value::RemoveKey()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2297212
Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296
* 3082756: Change transport_security_persister_path param to be a path to a file.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3082756
> this CL intentionally changes the name of the parameter
> in the network context parameters and the order of the constructor
> parameters to ensure all callers update their code to pass a full
> file path rather than a path to a directory.
The 'path' in this diff is already an absolute path, coming from
`CHECK(base::PathService::Get(chrome::DIR_USER_DATA, &path_));` at
08ff1c2cbf/shell/browser/electron_browser_context.cc (L126)
* iwyu: network::mojom::HttpRawHeaderPair
* fixup! 3076040: Reland Remove delete_children RemoveAllChildViews arg
Missed one.
* 2999884: CodeHealth: Remove DictionaryValue::GetStringWithoutPathExpansion
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2999884
(example of replacing GetStringWithoutPathExpansion() w/FindStringKey())
Also: https://chromium-review.googlesource.com/c/chromium/src/+/3060296
(removal of DictionaryValue::GetStringWithoutPathExpansion)
* 3059260: Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3059260
We had both of these in a 'disable_features' list. Since these feature have
been removed upstream, remove them from our disable list, too.
IMPORTANT: this commit should not be backported to older branches that
still have these features, because doing so would un-disable them.
* 2920890: Load reroute_info from download in-progress and history db back into DownloadItem.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2920890
* 3039323: [Clipboard API] Clipboard Custom Formats implementation Part 5.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3039323
* chore: bump chromium in DEPS to 94.0.4606.0
* 3084502: Add a new PrintRasterizePdfDpi policy.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3084502
* chore: update patches
* chore: bump chromium in DEPS to 94.0.4606.3
* chore: bump chromium in DEPS to 95.0.4608.0
* chore: bump chromium in DEPS to 95.0.4609.0
* [DevTools] Remove report_raw_headers from network::ResourceRequest
https://chromium-review.googlesource.com/c/chromium/src/+/2856099
* Remove content::WebContentsObserver::OnInterfaceRequestFromFrame
https://chromium-review.googlesource.com/c/chromium/src/+/3092665
* Disable kDesktopCaptureMacV2
https://chromium-review.googlesource.com/c/chromium/src/+/3069272
* Add a new PrintRasterizePdfDpi policy.
https://chromium-review.googlesource.com/c/chromium/src/+/3084502
* chore: update patches
* chore: bump chromium in DEPS to 95.0.4609.3
* disable `use_lld` for macos
* chore: update patches
* Linux: use chrome_crashpad_handler instead of crashpad_handler
https://chromium-review.googlesource.com/c/chromium/src/+/3054290
* chore: fix lint
* Revert "[DevTools] Remove report_raw_headers from network::ResourceRequest"
This reverts commit 28f4da1582d046e96cb58f3cbb590503e89dfd0d.
* [DevTools] Remove report_raw_headers from network::ResourceRequest (Attempt #2 )
https://chromium-review.googlesource.com/c/chromium/src/+/2856099
* DCHECK that predictor always has a non-empty NetworkIsolationKey.
https://chromium-review.googlesource.com/c/chromium/src/+/3067698
* Remove --no-untrusted-code-mitigations from //content and //gin
https://chromium-review.googlesource.com/c/chromium/src/+/3096585
* fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
https://chromium-review.googlesource.com/c/chromium/src/+/3059260
* fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
* Convert PrintManager to RenderFrameHostReceiverSet.
https://chromium-review.googlesource.com/c/chromium/src/+/3072019
* chore: bump chromium in DEPS to 95.0.4612.5
* chore: disable v8 oilpan
* [Compiler] Remove untrusted code mitigations.
https://chromium-review.googlesource.com/c/v8/v8/+/3045704
* Remove most FTP logic from services/network.
https://chromium-review.googlesource.com/c/chromium/src/+/3076119
* Rename scale_factor.h -> resource_scale_factor.h
https://chromium-review.googlesource.com/c/chromium/src/+/3057113
* [GURL -> SiteForCookies] extensions/
https://chromium-review.googlesource.com/c/chromium/src/+/3100825
* breadcrumbs: add desktop entry point
https://chromium-review.googlesource.com/c/chromium/src/+/3021746
* Move args_ to private in ExtensionFunction
https://chromium-review.googlesource.com/c/chromium/src/+/3076261
* chore: iwyu
* fixup! Remove kSameSiteByDefaultCookies and kCookiesWithoutSameSiteMustBeSecure
* Disable kDesktopCaptureMacV2
https://chromium-review.googlesource.com/c/chromium/src/+/3069272
* fixup! [Compiler] Remove untrusted code mitigations.
* fixup! Disable kDesktopCaptureMacV2
* Revert "chore: disable v8 oilpan"
This reverts commit 5d255cf1d8e8efbb906047937a713279e5f800d0.
* Reland "chore: disable v8 oilpan"
This reverts commit 1c252765b07a205560e7b5eed06de2605336e2d8.
The previous revert was to test on which platforms did the
heapsnapshot test actually fail.
* [Clipboard API] Clipboard Custom Formats implementation Part 5.
https://chromium-review.googlesource.com/c/chromium/src/+/3039323
* Convert ExtensionFrameHost to RenderFrameHostReceiverSet.
https://chromium-review.googlesource.com/c/chromium/src/+/3063358
* Convert PDFWebContentsHelper to RenderFrameHostReceiverSet.
https://chromium-review.googlesource.com/c/chromium/src/+/3049751
* [Underscore Migration] Migrate ui/legacy
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3093160
* chore: remove unknown permission error
* chore: fix lint
* chore: ignore -Wunreachable-code-return for node deps/
* fixup! chore: ignore -Wunreachable-code-return for node deps/
* fix: windows build
* fix: build dependency
Dependency was missed in cbeae20438
* 3108669: arm,dsp: Fix 8bpp Dct64_NEON().
https://chromium-review.googlesource.com/c/codecs/libgav1/+/3108669
* chore: revert libgav1 roll
* Revert "3108669: arm,dsp: Fix 8bpp Dct64_NEON()."
This reverts commit 7ed31323127aac8ba2eaff9cae6c9be9a4954f33.
* Revert "chore: revert libgav1 roll"
This reverts commit 084a490d298811267316c786762fe7aa91b6318d.
* chore: revert clang roll
* chore: Fix -Wunreachable-code-aggressive warnings in arm and arm64 code
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: mlaurencin <mlaurencin@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2021-08-23 20:52:17 -04:00
Keeley Hammond
cbeae20438
fix: change gin_wrappable to scoped crash key ( #30578 )
2021-08-18 13:51:40 -07:00
Cheng Zhao
8699124397
refactor: dynamically search defines from node ( #30563 )
2021-08-18 13:34:15 -07:00
electron-roller[bot]
81c143318b
chore: bump chromium to 94.0.4590.2 (main) ( #30274 )
...
* chore: bump chromium in DEPS to 94.0.4587.0
* chore: update patches
* 2823155: fix GPU video decoding capabilities enumeration
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/2823155
* 3041383: Reduce includes in url_request_mojom_traits.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3041383
* chore: bump chromium in DEPS to 94.0.4588.0
* chore: update patches
* chore: bump chromium in DEPS to 94.0.4589.0
* chore: update patches
* 3050633: Rename ScaleFactor to ResourceScaleFactor
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3050633
* 3048296: Create new mojo target to prevent traits header spreading
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3048296
* 3046186: Rename base::ClampToRange
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3046186
* chore: update picture-in-picture patch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3056037
* chore: bump chromium in DEPS to 94.0.4590.0
* chore: update patches
* 3057495: Fix base::NoDestructor usage in Mac KeychainPassword
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3057495
* 3056134: Remove NetworkIsolationKey unused methods
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3056134
* 3035091: [rab/gsab] Fix gsab maxByteLength after transferring to worker
Adds a patch to v8 to disable a DCHECK that is also firing on node streams
in child processes.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3035091
* chore: bump chromium in DEPS to 94.0.4590.2
* chore: fix mas_no_private_api.patch
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3049052
* 3049555: [views] Add CHECK to prevent fallthrough to global NativeTheme
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3049555
* chore: empty commit
* chore: fix whitespace for lint
* chore: cherry-pick chromium woa fix
* Revert "chore: cherry-pick chromium woa fix"
This reverts commit 64f3082e2d5f93ef0e2ac5d98246532a105fd4a1.
* chore: fix the build on Windows on ARM
* chore: remove commented code in printing.patch
* fixup! chore: remove commented code in printing.patch
do not remove the new weak_ptr check
* build: sync disable_use_lld_for_macos.patch
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2021-08-11 17:04:56 -04:00
Keeley Hammond
60650abf09
fix: explicitly define REFGUID from ::GUID&, not base::GUID ( #30442 )
...
* fix: explicitly define REFGUID from ::GUID&
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3076480
* fix: duplicate GUID_NULL symbol, add comment
2021-08-11 12:43:33 -07:00
Michaela Laurencin
41646d1168
feat: enable windows control overlay on Windows ( #29600 )
...
* rebase "feat: enable windows control overlay on Windows"
* correct compilation error
* fix linting errors
* modify includes and build file
* change `hidden` option to `overlay`
* add patch to fix visual layout
* add button background color parameter
* add button text color parameter
* modify `overlay` in docs and modify button hover/press transition color
* change `text` to `symbol`
* remove todo and fix `text` replacement
* add new titleBarOverlay property and remove titleBarStyle `overlay`
* update browser and frameless window docs
* remove chromium patches
* chore: update patches
* change button hover color, update trailing `_`, update test file
* add dchecks, update title bar drawing checks, update test file
* modify for mac and linux builds
* update docs with overlayColor and overlaySymbolColor
* add corner and side hit test info
* modify docs and copyright info
* modify `titlebar_overlay_` as boolean or object
* move `title_bar_style_ to `NativeWindow`
* update docs with boolean and object titlebar_overlay_
* add `IsEmpty` checks
* move get options for boolean and object checks
* fix linting error
* disable `use_lld` for macos
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Update docs/api/frameless-window.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* Apply docs suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* modify `true` option description `titleBarOverlay`
* ci: cleanup keychain after tests on arm64 mac (#30472 )
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-08-11 14:07:36 -04:00
Keeley Hammond
6a9cada98c
fix: build SetCrashKeyGW without tray on Windows ( #30437 )
2021-08-06 14:04:19 -07:00
George Xu
bc508c6113
feat: add electron.safeStorage
encryption API ( #30020 )
...
* feat: add SafeStorage api; first commit
* chore: rename files to fit semantically
* chore: add linkedBindings
* chore: fix function signatures
* chore: refactor eisCookieEncryptionEnabled() fuse
* chore: create test file
* chore: add tests and documentation
* chore: add copyright and lint
* chore: add additional tests
* chore: fix constructor
* chore: commit for pair programming
* wip: commit for keeley pairing
* chore: docs change and code cleanup
* chore: add linux import
* chore: add description to documentation
* chore: fixing tests
* chore: modify behaviour to not allow unencrypted strings as decyption input
* fix add patch for enabling default v11 encryption on Linux
* chore: remove file after each test
* chore: fix patch
* chore: remove chromium patch
* chore: add linux specific tests
* chore: fix path
* chore: add checker for linuux file deletion
* chore: add dcheck back
* chore: remove reference to headless mode
* chore: remove tests for linux
* chore: edit commit message
* chore: refactor safeStorage to not be a class
* chore: remove static variable from header
* chore: spec file remove settimeout
Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
2021-08-05 15:12:54 -07:00
Jeremy Rose
ec6cd0053e
chore: more crash-keys for gin::Wrappable debugging ( #30404 )
2021-08-05 11:39:07 -07:00
Samuel Attard
320bea4c28
feat: add fuses for NODE_OPTIONS and --inspect ( #30190 )
...
* feat: add fuses for NODE_OPTIONS and --inspect
* chore: add node patch to ensure NODE_OPTIONS are never parsed when fuse is disabledd
* chore: fix lint
* chore: flip boolean logic
* chore: update patches
* chore: add trailing _ to static member
* Update add_should_read_node_options_from_env_option_to_disable_node_options.patch
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2021-08-05 10:50:11 -07:00
Milan Burda
1c29734c91
build: fix building with enable_desktop_capturer = false ( #30372 )
2021-08-03 15:12:46 -07:00
Biru Mohanathas
ced2e8779f
feat: Allow detection of MITM HTTPS proxies like ZScaler ( #30174 )
...
* feat: Allow detection of MITM HTTPS proxies like ZScaler
For security purposes, Figma heavily restrics the origins that are
allowed to load within our Electron app. Unfortunately some corporate
environments use MITM proxies like ZScaler, which intercepts our
connection to `https://www.figma.com ` and serves a redirect to e.g.
`https://gateway.zscloud.net ` before finally redirecting back to
`https://www.figma.com `.
In order to detect this situation and handle it gracefully, we need to
be able to know whether or not the certificate for our own origin
(`https://www.figma.com `) is chained to a known root. We do this by
exposesing `CertVerifyResult::is_issued_by_known_root`.
If the certification verification passed without the certificate being
tied to a known root, we can safely assume that we are dealing with a
MITM proxy that has its root CA installed locally on the machine. This
means that HTTPS can't be trusted so we might as well make life easier
for corporate users by loosening our origin restrictions without any
manual steps.
* Tweak docs wording
2021-08-02 10:24:58 +09:00
Milan Burda
c5ad7ed0cd
refactor: remove guestInstanceId from WebPreferences ( #30280 )
...
* refactor: remove guestInstanceId from WebPreferences
* refactor: remove WebViewManager::GetEmbedder
2021-07-28 15:32:53 -07:00
Jeremy Rose
ceebae170e
feat: partially support chrome.tabs.update ( #30069 )
2021-07-27 13:36:22 -07:00
electron-roller[bot]
64ba8feb93
chore: bump chromium to 94.0.4584.0 (main) ( #30030 )
...
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-07-26 09:02:16 -07:00
Keeley Hammond
19820fc2a7
chore: add additional crash key to gin::Wrappable ( #30161 )
2021-07-21 09:33:25 -04:00
Cheng Zhao
05ba6359d0
feat: add signal option to dialog.showMessageBox ( #26102 )
...
* mac: add dialog.closeMessageBox API
* win: Implement dialog.closeMessageBox
* mac: Return cancelId with closeMessageBox
* gtk: Implement dialog.closeMessageBox
* win: Fix 32bit build
* win: Reduce the scope of lock
* fix: Build error after rebase
* feat: Use AbortSignal to close message box
* chore: silently handle duplicate ID
* win: Add more notes about the threads
* chore: apply reviews
* fix: base::NoDestructor should be warpped in function
* chore: fix style on windows
2021-07-15 07:59:27 +09:00
Jeremy Rose
bec47f54f4
fix: use correct userData path when unbundled ( #30113 )
2021-07-14 13:10:37 -07:00
Jeremy Rose
4d0475c9ce
feat: expose location and modifiers on before-input-event ( #29850 )
...
* feat: expose location and modifiers on before-input-event
* lint
2021-07-14 20:50:02 +09:00
electron-roller[bot]
2585e6d5fa
chore: bump chromium to 93.0.4566.0 (main) ( #29980 )
...
* chore: bump chromium in DEPS to 93.0.4562.0
* chore: update patches
* [base] Made Value::Take{Dict,List}() rvalue ref-qualified.
https://chromium-review.googlesource.com/c/chromium/src/+/2988105
* Revert "Reland "Roll src/buildtools/third_party/libc++/trunk/ 8fa879467..79a2e924d (426 commits)""
https://chromium-review.googlesource.com/c/chromium/src/+/2995482
This reverts commit 9691d6c265f010791c37d374248559969980ec65 and 797723ec838709ddeba0c104e30727ee0b7ac8ca
* Pass gfx::Insets to GetHTComponentForFrame
https://chromium-review.googlesource.com/c/chromium/src/+/2984243
* chore: bump chromium in DEPS to 93.0.4563.0
* [Clipboard API] Clipboard Custom Formats implementation Part 2.
https://chromium-review.googlesource.com/c/chromium/src/+/2967649
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4564.0
* chore: bump chromium in DEPS to 93.0.4565.0
* chore: update patches
* Prevent use of base::NoDestructor for trivially-destructible types
https://chromium-review.googlesource.com/c/chromium/src/+/2998672
* chore: update patches
* fixup! [Clipboard API] Clipboard Custom Formats implementation Part 2.
* chore: bump chromium in DEPS to 93.0.4566.0
* chore: update patches
* chore: add missing header
* ci: do not run clipboard tests on WOA
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2021-07-06 08:17:13 -04:00
David Sanders
95a9ff952c
chore: cleanup usages of const char* ( #29906 )
2021-07-02 09:51:52 +09:00
David Sanders
f6531166ae
chore: clean up forward declarations ( #29904 )
2021-07-02 09:51:37 +09:00
John Kleinschmidt
1f8a46c9c6
feat: enable window controls overlay on macOS ( #29253 )
...
* feat: enable windows control overlay on macOS
* address review feedback
* chore: address review feedback
* Address review feedback
* update doc per review
* only enable WCO when titleBarStyle is overlay
* Revert "only enable WCO when titleBarStyle is overlay"
This reverts commit 1b58b5b1fcb8f091880a4e5d1f8855399c44afad.
* Add new titleBarOverlay property to manage feature
* spelling fix
* Update docs/api/frameless-window.md
Co-authored-by: Samuel Attard <sam@electronjs.org>
* Update shell/browser/api/electron_api_browser_window.cc
Co-authored-by: Samuel Attard <sam@electronjs.org>
* update per review feedback
Co-authored-by: Samuel Attard <sam@electronjs.org>
2021-07-01 15:25:40 -04:00
David Sanders
b60b96b221
chore: remove unused using and namespace declarations ( #29892 )
2021-06-28 15:26:10 +09:00
electron-roller[bot]
a518e4b2e1
chore: bump chromium to 93.0.4552.0 (main) ( #29862 )
...
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2021-06-24 17:06:42 -07:00
Fedor Indutny
d4a1b41129
fix: microtasks policy in CreateEnvironment ( #29531 )
...
* fix: microtasks policy in CreateEnvironment
Microtasks policy should not be updated for the renderer because
`NodeBindings::CreateEnvironment` might be entered with or without
`UvRunOnce()` on stack. One of the examples of such calls is
`window.open()` which is possible to invoke while `uv_run()` is still
running (e.g. with `setImmediate()`).
All in all, it doesn't matter that much which policy we use since
`v8::MicrotasksScope` has a check for the policy in its destructor and
no commits will be made if the policy is `kExplicit`. It is important,
however, to not change the policy in the middle of `UvRunOnce()` so we
should respect whatever we currently have and move on.
Fix : #29463
* Move test to a better place
* Update spec-main/fixtures/crash-cases/setimmediate-window-open-crash/index.html
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* Update spec-main/fixtures/crash-cases/setimmediate-window-open-crash/index.html
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* simplify crash-case
* comment
* fix comment
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Fedor Indutny <indutny@signal.org>
2021-06-21 14:06:17 +09:00
Milan Burda
de6696ef1d
chore: remove unused and broken ipcRendererInternal.sendTo() ( #29743 )
2021-06-17 23:26:18 -05:00
Charles Kerr
8ccab4ce91
feat: bring --enable-logging functionality in line with Chromium ( #25089 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-06-17 14:17:25 -07:00
Shelley Vohr
542abcd6fd
chore: bump Node.js to v16.2.0 ( #29244 )
2021-06-17 08:50:56 +02:00
Jeremy Rose
ebf54d7cc0
refactor: use PathProvider for user-data-dir and others ( #29649 )
...
* refactor: use PathProvider for user-data-dir and others
* consolidate logic for DIR_RECENT and DIR_APP_LOGS into path provider
* fix bad include
* remove debugging code
* fix build on mac
* fix build on win
* create app logs dir on both mac and non-mac
2021-06-15 09:32:56 +09:00
Jeremy Rose
34a4e26b24
fix: check DCHECK_IS_ON() instead of #ifdef DCHECK_IS_ON ( #29620 )
2021-06-14 11:06:09 +09:00
Samuel Attard
fa0323a3db
fix: Revert "fix: don't propagate GDK_BACKEND to subprocs ( #28898 )" ( #29610 )
...
This reverts commit 7b169c2884
.
2021-06-09 08:28:52 -07:00
Shelley Vohr
7b169c2884
fix: don't propagate GDK_BACKEND to subprocs ( #28898 )
2021-06-08 16:10:27 +02:00
Samuel Attard
8446ce1fc7
feat: add new imageAnimationPolicy webpref and webContents setter ( #29095 )
2021-06-08 11:00:22 +09:00
David Sanders
79cb5144ae
chore: use std::make_unique/base::MakeRefCounted when possible ( #29510 )
2021-06-08 11:00:05 +09:00
David Sanders
81c5da5221
chore: use =default for default constructors/destructors ( #29511 )
2021-06-04 13:16:13 +09:00
David Sanders
b1d1ac6524
fix: change ASAR archive cache to per-process to fix leak ( #29293 )
...
* fix: change ASAR archive cache to per-process to fix leak (#29292 )
* chore: address code review comments
* chore: tighten up thread-safety
* chore: better address code review comments
* chore: more code review changes
2021-06-04 10:49:08 +09:00
Milan Burda
00693bab30
refactor: use auto env = base::Environment::Create(); everywhere ( #29502 )
2021-06-04 09:23:06 +09:00
electron-roller[bot]
8532e1239e
chore: bump chromium to 93.0.4530.0 (master) ( #29256 )
...
* chore: bump chromium in DEPS to 92.0.4512.6
* 2887336: [CaptureHandle][#2 ] Propagate CaptureHandleConfig in browser process
https://chromium-review.googlesource.com/c/chromium/src/+/2887336
* refactor: base::Optional -> absl::optional
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4514.0
* 2899417: Make build work when enable_pdf is set to false.
https://chromium-review.googlesource.com/c/chromium/src/+/2899417
* 2904731: use BrowserContext instead of Profile in PreconnectManager
https://chromium-review.googlesource.com/c/chromium/src/+/2904731
* 2295749: fix: check IsSecureEventInputEnabled in constructor before setting SetPasswordInputEnabled to true
https://chromium-review.googlesource.com/c/chromium/src/+/2295749
* 2893803: Add a GetWebView to RenderFrame.
https://chromium-review.googlesource.com/c/chromium/src/+/2893803
* 2892345: Implement WebContents::ForEachRenderFrameHost
https://chromium-review.googlesource.com/c/chromium/src/+/2892345
* chore: fixup patch indices
* 2892048: Real instance methods for BrowserContext: remaining 5 methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2892048
* 2902821: [mojo] Don't require full header includes for referenced interfaces
https://chromium-review.googlesource.com/c/chromium/src/+/2902821
* 2496500: Remove last deprecated extension Event ctor.
https://chromium-review.googlesource.com/c/chromium/src/+/2496500
* chore: fixup malformed pepper support patch
* chore: bump chromium in DEPS to 92.0.4515.0
* 2908461: Add CreateEmptyPrintPagesParamsPtr() inside print_view_manager_base.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/2908461
* 2880838: viz: add optional HDRMetadata to TransferableResource
https://chromium-review.googlesource.com/c/chromium/src/+/2880838
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4515.5
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4515.7
* chore: bump chromium in DEPS to 92.0.4515.9
* chore: bump chromium in DEPS to 93.0.4522.0
* chore: bump chromium in DEPS to 93.0.4523.0
* chore: bump chromium in DEPS to 93.0.4524.0
* chore: update patches
* chore: enable_pak_file_integrity_checks was reverted
* chore: update patches
* refactor: base/optional was replaced with absl::optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::nullopt with absl::nullopt
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* chore: add missing base::Contains include
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::make_optional with
absl::make_optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace WorldScriptContext() with GetScriptContextFromWorldId
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893213
* chore: clean up left over opening namespace
Refs: 95bfe6d08f
* chore: add missing base::Contains include
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace GetCurrentDisplayIterator with the hard checker
GetCurrentDisplay
This code looks suspicious but if the iterator was invalid before it
will also be invalid now.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893191
* refactor: headers are now passed directly in extensions client
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2918906
* refactor: base::DictionaryValue::empty() has been removed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2912424
* chore: add missing includes for network URLLoaderFactory
Refs: unknown, probably a side effect of header changes
* refactor: make convenience wrapper around AppendArg
There is no converter FromV8 for base::StringPiece (apparently its not
possible). So we now take in an std::string and use the construct for
StringPiece to do implicit conversion.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2905544
* chore: add patch
* chore: bump chromium in DEPS to 93.0.4525.0
* chore: update patches
* refactor: CanResize has been de-virtualized
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2485774
* chore: update resource integrity patch
* chore: add character encoding idl patch
* chore: bump chromium in DEPS to 93.0.4526.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4527.0
* chore: bump chromium in DEPS to 93.0.4528.0
* chore: update patches
* chore: update idl encoding patch
* chore: bump chromium in DEPS to 93.0.4529.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4530.0
* chore: update patches
* fix: only SetCanResize after the widget has been initialized
* chore: add patch for vr on windows gn gen
* spec: fix focus related tests on linux due to delay in focus swap
* chore: remove new usages of base::Optional from main
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-06-03 01:05:04 -07:00
Milan Burda
44491b023a
refactor: eliminate duplicate C++ / JavaScript implementation of app.isPackaged ( #29464 )
2021-06-02 12:17:08 -07:00
Cheng Zhao
3cfe5c6a21
fix: keep shifted character in menu accelerator ( #29202 )
...
* fix: correctly handle shifted char in accelerator
* test: use actual accelerator of NSMenuItem
* chore: simplify KeyboardCodeFromStr
* chore: GetAcceleratorTextAt is testing only
2021-06-02 16:32:48 +09:00
David Sanders
31190d4c6d
chore: use static_cast rather than C-style cast ( #29467 )
2021-06-02 00:32:10 -07:00
Samuel Maddock
f9d2a7077e
feat: include resize edge with will-resize event ( #29199 )
...
* feat: emit resize edge with will-resize event
fix: wparam type
fix: private member usage on mac
docs: will-resize event edge option
refactor: 'info' -> 'details' for better type gen
* Update docs/api/browser-window.md
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* Update docs/api/browser-window.md
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-06-02 11:37:10 +09:00
David Sanders
80a039ec40
chore: move destructors to header so they can be trivially destructible ( #29379 )
2021-05-31 21:00:09 -07:00
David Sanders
ba26580f23
chore: use consistent parameter names ( #29361 )
2021-06-01 10:46:25 +09:00
David Sanders
038359a7d8
chore: fix typos in comments ( #29401 )
2021-06-01 10:42:38 +09:00
David Sanders
93c9374e95
chore: trim unused STL includes ( #29414 )
2021-06-01 10:34:44 +09:00
David Sanders
d80e36bcdb
chore: simplify WrappableBase::SecondWeakCallback ( #29359 )
2021-05-27 13:15:25 -07:00
David Sanders
9bb7051f54
chore: prefer empty() check for readability ( #29360 )
2021-05-27 13:08:30 -07:00
David Sanders
77ecc7d432
chore: fix typos in comments ( #29362 )
2021-05-27 11:48:03 -07:00
Milan Burda
241cceb2c9
refactor: eliminate duplicate code ( #29174 )
2021-05-24 11:32:55 +09:00
electron-roller[bot]
039f3d5cd2
chore: bump chromium to 92.0.4511.0 (master) ( #29173 )
2021-05-19 16:15:47 -07:00
Milan Burda
2806664bd0
fix: AdjustAmountOfExternalAllocatedMemory regression in NativeImage destructor ( #29179 )
2021-05-19 10:04:34 +09:00
Electron Bot
2eb3bddb05
chore: bump chromium to 92.0.4505.0 (master) ( #29058 )
...
* chore: bump chromium in DEPS to 92.0.4500.2
* resolve conflicts
* update patches
* chore: cherry-pick 82434206f306 from chromium (#29060 )
* fix patch
* chore: bump chromium in DEPS to 92.0.4501.0
* chore: bump chromium in DEPS to 92.0.4502.0
* chore: bump chromium in DEPS to 92.0.4503.0
* chore: update patches
* 2869869
: [Code Health] Refactor ListValue::Insert in gpu compositor
https://chromium-review.googlesource.com/c/chromium/src/+/2869869
* 2877924: Separate InkDropHost from InkDropHostView
https://chromium-review.googlesource.com/c/chromium/src/+/2877924
* chore: bump chromium in DEPS to 92.0.4504.0
* update patches
* Fixup for Separate InkDropHost from InkDropHostView
https://chromium-review.googlesource.com/c/chromium/src/+/2877924
* 2873469: Compute hashes of .pak files during the build, and check it at runtime.
https://chromium-review.googlesource.com/c/chromium/src/+/2873469
* 2874397: Remove flag to disable microtasks scope consistency checks
https://chromium-review.googlesource.com/c/v8/v8/+/2874397
* 2881471: Remove unneeded trace_event.h includes in headers.
https://chromium-review.googlesource.com/c/chromium/src/+/2881471
* 2844717: [Keyboard Tooltip] Rename RWHV*::SetTooltipText to UpdateTooltipUnderCursor
https://chromium-review.googlesource.com/c/chromium/src/+/2844717
* chore: bump chromium in DEPS to 92.0.4505.0
* chore: update patches
* 2883887: Retire ScopedObserver in /chrome/browser/predictors.
https://chromium-review.googlesource.com/c/chromium/src/+/2883887
* 2883694: Retire ScopedObserver in /chrome/browser.
https://chromium-review.googlesource.com/c/chromium/src/+/2883694
* fixup after merge
* fixup: Remove flag to disable microtasks scope consistency checks
* Temporarily disable setcallhandler-test.js nan test
This test should be renabled once https://github.com/electron/electron/pull/29028 lands
* Use gin_helper::MicrotasksScope instead of v8::MicrotasksScope
* chore: bump chromium in DEPS to 92.0.4506.0
* update patches
* Revert "update patches"
This reverts commit 333ec0d4c205bd3cbee28d2bc3d068871dbb900a.
* Revert "chore: bump chromium in DEPS to 92.0.4506.0"
This reverts commit 2bd52f8cd89b173c8b15a61d74fa7539cdbf574b.
* Fixup: Use gin_helper::MicrotasksScope instead of v8::MicrotasksScope
* Fixup: Use gin_helper::MicrotasksScope instead of v8::MicrotasksScope
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2021-05-13 21:21:36 -04:00
Milan Burda
a51aaeb28f
refactor: replace v8::Local<T>::Cast() with As<T>() ( #29097 )
2021-05-12 16:38:21 +09:00
Keeley Hammond
06f51b7283
fix: prevent crash on web-contents creation when error is thrown ( #28971 )
...
* fix: prevent crash when error occurs during event emitter CallMethod
* wip: emit error event within trycatch
* fix: handle uncaught exceptions within node on web_contents init
* fix: create gin_helper::CallMethodCatchException
* test: add web-contents create crash to test cases
* test: clean up test data for web-contents crash
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* fix: convert CatchException to WebContents static helper method
* fix: restore try_catch to callsite
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-05-11 13:57:11 -07:00
Electron Bot
d5f2eb5a81
chore: bump chromium to 92.0.4499.0 (master) ( #29046 )
2021-05-06 15:01:04 -07:00
Samuel Attard
e5e8ab4eea
refactor: remove more dead code post render process reuse ( #28983 )
...
* Overrides for window.history.*
* Node environment cleanup / creation logic
* Options and switches that are now static values
2021-05-04 11:30:29 -07:00
Fedor Indutny
99909baeac
fix: allow Node.js to manage microtasks queue ( #28957 )
...
* fix: allow Node.js to manage microtasks queue
When `uv_run()` resulted in invocation of JS functions the microtask
queue checkpoint in Node's CallbackScope was a no-op because the
expected microtask queue policy was `kExplicit` and Electron ran under
`kScoped` policy. This change switches policy to `kExplicit` right
before `uv_run()` and reverts it back to original value after `uv_run()`
completes to provide better compatibility with Node.
* add comment
2021-05-03 14:30:12 -07:00
Electron Bot
cdf04f3ae7
chore: bump chromium to 92.0.4488.0 (master) ( #28676 )
...
* chore: bump chromium in DEPS to 92.0.4478.0
* chore: update chromium patches
* chore: update v8 patches
* fix: add scale parameter to LookupIconFromFilepath
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2748317
Follow up: https://github.com/electron/electron/issues/28678
* build: depend on gtkprint config for gtk_util.h
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2824022
* build: add missing print_job_constants header
Refs: unknown
* chore: bump chromium in DEPS to 92.0.4479.0
* update patches
* chore: bump chromium in DEPS to 92.0.4480.0
* chore: bump chromium in DEPS to 92.0.4481.0
* chore: bump chromium in DEPS to 92.0.4482.2
* chore: bump chromium in DEPS to 92.0.4483.0
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4484.0
* chore: bump chromium in DEPS to 92.0.4485.0
* fix patches
* update patches
* 2810414: [LSC] Add PRESUBMIT check for ASCIIToUTF16("...") and UTF8ToUTF16("...")
https://chromium-review.googlesource.com/c/chromium/src/+/2810414
* 2781233: NotificationService: Plumb document_url for non-persistent notifications.
https://chromium-review.googlesource.com/c/chromium/src/+/2781233
* fixup! 2810414: [LSC] Add PRESUBMIT check for ASCIIToUTF16("...") and UTF8ToUTF16("...")
* 2836669: Refactor GTK build target and dependencies
https://chromium-review.googlesource.com/c/chromium/src/+/2836669
* chore: bump chromium in DEPS to 92.0.4486.0
* update patches
* fix DecrementCapturerCount patch
* explicitly include badging.mojom.h
* include ui/gtk/gtk_ui_factory.h for BuildGtkUi()
* fixup! 2810414: [LSC] Add PRESUBMIT check for ASCIIToUTF16("...") and UTF8ToUTF16("...")
* iwyu fix for base::size
* iwyu for TRACE_EVENT0
* 2799631: Use structured interface for DevTools messages
https://chromium-review.googlesource.com/c/chromium/src/+/2799631
* 2801573: Convert enum to enum class for Widget::InitParams::Activatable
https://chromium-review.googlesource.com/c/chromium/src/+/2801573
* 2805764: Add ContentBrowserClient support for service worker-scoped binders
https://chromium-review.googlesource.com/c/chromium/src/+/2805764
* fixup! 2799631: Use structured interface for DevTools messages
* fixup! 2805764: Add ContentBrowserClient support for service worker-scoped binders
* oops, use of linux_ui after std::move
* fix devtools message handling for null params
* disable node test parallel/test-debug-args
https://chromium-review.googlesource.com/c/v8/v8/+/2843348
* fix gn check
* chore: bump chromium in DEPS to 92.0.4487.0
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4488.0
* update patches
* Remove vpython use from Chromium DEPS file
https://chromium-review.googlesource.com/c/chromium/src/+/2810121
* Partial revert "workaround: disable CFG longjmp protection for Windows on Arm"
https://chromium-review.googlesource.com/c/chromium/src/+/2788210
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-04-27 14:27:34 -07:00
Jeremy Rose
be3c2fd0af
fix: shell.trashItem crash when called in renderer ( #28748 )
2021-04-22 13:46:41 -07:00
Electron Bot
22a70eb803
chore: bump chromium to 92.0.4475.0 (master) ( #28462 )
...
* chore: bump chromium in DEPS to 91.0.4464.0
* chore: rebuild chromium/dcheck.patch with import-patches -3
Mechanical only; no code changes
* chore: remove content_browser_main_loop.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
The function being patched (BrowserMainLoop::MainMessageLoopRun()) no
longer exists.
NB: if removing this introduces regressions the likely fix will be to
add a similar patch for ShellBrowserMainParts::WillRunMainMessageLoop()
which has similar code and was added at the same time this was removed.
* chore: rebuild chromium/put_back_deleted_colors_for_autofill.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/disable_color_correct_rendering.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/eat_allow_disabling_blink_scheduler_throttling_per_renderview.patch with patch
Mechanical only; no code changes
* chore: rebuild chromium/gpu_notify_when_dxdiag_request_fails.patch with import-patches -3
Mechanical only; no code changes
* chore: rebuild chromium/ui_gtk_public_header.patch manually
no code changes
* chore: rebuild chromium/web_contents.patch with import-patches -3
Mechanical only; no code changes
* chore: remove v8/skip_global_registration_of_shared_arraybuffer_backing_stores.patch
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2763874
This patch has been merged upstream
* chore: export patches
* chore: update add_trustedauthclient_to_urlloaderfactory.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_
* chore: sync chromium/put_back_deleted_colors_for_autofill.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2785841
SkColorFromColorId() no longer takes theme, scheme args
* chore: sync chromium/put_back_deleted_colors_for_autofill.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2772143
Change new calls to GetDarkSchemeColor to fit our patched call signature
* chore: update add_trustedauthclient_to_urlloaderfactory.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2757969
Sync with removal of render_frame_id_ in our mojom
* chore: update chromium/frame_host_manager.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
* chore: update chromium/revert_remove_contentrendererclient_shouldfork.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2755314
Upstream has removed `history_list_length_` which we were comparing to 0
to calculate our `is_initial_navigation` bool when calling ShouldFork().
ShouldFork() is ours and none of the code paths actually use that param,
so this commit removes it altogether.
* chore: update permissions_to_register
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2789074
Replace all uses of APIPermission::ID enum with Mojo type
* refactor: update return type of PreMainMessageLoopRun()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
Used to return void; now returns an int errorcode.
Note: 2725153 also has some nice doc updates about Browser's "stages"
* refactor: sync ElectronBrowserMainParts to MainParts changes
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
RunMainMessageLoopParts has been replaced with WillRunMainMessageLoop
so `BrowserMainLoop::result_code_` is no longer available to us for our
exit_code_ pointer.
This variable held a dual role: (1) of course, hold the exit code, but
also (2) was a nullptr before the message loop was ready, indicating to
anyone calling SetExitCode() that we were still in startup and could
just exit() without any extra steps. exit_code_ still fulfills these two
roles but is now a base::Optional.
* chore: update ElectronBrowserMainParts::PreDefaultMainMessageLoopRun
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2725153
BrowserMainParts::BrowsePreDefaultMainMesssageLoopRun() has been
removed; move that work to the new WillRunMainMessageLoop().
* refactor: stop using CallbackList; it has been removed.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2785973
* refactor: update use of threadpools.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2773408
The upstream code is still in flux (e.g. reverts and re-lands) but the
tl;dr for this commit is (1) include thread_pool.h if you're using it
and (2) don't instantiate pools directly.
* refactor: remove routing_id from CreateLoaderAndStart
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762858
NB: One logic branch in ProxyingURLLoaderFactory::CreateLoaderAndStart
calls std::make_unique<InProgressRequest>, which needs a routing_id.
This PR uses the member field `routing_id_` since there's no longer one
being passed into CreateLoaderAndStart.
* refactor: sync to upstream ParittionOptions churn
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771318
PartitionOptions' enums have changed.
* refactor: update Manifest::Location usage
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771320
tldr: s/Manifest::FOO/ManifestLocation::kFoo/
* chore: bump chromium in DEPS to 91.0.4465.0
* update patches
* refactor: update extensions::Manifest to upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771320
- extensions::Manifest::COMPONENT
+ extensions::mojom::ManifestLocation::kExternalComponent
* refactor: sync with upstream UrlInfo ctor changes
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2740008
UrlInfo ctor now takes UrlInfo::OriginIsolationRequest instead of a bool
* chore: update invocation of convert_protocol_to_json.py
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2792623
python3 is being used in parts of the upstream build, but the copy of
convert_protocol_to_json.py invoked in v8/third_party/inspector_protocol
is not python3-friendly. Node has a py2+3-friendly version of it in its
tools directory, so call it instead.
* chore: use extensions::mojom::APIPermissionID
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791122
tldr:
- extensions::APIPermission::kFoo
+ extensions::mojom::APIPermissionID::kFoo
* chore: Remove support for TLS1.0/1.1 in SSLVersionMin policy
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2765737
Remove TLS v1.0 & 1.1 from our SSLProtocolVersionFromString() function.
This is the same change made upstream at
https://chromium-review.googlesource.com/c/chromium/src/+/2765737/8/chrome/browser/ssl/ssl_config_service_manager_pref.cc
* fixup! chore: update ElectronBrowserMainParts::PreDefaultMainMessageLoopRun
* chore: Use IDType for permission change subscriptions.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791431
tldr: {Subscribe,Unsubscribe}PermissionStatusChange's tag type used to
be an int; now it's the new SubscriptionId type (which is an IdType64).
* chore: sync PowerMonitor code to upstream refactor
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2752635
tldr: PowerMonitor has been split into PowerStateObserver,
PowerSuspendObserver, and PowerThermalObserver to reduce number of tasks
posted to consumers who only need notifications for one of those things
instead of all of them.
* chore: use PartitionOptions's new Cookies field
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2771318
* Revert "refactor: remove routing_id from CreateLoaderAndStart"
This reverts commit 8c9773b87a3c84f9073a47089eb2b6889d745245.
8c9773b was only a partial fix; reverting to start & try again.
* update patches
* chore: bump chromium in DEPS to 91.0.4466.0
* chore: update chromium/accelerator.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2795472
tldr: sync patch with upstream renamed variable & macro names.
* chore: update chromium/gtk_visibility.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2796200
tldr: no code changes; just updating the diff to apply cleanly.
note: ooh upstream Wayland hacking!
* chore: update chromium/picture-in-picture.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2710023
tldr: no code changes; just updating the diff to apply cleanly.
* chore: update chromium/worker_feat_add_hook_to_notify_script_ready.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2775573
tldr: no code changes; just updating the diff to apply cleanly.
* chore: export_all_patches
* chore: update chromium/feat_add_set_theme_source_to_allow_apps_to.patch
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2796511
tldr: NotifyObservers has been renamed to NotifyOnNativeThemeUpdated,
so update the invocation in our patch.
* chore: update ElectronBrowserClient w/upstream API
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797454
tldr: GetDevToolsManagerDelegate() was returning an owned raw pointer.
Replaced it with CreateDevToolsManagerDelegate() which uses unique_ptr<>.
* chore: handle new content::PermissionType::FILE_HANDLING in toV8()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762201
`file-handling` string confirmed in https://chromium-review.googlesource.com/c/chromium/src/+/2762201/18/chrome/browser/ui/webui/settings/site_settings_helper.cc
* refactor: remove routing_id from CreateLoaderAndStart pt 1
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2762858
Part 1: the easiest ones
* 2796724: Support Python3
https://chromium-review.googlesource.com/c/infra/luci/python-adb/+/2796724
* chore: bump chromium in DEPS to 91.0.4468.0
* 2668974: WebShare: Implement SharingServicePicker
https://chromium-review.googlesource.com/c/chromium/src/+/2668974
* 2802766: Apply modernize-make-unique to media/
https://chromium-review.googlesource.com/c/chromium/src/+/2802766
* 2802823: Apply modernize-make-unique to gpu/
https://chromium-review.googlesource.com/c/chromium/src/+/2802823
* 2803041: Apply modernize-make-unique to remaining files
https://chromium-review.googlesource.com/c/chromium/src/+/2803041
* 2798873: Convert GtkKeyBindingsHandler build checks to runtime checks
https://chromium-review.googlesource.com/c/chromium/src/+/2798873
* 2733595: [ch-r] Parse ACCEPT_CH H2/3 frame and restart with new headers if needed
https://chromium-review.googlesource.com/c/chromium/src/+/2733595
* chore: update patch indices
* 2795107: Remove unused PermissionRequest IDs.
https://chromium-review.googlesource.com/c/chromium/src/+/2795107
* chore: bump chromium in DEPS to 91.0.4469.0
* chore: fixup patch indices
* chore: bump chromium in DEPS to 91.0.4469.5
* PiP 1.5: Add microphone, camera, and hang up buttons to the PiP window
https://chromium-review.googlesource.com/c/chromium/src/+/2710023
* fixup! refactor: remove routing_id from CreateLoaderAndStart
* refactor: use URLLoaderNetworkServiceObserver for auth requests from SimpleURLLoader
* fixup! chore: fixup patch indices
* 2724817: Expand scope of wasm-eval to all URLs
https://chromium-review.googlesource.com/c/chromium/src/+/2724817
* Fixup patch after rebase
* chore: bump chromium in DEPS to 91.0.4472.0
* 2797341: [ozone/x11] Enabled the global shortcut listener.
https://chromium-review.googlesource.com/c/chromium/src/+/2797341
* 2805553: Reland Add GTK ColorMixers to ColorPipeline P1
https://chromium-review.googlesource.com/c/chromium/src/+/2805553
* 2804366
: PiP 1.5: Label back to tab button with origin and center it
https://chromium-review.googlesource.com/c/chromium/src/+/2804366
* 2784730: Fix crash on AX mode change in NativeViewHost without a Widget
https://chromium-review.googlesource.com/c/chromium/src/+/2784730
* chore: update patch indices
* 2810174: Add PdfAnnotationsEnabled policy.
https://chromium-review.googlesource.com/c/chromium/src/+/2810174
* 2807829: Allow capturers to indicate if they want a WakeLock or not.
https://chromium-review.googlesource.com/c/chromium/src/+/2807829
* chore: bump chromium in DEPS to 92.0.4473.0
* chore: bump chromium in DEPS to 92.0.4474.0
* chore: bump chromium in DEPS to 92.0.4475.0
* chore: update patches
* chore: updates patches
* chore: update is_media_key patch to handle new ozone impl
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797341
* fix: ExecuteJavascript requests now need to be flagged as non-bf-aware
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2787195
* chore: icon_util_x11 is now icon_util_linux
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2791362
* build: update sysroots
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2628496
* build: fix missing symbols on linux build
* use_ozone and use_x11 are not exclusive
* new button view to build for pip
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2797341
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2804366
* chore: fix broken gtk_util color patch
* chore: remove patch conflict
* build: update linux manifests
* chore: build bttlb on all platforms for pip
* chore: add thread_pool include for views delegate win
* chore: fix lint
* chore: add node patches for V8 changes
* build: add missing base include on windows
* fix: update frame host manager patch for new state transitions
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2714464
* chore: update windows zip manifests
* chore: update mac zip manifests
* chore: fix patch linting
* refactor: implement missing URLLoaderNetworkServiceObserver methods
It is against The Mojo Rules to leave hanging callbacks. These always
have to be called.
Refs: 186528aab9
* spec: fix locale test on local linux
* fix: pass the exit code correctly in new PreMainMessageLoopRun
Refs: 2622e91c44
* fix: ensure we early-exit when request_handler_ is not provided
Refs: 93077afbfb
* fix: strongly set result_code in the BrowserMainLoop
* fix: invalid usage of non-targetted PostTask
You must always either use a host threadpool or specify a target
thread. In this case we did neither after this refactor.
Refs: 4e33ee0ad3
* chore: fix gn check
* chore: remove stray .rej files in patch
* chore: add mojo error code to url loader failure
* build: ensure CI is truthy in arm test env
* fix: handle windowCaptureMacV2 being enabled when fetching media source id
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2709931
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
2021-04-15 10:44:35 -07:00
Jeremy Rose
dba4df9326
feat: add more info in setWindowOpenHandler details ( #28518 )
...
* fix: invoke the window open handler for _blank links
* feat: add disposition to setWindowOpenHandler details
* fix: pass postData to new-window event
* postData can be heterogeneous
* fix type of postBody
* fix type of UploadFile and UploadRawData to be discriminated unions
* exclude the empty string from additionalFeatures
* add a test
* add postBody and referrer to setWindowOpenHandler args
* appease typescript
* Update api-browser-window-spec.ts
* update snapshots
2021-04-13 15:35:27 -04:00
Samuel Attard
6df2680cb6
refactor: clean up webFrame implementation to use gin wrappers ( #28497 )
...
* refactor: clean up webFrame implementation to use gin wrappers
The previous implementation of webFrame in the renderer process leaked
sub-frame contexts and global objects across the context boundaries thus
making it possible for apps to either maliciously or accidentally
violate the contextIsolation boundary.
This re-implementation binds all methods in native code directly to
content::RenderFrame instances instead of relying on JS to provide a
"window" with every method request. This is much more consistent with
the rest of the Electron codebase and is substantially safer.
* chore: un-re-order for ease of review
* chore: pass isolate around instead of ErrorThrower
* chore: fix rebase typo
* chore: remove unused variables
2021-04-12 16:35:18 -07:00
Milan Burda
da8c35e3b2
chore: remove deprecated worldSafeExecuteJavaScript option ( #28456 )
2021-04-08 12:03:57 -04:00
Jeremy Rose
6fbd84fc80
fix a messed up merge
2021-03-24 11:48:15 -07:00
Jeremy Rose
640a145112
only bind setAppUserModelId on windows
2021-03-24 10:55:32 -07:00
Jeremy Rose
7f7b1f6c8a
wstrings are cross-platform
2021-03-24 10:47:53 -07:00
Jeremy Rose
d874a59056
lint
2021-03-24 10:46:48 -07:00
Jeremy Rose
39e3576c48
Merge remote-tracking branch 'origin/master' into roller/chromium/master
2021-03-23 11:14:58 -07:00
Jeremy Rose
61cf1abd4d
more windows build fix
2021-03-23 11:12:59 -07:00
Samuel Attard
94af0e8bb0
fix: escape URL passed to shell.openExternal on windows ( #28334 )
2021-03-22 16:33:03 -07:00
Shelley Vohr
665ac6f9c8
fix: libuv hang on Windows ( #28175 )
2021-03-22 13:11:03 -07:00
Shelley Vohr
96ce59609d
refactor: prefer embedder-focused InitializeNodeWithArgs ( #28271 )
2021-03-22 02:42:06 -07:00
John Kleinschmidt
2d3c65beca
2757472: Reland "Reland "[LSC] Remove base::string16 alias""
...
https://chromium-review.googlesource.com/c/chromium/src/+/2757472
2021-03-18 15:55:51 -04:00
John Kleinschmidt
d0989802bd
2720306: [api] Remove deprecated [Shared]ArrayBuffer API
...
https://chromium-review.googlesource.com/c/v8/v8/+/2720306
2021-03-16 15:39:40 -04:00
John Kleinschmidt
ec893f8322
2757472: Reland "Reland "[LSC] Remove base::string16 alias""
...
https://chromium-review.googlesource.com/c/chromium/src/+/2757472
2021-03-16 13:58:27 -04:00
John Kleinschmidt
22d8f22cfb
2757472: Reland "Reland "[LSC] Remove base::string16 alias""
...
https://chromium-review.googlesource.com/c/chromium/src/+/2757472
2021-03-16 12:18:45 -04:00
John Kleinschmidt
b15b820bca
2743594: Remove WebSize from blink.
...
https://chromium-review.googlesource.com/c/chromium/src/+/2743594
2021-03-16 10:01:47 -04:00
John Kleinschmidt
9e336f5d0c
2752406: [LSC] Replace base::string16 with std::u16string in //ui
...
https://chromium-review.googlesource.com/c/chromium/src/+/2752406
2021-03-15 21:21:27 -04:00
John Kleinschmidt
57a8781c01
Merge branch 'master' into roller/chromium/master
2021-03-15 18:43:25 -04:00
Jeremy Rose
d27ad0d182
fix: revert "refactor: mmap asar files ( #24470 )" ( #28137 )
...
This reverts commit 01a2e23194
.
2021-03-15 11:42:54 -07:00
Samuel Attard
f73256651b
fix: convert system colors to device color space in systemPreferences ( #28121 )
2021-03-12 23:31:08 -08:00
Cheng Zhao
5b710519cf
test: reliably wait for spellchecker to load ( #28118 )
2021-03-12 16:35:57 +09:00
Milan Burda
5b205731f6
chore: remove deprecated remote module ( #25734 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-03-09 17:12:40 -08:00
Samuel Attard
be627568b2
refactor: blink::MenuItem::Type was moved to mojom
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2071443
2021-03-05 16:39:01 -08:00
Samuel Attard
1a296e59c2
refactor: MenuItemType was moved to mojom
...
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2071443
2021-03-05 15:36:52 -08:00
Electron Bot
ca75bca667
chore: bump chromium to 90.0.4415.0 (master) ( #27694 )
...
* chore: bump chromium in DEPS to 520c02b46668fc608927e0fcd79b6a90885a48bf
* chore: bump chromium in DEPS to 90.0.4414.0
* resolve chromium conflicts
* resolve v8 conflicts
* fix node gn files
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2676903: [mojo] Remove most legacy Binding classes.
https://chromium-review.googlesource.com/c/chromium/src/+/2676903
* 2644847: Move self-deleting URLLoaderFactory base into //services/network.
https://chromium-review.googlesource.com/c/chromium/src/+/2644847
* 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* 2672923: Remove RAPPOR reporting infrastructure.
https://chromium-review.googlesource.com/c/chromium/src/+/2672923
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2655126: Convert FrameHostMsg_ContextMenu and FrameMsg_ContextMenuClosed|CustomContextMenuAction to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/2655126
* 2628705: Window Placement: Implement screen.isExtended and change event
https://chromium-review.googlesource.com/c/chromium/src/+/2628705
* 2643161: Refactor storage::kFileSystem*Native*
https://chromium-review.googlesource.com/c/chromium/src/+/2643161
* fix build
* only remove the biggest subdir of //ios
* chore: bump chromium in DEPS to 90.0.4415.0
* update patches
* update sysroots
* 2686147: Remove WebContentsObserver::RenderViewCreated().
https://chromium-review.googlesource.com/c/chromium/src/+/2686147
* 2596429: Fixing how extension's split and spanning modes affect OriginAccessList.
https://chromium-review.googlesource.com/c/chromium/src/+/2596429
* 2686026: [mojo] Delete AssociatedInterfacePtr (replaced by AssociatedRemote)
https://chromium-review.googlesource.com/c/chromium/src/+/2686026
* 2651705: Move ui/base/dragdrop/file_info to ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/2651705
* 358217: drawBitmap is deprecated
https://skia-review.googlesource.com/c/skia/+/358217
* fix gn check
* 2678098: Use gen/front_end as input to generate_devtools_grd
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678098
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* fixup 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* fixup build_add_electron_tracing_category.patch
* 2673415: [base] Prepare CrashReporterClient for string16 switch
https://chromium-review.googlesource.com/c/chromium/src/+/2673415
* 2673413: Add CursorFactoryWin to handle Cursors on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2673413
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* fix mas gn check
* update patch after merge
* Update node for .mjs files
* build: load v8_prof_processor dependencies as ESM
* chore: add patch to fix linux 32bit
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-03-04 09:27:05 -08:00
Jeremy Rose
912c9c2254
fix: cap sendInputEvent text length at n-1 ( #27827 )
2021-02-22 10:38:59 -05:00
Shelley Vohr
642d6fca91
fix: libuv hang when nodeIntegrationInSubframes enabled ( #27582 )
2021-02-16 19:42:28 -08:00
Shelley Vohr
e46446e7e4
chore: bump chromium to e836cbe709f3cd703f233de8eb6cc6ec99b72c9d ( #27475 )
...
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-02-09 12:16:21 -08:00
Cheng Zhao
af4a050a1b
feat: add roundedCorners option for BrowserWindow ( #27572 )
...
* feat: add roundedCorner option for BrowserWindow
* Make roundedCorner work with vibrancy views
* roundedCorner => roundedCorners
2021-02-09 08:38:35 -08:00
Jeremy Rose
e87803919b
fix: memory leak in BrowserWindow ( #27621 )
2021-02-05 13:20:20 -08:00
Milan Burda
ddf3ef0a5f
refactor: use C++11 class member variable initialization ( #27477 )
2021-01-26 12:16:21 -06:00
Electron Bot
ed126eced4
chore: bump chromium to bf3f97675b5d9eade34526ebf730c (master) ( #27305 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2021-01-25 08:46:00 -08:00
Milan Burda
949fd0728f
refactor: replace base::Bind() with base::BindOnce() / base::BindRepeating() ( #27447 )
2021-01-25 10:27:40 +09:00
Charles Kerr
5a8f40ae13
fix: don't throw on bad icons in BrowserWindow constructor ( #27441 )
...
* fix: do not throw if NativeImage conversion fails.
Throwing is an unannounced semver/major breaking change, so revert that
behavior but keep the rest of the #26546 refactor.
* test: add invalid icon test
* refactor: be explicit about when to throw or warn.
2021-01-25 10:24:10 +09:00
riccardopiola
d7b02e123a
chore: duplicate symbols for mojom interfaces in component build ( #27186 )
...
* fix duplicate symbols in component build
* fix: duplicate symbols for mojom interfaces in component build
2021-01-19 11:31:44 +09:00
Milan Burda
2be3d03630
feat: add webFrameMain.send() / webFrameMain.postMessage() ( #26807 )
2021-01-15 09:00:37 +09:00
Electron Bot
adf0a73543
chore: bump chromium to a264339194bfa02f5ecb3b8cba449 (master) ( #27111 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2021-01-12 15:31:23 -08:00
Shelley Vohr
3455136e9d
refactor: remove path from nativeImage converter ( #26546 )
2021-01-04 12:58:31 -08:00
Electron Bot
8383c14aba
chore: bump chromium to 7264889ce3aad1568ff3d211c81fe (master) ( #27003 )
...
* chore: bump chromium in DEPS to 91c9f44297abe2844f593ec7956e6ce79c81f463
* chore: update chromium patches
* chore: update v8 patches
* build: service_names.mojom has been deleted
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2568681
* chore: add DISPLAY_CAPTURE permission to converter
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2551098
* chore: handle AXPropertyFilter::SCRIPT in accessibility_ui
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2563923
* refactor: web_isolated_world_ids.h has been deleted
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585255
* refactor: ResourceType has been deprecated / removed in ExtensionsBrowserClient
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2562002
* chore: fix lint
* chore: remove deleted headers
* build: disable gn check for blink header
* fix: refactor X11 event handling
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2577887
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585750
* chore: update patches
* chore: bump chromium in DEPS to bfd8e7dbd37af8b1bc40d887815edd5a29496fa3
* chore: update patches
* refactor: xeventobserver is now x11:eventobserver
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2585750
* refactor: remove UseWebUIBindingsForURL
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2583590
* chore: DidProcessXEvent has been removed
* chore: bump chromium in DEPS to b13e791d7244a08d9d61dbfa2bb2b6cdf1ff6294
* chore: update patches
* build: change gfx::GetAtom to x11:GetAtom
Refs: d972a0ae4a
* build: change gfx namespace to x11
Ref: d972a0ae4a
* build: change ui namespace to x11
Refs: c38f8571a8
:ui/gfx/x/xproto_util.h;dlc=ba9145d0c7f2b10e869e2ba482ca05b75ca35812
* chore: add patch to fix blink prefs fetching during frame swap
* chore: fix lint
* fix: do not make invalid SKImageRep in FrameSubscriber
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2572896
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-12-22 14:14:44 -08:00
Eryk Rakowski
bf24759354
fix(extensions): implement missing web_request hooks ( #22655 )
...
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com>
2020-12-18 15:11:43 -08:00
Shelley Vohr
9eab298779
feat: add missing 'context-menu' values ( #26788 )
...
* fix: add missing 'context-menu' values
* Add missing canSave
* Remove canTranslate
2020-12-16 14:32:11 +09:00
Shelley Vohr
b266b5208a
refactor: use public node::CallbackScope where possible ( #27001 )
...
* refactor: use public node::CallbackScope where possible
* Remove unused node_env() getter
2020-12-15 11:39:25 -08:00
Nick Harper
21024011d7
fix: incorrect case in content::PermissionType mapping ( #27006 )
2020-12-15 11:14:42 -08:00
Electron Bot
4588a41161
chore: bump chromium to 096e5313aaf19dfa0c4710145c34d (master) ( #26535 )
...
* chore: bump chromium in DEPS to 1d6b29cd85c1c3cba093b8b69b2727cc26eaac97
* update patches
* chore: use 'libvulkan.so.1' in the linux manifests
CL: https://chromium-review.googlesource.com/c/angle/angle/+/2538430
Upstream renamed libvulkan.so to libvulkan.so.1, so sync our manifests.
* chore: update expected window-open default policy.
CL: https://chromium-review.googlesource.com/c/chromium/src/+/2429247
Upstream CL contiues the work to make `strict-origin-when-cross-origin`
the default referrer policy. This commit changes our window-open tests
to expect that policy over the previous `no-referrer-when-downgrade`.
* chore: bump chromium in DEPS to 69cb7c65ad845cdab1cd5f4256237e72fceba2dd
* chore: re-export chromium patches
No code changes; just line numbers. `git am` failed because the upstream
changes were just large enough to require patching to fail w/o fuzzing.
The broken patch was
patches/chromium/feat_allow_disabling_blink_scheduler_throttling_per_renderview.patch
* update patches
* chore: bump chromium in DEPS to c6d97a240d30e5f5166856f5ae6ee14d95b9a4f0
* update patches
* fixup! chore: update expected window-open default policy.
* chore: disallow copying CppHeapCreateParams
Experimental commit to resolve FTBS https://ci.appveyor.com/project/electron-bot/electron-ljo26/builds/36405680#L25345
which introduces a new struct CppHeapCreateParams that aggregates a
vector of unique_ptrs. Our Windows CI is unhappy that this struct
implicitly deletes its copy ctor, so this commit makes it explicit.
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/2536642
* update patches
* chore: bump chromium in DEPS to 0df9a85ffa0ad4711b41a089842e40b87ba88055
* update patches
* fixup! chore: bump chromium to ac06d6903a2c981ab90a8162f1ba0 (master) (#26499 )
* chore: update calls to gfx::RemoveAcceleratorChar.
The call signature for gfx::RemoveAccelerator changed in
https://chromium-review.googlesource.com/c/chromium/src/+/2546471 .
This commit updates use to match that.
* chore: bump chromium in DEPS to 43d6c496251e08d3781bfadbe9727688551f74a9
* update patches
* chore: bump chromium in DEPS to 1fb5c9825be4e2271c4fef0e802f5d970b32f62f
* update patches
* chore: bump chromium in DEPS to 8a1f078d67825e727a598b89a8924699df8d3850
* chore: bump chromium in DEPS to 28ff715b3a97d8cedc143bad671edb08b6de5fc2
* chore: update patches
* Remove most service manifest remnants from Content
https://chromium-review.googlesource.com/c/chromium/src/+/2296482
* Reland "Portals: Fix a11y for orphaned portals"
https://chromium-review.googlesource.com/c/chromium/src/+/2542812
* Convert CallbackList::Subscription to a standalone class.
https://chromium-review.googlesource.com/c/chromium/src/+/2522860
* fix: actually apply the zlib patch
* chore: bump chromium in DEPS to 75b464e6357190ca302ba9ce8f8c2bf5a3b709ae
* chore: update patches
* chore: bump chromium@b884b9b2f647c59a75f5d2055030afa33d50ca10
* chore: bump chromium in DEPS to 829261dadcefdc54ce5fdf7c5fac2929786a63ce
* chore: bump chromium in DEPS to 5df3e69605c7c0130374aaccb91fc4726a558db2
* chore: bump chromium in DEPS to 22db748d5b7b90f87e6e97ef4c92a727ac753ea4
* chore: bump chromium in DEPS to 1475df80282b7eeeb0e153d8375bfe651f083bf8
* chore: bump chromium in DEPS to 6d34fe9e9b7386edd90574617bfa4008de972d72
* chore: update patches
* Disable CertVerifierService for now
2559260: Enable CertVerifierService by default | https://chromium-review.googlesource.com/c/chromium/src/+/2559260
* Remove force_ignore_site_for_cookies until we figure out what to do instead
2499162: Remove |force_ignore_site_for_cookies| from IPCs (e.g. ResourceRequest). | https://chromium-review.googlesource.com/c/chromium/src/+/2499162
* chore: bump chromium in DEPS to 95aeb1c59ebc03d19ba077b0cd707463d1b2865e
* update patches
* Set site_for_cookies to request url so that URLLoader::ShouldForceIgnoreSiteForCookies returns true
* 2490383: a11y inspect reorg: implement accessible tree formatter factory
https://chromium-review.googlesource.com/c/chromium/src/+/2490383
* 2485887: [Extensions][web_accessible_resources] Use |matches|.
https://chromium-review.googlesource.com/c/chromium/src/+/2485887
* update v8 headers
* chore: bump chromium in DEPS to 38587dc379a8cf4d4a13e482a6e89f2fe681144e
* update patches
* 2555005: [api] Simplify ScriptOrigin
https://chromium-review.googlesource.com/c/v8/v8/+/2555005
* 2563553: Remove Flash from PermissionRequestTypes and PermissionTypes.
https://chromium-review.googlesource.com/c/chromium/src/+/2563553
* 2546146: Remove browser-hosted InterfaceProvider
https://chromium-review.googlesource.com/c/chromium/src/+/2546146
* Actually apply nan patch
* update patches
* chore: bump chromium in DEPS to 6718d4b50c9db975c5642ca5b68e8dc7ee1b7615
* update patches
* 2546146: Remove browser-hosted InterfaceProvider
https://chromium-review.googlesource.com/c/chromium/src/+/2546146
* chore: bump chromium in DEPS to 338cc300e3fe3a4cb4883e9ccdc34a32f3dfe034
* chore: bump chromium in DEPS to d9baeb1d192c23ceb1e1c4bbe6af98380b263bc1
* chore: bump chromium in DEPS to 3ca3051932683739b304e721cc394b6c66f841fe
* chore: bump chromium in DEPS to 89292a4ae29096e5313aaf19dfa0c4710145c34d
* 2571639: mac: Remove code to support OS X 10.10 in //sandbox
https://chromium-review.googlesource.com/c/chromium/src/+/2571639
* Fixup patch indices
* Do not build MTLManagedObjectAdapter
It's been removed in newer Mantle versions and uses a deprecated enum
* update patches
* Remove sendToAll
https://github.com/electron/electron/pull/26771
* 2569367: Remove dead fullscreen code in RenderWidgetHostView and friends
https://chromium-review.googlesource.com/c/chromium/src/+/2569367
* Remove deprecated performFileOperation usage
* 2568359: mac: Ignore Wdeprecated-declarations for LSSharedFileList* functions.
https://chromium-review.googlesource.com/c/chromium/src/+/2568359
* 2561401: Add OutputPresenterX11 which uses X11 present extension.
https://chromium-review.googlesource.com/c/chromium/src/+/2561401
* 2565511: [objects] Remove MakeExternal case for uncached internal strings
https://chromium-review.googlesource.com/c/v8/v8/+/2565511
* fixup: Add disconnect logic to ElectronBrowserHandlerImpl
* Allow local networking override for ATS
https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html
* Refactor: clean up rfh getters in ElectronBrowserHandlerImpl
* Update patches
* Remove unneeded BindTo
* Don't assign ElectronBrowserHandlerImpl at all
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2020-12-14 10:57:36 -08:00
Milan Burda
cec6378881
feat: add event.senderFrame property returning the originating webFrameMain ( #26764 )
2020-12-09 15:34:06 -08:00
Jeremy Rose
07a1c2a3e5
fix: restrict sendToFrame to same-process frames by default ( #26875 )
2020-12-09 12:48:16 -08:00
Shelley Vohr
76f721474e
fix: stack traces in non-Node.js contexts ( #26820 )
2020-12-09 11:08:13 -08:00
Milan Burda
b37982987a
chore: remove unused sendToAll + related APIs ( #26771 )
...
* chore: remove unused sendToAll + related APIs
* refactor: no need to args.ShallowClone() anymore
2020-12-03 15:55:50 +09:00
Shelley Vohr
e96fa95b94
fix: properly emit after hooks after exception ( #26752 )
2020-12-01 21:34:08 -08:00
Milan Burda
09d7b2bc91
chore: remove deprecated shell.moveItemToTrash() ( #26723 )
2020-11-30 23:25:03 +03:00
Samuel Attard
dcc6196fe7
revert: disable rosetta as Electron does not run under rosetta
...
This reverts commit 4829b0f816
.
2020-11-18 09:04:16 -08:00
Jeremy Rose
a303813d15
refactor: move GetPrinterList off WebContents ( #26518 )
2020-11-17 14:14:09 -08:00
Jeremy Rose
023c89265f
refactor: move TerminationStatus converter ( #26520 )
2020-11-17 11:13:58 -08:00
Shelley Vohr
6f6c1b7ca6
feat: add displayFrequency to Display object ( #26472 )
2020-11-16 15:33:51 -08:00
Electron Bot
e017d8714e
chore: bump chromium to adc5df74b86afdff676989ced8cd3 (master) ( #26223 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
2020-11-13 16:16:56 -08:00
Shelley Vohr
e6db49686b
fix: renderer crash on setImmediate ( #26365 )
2020-11-10 09:17:58 -08:00
loc
0b85fdf26c
feat: add webContents.setWindowOpenHandler API ( #24517 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-11-10 09:06:03 -08:00
John Kleinschmidt
7f9b21daa0
feat: correctly identify permissions when using setPermissionRequestHandler ( #26172 )
...
* fix: correctly identify clipboard read permission
* Update tests for variable clipboard content
* chore: add all possible permission conversions
* VIDEO_CAPTURE and AUDIO_CAPTURE were already defined
* Handle all PermissionTypes
* use skewer case for accessibility events to match permissions api
https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API
2020-10-29 14:22:32 -04:00
Charles Kerr
f489e3054a
feat: honor nativeTheme.themeSource = 'dark'
before creating BrowserWindow on Windows ( #25373 )
...
* fix: support 'dark' theme before creating windows.
2020-10-28 15:00:21 -05:00
Milan Burda
1c99a9b425
refactor: Chromium code style for enum classes ( #26165 )
2020-10-27 10:51:45 -07:00
Samuel Attard
dbf2931f0e
feat: Electron Fuses, package time feature toggles ( #24241 )
...
* feat: add new 'fuses' feature for package-time build-flag style feature control
* feat: put ENABLE_RUN_AS_NODE behind a fuse as well
* chore: address PR feedback
* build: move FUSE_EXPORT to headers
* build: use hex codes for kFuseWire char[]
* docs: add fuse wire documentation
* chore: update fuses.json info
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* chore: add link to fuse schema
* Update shell/app/electron_library_main.mm
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-10-27 10:49:25 -07:00
David Sanders
422190e1ff
chore: change some for loops to range-based ( #26182 )
2020-10-27 10:22:24 -07:00
David Sanders
d8167ce138
chore: use consistent parameter names ( #26162 )
2020-10-27 10:18:36 -05:00
David Sanders
4be10523e8
chore: use auto to avoid repeating type ( #26113 )
2020-10-26 11:56:31 -07:00
LuoJinghua
0fc5f18b63
fix: Don't sort the headers of ClientRequest ( #26134 )
2020-10-26 11:33:36 -07:00
David Sanders
554ad93d45
chore: prefer empty() check for readability ( #26109 )
2020-10-22 13:24:59 -07:00
Samuel Maddock
10a209ecba
feat: add webPreferences.enablePreferredSizeMode ( #25874 )
...
* feat: add preferredSizeMode preference
* docs: webPreferences.preferredSizeMode and event
* docs: better explain preferred size
* docs: small improvement
* refactor: preferredSizeMode -> enablePreferredSizeMode
2020-10-21 15:44:19 -07:00
Julie Koubová
56d1fafe66
build: Wrap bundles using webpack ( #25557 )
2020-10-20 12:10:15 -07:00
Cheng Zhao
6b6ffbdd10
feat: add support for share menu on macOS ( #25629 )
2020-10-19 18:33:06 -07:00
Electron Bot
e895353f7a
chore: bump node to v14.14.0 (master) ( #25994 )
...
* chore: bump node in DEPS to v14.14.0
* Remove upstreamed certs patch
https://github.com/nodejs/node/pull/35546
* Remove V8 Isolate callbacks patch
https://github.com/nodejs/node/pull/35512
* Update patch indices
* Update Node.js filenames
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-10-19 13:28:28 -07:00
Electron Bot
46f3491c7d
chore: bump chromium to 6b9fa6b352d824d052222e1abe541 (master) ( #25558 )
...
* chore: bump chromium in DEPS to d5c9bf9e2a18fa508201a88e5803bec1d107b1ae
* chore: bump chromium in DEPS to 45f1316afae33e52c92480b34bf4f7fe4a7db898
* update patches
* WillCreateURLLoaderFactory now gets a ukm_source_id
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2346803
* ink_drop_visible_opacity -> GetInkDropVisibleOpacity
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2415368
* chore: bump chromium in DEPS to ddb5b6db5e35ab1a7b5adbd9f15373af6c35ea2a
* 2418471: PDF Viewer update: Add missing aria-labels to various buttons.
https://chromium-review.googlesource.com/c/chromium/src/+/2418471
* update printing.patch given print settings mojoification
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2409467
* update patches
* content::BluetoothChooser::Event -> content::BluetoothChooserEvent
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2387901
* set_ink_drop_base_color -> SetInkDropBaseColor
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2419388
* chore: bump chromium in DEPS to ecf7c9ee830d4d85f300b461a2fa13aa40c79a4c
* update patches
* gfx::ConvertPointToPixel -> gfx::ConvertPointToPixels
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2418568
* remove ContentSettingsObserver::AllowStorage()
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2401847
* service_manager::kCrashDumpSignal -> kCrashDumpSignal
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2417073
* chore: bump chromium in DEPS to abdb7ebe5f8c8328b8f435283df90d0a3ecff7bd
* chore: bump chromium in DEPS to 2a7e138ab1066534ceb2622e8a9d2c8ebf574215
* chore: bump chromium in DEPS to ab1884e75ced904e4276851eb4e1ad89919ca93b
* chore: bump chromium in DEPS to a12413902380dcc2a73ac74d582328280a8af686
* Fixup printing patch
https://chromium-review.googlesource.com/c/chromium/src/+/2428623
* Fixup OSR patch
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Make ExtensionURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2357523
* Add deprecated_default_sources_assignment_filter variable
https://chromium-review.googlesource.com/c/chromium/src/+/2416496
* Fixup patch indices
* Remove several references to BrowserPlugin from content
https://chromium-review.googlesource.com/c/chromium/src/+/2401031
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Add DragOperation and AllowedDragOperations Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/2196167
* chore: bump chromium in DEPS to 378450342cf6aa160663d0ce3a178a11b570c25a
* Fixup patch indices
* Remove SurfaceEmbeddingTime and LocalSurfaceIdAllocation
https://chromium-review.googlesource.com/c/chromium/src/+/2415128
* Add DragOperation and AllowedDragOperations Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/2196167
* 2426564: Remove global sources assignment filter value
https://chromium-review.googlesource.com/c/chromium/src/+/2426564
* Fixup blink_local_frame.patch
* [XProto] Remove a subset of ui/gfx/x/x11.h
https://chromium-review.googlesource.com/c/chromium/src/+/2430328
* Fixup patch indices
* Remove several references to BrowserPlugin from content
https://chromium-review.googlesource.com/c/chromium/src/+/2401031
* Remove lossy ConvertSizeToPixel() methods
https://chromium-review.googlesource.com/c/chromium/src/+/2419534
* serial: Use USB driver name to disambiguate ports
https://chromium-review.googlesource.com/c/chromium/src/+/2413176
* Remove set_sources_filter import
* Fix ModMask usage
* [XProto] Remove usage of all Xlib headers
https://chromium-review.googlesource.com/c/chromium/src/+/2392140
* [XProto] Remove usage of Xlib Visuals
https://chromium-review.googlesource.com/c/chromium/src/+/2429933
* Skip Angle manifest file
https://chromium-review.googlesource.com/c/angle/angle/+/2425197
* Add whole src\third_party\angle\.git directory
This directory is needed in order to properly generate gen/angle/angle_commit.h
* [libvpx] Fix HighBD config on Windows ARM64
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* update patches
* fix: correct calling convention for Windows on Arm
https://chromium-review.googlesource.com/c/v8/v8/+/2440717
* Add third_party/angle/.git to the archive before adding the rest of the source
* fixup source caching on Windows
* Fixup erroneous close paren
* fixup for goma issues
* This should work
* chore: bump chromium roll manually
https://chromium-review.googlesource.com/c/chromium/src/+/2435142
This landed the day after we paused roller-bot and may resolve the
visibility test flakes that we're seeing. h/t to @jkleinsc for
finding this with me.
* chore: remove obsoleted cherry-pick fix for libvpx
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* chore: remove obsoleted cherry-pick libvpx patch
https://chromium-review.googlesource.com/c/chromium/src/+/2437745
* chore: re-export patches
* chore: add tracer comment to visibility-stat-spec.
The line numbers between the source and the CI runs don't seem to match
up, so this temp tracer is to help track the source of that difference.
* chore: bump chromium in DEPS to 7c2b8cc3b8638aee8abeb013042a6c1d15b2da6b
* update patches
* impl SortingLSH service
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2425327
* 2446525: [Flash] Remove some Flash APIs
https://chromium-review.googlesource.com/c/chromium/src/+/2446525
* 2440974: Reland "Delete service_manager/embedder/switches.h"
https://chromium-review.googlesource.com/c/chromium/src/+/2440974
* 2359402: Remove ContentBrowserClient::NonNetworkURLLoaderFactoryDeprecatedMap.
https://chromium-review.googlesource.com/c/chromium/src/+/2359402
* 2250506: Implement tabs.removeCSS
https://chromium-review.googlesource.com/c/chromium/src/+/2250506
* 2429143: Remove implicit-conversion-to-integer ConvertRectToPixel() methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2429143
* 2444430: Remove DataElementType::kBlob
https://chromium-review.googlesource.com/c/chromium/src/+/2444430
* 2441964: Clean up WebView public API
https://chromium-review.googlesource.com/c/chromium/src/+/2441964
* 2357523: Make ExtensionURLLoaderFactory always owned by its |receivers_|.
https://chromium-review.googlesource.com/c/chromium/src/+/2357523
* 2461606: Use blink::mojom::PreferredColorScheme instead of blink::PreferredColorScheme
https://chromium-review.googlesource.com/c/chromium/src/+/2461606
* 2461235: a11y inspect reorg: move PropertyFilter struct to a new location
https://chromium-review.googlesource.com/c/chromium/src/+/2461235
* remove flash support
* fix frame_host_manager patch
* fix lint
* remove flash info from docs
* fix build
* fix osr
* chore: bump chromium in DEPS to 9269f9eb1d98d29564c2b2ab97f30c6e148c4e11
* fix visibilityState tests
* 2463049: Replace all uses of web_pref::AutoplayPolicy with mojom::AutoplayPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/2463049
* update patches
* fix tests harder
* 2414921: Add Group and Ungroup functions to Tabs extension API
https://chromium-review.googlesource.com/c/chromium/src/+/2414921
* more test fix
* Remove all keyboard related usage of Xlib
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2436787
* fix linux build
* 2453807: [XProto] Remove usage of Xlib error handling
https://chromium-review.googlesource.com/c/chromium/src/+/2453807
* lint
* fixup! 2453807: [XProto] Remove usage of Xlib error handling
* disable CalculateNativeWinOcclusion on win ci
* remove UploadBlob from docs
* Update appveyor.yml
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-10-15 18:30:41 -07:00
David Sanders
b194030a34
chore: cleanup some typos in comments ( #25770 )
2020-10-13 10:25:21 -07:00
Jeremy Rose
cbe751d349
fix: NativeImage.getScaleFactors returns correct scales ( #25832 )
...
* fix: NativeImage.getScaleFactors returns correct scales
* fix tests
2020-10-13 10:59:18 +09:00
Samuel Maddock
704d69a8f9
feat: add webFrameMain API to the main process ( #25464 )
2020-10-09 09:50:46 -07:00
Shelley Vohr
042d25e926
fix: wasm code generation in the renderer ( #25777 )
2020-10-08 12:26:01 -07:00
Jeremy Rose
f31a1c9e4e
fix: prevent UAF in NativeImage.getBitmap ( #25782 )
2020-10-06 15:58:40 -07:00
Shelley Vohr
0632d59da0
chore: use noop ShouldAbortOnUncaughtException cb ( #25772 )
2020-10-06 11:16:49 -07:00
Milan Burda
b33f22601e
refactor: check ELECTRON_ENABLE_LOGGING via native implementation ( #25623 )
2020-10-06 09:58:31 +09:00
Cheng Zhao
57dc170e81
fix: no more need to hijack process.stdout on Win32 ( #25765 )
2020-10-05 10:10:38 -07:00
Jeremy Rose
485adae94c
fix: nativeImage.crop().toBitmap() returning garbage ( #25757 )
2020-10-05 10:15:16 +09:00
Samuel Maddock
462de5f97a
chore(extensions): remove unused features json ( #25660 )
2020-09-29 20:03:35 -07:00
Shelley Vohr
99a4284174
refactor: remove unnecessary copied helper ( #25668 )
2020-09-29 11:40:31 -04:00
CezaryKulakowski
b85195ee5f
fix: ensure ready-to-show event is fired ( #25632 )
2020-09-28 13:36:45 -07:00
John Kleinschmidt
fd63510ca9
feat: add serial api support ( #25237 )
...
* feat: add serial api support
resolves #22478
* Put serial port support behind a flag and mark as experimental
* Update docs/api/session.md
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* Use enable-blink-features=Serial instead of enable-experimental-web-platform-features
* Set enableBlinkFeatures on webPreferences instead of commandline
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-09-28 12:22:03 -04:00
Shelley Vohr
b807cabe1b
chore: remove custom Node.js debugger ( #25587 )
2020-09-23 20:35:56 -07:00
bitdisaster
2cfa41e6e0
feat: read/write Toast Activator CLSID in shortcuts ( #25493 )
...
* read/write Toast Activator CLSID
* docs
* tests
* tweaks
2020-09-17 15:17:44 -07:00
Shelley Vohr
77038b7bda
chore: upgrade to Node.js v14.9.0 ( #25249 )
2020-09-17 16:08:57 -06:00
Jeremy Rose
ba55aaa53b
fix: check for destroyed webcontents in converter ( #25431 )
2020-09-16 12:25:49 -07:00
Charles Kerr
70e3aa0182
refactor: add a wrapper for wrangling uv handles. ( #25332 )
...
* refactor: add a wrapper for wrangling uv handles.
Part 1 of a fix for #25248 , #22069 .
Place the uv_asyncs owned by NodeBindings, ElectronBindings inside a new
UvHandle wrapper class which manages uv_handles' need for their closed()
callback to be invoked before the handles' memory can be freed.
* chore: make lint happy
* refactor: use DCHECK_EQ() instead of DCHECK()
* refactor: fix oops
2020-09-14 09:53:50 +09:00
Samuel Maddock
860e14c0da
chore(extensions): remove old renderer code ( #25347 )
2020-09-08 20:11:38 +09:00
Samuel Attard
4ad9bcb8b5
fix: handle electron script errors better ( #25328 )
2020-09-04 14:53:49 -07:00
Jeremy Rose
1b6534b326
feat: add shell.trashItem() to replace shell.moveItemToTrash() ( #25114 )
2020-09-02 10:32:33 -07:00
Eryk Rakowski
3745b76da8
feat(extensions): add support for some chrome.management APIs ( #25098 )
...
* fix: initialize management policy
* fix(extensions): crash when using chrome.management
* test: add tests
* docs: add a note about chrome.management
* fix: lint errors
* fix: lint errors
* fix: remove favicon_service include
* fix: add missing management permission
* docs: more supported apis
* fix: extensions.md line endings
2020-09-02 09:59:56 +09:00
Markus Olsson
bab69ae4d2
fix: make shell.moveItemToTrash return false on Windows when move unsuccessful ( #25124 )
2020-08-27 09:55:33 -07:00
Jeremy Rose
2c9e79c8d5
test: add tests for shell.moveItemToTrash ( #25113 )
2020-08-26 09:34:29 -07:00
Jeremy Rose
35237d3c30
fix: [linux] open directories with dbus FileManager ( #25087 )
2020-08-24 13:54:50 -07:00
George Xu
beaf60de0a
feat: add nativeImage.createThumbnailFromPath API ( #24802 )
...
* initial commit, mac implementation
* add documentation
* convert createThumbnailFromPath to async function
* windows impl protoype
* add tests
* added test
* fix
* fix test
* clean up
* update docs
* cleaning up code
* fix test
* retrigger CI
* retrigger CI
* refactor from app to native_image
* windows build
* lint
* lint
* add smart pointers, fix test
* change tests and update docs
* fix test, remove nolint
* add renderer-main process routing to fix tests
* lint
* thanks sam
* thanks sam
2020-08-24 09:36:13 -07:00
Shelley Vohr
024ea32313
feat: make window visual effect state customizable ( #25083 )
2020-08-24 11:44:48 -04:00
Electron Bot
8798571a77
chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) ( #24687 )
...
* chore: bump chromium in DEPS to 1f1c4d91f6eaa4a033ec8f499d63a0717f79a42a
* viz: Do not apply white level scaling for RGBA fp16 HDR video
https://chromium-review.googlesource.com/c/chromium/src/+/2296006
* Move WebPreferences to WebContents
https://chromium-review.googlesource.com/c/chromium/src/+/2263635
* Fix missing WeakPtr check in PreconnectManager
https://chromium-review.googlesource.com/c/chromium/src/+/2309029
* Fixup swiftshader roll revision
* Update patch indices
* Move WebDeviceEmulationParams into common.
https://chromium-review.googlesource.com/c/chromium/src/+/2303356
* Move EnableDisableDeviceEmulation to blink mojom messages
https://chromium-review.googlesource.com/c/chromium/src/+/2303367
* PDF Viewer: Remove flag for two-up view
https://chromium-review.googlesource.com/c/chromium/src/+/2311130
* Add mojom definition for DeviceEmulationParams.
https://chromium-review.googlesource.com/c/chromium/src/+/2303491
* Remove ServiceWorkerContextWatcher from PaymentAppInstaller
https://chromium-review.googlesource.com/c/chromium/src/+/2291186
* Loader: Move transferrable_url_loader.mojom into blink's mojom directory
https://chromium-review.googlesource.com/c/chromium/src/+/2306123
* chore: bump chromium in DEPS to 4974f436479739025a90ebc2cc2e36d67ee1ac46
* mac: Work around Xcode 12b3 SDK bug
https://chromium-review.googlesource.com/c/chromium/src/+/2315078
* Reland Update core items for macOS Big Sur.
https://chromium-review.googlesource.com/c/chromium/src/+/2315162
* Update Swiftshader revision
* mac/arm64: When cross-building the snapshot, use page size of the target ISA instead of the host.
https://chromium-review.googlesource.com/c/v8/v8/+/2310575
* Update patch indices
* Rename {,Non}ClientView::CanClose() to OnWindowCloseRequested()
https://chromium-review.googlesource.com/c/chromium/src/+/2247838
* chore: bump chromium in DEPS to e9465d70d1dea539400f0fddad43358ea3c31d71
* chore: bump chromium in DEPS to bd5b71c5f20288eb26068a39ae6e0579566a51c5
* chore: bump chromium in DEPS to 786ee543048bd07d07c5ac50b7dbbdd6bdd8dcce
* chore: bump chromium in DEPS to 34eb6ecbf2c5894b648900bf771a2a29de204798
* chore: bump chromium in DEPS to 567ff038d68e3adb8116a01eec863cdf34d775f5
* chore: bump chromium in DEPS to 340b45c8d4ceb2dd61969fc34e1928d3c46db48c
* chore: update patches
* chore: base::DeleteFile with two params is removed
Should use base::DeleteFile and base::DeletePathRecursively when
appropriate
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2313376
* chore: add patch for NodePlatform::PostJob impl
* chore: update patches
* chore: extension file access is now instrumented
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2209995
* chore: implement SetWindowFrameInScreen in OSR RWHV
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2321409
* chore: NotifyUserActivation requires a type now
This is just for a histogram thing and therefore it does not matter what
we pass in
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2281303
* chore: update patches
* chore: bump chromium in DEPS to cd570e6dd3dcb84463ac252b04e92ceb02d8400c
* chore: update patches
* chore: bump chromium in DEPS to 0187908a31866992b90c59719ac1d016328f6ee0
* chore: bump chromium in DEPS to 3c9df38c508f3dba26a75248beed4882ddfb98e9
* chore: bump chromium in DEPS to 1a47d3b9cee710bd3c958c4f2d8b205710df9d50
* chore: bump chromium in DEPS to baac93040d96abdab72d46dd034c60f86e108702
* chore: bump chromium in DEPS to 13836145f97299e636491de38064b78861c4fb2e
* update patches
* change OS_MACOSX -> OS_MAC
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1105907
* patch: add header for ToExecutionContext in WebMessagePortConverter
* chore: bump chromium in DEPS to 91ab9b6ac5d04dc034a03ad847fbfa8261328c2b
* update patches
* NeedToFireBeforeUnloadOrUnload -> NeedToFireBeforeUnloadOrUnloadEvents
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2288711
* chore: bump chromium in DEPS to 290deb11f0e30cb1382fd8f8793d340560283c23
* update patches
* add dragdrop header for autofill popup
* int -> x11::Time
* patch out accessibility private API use
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2330812
* remove usage of XEvent
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2317767
* trigger recalculation of WebPreferences before renderer initialization
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2263635
* chore: bump chromium in DEPS to 6bdb484583b99c96ef3388d0c2184326581b2d5a
* chore: bump chromium in DEPS to 1eb2a79cde04fd5c8ae51b4d813e6521635269e5
* chore: bump chromium in DEPS to 3dc8e3c0f400e4ca9c0a63d7a39bd910997ad4c6
* chore: update patches
* fixup! trigger recalculation of WebPreferences before renderer initialization
* views: Make MenuButton and RadioButton default constructible
https://chromium-review.googlesource.com/c/chromium/src/+/2339586
* chore: fix code style
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2020-08-12 11:33:58 -07:00
Shelley Vohr
8311078a96
fix: don't try to init mmap on missing asar ( #24890 )
2020-08-10 08:22:49 -07:00
Jeremy Rose
01a2e23194
refactor: mmap asar files ( #24470 )
2020-08-04 11:48:04 -07:00
Jeremy Rose
1350dc46ed
refactor: ginify Archive ( #24799 )
2020-08-03 14:26:27 -07:00
Jeremy Rose
b5cd9ce0b3
refactor: ginify WebContents ( #24651 )
2020-07-30 09:17:57 -07:00
Shelley Vohr
948cc08265
chore: add V8 crash information to crashReporter ( #24771 )
...
* feat: add V8 crash information to crashReporter
* Address review feedback
2020-07-29 19:04:24 -07:00
Jeremy Rose
d93bb34ac4
fix: increase max crash key value length ( #24782 )
...
* fix: increase max crash key value length
* chore: fix linting
* chore: fix linux
* Update spec-main/api-crash-reporter-spec.ts
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
2020-07-29 19:04:04 -07:00
Samuel Attard
4829b0f816
fix: disable rosetta as Electron does not run under rosetta ( #24670 )
2020-07-27 13:26:04 -07:00
Samuel Attard
b500294c1d
feat: add worldSafe flag for executeJS results ( #24114 )
...
* feat: add worldSafe flag for executeJS results
* chore: do not log warning for webContents.executeJS
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* chore: apply PR feedback
* chore: split logic a bit
* chore: allow primitives through the world safe checl
* chore: clean up per PR feedback
* chore: flip boolean logic
* chore: update per PR feedback
* chore: fix typo
* chore: fix spec
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2020-07-23 14:32:20 -07:00
Electron Bot
2fb14f53fe
chore: bump chromium to 1a093e6a0cb5e72ba78990fe39824 (master) ( #24575 )
2020-07-21 22:34:34 -07:00
Shelley Vohr
bcba4baa85
fix: use Node.js isolate setup logic in bindings ( #24579 )
...
* fix: use Node.js isolate setup logic in bindings
* Flags should be more process-specific
* Remove redundant isolate function setting
* Remove old SetFatalErrorHandler call
2020-07-20 12:41:52 -07:00
Jeremy Rose
f0953902db
refactor: clean up Session with CleanedUpAtExit ( #24603 )
2020-07-20 12:13:33 -07:00
Samuel Attard
f649e604be
build: tsify asar and move to webpack js2c pipeline ( #24495 )
...
* build: tsify asar and move to webpack js2c pipeline
* build: use the webpack provider for fs-wrapper
2020-07-16 11:38:31 -07:00
Electron Bot
8bbdc224ac
chore: bump chromium to 6d130075d378a64187360ba4e7820 (master) ( #24256 )
...
* chore: bump chromium in DEPS to 7fb9778894d73378bff51087ce869ea5aa6e5d5d
* chore: bump chromium in DEPS to 83da426e53d423f0530fc23433b6d2c4d0548442
* update patches
* remove chromeos-only TtsControllerDelegate
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2255314
* SharedUserScriptMaster -> SharedUserScriptManager
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2258357
* avoid deprecated DISALLOW_COPY_AND_ASSIGN
https://groups.google.com/a/chromium.org/forum/#!msg/cxx/qwH2hxaEjac/TUKq6eqfCwAJ
* chore: bump chromium in DEPS to b2eaf9ff4e6b03267bf279583ea20ceb2b25e9d0
* update patches
* rename GetHighContrastColorScheme -> GetPlatformHighContrastColorScheme
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2250224
* remove vulkan info collection
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2252818
* add max_xcode_version build var
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2264867
* add missing headers
* chore: bump chromium in DEPS to cded18ca1138f7e8efc904f077ddcca34f0135cf
* update patches
* add empty floc blocklist to BrowserProcessImpl
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2240873
* chore: bump chromium in DEPS to f06602226cd80bf677b2ce013a94a2fb7f6ac58d
* chore: bump chromium in DEPS to 747aa4bfc74fc6cf7f08ee72624cd69ae41ae28d
* chore: bump chromium in DEPS to 31c0105e50fcc4e94de33e5c8602c755ace4a32b
* chore: update patches
* Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
https://chromium-review.googlesource.com/c/chromium/src/+/2264297
* X11 and Ozone: make sure gfx::AcceleratedWidget to be uint32_t
https://chromium-review.googlesource.com/c/chromium/src/+/2260554
* Move zygote from //services/service_manager back to //content
https://chromium-review.googlesource.com/c/chromium/src/+/2252466
* chore: update v8 patches
* [XProto] Remove usage of Shape extension
https://chromium-review.googlesource.com/c/chromium/src/+/2262113
* fixup! add empty floc blocklist to BrowserProcessImpl
* Require macOS 10.15.1 sdk
https://chromium-review.googlesource.com/c/chromium/src/+/2238504
* Use newer Xcode version 11.5.0
* update src cache
* chore: bump chromium in DEPS to 60a9883e35db3f6f91916f0878e88e1849c17b11
* chore: update patches
* Reland "Reland "New toolchain for Windows 10 19041 SDK""
https://chromium-review.googlesource.com/c/chromium/src/+/2255527
* update patches
* Convert raw NonClientFrameViews to unique_ptrs
https://chromium-review.googlesource.com/c/chromium/src/+/2240417
* [printing] Move PrintHostMsg_DidPreviewDocument_Params to print.mojom
https://chromium-review.googlesource.com/c/chromium/src/+/2257035
* chore: bump chromium in DEPS to 12c233c2a85bfa28fb279f390121ba681e52a71b
* chore: update patches
* Removing oppressive language for the directory chrome/browser/apps
https://chromium-review.googlesource.com/c/chromium/src/+/2269822
* Inclusion: rename SpellcheckLanguageBlacklistPolicyHandler
https://chromium-review.googlesource.com/c/chromium/src/+/2267646
* Clean up duplicate WebContents "is fullscreen" functions
https://chromium-review.googlesource.com/c/chromium/src/+/2275148
* Adds icon loading service with sandbox for Windows.
https://chromium-review.googlesource.com/c/chromium/src/+/1987273
* No more Vulkan info collection for UMA on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2252818
* fix lint
* chore: update buildflag conditions
* chore: bump chromium in DEPS to a837d4c4230ace4f10b2768728f4044b7995dfa5
* update hunspell files
* chore: update patches
* Make content::FileSelectListener a RefCounted
https://chromium-review.googlesource.com/c/chromium/src/+/2275338
* fix build failures on MAS
* update patches
* fixup! Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
* fix build on windows
* Check for GDI exhaustion if window creation fails
https://chromium-review.googlesource.com/c/chromium/src/+/2244124
* chore: bump chromium in DEPS to 2c9b2a73be4ef9ec22d8b6da8e174cb80753f125
* chore: update patches
* Network Service: Move DeleteCookiePredicate into public folder
https://chromium-review.googlesource.com/c/chromium/src/+/2264186
* chore: bump chromium in DEPS to fa2606299bcc02c362528d26b5dcf8c8a0db0735
* chore: bump chromium in DEPS to d9c235d1227204dbae3708daae851573a3566b94
* chore: bump chromium in DEPS to 2f82c284243c035f49a747fd1ead6c44b4b31093
* chore: update patches
* Move creating the LayerTreeSettings into blink.
https://chromium-review.googlesource.com/c/chromium/src/+/2267720
* chore: bump chromium in DEPS to 914112f1d9af9e4974059dc403da62699a55550f
* update patches
* chore: bump chromium in DEPS to e0bc1ffae6393fc543a2da94c88167df75859b36
* refactor: match upstream print preview handling (#24452 )
* update patches
* chore: bump chromium in DEPS to 0881423156abe084164b51ab58ce93a8bd380524
* update patches
* update patches
* give a type to pendingPromise
* chore: bump chromium in DEPS to 11a8c1534b16d130075d378a64187360ba4e7820
* update patches
* 2272609: Move //services/service_manager/sandbox to //sandbox/policy.
https://chromium-review.googlesource.com/c/chromium/src/+/2272609
* update patches
* fixup! 2272609: Move //services/service_manager/sandbox to //sandbox/policy.
* fixup! 2272609: Move //services/service_manager/sandbox to //sandbox/policy.
* 2264511: Cookies: Update SetCanonicalCookie to return CookieAccessResult
https://chromium-review.googlesource.com/c/chromium/src/+/2264511
* chore: fix setAlwaysOnTop test
The window must be visible for state to be updated properly.
* Revert "Migrate modules/desktop_capture and modules/video_capture to webrtc::Mutex."
https://webrtc-review.googlesource.com/c/src/+/179080
* update patches
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2020-07-13 21:13:34 -04:00
Jeremy Rose
36bd940bc3
refactor: ginify NativeImage ( #24486 )
2020-07-13 14:44:12 -07:00
Jeremy Rose
9bd0fc5348
refactor: ginify BrowserView ( #23578 )
2020-07-09 08:48:39 -07:00
Robo
7dd365784d
fix: clipboard.readBuffer returning empty value ( #24454 )
2020-07-08 15:02:42 -07:00
Shelley Vohr
6cfbee9f34
fix: uv_walk crash on web worker close ( #24436 )
...
* fix: uv_walk crash on web worker close
* Use DCHECK_EQ
2020-07-08 11:00:43 -07:00
Cheng Zhao
ef3579eae3
refactor: rename TopLevelWindow to BaseWindow ( #24305 )
2020-06-29 16:06:20 +09:00
Shelley Vohr
659e79fc08
refactor: prevent consistent early exception ( #24191 )
...
* refactor: prevent consistent early exception
* Use _linkedBinding where possible
* Remove dead electronBinding
2020-06-22 20:32:45 -07:00
Electron Bot
72a089262e
chore: bump chromium to a84d34e372b8fb5e9a94b1b4b447e (master) ( #23908 )
...
* chore: bump chromium in DEPS to a7249f73ae05d456c04487ef1693325f719556dd
* chore: bump chromium in DEPS to 202466fa40b58f0bb9c9a76a037d1c50154c099e
* chore: bump chromium in DEPS to 2dd1b25c8d794b50fb0dd911e0c4e909ff39f145
* Update patches
* update patches
* Revert "[printing] Mojofy PrintHostMsg_CheckForCancel"
https://chromium-review.googlesource.com/c/chromium/src/+/2226002
* chore: bump chromium in DEPS to 8c1542e7dd36854fdf4abd1a8021eeb65a6a2e2b
* chore: bump chromium in DEPS to 078bc6d796334fb403acd8975b99d1c8ecd028e8
* chore: bump chromium in DEPS to d96e9f16ae852ec9dbd15bf17df3d440402413bb
* update patches
* chore: update patches
* Use ExtensionSystem::is_ready() instead of ExtensionService::is_ready()
https://chromium-review.googlesource.com/c/chromium/src/+/2207499
* Remove WebImeTextSpan
https://chromium-review.googlesource.com/c/chromium/src/+/2225240
* Remove PDFAnnotations flag altogether.
https://chromium-review.googlesource.com/c/chromium/src/+/2229317
* Rework find-from-selection so it's synchronous -- fixes flaky tests
https://chromium-review.googlesource.com/c/chromium/src/+/2181570
* fixup! Revert "[printing] Mojofy PrintHostMsg_CheckForCancel"
* chore: bump chromium in DEPS to a8a280835830c65145ed8573a9a09f36d3920418
* update sysroots
* update patches
* update patches
* Take RFH as a parameter for DidUpdateFavicon/ManifestURL
https://chromium-review.googlesource.com/c/chromium/src/+/2224745
* chore: bump chromium in DEPS to b6149cb5a5e32caf8eab67b97ef3072b72521ca8
* Update patches
* Rename net::cookie_util::StripStatuses to StripAccessResults
https://chromium-review.googlesource.com/c/chromium/src/+/2212697
* use net::CookieAccessResultList instead of net::CookieAccessResultList
* fix mas_no_private_api patch
https://chromium-review.googlesource.com/c/chromium/src/+/2230281
* chore: bump chromium in DEPS to a27feee1643d952e48f77c92d8c03aedea14b720
* update patches
* fix: add new navigation state REUSE_SITE_INSTANCE
To fix the new set of state checks added in
https://chromium-review.googlesource.com/c/chromium/src/+/2215141
* chore: bump chromium in DEPS to ff4559a4c13d20888202474e4ab9917dbdad8a9a
* update patches
* Cleanup usages of old mojo types and remove unused code
https://chromium-review.googlesource.com/c/chromium/src/+/2235699
* chore: bump chromium in DEPS to 05279845f76eb22900a8b0d1a11d4fd339a8e53b
* chore: bump chromium in DEPS to 821558279767cffec90e3b5b947865f90089fed3
* chore: bump chromium in DEPS to 1aef04e6486be337d3dd820b2d64d6320a1b9c13
* chore: bump chromium in DEPS to dc86386e8fdd796a0f7577e91e42a7f8b7e9bc78
* chore: bump chromium in DEPS to 64f2360794f14643764092ba3e58e2ed8f9fee12
* chore: update patches
* refactor: MessageLoop, you are terminated \o/
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2246173
* refactor: plumb DownloadSchedule to DownloadItem
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2242202
* chore: fix variable typo in IPC
* chore: s/BindPipeAndPassReceiver/BindNewPipeAndPassReceiver
* chore: update patches
* chore: XEvent becomes x11::Event
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2240355
* fixup! refactor: MessageLoop, you are terminated \o/
* fixup! chore: XEvent becomes x11::Event
* build: update v8 headers
* chore: fix windows build
* chore: disable SameSite-by-default changes
https://chromium-review.googlesource.com/c/chromium/src/+/2231445
* update printing.patch
* chore: bump chromium DEPS to 9ae03ef8f7d4f6ac663f725bcfe70311987652f3
* Convert WidgetHostMsg_SelectionBoundsChanged/TextInputStateChanged
https://chromium-review.googlesource.com/c/chromium/src/+/2243531
* chore: update v8 patches
* [XProto] Replace usages of XID and ::Window with x11::Window
https://chromium-review.googlesource.com/c/chromium/src/+/2249389
* Update VideoFrameMetadata to use base::Optionals
https://chromium-review.googlesource.com/c/chromium/src/+/2231706
https://chromium-review.googlesource.com/c/chromium/src/+/2238361
* --disable-dev-shm-usage for gpu process crash
* [v8] Allow for 4GB TypedArrays
https://chromium-review.googlesource.com/c/v8/v8/+/2249668
* update lib_src_switch_buffer_kmaxlength_to_size_t.patch
* disable app.getGPUInfo spec on linux
* update patches
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-06-22 10:35:10 -07:00
Electron Bot
b665eb6d43
chore: bump node to v12.18.0 (master) ( #23789 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2020-06-17 15:57:12 -07:00
Robo
7cc780d077
fix: let Node.js perform microtask checkpoint in the main process ( #24131 )
...
* fix: let Node.js perform microtask checkpoint in the main process
* fix: don't specify v8::MicrotasksScope for explicit policy
* fix: remove checkpoint from some call-sites
We already perform checkpoint at the end of a task,
either through MicrotaskRunner or through NodeBindings.
There isn't a need to add them again when calling into JS
except when dealing with promises.
* fix: remove checkpoint from some call-sites
We already perform checkpoint at the end of a task,
either through MicrotaskRunner or through NodeBindings.
There isn't a need to add them again when calling into JS
except when dealing with promises.
* fix incorrect specs
* default constructor arguments are considered for explicit mark
* add regression spec
2020-06-17 10:08:10 -07:00
Milan Burda
cb6476fd12
chore: cleanup unused WebContents::DereferenceRemoteJSObject() ( #24167 )
2020-06-17 16:50:21 +02:00
Jeremy Rose
e1e73fa5f5
refactor: use WeakRef on main process side of remote ( #24115 )
2020-06-16 14:34:08 -07:00
Samuel Attard
7bf0af7d96
Revert "build: remove dead symlink from MAS build ( #23831 )" ( #24146 )
...
This reverts commit 7a216a8fab
.
2020-06-15 23:42:18 -07:00
Samuel Attard
7a216a8fab
build: remove dead symlink from MAS build ( #23831 )
...
* build: remove dead symlink from MAS build
* chore: new out cache
* fix gn check errors
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2020-06-16 14:25:21 +09:00
Jeremy Rose
c0182bca15
chore: remove test usages of createIDWeakMap ( #24116 )
2020-06-15 13:56:51 -07:00
Jeremy Rose
379bb174e9
refactor: use WeakRef on renderer side of remote ( #24037 )
2020-06-12 15:50:03 -07:00
Jeremy Rose
78fe545d18
refactor: remove renderer-side refcount in remote ( #24054 )
2020-06-11 10:22:28 -07:00
Paul Frazee
c6c022dc46
feat: add {stream} opt to custom protocol registry to configure media player ( #22955 )
2020-06-08 09:49:36 -07:00
Shelley Vohr
27d629abb9
fix: add missing isComposing KeyboardEvent property ( #23971 )
2020-06-05 15:18:20 -07:00
Robo
512e1541c6
fix: default to NTLM v2 in the network service for POSIX platforms ( #23846 )
...
* fix: default to NTLM v2 in the network service
* chore: update patch details
2020-06-02 12:58:00 -07:00
Cheng Zhao
aa8d81511f
fix: MakeAbsoluteFilePath is a blocking call ( #23840 )
2020-05-30 10:01:55 -07:00
Cheng Zhao
ca6a415626
fix: pass correct buffer length ( #23785 )
2020-05-27 10:50:01 -07:00
Electron Bot
dc72f74020
chore: bump chromium to 580fe983e138952553cd6af11ee8b (master) ( #23379 )
...
* chore: bump chromium in DEPS to 5ce64b91b4d6a78c97480059f15ff6469fc0918e
* chore: bump chromium in DEPS to e74c73d0000f81b3f40a513176c8d024bba57d28
* chore: bump chromium in DEPS to 501640e650d4657ba63db65fa257e4a899168de7
* chore: bump chromium in DEPS to 00db20e1bc3d77706723a87ada3c1c647a1c37b7
* chore: update patches
* refactor: AddNewContents now takes a target_url
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2167732
* chore: SetHostCleanupFinalizationGroupCallback has been removed from V8
* refactor: use WebInputEvent::Namespace types directly
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2160523
* refactor: FollowRedirect takes in cors exempt headers now
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2129787
* refactor: printing::DuplexMode moved to mojo
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2162388
* refactor: use MessagePortDescriptor instead of raw mojo::MessagePipeHandles
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1952124
* chore: update patches
* chore: bump chromium in DEPS to f1537676d613f3567cfb43adf577b3847fba4bc3
* chore: update patches
* refactor: service_manager::BinderMapWithContext merged into mojo::BinderMap
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2174654
* chore: unused argument removed from ReadAvailableTypes in ui::Clipboard
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2173666
* chore: bump chromium in DEPS to 949888433ab935dd6125c107226a4c9d6da9bf48
* chore: update patches
* update patches
* chore: update sysroots
* chore: bump chromium in DEPS to eaac5b5035fe189b6706e1637122e37134206059
* chore: bump chromium in DEPS to 258b54b903d33dab963adf59016691e6537f8b70
* build: update patches
* refactor: cursor.mojom and cursor_types.mojom moved to //ui/base/cursor/mojom
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2172874
* chore: DesktopWindowTreeHostLinux becomes DesktopWindowTreeHostPlatform
Refs:
* refactor: LogErrorEventDescription moved from ui to x11
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2164245
* chore: update patches
* chore: bump chromium in DEPS to bd06abcfe807d4461683479237cdd920dafa52ca
* chore: bump chromium in DEPS to 1afb0891e56f1e79d204db43ca053a46d0974511
* chore: bump chromium in DEPS to 5cb0f794bf7f155bf8c0a241b94e01c9d90c2744
* chore: bump chromium in DEPS to 37327ba3303234e1a3cd3310ca11a68e81b95123
* update patches
* remove ClientSideDetectionService from browser_process
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2175320
* refactor: shuttle cursor changed event to WebContentsObserver
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2172779
* chore: bump chromium in DEPS to 1d97904bb6936e106df13705208b73e47367c2b9
* avoid IPC crash introduced earlier in the roll
Refs: b67334e781 (diff-607f4e8f7c5686aa09af98c783925babR128)
* remove WebContentsView::SizeContents
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2188931
* chore: bump chromium in DEPS to 87066d1db0546a9de33952ba964e1e42f76f1dae
* update patches
* adapt to //content creating NetworkContexts
https://chromium-review.googlesource.com/c/chromium/src/+/2195196
* WIP temporarily ignore mojo-ified PrintHostMsg_PrintPreviewFailed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2195343
* add checkout_pgo_profiles to DEPS
* chore: bump chromium in DEPS to a095318bec1dedf580d676f408eaeefdbd9956b1
* add blink's execution_context to electron_lib deps
Refs:
b67334e781
#, https://chromium-review.googlesource.com/c/chromium/src/+/1952124
* update patches
* update patches
* refactor: use newly mojo-ified PrintPreviewFailed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2195343
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: update patches
* chore: remove NOTIFICATION_EXTENSIONS_READY_DEPRECATED
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2199874
* avoid a call to Profile::FromBrowserContext in printing
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2195757
* chore: bump chromium in DEPS to 8f5c6a46861a991e12ffd80554b6bd41a11b0b65
* chore: bump chromium in DEPS to ab66134739ff3b6bdb8de53bbc58a97d1b7b5d8a
* chore: bump chromium in DEPS to dd08df9f6c8d6198f0a7b931ca9e845e27dae033
* chore: update patches
* [printing] Mojofy PrintHostMsg_PrintPreviewCancelled
https://chromium-review.googlesource.com/c/chromium/src/+/2198331
* [printing] Mojofy PrintHostMsg_PrintPreviewInvalidPrinterSettings
https://chromium-review.googlesource.com/c/chromium/src/+/2200556
* [printing] Mojofy PrintHostMsg_DidPrepareDocumentForPreview
https://chromium-review.googlesource.com/c/chromium/src/+/2201496
* fix: inherit base network context params
* fix: use message handle api specific to embedders
* update patches
* chore: update v8 headers
* fixup! avoid a call to Profile::FromBrowserContext in printing
* chore: bump chromium in DEPS to f198bc3276828d992b6202d75a9da6a8363164ea
* chore: update patches
* Remove cors_exempt_headers.h
https://chromium-review.googlesource.com/c/chromium/src/+/2203759
* Supply speech recognition sandbox from service_sandbox_type.h
https://chromium-review.googlesource.com/c/chromium/src/+/2206918
* [content] Remove unused methods from WebContents
https://chromium-review.googlesource.com/c/chromium/src/+/2199113
* [XProto] Replace XAtom with x11::Atom
https://chromium-review.googlesource.com/c/chromium/src/+/2202789
* chore: bump chromium in DEPS to 5df37fabaaed09f3ea511f4ef49203d8ebee7b68
* [UI] Support secondary labels in dropdown menus
https://chromium-review.googlesource.com/c/chromium/src/+/2208976
* chore: update patches
* refactor: GetSublabelAt => GetSecondaryLabelAt
* Revert "[printing] Mojofy PrintHostMsg_DidPrepareDocumentForPreview"
This reverts commit 44ed0892a0c81716229638f17253bbb2cf8f037d.
https://chromium-review.googlesource.com/c/chromium/src/+/2208778
* Unnest CanonicalCookie::CookieInclusionStatus
https://chromium-review.googlesource.com/c/chromium/src/+/2203171
* update print-to-pdf.html with latest html data
https://bugs.chromium.org/p/chromium/issues/detail?id=1085667
* chore: bump chromium in DEPS to 5dfa8d5f706580fe983e138952553cd6af11ee8b
* fix crash in x server when setting window icon
* chore: update patches
* Use a normal return value for WebContentsView::GetContainerBounds.
https://chromium-review.googlesource.com/c/chromium/src/+/2212481
* fix build on windows
* chore: bump chromium in DEPS to 9d15054f4cba060901e43deecf74002f11f47be3
* chore: update patches
* [printing] Mojofy PrintHostMsg_CheckForCancel
https://chromium-review.googlesource.com/c/chromium/src/+/2212181
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2020-05-26 13:06:26 -07:00
Cheng Zhao
08f288faf1
test: use WebContents event to test beforeunload ( #23699 )
2020-05-26 09:21:38 -04:00
Jeremy Apthorp
0a481242f0
fix: wrap EmitWarning with HandleScope ( #23667 )
2020-05-20 09:44:27 -07:00
Shelley Vohr
ee0f67d541
fix: nativeImage remote serialization ( #23543 )
...
We weren't serializing nativeImages properly in the remote module, leading to gin conversion errors when trying to, for example, create a new context menu in the renderer with icons using nativeImage. This fixes that by adding a new special case to handle them.
2020-05-18 09:29:24 -07:00
Shelley Vohr
75fd9a3496
refactor: improve MoveItemToTrash error description ( #23589 )
2020-05-17 19:18:34 -07:00
Samuel Attard
9d7ba98209
refactor: remove the RenderFrameFunctionStore and use privates to memory manage ( #23592 )
2020-05-15 11:57:40 -07:00
Milan Burda
54b6c06062
fix: expose v8util.createIDWeakMap() regardless of enable_remote_module ( #23546 )
2020-05-13 12:10:03 +02:00
Felix Rieseberg
dcbed18f44
feat: app.getPath('recent') ( #23381 )
...
* feat: getPath("recent")
* test: Add a spec and docs
* fix: Integrate feedback
* fix: Handle path change
* chore: Cut SetRecentPath
2020-05-13 11:27:56 +09:00
Milan Burda
ef176ce368
build: fix building with enable_remote_module = false ( #23499 )
2020-05-12 18:32:04 +02:00
Shelley Vohr
6114518463
fix: NSImageName string conversion ( #23467 )
2020-05-11 10:24:45 +09:00
Milan Burda
392ea320cf
build: allow use of BUILDFLAG directives from within JS code ( #20328 )
2020-05-11 01:06:07 +02:00
Jeremy Apthorp
06bf0d08dc
fix: crashReporter incompatible with sandbox on Linux ( #23265 )
2020-05-07 13:31:26 -07:00
Robo
a707a3eda3
feat: add enableWebSQL webpreference ( #23311 )
...
* feat: add enableWebSQL webpreference
* chore: update indexedDB test
2020-05-06 12:52:59 -07:00
Sorah Fukumori
f176d2494f
fix: respect system language preferences on Win/macOS ( #23247 )
...
This commit fixes https://github.com/electron/electron/issues/18829
Previously the full preferences set to OS was not given to Chromium.
Also, this commit improves fallback font selection for CJK text.
Chromium uses browser languages to determine fallback fonts on Windows,
especially kanji/han characters in CJK.
For instance, when user sets 'en-US, ja-JP' to Accept-Language,
while Chromium chooses Japanese font for kanji text, but Electron
chooses Chinese font. This is because only the first language was given
to Accept-Language on Electron.
This patch is based on https://github.com/electron/electron/pull/15532
Co-authored-by: Nitish Sakhawalkar <nitsakh@icloud.com>
Co-authored-by: Kasumi Hanazuki <kasumi@rollingapple.net>
Co-authored-by: Nitish Sakhawalkar <nitsakh@icloud.com>
Co-authored-by: Kasumi Hanazuki <kasumi@rollingapple.net>
2020-05-04 10:49:29 -07:00
Electron Bot
8edc7a1fb1
chore: bump chromium to 0f4170320ff37e971064916aed1dc (master) ( #23285 )
...
* chore: bump chromium in DEPS to 53836640273c3d45b05ad74bdff7323ef0ffc610
* chore: bump chromium in DEPS to 17da1064b910f4170320ff37e971064916aed1dc
* Rename attach_same_site_cookies param to force_ignore_site_for_cookies
https://chromium-review.googlesource.com/c/chromium/src/+/2162209
* chore: update patch indices
* Remove single argument HttpResponseHeaders::AddHeader() method
https://chromium-review.googlesource.com/c/chromium/src/+/2155353
* Rename attach_same_site_cookies param to force_ignore_site_for_cookies
https://chromium-review.googlesource.com/c/chromium/src/+/2162209
* fixup! Remove single argument HttpResponseHeaders::AddHeader() method
* Exchange SandboxType::kInvalid for a CHECK.
https://chromium-review.googlesource.com/c/chromium/src/+/2167995
* chore: fix string type on windows
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2020-04-30 13:20:44 -07:00
Robo
ec7942e8b5
fix: build when some buildflags are disabled ( #23307 )
2020-04-28 23:16:10 -07:00
shelley vohr
6a564af580
refactor: use Node.js isolate setup in node mode ( #23213 )
2020-04-28 09:10:27 -07:00
shelley vohr
979c291847
fix: isolate callbacks in node_bindings ( #23261 )
...
* fix: isolate callbacks in node_bindings
* clarify microtask policy comment
2020-04-27 17:03:40 +09:00
Sorah Fukumori
6ab317cc83
style: use build/include_directory for NOLINT ( #23266 )
...
build/include linter was splitted to build/include_directory at
depot_tools upstream.
https://crrev.com/c/2159690
https://crbug.com/1073191
2020-04-24 12:57:41 -07:00
Jeremy Apthorp
e65cac6ae8
refactor: remove extra args from crashreporter init ( #23144 )
2020-04-20 14:44:09 -07:00
Jeremy Apthorp
aeaccd00a2
feat: crashReporter: expose rateLimit and compress options ( #23062 )
2020-04-14 10:36:31 -07:00
Electron Bot
3e8d77d564
chore: bump chromium to 98ebf6c3f0b7bd96bdb1a4b42208f (master) ( #22999 )
...
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-04-13 16:39:26 -07:00
Jeremy Apthorp
0a78ab4b98
refactor: ginify DownloadItem ( #22924 )
2020-04-02 17:22:46 -07:00
Jeremy Apthorp
6159066c26
refactor: ginify Menu ( #22916 )
2020-04-02 16:07:56 -07:00
Jeremy Apthorp
a3e28788ce
refactor: ginify Tray ( #22822 )
...
* refactor: ginify Tray
* lint
* improve argument parsing logic
* remove redundant imports from tray.js
* new Tray produces an instanceof Tray
* make Constructible generic
* lint
* clean up on exit
2020-03-30 10:32:02 +09:00
Cheng Zhao
76ae3b7ecb
chore: remove unused classes of views API ( #22861 )
...
* chore: remove unused views API classes
* chore: remove LayoutManager code
* chore: no more need to make View inherit from TrackabeObject
* chore: make enable_view_api default to true
* chore: enable_view_api => enable_views_api
2020-03-28 15:44:57 +09:00
Jeremy Apthorp
07cd70a37e
refactor: ginify powerMonitor ( #22751 )
2020-03-24 09:03:29 -07:00
Cheng Zhao
341f643b81
feat: add ImageView ( #22738 )
2020-03-22 19:11:43 +09:00
Jeremy Apthorp
07a049ef1b
chore: stop leaking v8 environment ( #22761 )
2020-03-20 14:15:55 -07:00
Jeremy Apthorp
a824e12275
refactor: ginify desktopCapturer ( #22746 )
2020-03-19 11:35:11 -07:00
Samuel Attard
f3fd40c221
fix: prevent crash in ListValue v8 converter when conversion fails ( #22753 )
2020-03-18 13:59:34 -07:00
Jeremy Apthorp
232ca8af39
refactor: EventEmitters without gin_helper ( #22726 )
2020-03-18 12:57:08 -07:00
Shelley Vohr
674e4a9fdd
chore: more modules to dual prop/fn support ( #22688 )
2020-03-17 18:06:52 -07:00
Cheng Zhao
7814c67830
fix: enter handle scope when creating custom event ( #22657 )
2020-03-16 14:20:32 +09:00