d4a1b41129
* fix: microtasks policy in CreateEnvironment Microtasks policy should not be updated for the renderer because `NodeBindings::CreateEnvironment` might be entered with or without `UvRunOnce()` on stack. One of the examples of such calls is `window.open()` which is possible to invoke while `uv_run()` is still running (e.g. with `setImmediate()`). All in all, it doesn't matter that much which policy we use since `v8::MicrotasksScope` has a check for the policy in its destructor and no commits will be made if the policy is `kExplicit`. It is important, however, to not change the policy in the middle of `UvRunOnce()` so we should respect whatever we currently have and move on. Fix: #29463 * Move test to a better place * Update spec-main/fixtures/crash-cases/setimmediate-window-open-crash/index.html Co-authored-by: Jeremy Rose <nornagon@nornagon.net> * Update spec-main/fixtures/crash-cases/setimmediate-window-open-crash/index.html Co-authored-by: Jeremy Rose <nornagon@nornagon.net> * simplify crash-case * comment * fix comment Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com> Co-authored-by: Jeremy Rose <nornagon@nornagon.net> Co-authored-by: Fedor Indutny <indutny@signal.org> |
||
---|---|---|
.. | ||
api | ||
asar | ||
extensions | ||
gin_converters | ||
gin_helper | ||
mac | ||
resources/mac | ||
application_info.cc | ||
application_info.h | ||
application_info_linux.cc | ||
application_info_mac.mm | ||
application_info_win.cc | ||
color_util.cc | ||
color_util.h | ||
crash_keys.cc | ||
crash_keys.h | ||
electron_command_line.cc | ||
electron_command_line.h | ||
electron_constants.cc | ||
electron_constants.h | ||
electron_paths.h | ||
heap_snapshot.cc | ||
heap_snapshot.h | ||
key_weak_map.h | ||
keyboard_util.cc | ||
keyboard_util.h | ||
language_util.h | ||
language_util_linux.cc | ||
language_util_mac.mm | ||
language_util_win.cc | ||
logging.cc | ||
logging.h | ||
mouse_util.cc | ||
mouse_util.h | ||
node_bindings.cc | ||
node_bindings.h | ||
node_bindings_linux.cc | ||
node_bindings_linux.h | ||
node_bindings_mac.cc | ||
node_bindings_mac.h | ||
node_bindings_win.cc | ||
node_bindings_win.h | ||
node_includes.h | ||
node_util.cc | ||
node_util.h | ||
options_switches.cc | ||
options_switches.h | ||
platform_util.cc | ||
platform_util.h | ||
platform_util_internal.h | ||
platform_util_linux.cc | ||
platform_util_mac.mm | ||
platform_util_win.cc | ||
process_util.cc | ||
process_util.h | ||
skia_util.cc | ||
skia_util.h | ||
v8_value_converter.cc | ||
v8_value_converter.h | ||
v8_value_serializer.cc | ||
v8_value_serializer.h | ||
world_ids.h |