mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: cleanup unused WebContents::DereferenceRemoteJSObject() (#24167)

Browse source
This commit is contained in:
Milan Burda 2020-06-17 16:50:21 +02:00 committed by GitHub
parent e1e73fa5f5
commit cb6476fd12
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
shell/browser/api/electron_api_web_contents.cc
View file

@ -1226,18 +1226,6 @@ void WebContents::MessageHost(const std::string& channel,
InvokeCallback(), channel, std::move(arguments));
}
#if BUILDFLAG(ENABLE_REMOTE_MODULE)
void WebContents::DereferenceRemoteJSObject(const std::string& context_id,
int object_id) {
base::ListValue args;
args.Append(context_id);
args.Append(object_id);
EmitWithSender("-ipc-message", bindings_.dispatch_context(), InvokeCallback(),
/* internal */ true, "ELECTRON_BROWSER_DEREFERENCE",
std::move(args));
}
#endif
void WebContents::UpdateDraggableRegions(
std::vector<mojom::DraggableRegionPtr> regions) {
for (ExtendedWebContentsObserver& observer : observers_)

4
shell/browser/api/electron_api_web_contents.h
View file

@ -597,10 +597,6 @@ class WebContents : public gin_helper::TrackableObject<WebContents>,
blink::CloneableMessage arguments) override;
void MessageHost(const std::string& channel,
blink::CloneableMessage arguments) override;
#if BUILDFLAG(ENABLE_REMOTE_MODULE)
void DereferenceRemoteJSObject(const std::string& context_id,
int object_id) override;
#endif
void UpdateDraggableRegions(
std::vector<mojom::DraggableRegionPtr> regions) override;
void SetTemporaryZoomLevel(double level) override;

7
shell/common/api/api.mojom
View file

@ -72,13 +72,6 @@ interface ElectronBrowser {
string channel,
blink.mojom.CloneableMessage arguments);
// This is an API specific to the "remote" module, and will ultimately be
// replaced by generic IPC once WeakRef is generally available.
[EnableIf=enable_remote_module]
DereferenceRemoteJSObject(
string context_id,
int32 object_id);
UpdateDraggableRegions(
array<DraggableRegion> regions);