Ben Gotow
e96e674201
Properly clean up NSEvent monitor
2016-01-21 16:31:31 -08:00
Ben Gotow
d492ff45d5
Rename up/down => begin/end
2016-01-21 16:31:09 -08:00
Ben Gotow
bd2252ea55
Extend NativeWindow to track touch-based scroll events on OS X
...
In N1, we want to implement the famous "swipe to archive" action on threads in the user's inbox. Chrome exposes `scroll` and `wheel` events, but these aren't sufficient to implement the interaction because the element needs to "snap" when the user lifts their fingers from the trackpad, not when they / we stop receiving `wheel` / `scroll` events. These events may stop before the user lifts their fingers, or continue after the user has lifted their fingers if they had enough momentum for the gesture to continue.
This exposes BrowserWindow `scroll-touch-down` and `scroll-touch-up`, which fire immeditaely when the user touches two fingers to the trackpad, and again when the user lifts their fingers. Combined with the existing wheel event should allow for "swipe-to-archive" and other similar interactions.
Note: This is only implemented on Mac OS X and the events don't fire unless you're using a trackpad!
Related: #1486 , #2683 , https://github.com/nylas/N1/issues/541
2016-01-21 09:40:21 -08:00
Kevin Sawicki
fda480d1aa
Merge pull request #4172 from atom/enable-eslint-rules
...
Enable more eslint rules
2016-01-21 09:56:07 -07:00
Kevin Sawicki
3a55647ae3
Add WebView to globals
2016-01-21 09:32:22 -07:00
Kevin Sawicki
b46d8ec91b
Enable no-undef eslint rule
2016-01-21 09:32:22 -07:00
Kevin Sawicki
e9b3a51703
Add missing fs require
2016-01-21 09:32:22 -07:00
Kevin Sawicki
669b815758
Add missing semicolons
2016-01-21 09:32:22 -07:00
Kevin Sawicki
b5cf352312
Add globals to eslint config
2016-01-21 09:32:22 -07:00
Kevin Sawicki
b399455808
Run cpplint from lint npm script
2016-01-21 09:32:21 -07:00
Kevin Sawicki
16b4b58de1
e -> error
2016-01-21 09:32:21 -07:00
Kevin Sawicki
b1f679ff6d
Clean up semicolon lint errors
2016-01-21 09:32:21 -07:00
Kevin Sawicki
70bcb0ac5a
Clean up no-unused-vars lint errors
2016-01-21 09:32:21 -07:00
Kevin Sawicki
ccce284a5b
Clean up no-empty lint errors
2016-01-21 09:32:21 -07:00
Kevin Sawicki
4f4456bde8
Clean up indent eslint errors
2016-01-21 09:32:21 -07:00
Kevin Sawicki
45ddbb6d67
Clean up no-unreachable lint errors
2016-01-21 09:32:21 -07:00
Kevin Sawicki
fbfbf2158a
Add npm run lint script
2016-01-21 09:32:21 -07:00
Cheng Zhao
2e8a2c3a7f
Merge pull request #4170 from arniu/patch-1
...
Update coding-style.md
2016-01-20 15:47:32 -07:00
Cheng Zhao
2fba39d719
Merge pull request #4166 from ragingwind/patch-1
...
Add Korean community
2016-01-20 15:34:31 -07:00
Cheng Zhao
40557083f0
Merge pull request #4164 from deepak1556/menu_toggle_crash_patch
...
browser: fix crash when switching to sibling menu from submenus
2016-01-20 15:32:53 -07:00
Cheng Zhao
ee2d2cc532
Merge pull request #4165 from yamatoya/master
...
Add Japanes translated docs.
2016-01-20 15:28:17 -07:00
Kevin Sawicki
cac8466fb1
Merge pull request #4168 from atom/cpplint-utility-folder
...
Run cpplint on utility folder
2016-01-20 10:00:50 -07:00
Cheng Zhao
5bd2d4b08d
docs: win.destroy() is safe
2016-01-20 09:46:38 -07:00
Kevin Sawicki
8140adb6bc
Remove trailing whitespace
2016-01-20 09:43:32 -07:00
Kevin Sawicki
5d249e2a94
Run cpplint on utility folder
2016-01-20 09:43:32 -07:00
Cheng Zhao
54b5369215
Merge pull request #4158 from atom/desktop-capturer-error-message
...
Fix error calling desktopCapturer.getSources twice
2016-01-20 09:42:51 -07:00
Hailin Tseng
f1ef24b359
Update coding-style.md
2016-01-21 00:03:41 +08:00
Jimmy Moon
9a82c5a1c0
Add Korean community
2016-01-20 19:05:35 +09:00
Takahito Yamatoya
a874abd5a8
Add Japanes translated docs.
2016-01-20 16:09:01 +09:00
Robo
65325dc63f
browser: fix crash when switching to sibling menu from submenus
2016-01-20 10:54:12 +05:30
Cheng Zhao
af3def91f2
Merge pull request #4146 from yamatoya/master
...
Add Japanes translated docs.
2016-01-19 12:12:41 -08:00
Kevin Sawicki
b014eea8d3
Tweak spec description
2016-01-19 11:05:57 -08:00
Kevin Sawicki
517dce443b
Remove unused errorMessage reference
2016-01-19 11:02:12 -08:00
Kevin Sawicki
c719b252cb
Add failing spec
2016-01-19 10:57:18 -08:00
Kevin Sawicki
fb3ab9e1f1
Use const and remove extra returns
2016-01-19 10:54:12 -08:00
Kevin Sawicki
01e1d0dfef
Merge pull request #4153 from sunaiwen/patch-1
...
Update debugging-main-process.md
2016-01-19 10:12:26 -08:00
Kevin Sawicki
d3186a9665
Merge pull request #4150 from hamxiaoz/patch-1
...
Fix a broken link
2016-01-19 10:10:17 -08:00
Takahito Yamatoya
140bc4effc
Add Japanes translated docs.
2016-01-19 17:23:17 +09:00
Niven Su
b9c9da3f4e
Update debugging-main-process.md
...
fix doc typo
2016-01-19 13:49:49 +08:00
Andrew Zheng
b4aaaed843
Fix a broken link
...
The reference-style link uses a relative path, which doesn't work well on the main site http://electron.atom.io/ .
2016-01-18 13:50:33 -08:00
Takahito Yamatoya
fc42e97144
Add Japanes translated docs.
2016-01-18 23:38:44 +09:00
Cheng Zhao
7842a657d0
Merge pull request #4142 from Rokt33r/patch-2
...
Update frameless-window.md
2016-01-18 18:33:03 +08:00
Dick Choi
2907c4f068
Update frameless-window.md
...
`-title-bar-style` => `titleBarStyle“
https://github.com/atom/electron/blob/master/docs/api/browser-window.md#class-browserwindow
2016-01-18 18:35:14 +09:00
Cheng Zhao
307add22b2
Merge pull request #4138 from yamatoya/master
...
Add Japanes translated docs.
2016-01-18 15:37:07 +08:00
Takahito Yamatoya
def1477466
Add Japanes translated docs.
2016-01-18 01:00:28 +09:00
Cheng Zhao
40a93f1374
Merge pull request #4135 from atom/add-npm-start
...
Add npm start script
2016-01-17 14:33:28 +08:00
Kevin Sawicki
4e183df997
Add npm start script
2016-01-16 12:31:09 -08:00
Cheng Zhao
6f1fe2e478
Merge pull request #4133 from yamatoya/master
...
Update Japanese translated docs.
2016-01-17 00:11:52 +08:00
Takahito Yamatoya
6ecacd18be
Update Japanese translated docs.
2016-01-17 01:02:02 +09:00
Cheng Zhao
3b62ce7fa6
modules.exports => module.exports
2016-01-16 14:26:01 +08:00
