Jeremy Apthorp
418c4e170c
chore: [gn] only define WIN32_LEAN_AND_MEAN if not already defined ( #13430 )
...
Chromium's GN build already defines `WIN32_LEAN_AND_MEAN` and `NOMINMAX` (see [build/config/win/BUILD.gn](dbe762aaff/build/config/win/BUILD.gn (515)
2018-06-26 02:00:50 +02:00
Jeremy Apthorp
43c1a7778d
chore: fix chromium-style errors in windows code
2018-06-21 16:50:58 -07:00
Shelley Vohr
49c8c31220
format previously misses .cc files
2018-04-17 21:56:12 -04:00
Shelley Vohr
284aca68c0
clang-format brightray
2018-04-17 21:46:27 -04:00
Aleš Pergl
efb44050db
Enable official build ( #11847 )
...
* Updated libchromiumcontent submodule
* Use same LTO settings as libcc
* Use whole program optimization, favour speed, remove redundancies
* Don't use variable template as it confuses LTCG
* Use lld and ThinLTO only on limited set of architectures
2018-02-08 13:26:23 -06:00
Samuel Attard
9676c0a4f9
Fix build and ensure no breaking change
2018-02-05 17:29:59 +09:00
Samuel Attard
87c2f0f14f
Fix build and ensure no breaking change
2018-02-05 17:29:59 +09:00
Samuel Attard
5f7a173d1d
Add missing header import
2018-02-05 17:29:59 +09:00
Samuel Attard
72464a6db5
Fix implicit appUserModelId set
2018-02-05 17:29:59 +09:00
Cheng Zhao
0cce6b3d21
Fix cpplint warning
2018-01-03 17:32:18 +09:00
Cheng Zhao
d6068759b6
win: Fix assertion when creating Notification
2018-01-03 17:25:19 +09:00
Felix Rieseberg
75cdd9ec70
🔧 Linter's gotta lint
2017-12-13 16:31:02 -08:00
Felix Rieseberg
8a8aaaf16c
🔧 Allow notifications debugging (Windows)
2017-12-13 16:25:49 -08:00
Samuel Attard
ef40bd4786
Remove dead header file for notification delegate
2017-11-24 10:58:17 +09:00
Aleksei Kuzmin
ea8e113b19
SkBitmap and SkPixelRef no longer need lock/unlock
...
https://codereview.chromium.org/2823003002
2017-11-24 10:58:16 +09:00
Ales Pergl
1d25d58c26
Fixed font DPI scaling
2017-10-09 10:17:00 +02:00
Cheng Zhao
91e11f8e6f
Merge pull request #10609 from electron/win32_toast_update
...
Fix for narrowing conversion warnings, minor style change
2017-09-26 10:50:45 +09:00
Felix Rieseberg
741dc1eb0b
🔧 Ensure correct path
2017-09-25 13:51:16 -07:00
Ales Pergl
75feb495ad
Fix for narrowing conversion warnings, minor style change
2017-09-25 18:08:54 +02:00
Yuya Ochiai
d621471eb2
🏁 Set duration for Windows 7 notifications based on Control Panel
2017-09-22 21:28:29 +09:00
Ales Pergl
af92a639be
Fixed potential crash in Win32 notifications.
2017-09-14 11:52:53 +02:00
Samuel Attard
7eb14243eb
Refactor notification options
2017-06-24 21:39:06 +10:00
Samuel Attard
4f0d48f164
Add support for notification actions on macOS
2017-06-23 20:50:20 +10:00
Samuel Attard
686b1388b1
Fix linting issues
2017-05-30 19:12:36 +10:00
Samuel Attard
5048425e6e
Update implementation as per feedback
2017-05-30 19:06:51 +10:00
Samuel Attard
058bdfbced
Use NotificationPresenter - macOS
2017-05-29 20:02:33 +10:00
Kevin Sawicki
7e185ef1a3
Remove extra newlines
2017-05-19 08:46:15 -07:00
Kevin Sawicki
d7321ed980
Add brightray prefix to include paths from within brightray
2017-05-19 08:46:15 -07:00
Kevin Sawicki
c4608c0f37
Fix build/include_alpha linter violations in brightray
2017-05-19 08:46:15 -07:00
Kevin Sawicki
f193b2b2a6
Fix build/include_what_you_use linter violations in brightray
2017-05-19 08:46:15 -07:00
Ales Pergl
fbe3b27409
Addressed review feedback
2017-04-05 14:30:17 +02:00
Ales Pergl
f73233ee55
Changed local variable and parameter names to snake case style
2017-04-05 14:30:17 +02:00
Ales Pergl
3336e02769
Address cpplint issue "Constructors callable with one argument should be marked explicit. [runtime/explicit] [5]"
2017-04-05 14:30:17 +02:00
Ales Pergl
1a7d9a5d20
Address cpplint issue "At least two spaces is best between code and comments [whitespace/comments] [2]"
2017-04-05 14:30:17 +02:00
Ales Pergl
bf86718d61
Address cpplint issue "DISALLOW_COPY_AND_ASSIGN should be the last thing in the class [readability/constructors] [3]"
2017-04-05 14:30:16 +02:00
Ales Pergl
161b4e752b
Address cpplint issue "public: should be indented +1 space inside class NotificationPresenterWin7 [whitespace/indent] [3]"
2017-04-05 14:30:16 +02:00
Ales Pergl
9d75e9f54c
Address cpplint issue "Namespace should be terminated with "// namespace brightray" [readability/namespace] [5]"
2017-04-05 14:30:16 +02:00
Ales Pergl
64bf0d210e
Address cpplint issue "An else should appear on the same line as the preceding } [whitespace/newline] [4]"
2017-04-05 14:30:16 +02:00
Ales Pergl
9b7fbd4d22
Address cpplint issue "Using C-style cast. Use reinterpret_cast<BYTE*>(...) instead [readability/casting] [4]"
2017-04-05 14:30:16 +02:00
Ales Pergl
91cff2e6c7
Address cpplint issue "Missing space before ( in if( [whitespace/parens] [5]"
2017-04-05 14:30:16 +02:00
Ales Pergl
29f3332276
Address cpplint issue "{ should almost always be at the end of the previous line [whitespace/braces] [4]"
2017-04-05 14:30:16 +02:00
Ales Pergl
63eeb96e71
Address cpplint issue "Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]"
2017-04-05 14:30:16 +02:00
Ales Pergl
20d0bda538
Address cpplint issue "Found C++ system header after other header. Should be: toast.h, c system, c++ system, other. [build/include_order] [4]"
2017-04-05 14:30:16 +02:00
Ales Pergl
33b4936a68
Address cpplint issue "Include the directory when naming .h files [build/include] [4]"
2017-04-05 14:30:15 +02:00
Ales Pergl
0bba5b9b41
Address cpplint issue "Lines should be <= 80 characters long [whitespace/line_length] [2]"
2017-04-05 14:30:15 +02:00
Ales Pergl
392d606848
Changed member variable naming style to snake case
2017-04-05 14:30:15 +02:00
Ales Pergl
0fa6c82b3f
Use NotificationPresenterWin7 on Windows 7
2017-04-05 14:30:15 +02:00
Ales Pergl
fe05b66a6c
Added desktop notifications implementation for Windows 7 (and earlier)
2017-04-05 14:30:15 +02:00
Ales Pergl
e6a30388da
Make Notification factory function a member of NotificationPresenter so that we can create different types of notifications based on runtime conditions.
2017-04-05 14:30:15 +02:00
Kevin Sawicki
2ece711c2e
Format line length to 80 instead of 100
2017-03-23 15:47:30 -07:00
