mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: [gn] only define WIN32_LEAN_AND_MEAN if not already defined (#13430)

Browse source 
Chromium's GN build already defines `WIN32_LEAN_AND_MEAN` and `NOMINMAX` (see [build/config/win/BUILD.gn](https://chromium.googlesource.com/chromium/src/+/dbe762aaff7e5ec435082d7bf0ac7f06a066774c/build/config/win/BUILD.gn#515) in chrome), so we don't need to define them ourselves. Left as #ifndefs so as not to break the gyp build.
This commit is contained in:
Jeremy Apthorp 2018-06-26 02:00:50 +02:00 • committed by GitHub
commit 418c4e170c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
brightray/browser/win/win32_desktop_notifications/desktop_notification_controller.cc
View file

@ -1,5 +1,9 @@
#ifndef NOMINMAX
#define NOMINMAX
#endif
#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif
#include "brightray/browser/win/win32_desktop_notifications/desktop_notification_controller.h"
#include <windowsx.h>
#include <algorithm>

2
brightray/browser/win/win32_desktop_notifications/toast.cc
View file

@ -1,4 +1,6 @@
#ifndef NOMINMAX
#define NOMINMAX
#endif
#include "brightray/browser/win/win32_desktop_notifications/toast.h"
#include <uxtheme.h>
#include <windowsx.h>

2
brightray/browser/win/win32_notification.cc
View file

@ -1,4 +1,6 @@
#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif
#include "brightray/browser/win/win32_notification.h"