Jeremy Apthorp
3bdff2d238
feat: allow setting window shape ( #13789 )
...
This binds Widget::SetShape, an API that already exists in Chromium (for
Windows and Linux). It's a more reliable method of having some parts of
your window be "click-through" than the current `setIgnoreMouseEvents`
API, which messes around with the `WS_EX_LAYERED` window style on
Windows, causing strange bugs and incompatibility with hardware
acceleration.
2018-07-30 13:37:40 -07:00
Gellert Hegyi
4bcf0e34c5
fix: window.setVibrancy parameter passing ( #13627 )
...
* fix: setVibrancy parameter passing
* fix: uses correct parameter types for setVibrancy
2018-07-30 11:29:18 +10:00
Milan Burda
db38c8b620
Fix process.execPath returning parent process path instead of the helper in sandboxed renderer ( #13839 )
2018-07-30 11:13:42 +10:00
Samuel Attard
4b3011f3e8
feat: add getUploadProgress API to the net API ( #13783 )
2018-07-27 07:15:48 -07:00
Birunthan Mohanathas
c8dc2d3730
feat: Add will-resize event to TopLevelWindow ( #13649 )
...
The new `will-resize` event can be used to prevent the resize from
happening before the native window is actually resized. This is in
contrast to the existing the `resize` event, which is sent *after* the
native window has already been resized. For apps with e.g. custom window
snapping logic, the `resize` event is not sufficient because it will
result in flickering between the dragged size and the snapped size.
`will-resize` is only emitted on macOS and Windows.
2018-07-27 18:53:01 +09:00
Jeremy Apthorp
9af9634f7d
chore: remove unused process_type variable ( #13823 )
2018-07-26 23:25:54 -07:00
Cheng Zhao
ce4e05b85a
fix: pass scrollBounce by command line flag ( #13812 )
...
Implement the scrollBounce option by reading the command line flag in
`RenderThreadImpl::IsElasticOverscrollEnabled`, there is no more need
to set NSScrollViewRubberbanding.
2018-07-26 18:38:37 +09:00
Birunthan Mohanathas
a42ca9eecc
feat: Add BrowserWindow.setWindowButtonVisibility()
...
Fixes #12701 and supersedes #13131 .
Ideally we would have added `setTitleBarStyle()`, but that is a
significantly more involved change. For example, consider the case where
we switch from `hidden` to `normal`. We would not only have to show the
traffic light buttons, we would also have to switch the window from a
frameless to a framed window and deal with various other window state.
Lets instead implement a simple solution for #12701 .
2018-07-25 10:12:27 -07:00
Cheng Zhao
3094f62f0b
fix: use webContentsId with contextId together ( #13749 )
...
After after using `processId-contextCounter` as contextId, it may happen
that contexts in different WebContents sharing the same renderer process
get the same contextId. Using webContentsId as part of key in
ObjectsRegistry can fix this.
2018-07-24 16:21:38 +09:00
Cheng Zhao
305e3aad40
refactor: remove private webContents.getId() API ( #13674 )
2018-07-23 18:08:36 +09:00
Jeremy Apthorp
16b66db9c7
build: [gn] working on 32bit windows
2018-07-19 17:04:44 -07:00
John Kleinschmidt
f8b646c90a
Merge pull request #13543 from electron/ajm-win7-crash
...
Ensure DirectX capturer is supported.
2018-07-19 15:11:42 -04:00
Cheng Zhao
e2029435c4
fix: use context counter as contextId
...
For sandboxed renderer it may not have a node::Environment in the context,
using a increasing counter as contextId works for all cases.
2018-07-19 11:00:10 -07:00
Samuel Attard
777d0113d5
fix: create a window capturer correctly ( #13689 )
...
* fix: create a window capturer correctly
We were incorrectly creating two screen capturers instead of a window
capturer
* spec: ensure dc tests pass
* spec: enable all tests after verifying dc tests work
2018-07-17 14:20:50 +10:00
Shelley Vohr
6045d1218a
refactor: remove experimentalCanvasFeatures property ( #13684 )
2018-07-16 13:32:42 -07:00
Cheng Zhao
4a7c85f43e
fix: use InspectableWebContentsView as content view
2018-07-16 10:20:35 +09:00
John Kleinschmidt
539b554ecc
Merge pull request #13578 from electron/miniak/refactoring
...
refactor: statically link functions available on Windows 7+
2018-07-13 10:52:37 -04:00
Cheng Zhao
77ca5b7d64
fix: don't invoke callback after FrameSubscriber is destroyed ( #13657 )
2018-07-13 19:54:49 +10:00
PalmerAL
ffc15e02a6
fix: add native function to create preload script ( #13032 )
...
* add native function to create preload script
* add tests
* fix formatting
* fix tests
* rerun CI
2018-07-13 11:17:11 +09:00
Milan Burda
5b0a898dd2
refactor: SHOpenFolderAndSelectItems does not have to be dynamically resolved
2018-07-12 22:28:44 +02:00
Milan Burda
adaa32003d
refactor: DwmGetColorizationColor does not have to be dynamically resolved
2018-07-12 22:28:44 +02:00
John Kleinschmidt
e922b1733b
Merge pull request #13636 from nornagon/gn-release
...
build: [gn] release build
2018-07-12 10:45:21 -04:00
Felix Rieseberg
deedf6c3f4
feat: Add isCurrentlyAudible() to WebContents ( #13614 )
...
* 🔧 Add isCurrentlyAudible() to WebContents
* ❤️ Implement feedback, use await to wait for event
* 👷 Add missing imports
2018-07-12 21:35:11 +10:00
Cheng Zhao
4cdb1b8fc3
fix double-freeing remote references
...
After the page does navigations, garbage collection can still happen in
the old context. This commit changes to store references to remote objects
by _pages_, instead of by _WebContents_.
2018-07-12 10:44:26 +09:00
Cheng Zhao
9cbbb2a6c4
add API to return an unique ID for page
2018-07-12 10:44:26 +09:00
Jeremy Apthorp
03131c5e77
build: [gn] node as a static lib
2018-07-11 10:43:52 -07:00
Jeremy Apthorp
bdceea6aca
fix: enable spell checking, which broke in upgrade to ch66
...
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.
Added the first (!) test for spellchecking, too.
Fixes #13608 .
[1]: 03563dd163
2018-07-11 10:27:56 -07:00
John Kleinschmidt
bc2ea0e705
Merge pull request #13540 from electron/breakpad-compat
...
chore: breakpad #include compatibility between GN and GYP
2018-07-10 08:30:56 -04:00
Cheng Zhao
0ec4ad288d
fix: fallback to FullSizeContentView for frameless window on mac ( #13599 )
...
fix: draggable regions not working on macOS
2018-07-10 11:43:42 +10:00
Jeremy Apthorp
810909425e
chore: breakpad #include compatibility between GN and GYP
2018-07-09 16:53:06 -07:00
Andrew MacDonald
7639e4a32a
Actually try building on Windows.
2018-07-03 01:03:05 -07:00
Andrew MacDonald
68541f2ae8
Ensure DirectX capturer is supported.
2018-07-02 21:37:10 -07:00
Hari Juturu
eb223f8bc3
Enable webview in sandbox renderer ( #13435 )
...
* Enable webview in sandbox renderer
Security: Inherit embedder prefs onto webview
* cache lastwebprefs
2018-07-03 02:06:26 +10:00
Maxine Whitely
6cf68f8247
fix: tray setContextMenu crash ( #13513 )
...
Co-authored-by: Zhuo Lu <sethlu@mintkit.net>
Co-authored-by: Kristine Zhang <kzhang@slack-corp.com>
2018-06-29 14:48:26 -07:00
Jeremy Apthorp
3d4487ccfd
Merge pull request #13463 from electron/remove_wtl
...
refactor: Using win32 file open api instead of WTL
2018-06-29 10:00:50 -07:00
Jeremy Apthorp
733e495e91
chore: use full path for ui_unscaled_resources.h ( #13492 )
...
This is the path that resolves in Chromium, it also works fine in the gyp build.
2018-06-28 14:41:37 -07:00
Jeremy Apthorp
d6af3bfcd2
chore: fix more chromium-style errors in windows code ( #13487 )
...
Finding more chromium-style linting errors as I build more of the windows code :)
2018-06-28 14:20:11 -07:00
Shelley Vohr
003a92e099
refactor: remove deprecated GetAs methods ( #13425 )
...
* refactor: remove deprecated GetAs methods
* restructure URLRequestAsyncAsarJob on win
* fix: add string conversion header
2018-06-27 14:52:48 -07:00
Samuel Attard
92588be2bd
refactor: add promise helper and change whenReady to be native impl ( #13115 )
...
* Add promise helper and change whenReady to be native impl
* remove commented code
* add GetInner helper to dedupe promise code
* add Promise.reject helper to be consistent with JS
* fix linting
* update promise impl per feedback
* remove param name from unused isolate
* Use non-depreceated resolvers for promises
* Add thread dchecks for promise helper, intiialize promise pointer to nullptr
2018-06-27 16:06:08 -05:00
Shelley Vohr
e9971173d4
fix: inline vector allocation ( #13449 )
...
* fix: inline vector allocation
* remove size_t static cast
2018-06-27 12:57:10 -07:00
zacwalk
9db76394f7
Link gdi from gyp
2018-06-27 20:58:37 +02:00
Zac Walker
8151c90c6b
Fix warnings as error fixes.
2018-06-27 16:28:12 +02:00
Zac Walker
f122c44b07
Using win32 file open dialogs instead of WTL
2018-06-27 13:09:18 +02:00
Shelley Vohr
1dde9492c9
refactor: remove deprecated CreateWithCopiedBuffer ( #13436 )
...
* refactor: remove deprecated CreateWithCopiedBuffer
* fix: add missing vector includes
* fix std::vector<char> allocation
2018-06-26 15:08:27 -07:00
Jeremy Apthorp
4b60efcaf8
chore: [gn] fix WTL include paths and namespace include ( #13433 )
...
As of libchromiumcontent#576, the WTL namespace isn't included by
default in the GN build.
2018-06-26 22:57:40 +02:00
Jeremy Apthorp
4255384abc
chore: [gn] remove vendor/ from windows include paths ( #13432 )
2018-06-26 15:03:56 +10:00
Jeremy Apthorp
78bc1081fd
chore: fix some more warnings in windows build ( #13431 )
...
Remove an unused function and fix an int type comparison warning. Only showed up when building with GN.
2018-06-26 02:00:20 +02:00
Jeremy Apthorp
6f91af9343
chore: fix various chromium-style errors in windows ( #13394 )
...
These errors weren't previously picked up because the GN build wasn't running on Windows.
2018-06-25 22:30:00 +02:00
deepak1556
5e2406081e
build: move pepper flash behind feature flag
2018-06-21 17:02:12 +05:30
Jeremy Apthorp
8ccb5cc6eb
chore: Annotate fallthrough switch paths with FALLTHROUGH
...
The compiler was throwing errors about unannotated fallthroughs when
building with GN.
2018-06-20 14:38:18 -07:00
Jeremy Apthorp
3f40e93ba7
chore: fix chromium-style errors in frame_subscriber
...
The chromium-style linter we run in the GN build was throwing errors
about these issues.
2018-06-20 14:14:11 -07:00
Milan Burda
122d00f415
Revert "Drop support of Mac OS 10.9" ( #13348 )
...
This reverts commit efa0ec0263481ae188f206625bec6f4a4e5d3ecf.
2018-06-20 13:40:18 -07:00
Samuel Attard
79fbd6bab1
Revert "fix: Drop support for OS X Mavericks (version 10.9)" ( #13333 )
2018-06-20 07:27:55 -05:00
Husayn
1a8c986fb1
set mac protocol to none ( #13302 )
2018-06-20 13:16:37 +10:00
Shelley Vohr
c20e0c30a2
src: base::Value::HasKey(key) => base::Value::FindKey(key) ( #13312 )
2018-06-20 13:07:10 +10:00
John Kleinschmidt
04a7a34c42
Merge pull request #13301 from electron/revert-frame-sub-deprecation
...
fix: revert frame subscriber deprecation and re-enable tests
2018-06-19 14:26:14 -04:00
Heilig Benedek
f643ce4f66
revert: frame subscriber deprecation and re-enable tests
2018-06-19 19:49:44 +02:00
John Kleinschmidt
d367b75680
Merge pull request #13296 from electron/miniak/drop-macos-10.9
...
fix: Drop support for OS X Mavericks (version 10.9)
2018-06-19 13:19:24 -04:00
Milan Burda
794fe741e9
fix: Drop support for OS X Mavericks (version 10.9)
2018-06-19 17:49:27 +02:00
Justin Guze
137aaf2429
fix: pass down the bool value of enableAutoSize to setSize ( #13282 )
...
* fix: pass the boolean value of enableAutoSize to setSize
The webContents setSize API takes in an optional enableAutoSize boolean.
Looking in the code, if that property is set, regardless if you pass in
true or false, it will always set it to true. This change passes the
appropriate boolean value down properly.
* creating new bool for autosize
2018-06-19 10:38:55 -05:00
Jeremy Apthorp
9e8f83e25c
refactor: fix chromium-style in url_request_asar_job ( #13284 )
2018-06-19 10:31:55 -05:00
Milan Burda
d5d5386017
use std::make_unique<T>
2018-06-19 10:20:39 +02:00
Samuel Attard
2720fa751b
Fix windows desktop_capturer build
2018-06-19 15:29:16 +10:00
Samuel Attard
9d18be8fde
Remove removed variable popup_bounds_in_view_
2018-06-19 11:58:26 +10:00
Samuel Attard
5a28759fea
post all desktop capturer apis to worker threads
2018-06-19 11:49:46 +10:00
Samuel Attard
8200a132be
Re-enable cookie specs and add custom cookie name/url validation
2018-06-19 11:49:46 +10:00
Samuel Attard
b7d00e26bf
Default LoadV8Snapshot changed in C66
...
CR Ref: https://chromium-review.googlesource.com/c/chromium/src/+/859577
2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
f4a9575193
Drop support of Mac OS 10.9
...
- set minimum deployment target to 10.10
- set minimum system version to 10.10
2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
c786abf1e9
Add gfx:PointF support to mate::Converter
...
It's needed by atom_api_screen, BuildPrototype function on Windows.
2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
81398c1fde
Use Chromium 66.0.3359.181 and Node.js 10.2.0
2018-06-19 11:49:44 +10:00
Heilig Benedek
65b8dd48d8
Update OSR code
2018-06-19 11:49:44 +10:00
Heilig Benedek
60ba2013c4
Re-add dirtyOnly to FrameSubscriber and document API change
2018-06-19 11:49:44 +10:00
Heilig Benedek
b9413fe59d
Update FrameSubscriber implementation
2018-06-19 11:49:44 +10:00
Nitish Sakhawalkar
ca8843102a
Fix duplicate RTCDispatcher console error for debug build.
...
The solution was to call CreateScreenCapturer from content, and not link the static library in.
2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
90c3d87e21
Rename LocalSurfaceIdAllocator
...
https://chromium-review.googlesource.com/809886
2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
016ac8ff6e
Set CHROME_VERSION_STRING to 66.0.3359.117
2018-06-19 11:49:43 +10:00
Tomas Rycl
7ca1b0704d
Rename ScopedWindowsThreadEnvironment::succeeded() to Succeeded()
...
https://chromium-review.googlesource.com/742447
2018-06-19 11:49:43 +10:00
Tomas Rycl
1ac0ab2b71
Include missing "windows.h" and fix headers ordering
...
For PCWSTR on line 198.
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
d6ffbc0148
Use an int for wm::ShadowElevation. Pick semantic constants.
...
https://chromium-review.googlesource.com/899886
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
4a38c2d800
Remove deprecated View::SetLayoutManager
...
https://chromium-review.googlesource.com/844760
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
f6648a0d4d
Remove ScopedComPtr and scoped_comptr.h
...
https://chromium-review.googlesource.com/726461
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
82d204e932
Wrap X11 headers in ui/gfx/x/x11.h
...
https://chromium-review.googlesource.com/756711
2018-06-19 11:49:43 +10:00
Heilig Benedek
1de1ca906a
Reimplement FrameSubscriber with mojo VideoCapture APIs
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
ac33694028
Update chrome_version.h
2018-06-19 11:49:43 +10:00
deepak1556
405adb938b
Permissions: Remove CONTENT_SETTINGS_TYPE_PUSH_MESSAGING
...
https://chromium-review.googlesource.com/c/chromium/src/+/758456
2018-06-19 11:49:42 +10:00
deepak1556
4068a62fa6
Define gfx::AcceleratedWidget to be uint64_t instead of NSView*
...
https://chromium-review.googlesource.com/c/chromium/src/+/792295
2018-06-19 11:49:42 +10:00
deepak1556
c4b8e106c0
Create network_converter for services/network/* types
2018-06-19 11:49:42 +10:00
deepak1556
f1e2304585
Remove OSCertHandle typedefs, use smart pointers for CRYPTO_BUFFER ownership.
...
https://chromium-review.googlesource.com/c/chromium/src/+/775540
2018-06-19 11:49:42 +10:00
deepak1556
77f427acc8
Check for key system support using new mojo service KeySystemSupport
...
https://chromium-review.googlesource.com/c/chromium/src/+/834764
2018-06-19 11:49:42 +10:00
Aleksei Kuzmin
e1f25253db
REVIEW: Don't use removed and deprecated Value::To* APIs
...
See https://chromium-review.googlesource.com/848782 for removed APIs.
2018-06-19 11:49:42 +10:00
Aleksei Kuzmin
a218c9696c
Fix error: no matching constructor for initialization of 'v8::TryCatch'
...
The deprecated constructor has been removed
in https://chromium-review.googlesource.com/848782
2018-06-19 11:49:42 +10:00
deepak1556
5df0362361
Remove obsolete ShouldHandleSystemCommands function.
...
https://chromium-review.googlesource.com/c/chromium/src/+/924315
2018-06-19 11:49:42 +10:00
deepak1556
2f7c413199
v8: set fatal error handler per isolate
2018-06-19 11:49:42 +10:00
deepak1556
66058c8cfe
REVIEW: Use RenderWidgetHost api for event routing
...
https://chromium-review.googlesource.com/c/chromium/src/+/836267
2018-06-19 11:49:42 +10:00
deepak1556
d386ec0a2b
Remove unused elements from RWHV::CopyFromSurface() API and dead code.
...
https://chromium-review.googlesource.com/c/chromium/src/+/929874
2018-06-19 11:49:42 +10:00
deepak1556
3ad0639b2e
Surface synchronization: Implement auto-resize for OOPIF/BrowserPlugin
...
https://chromium-review.googlesource.com/c/chromium/src/+/753801
2018-06-19 11:49:42 +10:00
deepak1556
ea7e273a06
gin: Make gin/ remember external reference table
...
https://chromium-review.googlesource.com/c/chromium/src/+/778741
2018-06-19 11:49:42 +10:00
deepak1556
383b21e20a
Change calls to GeolocationProvider::UserDidOptIntoLocationServices() to occur via Mojo.
...
https://chromium-review.googlesource.com/c/chromium/src/+/760239
2018-06-19 11:49:42 +10:00
deepak1556
a5bdb8103b
Remove invalid include headers
2018-06-19 11:49:42 +10:00
deepak1556
0cbffb15cc
NetworkService: Implement URLLoader::OnAuthRequired
...
https://chromium-review.googlesource.com/c/chromium/src/+/938960
2018-06-19 11:49:42 +10:00