mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1
29048 commits 1 branch 388 tags 476 MiB
Commit graph

3663 commits

Author SHA1 Message Date
trop[bot]
c39683b2cb
 		fix: remove redundant MediaCaptureDevicesDispatcher::GetInstance() call (#45961) 
fix: remove redundant MediaCaptureDevicesDispatcher::GetInstance() call

This appears to be a copy-paste error introduced in 465dee2c

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2025-03-10 22:29:39 +01:00
trop[bot]
f90de88c63
 		perf: prefer base::SplitStringPiece() over base::SplitString() (#45947) 
* perf: use base::SplitStringPiece() in SetNodeOptions()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* perf: use base::SplitStringPiece() in StringToAccelerator()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: StringToAccelerator() now takes a std::string_view

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2025-03-10 12:24:36 -05:00
trop[bot]
e74e1ab4c5
 		fix: resolve font list in default prefernce values (#45919) 
* fix: resolve font list in default prefernce values

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* chore: fix unsafe buffer usage

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* docs: add code comment

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2025-03-07 16:23:47 +01:00
trop[bot]
7d0f24420f
 		fix: javascript heap OOM is not raised (#45912) 
fix: javascript heap oom is not raised in node::OOMErrorHandler

node::OOMErrorHandler terminates the process directly without raising an
oom exception. To fix it, set an oom handler into node from electron.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Yang Liu <ouyangliu.leo@gmail.com>
 2025-03-07 09:00:12 -06:00
Shelley Vohr
99c943df23
 		fix: setContentProtection(true) after hide on Windows (#45868) 
fix: content protection after hide on Windows

https://chromium-review.googlesource.com/c/chromium/src/+/5789117
 2025-03-04 16:39:59 -05:00
Sam Maddock
8c11764800
 		feat: WebContents.focusedFrame (#45667) 
feat: webContents.focusedFrame
 2025-03-04 11:38:58 -05:00
electron-roller[bot]
e8631b2f3a
 		chore: bump chromium to 135.0.7047.0 (main) (#45859) 
* chore: bump chromium in DEPS to 135.0.7043.0

* chore: bump chromium in DEPS to 135.0.7045.0

* 6305947: Preconnect to the Glic FRE when the button is hovered.

https://chromium-review.googlesource.com/c/chromium/src/+/6305947

* 6207093: Remove line_bounds from ImeCompositionRangeChanged

https://chromium-review.googlesource.com/c/chromium/src/+/6207093

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2025-03-03 14:26:52 +01:00
electron-roller[bot]
add374ef6a
 		chore: bump chromium to 135.0.7041.2 (main) (#45850) 
* chore: bump chromium in DEPS to 135.0.7041.2

* [Extensions] Remove ExtensionsBrowserClient::GetUserAgent()

https://chromium-review.googlesource.com/c/chromium/src/+/6306854

* chore: update patches

* [api] Remove deprecated FunctionCallbackInfo::Holder()

https://chromium-review.googlesource.com/c/v8/v8/+/6309166

* [test] Add createExternalizableTwoByteString to extension

https://chromium-review.googlesource.com/c/v8/v8/+/6304942

* fixup [test] Add createExternalizableTwoByteString to extension

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2025-02-28 17:29:23 -05:00
co63oc
36ec9d7236
 		docs: fix spelling errors in code comments (#45842) 
chore: Fix typos
 2025-02-28 12:24:00 +01:00
Shelley Vohr
eac1a7ff68
 		fix: context-menu event emitted in draggable regions (#45813) 
* fix: context-menu event emitted in draggable regions

* fix: only trigger on mouse release
 2025-02-27 14:44:46 -05:00
electron-roller[bot]
00089a951b
 		chore: bump chromium to 135.0.7039.0 (main) (#45836) 
* chore: bump chromium in DEPS to 135.0.7039.0

* chore: update patches

* extensions: Refactor ExtensionService GrantPermissionsAndEnableExtension

https://chromium-review.googlesource.com/c/chromium/src/+/6302374

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2025-02-27 13:20:42 -05:00
reito
b8d0f18ff8
 		docs: add docs about shared texture mode osr (#45670) 
* docs: add docs about shared texture mode osr

* docs: add docs about shared texture mode osr

* docs: fix dot

* 更新 web-contents.md

Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>

---------

Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
 2025-02-27 11:10:58 -05:00
Charles Kerr
989918a59c
 		refactor: simplify Invoker::IsOK() (#45803) 
* refactor: simplify Invoker::IsOK()

* refactor: might as well make it [[nodiscard]] as well
 2025-02-26 18:50:57 -06:00
Charles Kerr
7d045dcddb
 		refactor: remove unused gin_helper::WrappableBase::GetWrapper(v8::Isolate*) (#45793) 
refactor: remove unused EventEmitter::GetWrapper(v8::Isolate*)
 2025-02-25 19:50:09 -06:00
Charles Kerr
199f6d64db
 		perf: avoid redundant method calls in EventEmitter (#45786) 
* refactor: move EventEmitter::EmitWithEvent() into EventEmitter::Emit()

* perf: remove redundant calls to isolate() in EventEmitter::Emit()

* perf: remove redundant calls to GetWrapper() in EventEmitter::EmitEvent()

* perf: remove redundant calls to isolate() in EventEmitter::EmitWithoutEvent()

* perf: remove redundant calls to GetWrapper() in EventEmitter::EmitWithoutEvent()

* refactor: remove unused method EventEmitter::isolate()

* refactor: remove unused method EventEmitter::GetWrapper(v8::Isolate*)

* refactor: remove unused method EventEmitter::GetWrapper()

refactor: make the EventEmitter::Base typedef private

* refactor: remove unused typedef EventEmitter::Base

See "Workarounds" section in
https://isocpp.org/wiki/faq/templates#nondependent-name-lookup-members

* refactor: remove redundant gin_helper:: namespace use
 2025-02-25 19:20:33 -06:00
Keeley Hammond
9b6ba1ced1
 		fix: re-enable MacWebContentsOcclusion feature flag (#45775) 2025-02-25 09:28:09 -08:00
Charles Kerr
0de1e8e610
 		refactor: remove unused v8::Isolate* arg from GlobalShortcut constructor (#45773) 
refactor: remove unused isolate arg from GlobalShortcut constructor

has not been used since f1a0d5e811 (#22755)
 2025-02-24 19:38:20 -06:00
Charles Kerr
69eb076bca
 		refactor: do not use AdaptCallbackForRepeating() in electron_api_url_loader.cc (#45771) 
refactor: do not use AdaptCallbackForRepeating in electron_api_url_loader.cc
 2025-02-24 11:09:01 -05:00
reito
f3259be73c
 		feat: remove osr framerate limit when use shared texture (#45669) 
feat: remove framerate limit, if use shared texture osr.
 2025-02-24 10:21:46 -05:00
Sam Maddock
e3f61b465d
 		refactor: move extension APIs to session.extensions (#45597) 
refactor: move extensions to session.extensions
 2025-02-21 17:36:51 -06:00
Charles Kerr
2a383e9ddd
 		refactor: use C++20's contains() method (#45742) 
* chore: use std::map<>::contains() instead of count() or find()

* chore: use std::map<>::contains() instead of base::Contains()
 2025-02-21 17:33:43 -06:00
electron-roller[bot]
612da3ec47
 		chore: bump chromium to 135.0.7027.0 (main) (#45677) 
* chore: bump chromium in DEPS to 135.0.7021.0

* chore: bump chromium in DEPS to 135.0.7023.0

* chore: update patches

* chore: gen-libc++-filenames.js

* [Extensions] Add a BUILD.gn file for the chrome.system.display API.

Refs https://chromium-review.googlesource.com/c/chromium/src/+/6227347

* chore: bump chromium in DEPS to 135.0.7025.0

* fixup! [Extensions] Add a BUILD.gn file for the chrome.system.display API.

* [DevTools] Add support for automatic workspace folders.

Refs https://chromium-review.googlesource.com/c/chromium/src/+/6275926

* Add UseCounter for potential PNA 2.0 breakage

Refs https://chromium-review.googlesource.com/c/chromium/src/+/6259197

* Remove references to NavigationEntry/Controller in Zoom code.

Refs https://chromium-review.googlesource.com/c/chromium/src/+/6258070

* chore: update patches

* Allow DevTools to record UmaHistogramMediumTimes

Refs https://chromium-review.googlesource.com/c/chromium/src/+/6183713

* chore: update patches

* [gpu] Remove unnecessary media_buildflags include

Refs https://chromium-review.googlesource.com/c/chromium/src/+/6286526

* chore: bump chromium in DEPS to 135.0.7027.0

* chore: update patches

* Remove type alias

Refs https://chromium-review.googlesource.com/c/chromium/src/+/6280957

* [Refactor] Make ExtensionRegistrar a browser keyed service.

Refs https://chromium-review.googlesource.com/c/chromium/src/+/6285230

* Remove unused functions

Refs https://chromium-review.googlesource.com/c/chromium/src/+/6278736

* chore: IWYU

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2025-02-21 14:46:51 -08:00
Keeley Hammond
6248c2436a
 		fix: re-enable synchronous spellcheck on Windows (#45712) 
* fix: re-enable synchronous spellcheck on Windows

* revert: fix: empty suggestions with windows platform checker

---------

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
 2025-02-21 14:45:46 -08:00
Charles Kerr
8d58999135
 		refactor: use base's map utills in WebFrameMain (#45741) 
refactor: use base::FindPtrOrNull() in WebFrameMain::FromFrameTreeNodeId()

refactor: use base::FindPtrOrNull() in WebFrameMain::FromFrameToken()
 2025-02-21 15:28:00 -06:00
Shelley Vohr
324fc0f62a
 		fix: crash on getUserMedia with invalid chromeMediaSourceId (#45733) 
* fix: crash on getUserMedia with invalid chromeMediaSourceId

* test: add a test
 2025-02-21 10:17:52 -06:00
Charles Kerr
f62668e2e3
 		refactor: use base::as_byte_span() in EncodeToken(). (#45723) 
This matches the change in upstream's serial_chooser_context.cc.

https://chromium-review.googlesource.com/c/chromium/src/+/5247305
 2025-02-20 20:20:16 -05:00
Charles Kerr
a15fa87558
 		refactor: use base::as_bytes() in WriteAsciiChunk() (#45724) 
refactor: use base::as_bytes() in WriteAsciiChunk()

this avoids a reinterpret_cast and a static_cast
 2025-02-20 20:19:48 -05:00
Charles Kerr
ceaa0e26c7
 		refactor: use base::as_string_view() (#45722) 
Use `base::as_string_view()` as a safer alternative to `reinterpret_cast`
in a couple of places.

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5472408
 2025-02-20 18:19:36 -06:00
Shelley Vohr
4867b5dc75
 		refactor: bluetooth in serial chooser when exclusively wireless serial ports are expected (#45671) 
* refactor: bluetooth in serial chooser when exclusively wireless serial ports are expected

https://chromium-review.googlesource.com/c/chromium/src/+/5737296

* chore: review feedback
 2025-02-20 16:44:35 -06:00
Shelley Vohr
340fdaf511
 		feat: allow setting roundedCorners on Windows (#45594) 
* feat: allow setting roundedCorners on Windows

* Update docs/api/structures/base-window-options.md

Co-authored-by: Will Anderson <will@itsananderson.com>

---------

Co-authored-by: Will Anderson <will@itsananderson.com>
 2025-02-20 15:39:12 -05:00
Sam Maddock
9d558cec5e
 		fix: action.openPopup function missing (#45697) 2025-02-19 18:05:02 -05:00
Shelley Vohr
159e1a42b3
 		refactor: track downloads by guid (#45675) 2025-02-19 16:49:34 -06:00
Sam Maddock
b50066f420
 		fix: extension web workers net request failing (#45698) 2025-02-19 13:08:28 -05:00
Sam Maddock
ee67bc7dcb
 		fix: dangling speculative frames (#45609) 
* fix: dangling speculative frames

* harden lifecycle state checks

* feedback

* add const
 2025-02-18 17:52:05 -05:00
electron-roller[bot]
47572286f3
 		chore: bump chromium to 135.0.7015.0 (main) (#45500) 
* https://chromium-review.googlesource.com/c/chromium/src/+/6230977

* chore: bump chromium to 135.0.7012.0

* chore: update accelerator.patch

Support parsing Ctrl+Alt shortcuts | https://chromium-review.googlesource.com/c/chromium/src/+/6238137

* 6234236: Reapply bindings: Pass CppHeap on Isolate creation | https://chromium-review.googlesource.com/c/chromium/src/+/6234236

* 6234614: [ios blink] Move to use external begin frame source | https://chromium-review.googlesource.com/c/chromium/src/+/6234614

* chore: update chromium/feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch

no manual changes; patch applied with fuzz

* chore: update chromium/build_libc_as_static_library.patch

no manual changes; patch applied with fuzz

* chore: remove chromium/cherry-pick-dd8e2822e507.patch

landed upstream

* 6188884: Grit: Remove output_all_resource_defines from list of valid attributes. | https://chromium-review.googlesource.com/c/chromium/src/+/6188884

* 6226981: [views-ax] Remove View::GetAccessibleNodeData() method | https://chromium-review.googlesource.com/c/chromum/src/+/6226981

* 6214895: [views-ax] Deprecate View::NotifyAccessibilityEvent | https://chromium-review.googlesource.com/c/chromium/src/+/6214895

* 6196494: Remove ImageView::SetImage() with ImageSkia param | https://chromium-review.googlesource.com/c/chromium/src/+/6196494

* 6236267: [cleanup] Remove unused PrinterBasicInfo fields | https://chromium-review.googlesource.com/c/chromium/src/+/6236267

* refactor: remove status, isDefault properties from PrinterInfo

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6236267

* chore: lint

* fixup: added mas bypass to new file added in https://chromium-review.googlesource.com/c/chromium/src/+/6208630 see slack for more context

* chore: node script/gen-libc++-filenames.js

* chore: e patches all

* fix: duplicate crdtp symbols

* chore: update patches

* fixup! [Media Features] Remove launched features

---------

Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2025-02-18 11:51:27 -05:00
Sam Maddock
6be1151ffc
 		fix: win.closeFilePreview recreates panel when called twice (#45319) 
* fix: close quick look during tests on macOS

* use longer delay 🤷

* fix: sharedPreviewPanel being recreated on close

* test: ensure preview panel gets closed
 2025-02-17 17:25:19 -05:00
Sam Maddock
c0422d7cc9
 		refactor: dispatch IPC messages from Session (#45452) 
* refactor: dispatch IPC messages from Session

* refactor: move MessageHost to Session
 2025-02-17 16:36:28 -05:00
Alice Zhao
02be7c1185
 		feat: add excludeUrls and modify urls in WebRequestFilter for better URL filtering (#44692) 
* feat: add excludeUrls to web request filter

* refactor: add deprecated field

* test: update tests

* lint: newline

* docs: improve API doc

* fix: add is filter defined property to match all urls

* refactor: remove includeUrls

* refactor: remove typescript binding

* refactor: all_url

* refactor: remove isDefined methods

* refactor: remove comment

* fix: logic

* docs: add to breaking changes
 2025-02-17 12:40:47 -08:00
Robo
137a552641
 		fix: support for v8.setHeapSnapshotNearHeapLimit api (#45606) 
* fix: support for v8.setHeapSnapshotNearHeapLimit api

* docs: add  support
 2025-02-14 10:00:39 -06:00
Shelley Vohr
2af57c4b6a
 		fix: osr crash on window close (#45573) 2025-02-14 11:01:00 +01:00
Shelley Vohr
47dbab3856
 		fix: pointer lock permission after focus loss and regain (#45574) 2025-02-14 10:22:13 +01:00
Charles Kerr
aa06b065c0
 		chore: bump chromium to 134.0.6998.10 (main) (#45564) 
* chore: bump chromium to 134.0.6992.0

* chore: add BrowserProcessImpl::CreateGlobalFeaturesForTesting() stub

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6216193

Remove GlobalFeatures from TestingBrowserProcess::Init

* chore: bump chromium to 134.0.6994.0

* 6208630: Mac sandbox: don't use protobuf for policy serialization | https://chromium-review.googlesource.com/c/chromium/src/+/6208630

* [PDF] Remove HasUnsupportedFeature Mojo interface

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6220800

* 6217444: Remove scoped_gdi_object.h type aliases. | https://chromium-review.googlesource.com/c/chromium/src/+/6217444

* chore: bump chromium to 134.0.6998.10

* 6221378: Revert [OBC] Exclude Aliasing Cookies in FilterCookiesWithOptions() | https://chromium-review.googlesource.com/c/chromium/src/+/6221378

* Update ExtensionPrefs::GetDisableReasons to return DisableReasonSet

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6218840

change copied from 6218840 extensions/shell/browser/shell_extension_loader.cc

* 6218402: Typemap ui.gfx.DXGIHandle <=> gfx::DXGIHandle | https://chromium-review.googlesource.com/c/chromium/src/+/6218402

* chore: disable flaky contentTracing test

not new to this roll; it is happening in main as well

* fixup! chore: disable flaky contentTracing test

---------

Co-authored-by: alice <alice@makenotion.com>
 2025-02-11 17:26:39 -06:00
Felix Rieseberg
9f47c9a051
 		feat: Restore webContents navigation history and page state (#45433) 
* feat: Working navigationHistory.restore with just title/url

* feat: Restore page state, too

* chore: Docs, lint, tests

* Implement feedback

* More magic

* Make _awaitNextLoad truly private

* Implement API group feedback

* One more round of feedback
 2025-02-11 15:09:38 -08:00
Calvin
f5025b6246
 		fix: avoid IPC for renderer webFrame.getZoom... APIs (#45499) 
* fix: avoid IPC for renderer `webFrame.getZoom...` APIs

* Remove `DoGetZoomLevel` IPC

* Fix synchronous behavior & nullptr deref

* Use local root
 2025-02-10 16:09:11 -05:00
Milan Burda
e055ce7c39
 		chore: deprecate systemPreferences.isAeroGlassEnabled() (#45434) 2025-02-10 15:17:07 -05:00
Shelley Vohr
a141f68c83
 		refactor: use node::tracing::Agent() directly (#45489) 
refactor: use node::tracing::Agent()
 2025-02-09 21:36:42 +01:00
Shelley Vohr
9199d5c610
 		fix: window maximizing with Mica (#45456) 
* fix: window maximizing with Mica

* Fix rounded corners after restore
 2025-02-07 15:00:36 -05:00
michal-pichlinski-openfin
96460becf9
 		fix: Update widget visibility in NativeWindowMac::ShowInactive (#45427) 
When using `views::WebView` on macOS `NativeWidgetMacNSWindowHost`
contains a layer and compositor responsible for drawing web contents.
To trigger drawing `NativeWidgetMacNSWindowHost::OnVisibilityChanged`
needs to be called and `[NSWindow orderFrontRegardless]` does not trigger
`[NSWindow orderWindow:relativeTo:]` which can change
`NativeWidgetMacNSWindowHost` visiblity with stack:
```
views::NativeWidgetMacNSWindowHost::OnVisibilityChanged(bool)
remote_cocoa::NativeWidgetNSWindowBridge::OnVisibilityChanged()
-[ViewsNSWindowDelegate onWindowOrderChanged:]
-[NativeWidgetMacNSWindow orderWindow:relativeTo:]
```
`views::Widget` has method for showing inactive window:
`views::Widget::ShowInactive` which triggers
`NativeWidgetMacNSWindowHost::OnVisibilityChanged` with stack:
```
views::NativeWidgetMacNSWindowHost::OnVisibilityChanged(bool)
remote_cocoa::NativeWidgetNSWindowBridge::SetVisibilityState(remote_cocoa::mojom::WindowVisibilityState)
views::NativeWidgetMacNSWindowHost::SetVisibilityState(remote_cocoa::mojom::WindowVisibilityState)
views::NativeWidgetMac::Show(ui::mojom::WindowShowState, gfx::Rect const&)
views::Widget::ShowInactive() + 168
```
However this call seems to be insufficient to bring window to front,
therefore `[NSWindow orderFrontRegardless]` still needs to be called.
Calling `views::Widget::ShowInactive` ensures that all logic related to
showing Chromium widget will be properly executed, but onfortunately it
does not call `[NSWindow orderWindow:relativeTo:]` which is used to
disabling headless mode by the `ElectronNSWindow`, therefore we need to
trigger it manually through exposed `[ElectronNSWindow disableHeadlessMode]`.

Fixes: #45415
 2025-02-07 11:31:08 -08:00
Charles Kerr
d7c6fb8250
 		refactor: follow upstream's suggestions on when to use EmptyGURL() (#45498) 
- Prefer GURL() when we want to return a non-reference empty URL.

- In ServiceWorkerMain::GetStorageKey(), use a reference instead
  of instantiating a new temporary GURL.

From url/gurl.h:

> // Returns a reference to a singleton empty GURL. This object is for
> // callers who return references but don't have anything to return in
> // some cases. If you just want an empty URL for normal use, prefer
> // GURL().
 2025-02-07 13:58:31 -05:00
Charles Kerr
67f5ac5bbc
 		fix: RenderFrameHost nullptr dereference (#45487) 
* fix: add nullptr tests before using render_frame_

* refactor: extract-method HasRenderFrame()
 2025-02-06 22:02:57 -06:00