mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: remove unused gin_helper::WrappableBase::GetWrapper(v8::Isolate*) (#45793)

Browse source 
refactor: remove unused EventEmitter::GetWrapper(v8::Isolate*)
This commit is contained in:
Charles Kerr 2025-02-25 19:50:09 -06:00 • committed by GitHub
parent 199f6d64db
commit 7d045dcddb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 0 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
shell/common/gin_helper/wrappable.cc
View file

@ -29,14 +29,6 @@ v8::Local<v8::Object> WrappableBase::GetWrapper() const {
return {};
}
v8::MaybeLocal<v8::Object> WrappableBase::GetWrapper(
v8::Isolate* isolate) const {
if (!wrapper_.IsEmpty())
return {v8::Local<v8::Object>::New(isolate, wrapper_)};
else
return {};
}
void WrappableBase::InitWithArgs(gin::Arguments* args) {
v8::Local<v8::Object> holder;
args->GetHolder(&holder);

1
shell/common/gin_helper/wrappable_base.h
View file

@ -39,7 +39,6 @@ class WrappableBase {
// Retrieve the v8 wrapper object corresponding to this object.
v8::Local<v8::Object> GetWrapper() const;
v8::MaybeLocal<v8::Object> GetWrapper(v8::Isolate* isolate) const;
// Returns the Isolate this object is created in.
v8::Isolate* isolate() const { return isolate_; }