mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

perf: avoid redundant method calls in EventEmitter (#45786)

Browse source 
* refactor: move EventEmitter::EmitWithEvent() into EventEmitter::Emit()

* perf: remove redundant calls to isolate() in EventEmitter::Emit()

* perf: remove redundant calls to GetWrapper() in EventEmitter::EmitEvent()

* perf: remove redundant calls to isolate() in EventEmitter::EmitWithoutEvent()

* perf: remove redundant calls to GetWrapper() in EventEmitter::EmitWithoutEvent()

* refactor: remove unused method EventEmitter::isolate()

* refactor: remove unused method EventEmitter::GetWrapper(v8::Isolate*)

* refactor: remove unused method EventEmitter::GetWrapper()

refactor: make the EventEmitter::Base typedef private

* refactor: remove unused typedef EventEmitter::Base

See "Workarounds" section in
https://isocpp.org/wiki/faq/templates#nondependent-name-lookup-members

* refactor: remove redundant gin_helper:: namespace use
This commit is contained in:
Charles Kerr 2025-02-25 19:20:33 -06:00 • committed by GitHub
parent b82e4585cf
commit 199f6d64db
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

45
shell/common/gin_helper/event_emitter.h
View file

@ -23,37 +23,30 @@ namespace gin_helper {
template <typename T>
class EventEmitter : public gin_helper::Wrappable<T> {
public:
using Base = gin_helper::Wrappable<T>;
// Make the convenient methods visible:
// https://isocpp.org/wiki/faq/templates#nondependent-name-lookup-members
v8::Isolate* isolate() const { return Base::isolate(); }
v8::Local<v8::Object> GetWrapper() const { return Base::GetWrapper(); }
v8::MaybeLocal<v8::Object> GetWrapper(v8::Isolate* isolate) const {
return Base::GetWrapper(isolate);
}
// this.emit(name, new Event(), args...);
template <typename... Args>
bool Emit(const std::string_view name, Args&&... args) {
v8::HandleScope handle_scope(isolate());
v8::Local<v8::Object> wrapper = GetWrapper();
v8::Isolate* const isolate = this->isolate();
v8::HandleScope handle_scope{isolate};
v8::Local<v8::Object> wrapper = this->GetWrapper();
if (wrapper.IsEmpty())
return false;
gin::Handle<gin_helper::internal::Event> event =
internal::Event::New(isolate());
return EmitWithEvent(name, event, std::forward<Args>(args)...);
gin::Handle<internal::Event> event = internal::Event::New(isolate);
// It's possible that |this| will be deleted by EmitEvent, so save anything
// we need from |this| before calling EmitEvent.
EmitEvent(isolate, wrapper, name, event, std::forward<Args>(args)...);
return event->GetDefaultPrevented();
}
// this.emit(name, args...);
template <typename... Args>
void EmitWithoutEvent(const std::string_view name, Args&&... args) {
v8::HandleScope handle_scope(isolate());
v8::Local<v8::Object> wrapper = GetWrapper();
v8::Isolate* const isolate = this->isolate();
v8::HandleScope handle_scope{isolate};
v8::Local<v8::Object> wrapper = this->GetWrapper();
if (wrapper.IsEmpty())
return;
gin_helper::EmitEvent(isolate(), GetWrapper(), name,
std::forward<Args>(args)...);
EmitEvent(isolate, wrapper, name, std::forward<Args>(args)...);
}
// disable copy
@ -62,20 +55,6 @@ class EventEmitter : public gin_helper::Wrappable<T> {
protected:
EventEmitter() = default;
private:
// this.emit(name, event, args...);
template <typename... Args>
bool EmitWithEvent(const std::string_view name,
gin::Handle<gin_helper::internal::Event> event,
Args&&... args) {
// It's possible that |this| will be deleted by EmitEvent, so save anything
// we need from |this| before calling EmitEvent.
auto* isolate = this->isolate();
gin_helper::EmitEvent(isolate, GetWrapper(), name, event,
std::forward<Args>(args)...);
return event->GetDefaultPrevented();
}
};
} // namespace gin_helper