4822 commits

Author	SHA1	Message	Date
Matt Way	638d8219c4	Removed tracking area when removing icon to prevent mouse exit race condition crash	2018-01-10 10:24:11 +09:00
Jonathon Simister	9c018744f4	Fixes hexColorDWORDToRGBA for transparent colors	2018-01-09 11:07:29 -08:00
Cheng Zhao	4298aecb7c	Merge pull request #11547 from electron/draggable_regions_patch ... fix: draggable region ipc should be frame based	2018-01-07 21:15:50 +09:00
Cheng Zhao	104585e772	Do not create DIR_USER_DATA on IO thread ... It would slowdown the startup time of apps since we have wait for two message posts between threads.	2018-01-03 19:07:24 +09:00
Cheng Zhao	952928dc79	Singleton must be created on request ... The creation of singleton relies on the `userData` dir, which can be changed by user, we have to ensure singleton uses the `userData` dir set by user.	2018-01-03 18:59:12 +09:00
deepak1556	14de22a8c7	Use cached application locale as default for generating accept-lang header	2018-01-02 17:33:46 +05:30
Cheng Zhao	de93b30d3c	win: Fix assertion when getting exe version	2018-01-02 17:02:12 +09:00
Cheng Zhao	82452e7924	win: Fix assertion when getting printers	2018-01-02 16:54:36 +09:00
Cheng Zhao	7bf156d197	win: Fix assertion "IsWprintfFormatPortable(format)"	2018-01-02 16:45:43 +09:00
deepak1556	b9ace16959	update libcc for using custom platform with gin	2018-01-02 16:37:12 +09:00
deepak1556	769fbd0d3b	REVIEW: register BrowserChildProcessObserver once main message loop is ready	2018-01-02 16:37:11 +09:00
deepak1556	1b30cac372	Don't delay node module initialization	2018-01-02 16:37:11 +09:00
Cheng Zhao	1043f07b42	Fix compilation on Windows	2018-01-02 16:37:11 +09:00
deepak1556	0df464e16a	address review comments	2018-01-02 16:37:09 +09:00
deepak1556	ee80313666	opt into location service on main thread	2018-01-02 16:37:09 +09:00
deepak1556	d29c27dc78	REVIEW: obtain mime type from file path only on IO allowed sequence	2018-01-02 16:37:09 +09:00
deepak1556	e072213923	FIXME: dbus ObjectProxy methods should only be invoked on IO allowed sequence	2018-01-02 16:37:09 +09:00
deepak1556	a1592446da	REVIEW: access GetApplicationLocale on sequence that allows IO	2018-01-02 16:37:08 +09:00
deepak1556	69bd44edbb	REVIEW: add render process lifecycle observer only once	2018-01-02 16:37:08 +09:00
deepak1556	ebb0e46380	REVIEW: create AtomNetworkDelegate on the IO thread	2018-01-02 16:37:08 +09:00
Cheng Zhao	b2cef31bc0	Revert "Fix race condition when calling JsAsker::BeforeStartInUI" ... This reverts commit 37317d74adb53afdcb22c85f2d3987fbae290ac7.	2018-01-02 16:37:08 +09:00
Cheng Zhao	6d9b186fa7	Fix race condition when calling JsAsker::BeforeStartInUI	2018-01-02 16:37:07 +09:00
deepak1556	e30131f30b	Initialize isolate holder in standalone node mode	2018-01-02 16:37:07 +09:00
deepak1556	88e53b1b5e	REVIEW: destroy process singleton on sequence where IO is allowed	2018-01-02 16:37:07 +09:00
deepak1556	90acb22a58	dont use UI methods on IO thread	2018-01-02 16:37:06 +09:00
deepak1556	a518c5c3c4	derefence weak ptr only on the same sequence runner it was created in	2018-01-02 16:37:06 +09:00
deepak1556	b4e6516ad8	fix dcheck failure with invalid UTF8 string conversion for base::Value	2018-01-02 16:37:05 +09:00
deepak1556	5c25855ac5	create user data dir on thread that allows IO	2018-01-02 16:37:05 +09:00
deepak1556	99e26b8318	fix: draggable region ipc should be frame based	2018-01-01 22:54:02 +05:30
Cheng Zhao	d04ae88426	The RenderWidgetHostView might not be available when showing menu	2018-01-01 19:37:59 +09:00
Cheng Zhao	bc61f2eafa	Copy the callback instead of reference ... I don't really see how this could be a problem, likely a bug of VS 2017?	2018-01-01 19:37:59 +09:00
Cheng Zhao	46330ac2a9	Remove the closed event of Menu ... The callback of Menu.popup does more things, and there is actually no request for the closed event.	2018-01-01 17:22:07 +09:00
Cheng Zhao	c3eadd5b63	mac: Call callback when menu is programmely closed	2018-01-01 16:49:25 +09:00
Cheng Zhao	7b01a8b860	Add callback parameter to Menu.popup	2018-01-01 16:26:19 +09:00
Cheng Zhao	d7bc127c60	mac: Correctly close popup menu	2018-01-01 15:40:15 +09:00
Cheng Zhao	c0c2461245	Do not create duplicate V8Platform in NodeDebugger	2017-12-22 20:29:09 +09:00
Cheng Zhao	00afeaba9a	Use Node's V8Platform instead of gin's	2017-12-22 20:29:08 +09:00
Cheng Zhao	7a8864063b	mac: Handle the case when closing all menu runners	2017-12-21 15:57:27 +09:00
Cheng Zhao	088042841d	win: Correctly close popup menu	2017-12-21 15:26:32 +09:00
Cheng Zhao	e4770c7604	Coding style fixes	2017-12-20 18:48:09 +09:00
Heilig Benedek	ef7357dedc	update tests for menu closed event and call cancel on closePopup	2017-12-20 15:40:07 +09:00
Heilig Benedek	bcef6eb3df	document menu closed event and fix styling issue	2017-12-20 15:40:07 +09:00
Heilig Benedek	c586806609	fix flash menu being unresponsive to commands	2017-12-20 15:40:07 +09:00
Heilig Benedek	d5ab691fdb	fix osr devtools crash introduced during merge	2017-12-20 12:57:02 +09:00
Cheng Zhao	b2e6340622	Reduce the number of helpers	2017-12-20 10:49:49 +09:00
Cheng Zhao	4fd8b04329	Better field names for details object	2017-12-20 10:25:31 +09:00
Samuel Attard	4d7b85bd01	Appease the linter	2017-12-20 10:21:38 +09:00
Samuel Attard	98e9311669	Give user access to the URL that is attempting to be openExternal'ed	2017-12-20 10:21:38 +09:00
Cheng Zhao	81527b71ba	Merge pull request #11279 from sethlu/openrecent ... Update submenu's title at replacement	2017-12-19 15:28:02 +09:00
timmyhadwen	a6bab71215	Fixed BT bug	2017-12-18 20:46:06 +10:00
Shelley Vohr	3fc844c15a	add loop to catch null values	2017-12-13 14:02:43 -05:00
Shelley Vohr	6252ce466c	remove failing badDefault	2017-12-12 13:39:38 -05:00
Shelley Vohr	8b447b9291	fixing error in registerDefaults	2017-12-12 13:08:09 -05:00
Alexey Kuzmin	1caa04c0bf	Revert "Add systemPreferences.registerDefaults()"	2017-12-12 13:59:15 +03:00
Cheng Zhao	19f1fef040	Merge pull request #11283 from electron/fix-event-subscriber-race ... Fix race condition in event_subscriber.h	2017-12-12 10:49:17 +09:00
Shelley Vohr	a8e67e7f61	fixes from review	2017-12-11 18:20:12 -05:00
Shelley Vohr	84bab48627	improve error handling	2017-12-11 13:11:03 -05:00
Shelley Vohr	c5aeda1fdd	fixes from code review	2017-12-11 00:20:26 -05:00
Shelley Vohr	18ee34f1a1	add method binding and error guards	2017-12-10 11:25:43 -05:00
Shelley Vohr	1ccad4a7e9	fix capitalization and clean logic	2017-12-10 11:04:05 -05:00
Shelley Vohr	f82086e6d3	first pass at adding infra for registerDefaults	2017-12-10 00:45:49 -05:00
simurai	fe0f203312	Replace app icons	2017-12-07 16:10:45 -05:00
deepak1556	19de41b764	BrowserClient::CanCreateWindow is no longer called on the IO thread ... https://codereview.chromium.org/2821473002	2017-12-07 09:47:32 +05:30
Charles Kerr	5fa29fcf58	Merge pull request #11329 from electron/remove-classes-key ... fix: Properly cleanup in `removeAsDefaultProtocolClient`	2017-12-06 17:31:50 -06:00
Cheng Zhao	9c109daa4b	Merge pull request #11168 from sethlu/fix-icns-color ... fix: Update icns	2017-12-06 14:45:36 +09:00
Thiago de Arruda	897712359f	Implement powerMonitor "suspend"/"resume" events for Linux.	2017-12-05 08:12:44 -03:00
Cheng Zhao	24b3ee3a4a	Revert some unnecessary changes	2017-12-05 16:50:25 +09:00
Cheng Zhao	cb3a9c69ab	Add a SessionPreferences to manage session related data ... By design the BrowserClient should not be aware of the api:: classes.	2017-12-05 15:59:15 +09:00
Cheng Zhao	776e8afa2b	Coding style changes	2017-12-05 11:50:06 +09:00
Samuel Attard	e535ba4808	Don't know why we suddenly need this, but hey :/	2017-12-05 11:35:54 +09:00
Samuel Attard	d1aded2831	Appease the almighty linter	2017-12-05 11:35:53 +09:00
Samuel Attard	d9359d8b6c	s/global/session in constants	2017-12-05 11:35:53 +09:00
Samuel Attard	3b80ee0655	Move global preload implementation to be session based	2017-12-05 11:35:53 +09:00
Samuel Attard	448ccc261d	Use const references	2017-12-05 11:35:27 +09:00
Samuel Attard	0ddd078aaf	Add ability to set global preload scripts	2017-12-05 11:35:27 +09:00
Cheng Zhao	d598aa1a67	Merge pull request #11300 from electron/external-devtools ... Add API to set arbitrary WebContents as devtools	2017-12-05 10:35:49 +09:00
Felix Rieseberg	d4275b144b	🔧 Linter fascism	2017-12-04 10:46:53 -08:00
Felix Rieseberg	f62e0a4ed4	🔧 Make it actually work	2017-12-04 10:30:20 -08:00
Felix Rieseberg	b4b729609a	🔪 Delete classes key if empty	2017-12-01 17:39:54 -08:00
Ales Pergl	dadfbd3a4f	Reset embedder_zoom_controller_ before assigning new one	2017-12-01 17:55:22 +01:00
Ales Pergl	fd7af5c1d9	Don't call ui::SetAtomArrayProperty with an empty vector (fails DCHECK)	2017-12-01 17:55:22 +01:00
Ales Pergl	7613afe6d7	Disabled DCHECKs that fail when running tests	2017-12-01 17:55:22 +01:00
Ales Pergl	8357a33d81	Don't leak the taskbar object, reuse it instead	2017-12-01 17:55:21 +01:00
deepak1556	903a5b5100	fix dcheck comparison between unsigned long vs int	2017-12-01 17:55:21 +01:00
Cheng Zhao	6b408de884	Allow using docked devtools for webview	2017-12-01 11:56:58 +09:00
Cheng Zhao	5e4914700e	Enable using external WebContents as devtools	2017-12-01 10:35:23 +09:00
Thiago de Arruda	68bceb9575	Fix race condition in event_subscriber.h	2017-11-29 12:57:47 -03:00
Zhuo Lu	c274312a3a	Update submenu's title	2017-11-28 19:38:07 -08:00
Cheng Zhao	0dc094fffc	Do not change logic on highlighing	2017-11-28 17:37:58 +09:00
Cheng Zhao	d1ebce0395	Remove unused methods	2017-11-28 17:31:13 +09:00
Cheng Zhao	590578c187	Cache the attributed string	2017-11-28 17:26:09 +09:00
Cheng Zhao	eab3342065	Fix the detection of ANSI code	2017-11-28 16:36:07 +09:00
Cheng Zhao	c9acccaddc	Fix memory leak in ANSCI parsing code ... We do not have ARC enabled.	2017-11-28 16:36:07 +09:00
Cheng Zhao	4ded79801f	Remove unused code in NSColor+Hex.h	2017-11-28 16:10:24 +09:00
Cheng Zhao	08f30e4ca6	Add license for the vendored files ... Checked the original files and they were compatible with MIT.	2017-11-28 15:38:42 +09:00
Cheng Zhao	edede7f33f	Fix cpplint warning	2017-11-28 15:36:45 +09:00
Sebastien Bramille	a4905b3c95	Lint	2017-11-28 15:34:13 +09:00
Sebastien Bramille	e8b0897ea1	Fix margin	2017-11-28 15:34:13 +09:00
Sebastien Bramille	71cfb7441c	Update header file	2017-11-28 15:34:13 +09:00
Sebastien Bramille	9f89bd8d8e	Add isHighlighted method	2017-11-28 15:34:13 +09:00
Sebastien Bramille	6a1cfafbd8	Clean	2017-11-28 15:34:13 +09:00
Sebastien Bramille	85f254316c	Add logic	2017-11-28 15:34:13 +09:00
Sebastien Bramille	d722d20974	Use NSString+ANSI on the Menu title	2017-11-28 15:34:13 +09:00
Sebastien Bramille	1d807c552e	Add NSString+ANSI class	2017-11-28 15:34:13 +09:00
Cheng Zhao	b161a4f515	Merge pull request #11166 from sethlu/openrecent ... feat: Recent documents menu item	2017-11-28 10:55:14 +09:00
Zhuo Lu	104d307a4a	Use base::scoped_nsobject	2017-11-27 17:26:23 +09:00
Zhuo Lu	8fa3e71ce4	Format code	2017-11-27 17:26:22 +09:00
Zhuo Lu	4934685f53	Declare with static	2017-11-27 17:26:22 +09:00
Zhuo Lu	0c4e425872	Do not autorelease global variables	2017-11-27 17:26:22 +09:00
Zhuo Lu	dcdc3621ac	Rename roles	2017-11-27 17:26:22 +09:00
Zhuo Lu	1ab4504e94	No need to make visible	2017-11-27 17:26:22 +09:00
Zhuo Lu	cf73fb737f	Small optimization	2017-11-27 17:26:22 +09:00
Zhuo Lu	5d44dbaf54	Redesign recent documents role API ... - For more flexibility in designing the recent documents menu, now there can be one menu item (known issue: you may specify more but AppKit doens't display more than one) in the submenu list, rather than separating the labels with a tab. - Also added is the role `clearrecent` that can be given to a menu item that can clear the recent documents.	2017-11-27 17:26:22 +09:00
Zhuo Lu	828d233f2a	Rollback duplicated feature	2017-11-27 17:26:22 +09:00
Zhuo Lu	0b9cea334f	Specify "Clear Menu" through label option ... Like a bit of a hack right now, conforming to the existing menu item definition	2017-11-27 17:26:22 +09:00
Zhuo Lu	8b720c120d	Hide "Open Recent" in xib	2017-11-27 17:26:22 +09:00
Zhuo Lu	4da2eb9366	Introduce openrecent role ... - Does not yet accept any options except label--"Clear Menu" can't be modified through exposed node API - If `openrecent` is present across multiple menu items, the last seen will be visible in the main menu due to that it is designed to behave like a singleton	2017-11-27 17:26:22 +09:00
Zhuo Lu	0ba2fa5cba	Use else if	2017-11-27 17:26:22 +09:00
Zhuo Lu	f0bff74995	Add "Open Recent" submenu to default	2017-11-27 17:26:22 +09:00
Cheng Zhao	c0e9dbcc00	Merge pull request #11144 from dittos/mas-login-helper-again ... Re-land MAS login helper (w/ regression fix)	2017-11-27 17:02:57 +09:00
shelley vohr	c18afc924b	Merge pull request #10213 from electron/upgrade-to-chromium-61 ... [WIP] Upgrade to Chromium 61	2017-11-24 10:17:52 +01:00
Charles Kerr	fcc8e0924e	Merge pull request #11097 from brenca/resizable-win-fix ... Fix resizable property not working when taskbar was resized	2017-11-24 10:04:43 +01:00
Cheng Zhao	a34d45d8c4	Fix uninitialized NodePlatform	2017-11-24 10:58:53 +09:00
Cheng Zhao	3138c85218	Fix linking problem with NodePlatform	2017-11-24 10:58:53 +09:00
deepak1556	ed4482d7a0	Fix node_debugger api changes ... * _debugWaitConnect => _breakFirstLine * Use default thread pool size specified by node.cc	2017-11-24 10:58:53 +09:00
Aleksei Kuzmin	1cf95d2a26	Use node::NodePlatform instead of v8::platform in atom::NodeDebugger	2017-11-24 10:58:53 +09:00
Ales Pergl	f3c32647af	Sanitized notification delegate implementation ... I made `brightray::NotificationDelegate` back into just an interface and extracted the implementation used by `PlatformNotificationService`, so that the main process notification implementation can inherit only the interface.	2017-11-24 10:58:53 +09:00
deepak1556	a0be734ccb	Fix client certificate private key handling api	2017-11-24 10:58:53 +09:00
Gellert Hegyi	a47497bf18	adds extra param for ui compositor creation	2017-11-24 10:58:53 +09:00
Gellert Hegyi	5d79dbc9a1	upgrades offscreen rendering to latest chromium	2017-11-24 10:58:53 +09:00
Tomas Rycl	e321a4a433	Setting raw pointer to nullptr as default so it can be detected as noninitialized	2017-11-24 10:58:53 +09:00
Tomas Rycl	69cd33395a	Fixed crash on startup on Windows	2017-11-24 10:58:53 +09:00
Aleksei Kuzmin	fe9ae41f98	Use gtk_toggle_button_get_active()	2017-11-24 10:58:53 +09:00
Samuel Attard	797a58bee0	Result of RunMenuAt is now void, no need to ignore it	2017-11-24 10:58:17 +09:00
Tomas Rycl	a723e5a4c5	Fixed moved cert x509 function issue on Windows	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	9326ce8cfd	allocator: rename use_experimental_allocator_shim to use_allocator_shim ... https://codereview.chromium.org/2902043007	2017-11-24 10:58:17 +09:00
Birunthan Mohanathas	4e859b4718	Remove "async" option from menu.popup() ... All menus are async now. See "Cleanup MenuRunner API" https://codereview.chromium.org/2790773002	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	338604239d	Cleanup MenuRunner API ... https://codereview.chromium.org/2790773002	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	14eb2af876	Give CustomButton a focus painter. ... https://chromium-review.googlesource.com/c/chromium/src/+/516824	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	e0d7b7d0fc	Clean up views::Background. ... https://chromium-review.googlesource.com/c/chromium/src/+/520702	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	93b3d8cb49	Changed top/bottom & left/right border parameters on BoxLayout to take single gfx::Insets parameter. ... https://chromium-review.googlesource.com/c/chromium/src/+/515902	2017-11-24 10:58:17 +09:00
Tony Ganch	59550b203f	Include objbase.h only for Windows	2017-11-24 10:58:17 +09:00
Tony Ganch	513d4fd225	Remove usage of X11AtomCache ... See https://codereview.chromium.org/2914103002/	2017-11-24 10:58:17 +09:00
Tony Ganch	da04cbd4d8	Rename set_background to SetBackground	2017-11-24 10:58:17 +09:00
Tony Ganch	d7e4e8d6cc	Rename GetPrefferedSize to CalculatePrefferedSize ... See https://chromium-review.googlesource.com/c/chromium/src/+/516542	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	7f5fbb04e2	Migrate from ScopedComPtr::CreateInstance() to CoCreateInstance in chrome/... ... https://codereview.chromium.org/2894483002	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	1073c9b1ed	Fix compilation of atom/browser/api/atom_api_app.cc ... Refactor client cert private key handling. https://codereview.chromium.org/2898573002	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	624b63a1ca	Move "atom/common/node_includes.h" to the end of the includes list ... https://github.com/electron/electron/issues/10363	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	56e7867455	Move IconURLs method from WebFrame to WebLocalFrame ... https://codereview.chromium.org/2918903002	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	fe662ccbdc	Remove obsolete Blink popup blocker. ... https://chromium-review.googlesource.com/c/chromium/src/+/512347	2017-11-24 10:58:17 +09:00
Aleksei Kuzmin	75b41102ef	Remove unused includes	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	a9eb0cbec0	Ban raw pointers to ref-counted types on base::Bind ... https://chromium-review.googlesource.com/c/chromium/src/+/549537	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	edb7bc6572	Make BlobReader create its own file TaskRunner. ... https://chromium-review.googlesource.com/c/chromium/src/+/570945	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	6c7ad3ac58	Remove the dependence on BrowserThread::FILE for ... https://codereview.chromium.org/2944313003	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	b29c485ec4	Consolidate PowerSaveBlocker and WakeLock inside Device Service. ... https://chromium-review.googlesource.com/c/chromium/src/+/563159	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	7608a0489c	Network Traffic Annotation added to DownloadURLParams. ... https://chromium-review.googlesource.com/c/530307	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	e926473e5a	Partial revert of Provide WebContents::CreateParams to tab helpers. ... https://chromium-review.googlesource.com/c/571285	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	9566904838	Speech recognition: Use BindOnce / OnceCallback / OnceClosure where applicable ... https://chromium-review.googlesource.com/c/565762	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	5831a5ffa1	Refactor client cert private key handling. ... https://codereview.chromium.org/2898573002	2017-11-24 10:58:16 +09:00
Tony Ganch	f694b64d71	FIXME: DesktopNotificationDelegate has been removed ... Related CL: https://codereview.chromium.org/2906883003	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	2c063f93ff	Remove raw base::DictionaryValue::Set ... https://codereview.chromium.org/2911033002	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	1127452429	PlzNavigate: make NavigationResourceHandler a LayeredResourceHandler ... https://codereview.chromium.org/2847443002	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	a72a08bccc	Convert iOS to use X509CertificateBytes. ... https://codereview.chromium.org/2864133002	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	ea8e113b19	SkBitmap and SkPixelRef no longer need lock/unlock ... https://codereview.chromium.org/2823003002	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	ea4a36039a	Add Keyboard Latency UMA Metrics. ... https://codereview.chromium.org/2756893002	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	f03ca53af5	Add blink::WebInputEvent::IsPinchGestureEventType(). ... https://codereview.chromium.org/2861373004	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	650902c656	Renamed LoadCommittedDetails.is_in_page to is_same_document. ... https://codereview.chromium.org/2841833002	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	90b0984a14	Add missing IWYU message_loop.h includes. ... https://codereview.chromium.org/2876013002	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	11fa935359	Introduce TaskRunner::RunsTasksInCurrentSequence() ... https://codereview.chromium.org/2823103003	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	f2bcdab037	Provide WebContents::CreateParams to tab helpers. ... https://codereview.chromium.org/2894973002	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	971002a197	Switch to using scoped_ptr with UserData ... https://codereview.chromium.org/2815913005	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	ee9a547985	Service CreateNewWindow on the UI thread with a new mojo interface ... https://codereview.chromium.org/2821473002	2017-11-24 10:58:16 +09:00
Aleksei Kuzmin	ba6e8b4dff	Merge ResourceRequestBodyImpl and ResourceRequestBody. ... https://codereview.chromium.org/2954343005	2017-11-24 10:58:15 +09:00
Aleksei Kuzmin	b77b67bfbe	Remove client_certs from SSLCertRequestInfo. ... https://codereview.chromium.org/2838243002	2017-11-24 10:58:15 +09:00
Aleksei Kuzmin	ba2f33d629	Remove base::Value::GetAsBinary ... https://codereview.chromium.org/2839753005	2017-11-24 10:58:15 +09:00
Aleksei Kuzmin	58e0771e47	Remove base::Value::Get{Buffer,Size} ... https://codereview.chromium.org/2841623003	2017-11-24 10:58:15 +09:00
Aleksei Kuzmin	132029ea32	Move components/display_compositor to components/viz/display_compositor ... https://codereview.chromium.org/2873243002	2017-11-24 10:58:15 +09:00
Cheng Zhao	f8adaed763	Merge pull request #11208 from electron/mips64el ... Add support for mips64el	2017-11-24 10:54:19 +09:00
Heilig Benedek	bb5eecc16c	Use SizeConstraints instead of window events	2017-11-23 21:25:25 +01:00
Heilig Benedek	ca76dda6a6	remove incorrect checks	2017-11-23 21:25:25 +01:00
Heilig Benedek	7a7f1ee711	dont resize on taskbar resize if resizable is false	2017-11-23 21:25:25 +01:00
Felix Rieseberg	3cb062b3d6	🔧 BrowserView.getAllViews()	2017-11-22 16:58:32 -08:00
Cheng Zhao	4f9c5310a9	Fix compiler warning when building with gcc	2017-11-21 21:47:51 +09:00
Charles Kerr	dba9181611	Merge pull request #11164 from electron/nstitlebar-hidden ... fix: Explicitally set "setTitlebarAppearsTransparent"	2017-11-21 07:51:47 +01:00
Cheng Zhao	cb98ed8674	Merge pull request #11176 from electron/proxy-crash-race ... Avoid proxy handler race condition crash	2017-11-20 20:15:02 +09:00
Cheng Zhao	3cc8330998	Merge branch 'master' into ahmedmohamedali-master	2017-11-20 11:04:47 +09:00
Matt Crocker	efaf7a6b85	Avoid race condition where login handler webcontents becomes null	2017-11-19 14:08:11 -08:00
Zhuo Lu	367f7f123d	Update icns	2017-11-19 00:33:33 -08:00
Felix Rieseberg	daad465fcd	🔧 Eh, let's do it for all the types	2017-11-18 20:19:22 -08:00
Felix Rieseberg	e3b6271806	🔧 setTitlebarAppearsTransparent=YES	2017-11-18 20:00:01 -08:00
Thiago de Arruda	a9a9e58b68	Fix random crash on app quit. ... Move AtomCTDelegate to brightray as RequireCTDelegate and transfer ownership to brightray::URLRequestContextGetter. This fixes the wrong lifetime assumptions that result in AtomCTDelegate being used after free in some scenarios. Close #10051	2017-11-17 12:03:23 -03:00
Ted Kim	8184cbfb06	Implement login helper to manage login item in Mac App Store build	2017-11-17 10:53:09 +09:00
Alexey Kuzmin	8657169017	Revert "Implement login helper to manage login item in Mac App Store build"	2017-11-16 19:05:13 +03:00
Charles Kerr	31172ecaa0	Merge pull request #11008 from electron/implement-stream-protocol ... Implement {register,intercept}StreamProtocol	2017-11-14 09:31:57 -06:00
Cheng Zhao	4b8ab8fc97	Merge pull request #10856 from dittos/mas-login-helper ... Implement login helper to manage login item in Mac App Store build	2017-11-14 21:34:50 +09:00
Thiago de Arruda	5ea3a5886b	Implement {register,intecept}StreamProtocol ... These new functions are more flexible than the other {intercept,register}*ProtocoProtocol functions, since it allows the user to return a node.js stream to feed the data to the protocol handler. It also allows the user to specify a response header dictionary, which makes it possible to correctly intercept any request made from renderers.	2017-11-13 16:16:14 -03:00
Thiago de Arruda	68f514b92f	Implement EventSubscriber<T> class. ... This class simplifies the task of subscribing/handling javascript events from C++ classes in the main process.	2017-11-13 15:22:50 -03:00
Thiago de Arruda	6b666b69c0	Implement GetLoadTimingInfo in JsAsker class. ... This is required to avoid a crash in blink when implementing a custom protocol handler that deals with redirects.	2017-11-13 15:20:56 -03:00
Thiago de Arruda	6b2ddc4814	Stop allowing electron.net requests to be intercepted. ... Not very useful to intercept requests from `electron.net`, since both the interception machinery and `electron.net` live in the browser process.	2017-11-13 15:20:46 -03:00
Cheng Zhao	72440d4ae7	No need to add new methods to WebContentsPreferences	2017-11-13 17:35:49 +09:00
Cheng Zhao	cee1c459c7	Do not accidentally change the behavior of did-change-theme-color	2017-11-13 16:20:54 +09:00
Cheng Zhao	7e0593950c	Code style fixes	2017-11-13 16:13:54 +09:00
Heilig Benedek	276e12ce71	pass on web_contents to properly handle devtools	2017-11-13 15:50:50 +09:00
Heilig Benedek	26daffea9c	use smart pointer for paint_canvas	2017-11-13 15:50:49 +09:00
Heilig Benedek	4b10445c2e	lint fix	2017-11-13 15:50:49 +09:00
Heilig Benedek	193beb57c9	fix datalist element popup position when menu is hidden	2017-11-13 15:50:49 +09:00
Heilig Benedek	f8b3009ebf	restructure code to use web_preferences if possible	2017-11-13 15:50:49 +09:00
Heilig Benedek	71b36ef54d	don't show the dummy window for the rest of the dialogs too on mac	2017-11-13 15:46:46 +09:00
Heilig Benedek	13b86598e8	don't show osr dummy window when dialog is shown on mac	2017-11-13 15:46:46 +09:00
Heilig Benedek	35dc6d03b9	lint fix	2017-11-13 15:46:46 +09:00
Heilig Benedek	e39aacb30e	fix a bug that caused a crash when using an offscreen window with detached devtools, related to autofill popups	2017-11-13 15:46:46 +09:00
Samuel Attard	a06a8a6f79	Merge pull request #11056 from ajmacd/allow-browser-window-logs ... Allow BrowserWindows to emit `console-message` events.	2017-11-11 14:34:39 +11:00
Ahmed	9b3960fe90	Merge branch 'master' into master	2017-11-08 18:03:55 +01:00
Samuel Attard	bb997c2ea4	Forward declare the scrubber layout	2017-11-08 16:48:08 +13:00
Andrew MacDonald	c260a0ab78	Allow BrowserWindows to emit console-message events.	2017-11-07 15:31:15 -08:00
Armagan Amcalar	edd113548a	Make ScrubberItem width dynamic ... Depending on whether a ScrubberItem has text or an icon, this changeset calculates the actual width and sizes the TouchBar items accordingly. Previously, all ScrubberItems, regardless of their content, had a static width of 50px. This commit also fixes #10539.	2017-11-07 00:09:14 +01:00
John Kleinschmidt	5383b4809f	v1.8.2-beta.2	2017-11-06 16:11:34 -05:00
Charles Kerr	4ceeddc09f	Merge pull request #10972 from electron/dpi-issues ... Workaround for Windows DPI issues	2017-11-02 10:16:11 -05:00
Felix Rieseberg	e8f8100e19	🔧 Add fixme	2017-11-01 11:30:32 -07:00
Felix Rieseberg	58708d6242	🔧 Lowercase	2017-10-31 10:31:05 -07:00
Felix Rieseberg	08b8f2df55	📝 Typo!	2017-10-31 08:38:33 -07:00
Felix Rieseberg	91414dde62	🔧 I can't believe this helps	2017-10-30 11:22:07 -07:00
Samuel Attard	c9926bed9f	Merge pull request #10954 from electron/less-process-metrics-warnings ... fix: Don't call idleWakeupsPerSecond on Windows	2017-10-28 12:36:45 +13:00
Samuel Attard	dc8b583363	Merge pull request #10944 from electron/fix-notification-ref-crash ... Close the previous notification on multiple calls to show	2017-10-28 12:33:30 +13:00
Felix Rieseberg	da21d6cdda	🔧 Don't call idleWakeupsPerSecond on Windows	2017-10-27 14:23:06 -07:00
Matt Crocker	b6fb016a9a	Cleanup per review comment	2017-10-27 00:07:54 -07:00
Matt Crocker	77a26882a3	Make linter happy	2017-10-27 00:04:19 -07:00
Matt Crocker	c5914516c8	Upstream good ideas from Muon	2017-10-27 00:04:19 -07:00
Matt Crocker	ca8f45a501	Notifications should emit close on close, not eventual GC	2017-10-27 00:04:19 -07:00
Samuel Attard	8719e9f098	Definitely didn't forget to push the header file	2017-10-27 16:27:37 +13:00
Samuel Attard	fe9069c028	Close the previous notification on multiple calls to show	2017-10-27 16:22:21 +13:00
Paul Frazee	c2d9e082cb	Fix crash in custom protocols caused by bad callback exec	2017-10-25 21:01:53 -05:00
John Kleinschmidt	67f0eb7b3b	Merge pull request #10873 from ahmedmohamedali/fix_issue_10697 ... Fixes #10697	2017-10-23 09:32:28 -04:00
Ahmed Mohamed Ali	463260b249	Electron crashes if user clicks Dev Tools & Zoom options #10697	2017-10-21 22:21:24 +02:00
Ted Kim	4119da607f	Implement login helper to manage login item in Mac App Store build	2017-10-20 11:44:19 +09:00
Ahmed Mohamed Ali	9f3cfa2dbd	Fix crash that happens when the PDF viewer is refreshed. ... The root cause is the PdfViewerHandler instanceis destroyed but not removed from the list of observer in WebContentsZoomController	2017-10-19 16:27:08 +02:00
John Kleinschmidt	90e7d7e112	v1.8.2-beta.1	2017-10-18 16:49:32 -04:00
Ahmed Mohamed Ali	05035eb1e3	Fix linefeeds	2017-10-18 17:36:56 +02:00
John Kleinschmidt	57537ea10e	Merge pull request #10810 from qazbnm456/add_error_code_to_session_set_certificate_verify_proc ... Add error code to session.setCertificateVerifyProc	2017-10-18 09:33:37 -04:00
John Kleinschmidt	cbda307ebf	Merge pull request #10696 from primalmotion/patch-1 ... 🍎 skip tabbing category if macOS < Sierra	2017-10-17 10:24:11 -04:00
Boik	f40cc5ab54	add error code to session.setCertificateVerifyProc	2017-10-16 17:17:21 +08:00
Ahmed Mohamed Ali	8763e8ee35	Fixing coding style	2017-10-14 11:17:52 +02:00
Ahmed Mohamed Ali	5030db000a	Applying changes requested by @deepak1556 after the review: ... - Move RenderFrameHost methods in the UI thread - Check GetAssociatedRenderFrame return value	2017-10-14 11:09:05 +02:00
Ahmed Mohamed Ali	1ad95eca4a	Add support for pdf in sub frames (https://github.com/electron/electron/issues/9192#issuecomment-335543866)	2017-10-13 19:56:20 +02:00
Birunthan Mohanathas	06d782279c	Add systemPreferences.removeUserDefault() ... This can be used to restore the default or global value of a `key` previously set with `setUserDefault`.	2017-10-10 22:57:47 +03:00
Samuel Attard	d350134c4f	Ensure that the touchbar's esape item can be set before setting it	2017-10-10 02:24:49 +11:00
Shelley Vohr	242e097e9b	Merge pull request #10670 from electron/add-linuxdefaultprotocol ... add setAsDefaultProtocolClient for Linux	2017-10-07 10:07:02 -05:00
Shelley Vohr	443c30890b	remove dummy check	2017-10-07 10:38:08 -04:00
Shelley Vohr	35eea8bea5	remove unused xdg setting	2017-10-07 00:38:25 -04:00
Shelley Vohr	66827755e7	remove chrome check and change protocol handler	2017-10-07 00:36:18 -04:00
Shelley Vohr	a1347f67a1	remove a space from a comment wow thanks linter	2017-10-06 23:40:58 -04:00
Shelley Vohr	c9da806c84	slight refactor and lin cleanup	2017-10-06 23:32:46 -04:00
Antoine	5e6b683cfb	fixed: trying to fix the build	2017-10-05 15:57:27 -07:00
Antoine	8e1945f768	🍎 skip tabbing category if macOS < Sierra ... Previously, the macro was ensuring the` MAC_OS_X_VERSION_10_12` was not defined to decide to compile a `NSWindow` category back porting native tabs or not. This patch ensures to compile the `NSWindow` category only if the min required version is lesser than 1012 (`MAC_OS_X_VERSION_10_12`)	2017-10-05 14:11:58 -07:00
Shelley Vohr	f8f21815eb	syntax updates and pointer conversion	2017-10-05 00:30:14 -04:00
Cheng Zhao	bb71b09452	Fix building on Windows	2017-10-05 11:51:41 +09:00
Cheng Zhao	4342480473	Fix cpplint warnings	2017-10-05 11:49:26 +09:00
Sean Bannigan	0b205019b6	add mouse-move event and click event position for tray	2017-10-05 11:41:08 +09:00
Cheng Zhao	8c5bb5969c	Merge pull request #10667 from dittos/window-opacity ... Add window opacity support	2017-10-04 15:03:45 +09:00
Felix Rieseberg	4e05d24d1b	Merge pull request #10661 from electron/browserview-multiple-screens ... BrowserView: Allow dragging of window to screen above menubar	2017-10-03 16:09:11 -07:00
Shelley Vohr	6131a523dc	add xdg helper method	2017-10-03 11:10:38 -04:00
Cheng Zhao	150a4797a4	Merge pull request #10676 from qazbnm456/fix-unhandle-null-pointer ... Add a null-pointer check before processing base::SupportsUserData::GetUserData	2017-10-03 20:18:51 +09:00
Daniel Ma	1bb042a661	feat(NativeWindowMac): addTabbedWindow ... Add support for the [`NSWindow addTabbedWindow`][nsw] method on MacOSX This plays nicely with the changes from #9052 and #9725 Usage samples available in [this commit][c] in my fork of `electron-quick-start` [nsw]: https://developer.apple.com/documentation/appkit/nswindow/1855947-addtabbedwindow [c]: 79f06591df	2017-10-03 20:11:16 +09:00
Boik	d594092675	add a null-pointer check before processing base::SupportsUserData::GetUserData	2017-10-03 12:42:35 +08:00
Taeho Kim	7570ec9d39	Add BrowserWindow.getOpacity for consistency	2017-10-03 00:08:10 +09:00
Shelley Vohr	3f73e000ee	first pass at adding linux setAsDefaultProtocolClient	2017-10-02 10:21:30 -04:00
Taeho Kim	7df5182901	Fix lint	2017-10-02 09:52:27 +09:00
Felix Rieseberg	0cc1ebc021	🔧 Allow dragging window to screen above menubar (for real)	2017-09-29 14:20:34 -04:00
Zeke Sikelianos	9f895879bf	Merge pull request #10191 from electron/add_log_path_support ... add ability to access logs in getPath()	2017-09-29 11:11:29 -07:00
Ted Kim	7f2c4a9e06	Add window opacity support	2017-09-29 17:49:10 +09:00
Shelley Vohr	5ef4caf8ab	add ability to access logs in getPath()	2017-09-28 13:35:22 -04:00
John Kleinschmidt	7788b33dc9	Bump v1.8.1	2017-09-28 13:13:49 -04:00
Felix Rieseberg	89246f3714	🔧 Allow dragging over menubar	2017-09-27 17:43:09 -04:00
Birunthan Mohanathas	044a3a29a6	Simplify checking for NSFullScreenWindowMask	2017-09-27 16:36:18 +03:00
Felix Rieseberg	d45788a7b8	🔧 Don't drag fullscreen window	2017-09-26 18:03:44 -04:00
Birunthan Mohanathas	e1ddd3bdbc	Stop sending resize event for minimized windows on Windows ... This makes it consistent with macOS. This also fixes BrowserView auto-resize on Windows when minimizing and restoring the window. Previously it would incorrectly grow too in some cases.	2017-09-25 11:44:32 +09:00
Birunthan Mohanathas	f3f6bedf8e	Make BrowserView auto-resize relative to window size on Windows/Linux ... Previously it was relative to the window web contents size, which was not consistent with macOS.	2017-09-25 11:44:32 +09:00
Cheng Zhao	b7119b5756	Create watcher when message loop is ready	2017-09-20 11:58:32 +09:00
Samuel Attard	4147fa4629	Appease the linting gods	2017-09-20 11:58:32 +09:00
Samuel Attard	0ab83b301d	Refactor as per @zcbenz comments ... Also fix issue where we run the single instance callback *not* on the UI thread, this apparently results in a hung process.	2017-09-20 11:58:32 +09:00
Samuel Attard	ecbeb0d117	Woops, how did that happen ;)	2017-09-20 11:58:32 +09:00
Samuel Attard	f928a399ae	Move OnBrowserReady call to PreMainMessageLoopRun to account for timing issues on macOS	2017-09-20 11:58:32 +09:00
Samuel Attard	28900a9b63	Fix app.makeSingleInstance hanging on posix systems ... Wait for the IO thread to be a thing before attempting to listen on the socket Fixes #9880	2017-09-20 11:58:32 +09:00
Cheng Zhao	ff023115f5	Style fixes	2017-09-14 16:12:34 +09:00
Rafael Nobre	77a1c5d7fc	Avoids deadlock in case NSUserActivityDelegate method start being called from main thread.	2017-09-14 15:59:43 +09:00
Rafael Nobre	9483f0fc14	Adds synchronization logic to allow NSUserActivityDelegate to wait Javascript updating the NSUserActiity UserInfo if requested.	2017-09-14 15:59:43 +09:00
Rafael Nobre	c23b4a48ec	Fixes NSUserActivityDelegate that was called on a background thread thus not working.	2017-09-14 15:59:43 +09:00
Rafael Nobre	76efee675f	Requests updated user info data before each Handoff operation.	2017-09-14 15:59:43 +09:00
Rafael Nobre	a870799c32	Exposes more Handoff related APIs to Electron.	2017-09-14 15:59:43 +09:00
Cheng Zhao	19a7c7ac39	Styling fixes	2017-09-14 14:43:22 +09:00
xaviergonz	e18cdc185a	add the fix for showinactive	2017-09-14 14:35:53 +09:00
xaviergonz	d0c91daaed	make sure setparentwindow only shows the window if already visible	2017-09-14 14:35:53 +09:00
xaviergonz	dc7cc6921e	fix for mac child windows so they honor show option	2017-09-14 14:35:53 +09:00
xaviergonz	dae63d323c	add new internal set parent window method	2017-09-14 14:33:24 +09:00
Cheng Zhao	a19a229a59	Merge pull request #10254 from zachflower/feature/simple-fullscreen-mode ... Feature/simple fullscreen mode	2017-09-14 09:39:50 +09:00
Zachary Flower	432b912c6a	🎨 Rename ambiguous simple_fullscreen_ variable to always_simple_fullscreen_	2017-09-13 12:16:37 -06:00
Cheng Zhao	2048a1a638	Merge pull request #10429 from qazbnm456/web-request-origin ... Track the origin of webRequest events	2017-09-13 22:23:44 +09:00
Cheng Zhao	c34fb146f6	Fix styling	2017-09-13 21:40:29 +09:00
Vanessa Yuen	9a7d8a0511	merge master into fix-fullscreen-with-resizable-flag.	2017-09-12 18:34:23 -04:00
Zachary Flower	fa4d52f042	🎨 Track/restore original stylemask, rather than individual states.	2017-09-12 12:27:30 -06:00