electron

Author	SHA1	Message	Date
Charles Kerr	c35739d60d	refactor: use url::DomainIs() to check cookie domains (#43262 ) * test: add tests to exercise pre-exsiting cookie domain matching behavior * refactor: use url::DomainIs() to match cookie domains * docs: fix typo	2024-08-09 18:35:18 -05:00
Charles Kerr	c4dfff9844	fix: accidental handle copying in a range loop (#43260 ) fix: accidental handle copying Xref: https://github.com/electron/electron/pull/37857	2024-08-09 13:38:03 -05:00
Shelley Vohr	f49f6ff68b	fix: check screen capture permissions in `desktopCapturer` (#43080 ) fix: check screen capture permissions in desktopCapturer	2024-08-09 10:08:49 +02:00
Shelley Vohr	0718c2b9ee	fix: system-context-menu with frameless BrowserWindows (#43243 )	2024-08-09 10:08:01 +02:00
Shelley Vohr	70dda694e2	build: fix build when `enable_pdf_viewer` and `enable_electron_extensions` disabled (#43206 ) build: fix build when enable_pdf_viewer and enable_electron_extensions disabled	2024-08-07 14:51:38 +02:00
Charles Kerr	6293bbced0	perf: avoid redundant calls to GetView() (#43216 ) * perf: avoid double-calls to GetView() There are a lot of places where we call the virtual method GetView() twice in succession: the first to check if the view exists, and the second to use. This PR holds the view in a temp variable instead, e.g.: if (auto* view = foo->GetView()) view->DoSomething(); * perf: avoid discarded GetView() call	2024-08-06 11:25:59 -05:00
Charles Kerr	3d766e9ccb	perf: don't build unused vectors in HidChooserContext (#43192 ) * refactor: remove unused code in HidChooserContext::DeviceRemoved() * refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError() * refactor: use structured bindings for readability	2024-08-05 15:31:58 +02:00
Charles Kerr	6877671390	fix: gin_helper::MicrotasksScope instantiation (#43185 )	2024-08-05 08:24:27 -05:00
Shelley Vohr	e64302cc91	refactor: simplify window `moveAbove/moveTop` impl on macOS (#43157 ) refactor: simplify window moveAbove/moveTop impl on macOS	2024-08-05 09:57:16 +02:00
Shelley Vohr	2a613cabaa	refactor: migrate `electron_login_helper` to non-deprecated API (#43182 ) refactor: migrate electron_login_helper to non-deprecated API	2024-08-05 09:56:18 +02:00
electron-roller[bot]	20e77afe0f	chore: bump chromium to 129.0.6634.0 (main) (#43189 ) * chore: bump chromium in DEPS to 129.0.6634.0 * chore: update chore_add_electron_deps_to_gitignores.patch no manual changes. patch applied with fuzz 1. * chore: e patches all * chore: update call to gfx::Image::CreateFrom1xPNGBytes() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5743597 The call now takes a base::span --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>	2024-08-04 07:31:31 -05:00
Charles Kerr	5a809a6694	refactor: prefer std::ranges over base::ranges (#43172 ) Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5668999 Xref: https://groups.google.com/a/chromium.org/g/cxx/c/ZnIbkfJ0Glw	2024-08-02 21:21:59 -05:00
Charles Kerr	5b18cc46bc	chore: bump chromium to 129.0.6630.0 (main) (#43087 ) * chore: bump chromium in DEPS to 129.0.6623.0 * chore: update mas_avoid_private_macos_api_usage.patch.patch remove the changes to media/audio/mac/audio_manager_mac.cc, since upstream has also made this change now. Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5738654 * chore: update fix_disable_scope_reuse_associated_dchecks.patch We had been removing a couple of `DCHECK`. Upstream changed their code to limit when these `DCHECK`s get called, so let's see if our change is still needed. Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5739076 * chore: e patches all * Bump the Chrome macOS deployment target to 11.0 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5734361 BREAKING CHANGE: Bump the Chrome macOS deployment target to 11.0 * src: stop using deprecated fields of `v8::FastApiCallbackOptions` Xref: `d0000b118d` Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5741336 Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5741199 * fixup! chore: update fix_disable_scope_reuse_associated_dchecks.patch chore: re-disable DCHECKs yep, it is still needed * refactor use non-deprecated variant of openApplicationAtURL old version is deprecated now in macOS 11 Xref: https://developer.apple.com/documentation/appkit/nsworkspace/1534810-launchapplicationaturl Xref: https://developer.apple.com/documentation/appkit/nsworkspace/3172700-openapplicationaturl * chore: bump chromium in DEPS to 129.0.6626.0 * chore: e patches all * chore: disable NSUserNotification deprecation errors * chore: disable NSWindowStyleMaskTexturedBackground deprecation errors Xref: https://github.com/electron/electron/issues/43125 * chore: disable deprecation errors in platform_util_mac.mm * chore: disable launchApplication deprecation errors * chore: bump chromium in DEPS to 129.0.6630.0 * chore: update refactor_expose_file_system_access_blocklist.patch apply patch manually due to context shear Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5745444 * chore: update deps_add_v8_object_setinternalfieldfornodecore.patch no manual changes. patch applied with fuzz 1 (offset -5 lines) * chore: e patches all * fix: add clang_x64_v8_arm64/snapshot_blob.bin to the zip manifest Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5746173 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>	2024-08-02 09:02:11 -05:00
Charles Kerr	e7ca92a574	chore: remove unused internal env.unSetVar() (#43148 ) chore: remove unused unSetVar JS binding Added in Oct 2020 (`b33f2260`, #25623) but never used	2024-08-01 18:41:41 -05:00
Shelley Vohr	3a07bd8821	fix: take bluetooth serial ports into account in `serial.getPorts()` (#43101 ) * fix: take bluetooth serial ports into account in serial.getPorts() * chore: remove port.path.LossyDisplayName()	2024-08-01 11:13:31 -05:00
cptpcrd	2337d8676d	fix: handle failing to enter fullscreen on macOS (#43112 ) * fix: handle failing to enter/exit fullscreen on macOS On macOS, failing to enter/exit fullscreen can fail. If this happens, properly restore the original window state. * refactor: remove fail to exit fullscreen handlers Seem to be unnecessary since the window exits fullscreen anyway.	2024-08-01 12:13:13 +02:00
Charles Kerr	45e5ccc55e	chore: remove unused KeyWeakMap JS bindings (#43111 ) The last three pieces of code that used it were removed in: - Oct 2020 (`8df4faa8` #25711) - Jun 2020 (`e1e73fa5` #24115) - Jun 2020 (`c0182bca` #24116).	2024-07-31 16:37:04 -05:00
Shelley Vohr	ed3242adc1	fix: vibrant view is inserted into Views API hierarchy (#43078 ) * fix: vibrant view is inserted into Views API hierarchy (#42263) * Update shell/browser/native_window_mac.mm Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu> Co-authored-by: Charles Kerr <charles@charleskerr.com>	2024-07-30 18:21:20 -05:00
Charles Kerr	1bcc566ad8	chore: remove unused & undocumented function v8Util.deleteHiddenValue() (#43090 ) chore: remove unused v8Util.deleteHiddenValue() Its last use was removed in Nov 2020 by `c8d77cae4a` (#26659)	2024-07-30 15:25:37 -05:00
Charles Kerr	47dde3b6e2	chore: remove unused class `electron::ObjectLifeMonitor` (#43089 ) * chore: remove unused electron::ObjectLifeMonitor The last users were removed in June 2020 `e1e73fa5f` (#24115) and May 2020 `9d7ba982` (#23592). * fixup! chore: remove unused electron::ObjectLifeMonitor fix: oops	2024-07-30 08:25:28 -05:00
Shelley Vohr	d09a2e513c	fix: `showInactive` window not showing (#43079 ) fix: showInactive window not showing Refs https://github.com/electron/electron/pull/42226 and https://github.com/electron/electron/pull/43033	2024-07-30 12:37:27 +02:00
Charles Kerr	7e9eb9e3f1	perf: avoid duplicate calculations in gin_helper::Dictionary getters (#43073 ) * perf: cache the dictionary handle * refactor: prefer result.IsJust() over !result.IsNothing() for consistency * refactor: prefer maybe.FromMaybe() over maybe.IsJust() && maybe.FromJust() the inlined code is simpler * refactor: simplify Get() impl * refactor: add private helper Dictionary::MakeKey() refactor: add private helper Dictionary::MakeHiddenKey()	2024-07-29 12:43:28 -05:00
Charles Kerr	e70ce89235	chore: more iwyu (#43063 ) * chore: iwyu shell/browser/electron_pdf_document_helper_client.h * chore: iwyu shell/browser/hid/electron_hid_delegate.h * chore: iwyu content/public/browser/web_contents.h * chore: iwyu shell/browser/usb/electron_usb_delegate.h * chore: iwyu shell/browser/browser_observer.h * chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h * chore: iwyu shell/browser/serial/electron_serial_delegate.h * chore: iwyu shell/browser/api/frame_subscriber.h * chore: iwyu mojo/public/cpp/bindings/ * chore: iwyu components/ * chore: iwyu extensions/ * chore: iwyu shell/common/gin_helper/ * chore: iwyu v8/ * chore: iwyu base/containers/linked_list.h * chore: iwyu shell/browser/native_window.h * chore: iwyu shell/browser/api/electron_api_base_window.h * chore: iwyu shell/common/node_includes.h * chore: iwyu gin/handle.h * chore: iwyu base/functional/callback.h * chore: iwyu ui/gfx/ * chore: iwyu content/public/browser/render_frame_host.h * fix: mac * fix: mac * fix: win * chore: iwyu base/files/file_path.h * chore: iwyu base/unguessable_token.h * chore: iwyu ui/display/screen.h * chore: iwyu chrome/browser/predictors/preconnect_manager.h * chore: iwyu base/observer_list_types.h * chore: iwyu content/public/browser/web_contents.h * chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h * chore: iwyu shell/browser/ui/inspectable_web_contents.h * chore: iwyu content/public/browser/keyboard_event_processing_result.h * chore: iwyu net/cookies/canonical_cookie.h * chore: iwyu net/base/address_list.h * chore: iwyu net/cert/x509_certificate.h * chore: iwyu net/cookies/cookie_change_dispatcher.h * chore: iwyu net/dns/public/host_resolver_results.h * fix: mac * Revert "chore: iwyu net/cert/x509_certificate.h" This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.	2024-07-29 12:42:57 -05:00
electron-roller[bot]	92496c1930	chore: bump chromium to 129.0.6616.0 (main) (#43012 ) * chore: bump chromium in DEPS to 128.0.6613.0 * chore: 5725076: Update EventType names \| https://chromium-review.googlesource.com/c/chromium/src/+/5725076 * chore: export patches * chore: 5725076: Update EventType names \| https://chromium-review.googlesource.com/c/chromium/src/+/5725076 for windows * chore: bump chromium in DEPS to 129.0.6614.0 * 5725672: Add a feature to limit the number of preconnect in LoadingPredictor \| https://chromium-review.googlesource.com/c/chromium/src/+/5725672 * chore: bump chromium in DEPS to 129.0.6616.0 * chore: e patches all and resolve conflict in patches/v8/fix_disable_scope_reuse_associated_dchecks.patch * 5730656: Show an error dialog when UpdatePrintSettings() fails \| https://chromium-review.googlesource.com/c/chromium/src/+/5730656 * chore: gen-libc++-filenames * 5729956: Finally remove string_piece.h \| https://chromium-review.googlesource.com/c/chromium/src/+/5729956 * chore: replace all references of base::StringPiece with std::string_view * chore: remove more references of stringPiece in favor of string_view * chore: rename string_piece variables to string_view * 5508795: Remove the NotificationService \| https://chromium-review.googlesource.com/c/chromium/src/+/5508795 * 5734053: Revert Rename GlobalFeatures to GlobalDesktopFeatures. \| https://chromium-review.googlesource.com/c/chromium/src/+/5734053 * chore: resolve conflict with main without merge --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Alice Zhao <alice@makenotion.com>	2024-07-29 09:37:35 -04:00
Fedor Indutny	55e7a47d70	fix: always terminate active Node Streams (#43056 ) `.destroy()` is an important method in the lifecycle of a Node.js Readable stream. It is typically called to reclaim the resources (e.g., close file descriptor). The only situations where calling it manually isn't necessary are when the following events are emitted first: - `end`: natural end of a stream - `error`: stream terminated due to a failure Prior to this commit the ended state was incorrectly tracked together with a pending internal error. It led to situations where the request could get aborted during a read and then get marked as ended (having pending error). With this change we disentangle pending "error" and "destroyed" cases to always properly terminate an active Node.js Readable stream. Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>	2024-07-27 12:25:43 -05:00
Keeley Hammond	8db1563d73	fix: remove InspectableWebContentsViewMac (#43033 ) * Revert "refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326)" This reverts commit `e67ab9a93d`. * build: fix gn check * chore: implement setCornerRadii in inspectable_web_contents_view_mac Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * fix: pass in cornerRadii value in setCornerRadii Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * fix: forward declaration * 5578714: Remove 0-arg (default) constructor for views::Widget::InitParams. https://chromium-review.googlesource.com/c/chromium/src/+/5578714 * fix: contents_web_view_ -> contents_view_ * chore: remove extraneous includes --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2024-07-27 11:44:22 -05:00
BILL SHEN	77ba40bc01	chore: avoid crash while notification removal (#43040 ) * avoid crash of operation on an invalid entry while erase set iterator. * fix notification removal crash due to the nullptr presenter --------- Co-authored-by: bill.shen <shenyb32768@gmail.com>	2024-07-26 15:34:40 +02:00
Keeley Hammond	2fd04a78a1	fix: revert BrowserWindow unresponsive handling refactor (#43034 ) * Revert "refactor: JSify BrowserWindow unresponsive handling (#37902)" This reverts commit `67ba30402b`. * chore: remove BrowserWindow::SetTitleBarOverlay --------- Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2024-07-25 13:02:02 -07:00
Charles Kerr	660872c048	refactor: move safe_storage functions into anonymous namespace (#43032 )	2024-07-25 13:18:13 -05:00
Shelley Vohr	976f5d1b75	fix: File System API permissions should reset on WebContents destruction (#43009 ) fix: active File System API permissions should reset on WebContents destruction	2024-07-25 09:53:30 -04:00
Charles Kerr	aa23198ad8	chore: remove more unused #include calls (#43000 ) * chore: in shell/renderer/renderer_client_base.h, remove include media/base/key_systems_support_registration.h last use removed in `c670e38b` (##41610) * chore: iwyu electron/fuses.h * chore: iwyu media/base/video_frame.h * chore: iwyu base/functional/callback.h * chore: iwyu base/task/cancelable_task_tracker.h * chore: iwyu shell/browser/draggable_region_provider.h * chore: iwyu shell/browser/ui/inspectable_web_contents_view.h * chore: iwyu ui/aura/window.h * chore: iwyu ui/base/win/shell.h * chore: iwyu ui/display/win/screen_win.h * chore: iwyu ui/gfx/geometry/insets.h * chore: iwyu ui/display/display.h * chore: iwyu ui/gfx/geometry/skia_conversions.h * chore: iwyu ui/gfx/geometry/rect_conversions.h * chore: iwyu ui/gfx/geometry/point.h * chore: iwyu ui/gfx/scoped_canvas.h * chore: iwyu ui/gfx/image/image.h * chore: iwyu ui/accessibility/ax_node_data.h * chore: iwyu ui/views/animation/ink_drop_highlight.h * chore: iwyu ui/gfx/font_list.h * chore: iwyu ui/linux/nav_button_provider.h * chore: iwyu shell/browser/ui/views/frameless_view.h * chore: iwyu services/metrics/public/cpp/ukm_source_id.h * chore: iwyu net/http/http_util.h * chore: iwyu net/base/mime_util.h * chore: iwyu content/public/common/content_client.h * chore: iwyu <list> * chore: iwyu <optional> * chore: iwyu <memory> * chore: iwyu base/files/file_path.h * chore: iwyu ui/base/cursor/cursor.h * chore: iwyu build/build_config.h * chore: iwyu content/public/browser/web_contents.h * chore: iwyu shell/browser/hid/hid_chooser_context.h * chore: iwyu shell/common/platform_util.h * chore: iwyu base/task/single_thread_task_runner.h * chore: iwyu content/browser/renderer_host/render_widget_host_impl.h * chore: iwyu content/public/browser/render_widget_host.h * chore: iwyu shell/browser/electron_browser_context.h * chore: iwyu content/public/browser/web_contents_observer.h * chore: iwyu content/public/browser/render_frame_host.h * chore: iwyu content/public/browser/media_stream_request.h * chore: iwyu chrome/common/chrome_paths.h * chore: iwyu chrome/browser/icon_manager.h * chore: iwyu printing/print_settings.h * chore: iwyu renderer/pepper_helper.h * chore: iwyu shell/browser/api/process_metric.h * chore: iwyu shell/browser/electron_browser_client.h * chore: iwyu shell/browser/electron_browser_context.h * chore: iwyu shell/browser/api/electron_api_session.h * chore: iwyu shell/browser/api/electron_api_app.h * chore: iwyu shell/browser/ui/views/client_frame_view_linux.h * chore: iwyu shell/browser/native_window_views.h * chore: iwyu base/win/windows_version.h * chore: iwyu shell/common/electron_paths.h * chore: iwyu content/public/common/content_switches.h * chore: iwyu third_party/skia/include/core/SkRRect.h * chore: iwyu third_party/skia/include/core/SkBitmap.h * chore: iwyu third_party/skia * chore: iwyu shell/browser/osr/osr_host_display_client.h * chore: iwyu shell/browser/login_handler.h * chore: iwyu shell/browser/javascript_environment.h * chore: iwyu shell/browser/event_emitter_mixin.h * fix: mac * fix: mac * chore: iwyu base/nix/xdg_util.h * fix: win * fix: win * fix: win * fix: win	2024-07-25 11:25:45 +02:00
Shelley Vohr	cfdcf48e1b	fix: desktopCapturer breaks BrowserWindow resizable on macOS (#43013 ) * fix: desktopCapturer breaks BrowserWindow resizable on macOS * test: oops fix showing	2024-07-25 11:17:37 +02:00
Charles Kerr	df524c6eca	chore: use v8::Local<>, not v8::Handle<> (#43019 ) v8::Handle is an alias for v8::Local that "is kept around for historical reasons" and is disabled when V8_IMMINENT_DEPRECATION_WARNING is defined	2024-07-24 18:24:07 -05:00
Shelley Vohr	5669a40d5c	feat: add transparency checking to `nativeTheme` (#42862 ) * feat: add transparency checking to nativeTheme Refs https://chromium-review.googlesource.com/c/chromium/src/+/4684870 * chore: deprecate previous function * chore: fix lint	2024-07-24 14:38:22 +02:00
electron-roller[bot]	3e22f992b0	chore: bump chromium to 128.0.6611.0 (main) (#42779 ) * chore: bump chromium in DEPS to 128.0.6577.0 * chore: bump chromium in DEPS to 128.0.6579.0 * 5675706: Reland "Reland "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al"""" https://chromium-review.googlesource.com/c/chromium/src/+/5675706 * 5668597: [PDF Ink Signatures] Prompt download menu on save when there are edits https://chromium-review.googlesource.com/c/chromium/src/+/5668597 * 5677014: Reland "Pull data_sharing_sdk from CIPD" https://chromium-review.googlesource.com/c/chromium/src/+/5677014 * chore: fixup patch indices * chore: bump chromium in DEPS to 128.0.6581.0 * chore: bump chromium in DEPS to 128.0.6583.0 * update patches * 5455480: [Extensions] Allow service worker requests to continue without a cert https://chromium-review.googlesource.com/c/chromium/src/+/5455480 * try to get some debugging output from script/push-patch.js * chore: bump chromium in DEPS to 128.0.6585.0 * chore: bump chromium in DEPS to 128.0.6587.0 * update patches * chore: bump chromium in DEPS to 128.0.6589.0 * more patch work * maybe over here? * chore: update patches * 5673207: [HTTPS Upgrades] Disable in captive portal login webview https://chromium-review.googlesource.com/c/chromium/src/+/5673207 * 5636785: Extensions: WAR: manifest.json's use_dynamic_url requires a dynamic url https://chromium-review.googlesource.com/c/chromium/src/+/5636785 * chore: bump chromium in DEPS to 128.0.6591.0 * 5665458: Trigger WN2 page when feature is enabled https://chromium-review.googlesource.com/c/chromium/src/+/5665458 * update patches * chore: bump chromium in DEPS to 128.0.6593.0 * chore: bump chromium in DEPS to 128.0.6595.0 * chore: bump chromium in DEPS to 128.0.6597.0 * (patch update) 5694586: [compile hints] Remove the usage of v8::Isolate::SetJavaScriptCompileHintsMagicEnabledCallback API https://chromium-review.googlesource.com/c/chromium/src/+/5694586 * update patches * 5691287: Reland "Change blink::WebKeyboardEvent to use std::array in is members" https://chromium-review.googlesource.com/c/chromium/src/+/5691287 The code changed here is modeled after code in `content/renderer/pepper/event_conversion.cc` that was also modified in this CL, so I took the same approach. * 5529018: Cleanup EnableWebHidOnExtensionServiceWorker flag https://chromium-review.googlesource.com/c/chromium/src/+/5529018 * 5526324: [Code Health] Add deprecation comment for base::SupportsWeakPtr. https://chromium-review.googlesource.com/c/chromium/src/+/5526324 Note that this CL actually does make `SupportsWeakPtr` strictly restricted to existing implementations, no new ones. We could add a patch to add ourselves to this list, but it looks like we'll have to refactor this anyways in the near future. Since the refactor seems straightforward, let's try that first. * chore: bump chromium in DEPS to 128.0.6598.0 * chore: update patches * 5704737: Rename ExclusiveAccessContext::GetActiveWebContents to avoid conflict https://chromium-review.googlesource.com/c/chromium/src/+/5704737 * chore: bump chromium in DEPS to 128.0.6601.0 * chore: update patches * Add `base::StringPiece` header includes Chromium is working on replacing `base::StringPiece` with `std::string_view`. (See the Chromium Bug below.) They're currently running mass codemods (across many multiple changes) to replace uses of `StringPiece` with `string_view`, including removing the header include for `StringPiece` in those files. This cascades down to our files that were implicitly depending on those includes through some other include. They're on track to eventually deprecate and remove `StringPiece` so our code should be converted, but that can be done as an upgrade follow-up task. For now, adding the header back to files that need it should suffice for minimal upgrade changes. Chromium Bug: https://issues.chromium.org/issues/40506050 * 5702737: GlobalRequestID: Avoid unwanted inlining and narrowing int conversions https://chromium-review.googlesource.com/c/chromium/src/+/5702737 contender for smallest commit 2024 * 5706534: Rename GlobalFeatures to GlobalDesktopFeatures. https://chromium-review.googlesource.com/c/chromium/src/+/5706534 * 5691321: ui: remove params variants of SelectFile listener functions https://chromium-review.googlesource.com/c/chromium/src/+/5691321 * 5714949: [Extensions] Display re-enable dialog for MV2 disabled stage https://chromium-review.googlesource.com/c/chromium/src/+/5714949 * chore: update libc++ filenames * patch: disable scope reuse & associated dchecks in v8 (hopefully temp, upgrade follow-up) * fixup! Add `base::StringPiece` header includes * update MAS patch 5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception https://chromium-review.googlesource.com/c/chromium/src/+/5710330 * chore: bump chromium in DEPS to 128.0.6603.0 * chore: update patches * 5713258: Reland "Preparation for decoupling creation/initialization of context" https://chromium-review.googlesource.com/c/chromium/src/+/5713258 When destroying a context, it must already be shutdown, and this change enforces it with a new CHECK. We were overriding `BrowserContextKeyedServiceFactory::BrowserContextShutdown` with an empty implementation, which differed from the default implementation that notifies the `KeyedServiceFactory` that the context has shutdown. Since we were missing this notification, the CHECK would later trip when the service was being destoryed because it was not registered as shutdown when it was shutdown. * chore: bump chromium in DEPS to 128.0.6605.2 * chore: update patches * refactor: linux open/save dialog patch Our existing implementation was relying on an opaque `void* params` parameter that was passed through `ui::SelectFileDialog`. Recently, that parameter has been getting removed: - 5691321: ui: remove params variants of SelectFile listener functions \| https://chromium-review.googlesource.com/c/chromium/src/+/5691321 - 5709097: ui: remove SelectFileDialog impl params \| https://chromium-review.googlesource.com/c/chromium/src/+/5709097 - https://issues.chromium.org/issues/340178601 "reconsider SelectFileDialog" This restructures the patch to work with mostly the same mechanics, but directly on the `ui::SelectFileDialog` object. This nets us some wins in terms of a smaller patch. * 5713262: DevTools UI binding AIDA client event returns response https://chromium-review.googlesource.com/c/chromium/src/+/5713262 * fixup! refactor: linux open/save dialog patch * chore: bump chromium in DEPS to 128.0.6606.0 * chore: update patches * fixup! refactor: linux open/save dialog patch * chore: bump chromium in DEPS to 128.0.6607.0 * chore: update printing.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5722937 * fix: pwd error in electron-test, nan-test fix: unshallow depot_tools before 3-way apply * chore: e patches all * fixup! fix: pwd error in electron-test, nan-test * chore: bump chromium in DEPS to 128.0.6609.0 * chore: bump chromium in DEPS to 128.0.6611.0 * chore: update patches * chore: update libcxx filenames --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Jeremy Rose <nornagon@nornagon.net> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: clavin <clavin@electronjs.org> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Alice Zhao <alice@makenotion.com>	2024-07-23 08:59:44 -07:00
Shelley Vohr	8454f4e49f	feat: emit an event when accessing restricted path in File System Access API (#42561 ) * fix: show a dialog when accessing restricted path in File System Access API * fix: allow overriding initial blocked paths * docs: fix doc * Update docs/api/session.md Co-authored-by: Erick Zhao <erick@hotmail.ca> * fix: change block to deny for consistency --------- Co-authored-by: Erick Zhao <erick@hotmail.ca>	2024-07-22 12:18:15 +02:00
Charles Kerr	60c4c9fec6	chore: remove unused #includes (#42971 ) * chore: iwyu buildflags.h * chore: iwyu dictionary.h * chore: iwyu arguments.h * chore: iwyu values.h * chore: iwyu compiler_specific.h * chore: iwyu binder_map.h * chore: iwyu <vector> * chore: iwyu <set> * chore: iwyu raw_ptr * chore: iwyu gfx/canvas.h * chore: iwyu gfx/color_utils.h * chore: iwyu base/strings/stringprintf.h * chore: iwyu base/task/thread_pool.h * chore: iwyu base/no_destructor.h * chore: iwyu base/path_service.h * chore: iwyu base/files/file_pathh * chore: iwyu base/strings/sys_string_conversions.h * chore: iwyu base/logging.h * chore: iwyu base/command_line.h * chore: iwyu base/files/file_util.h * chore: iwyu base/files/scoped_file.h * chore: iwyu base/strings/utf_string_conversions.h * chore: iwyu base/environment.h * chore: iwyu base/scoped_observation.h * chore: iwyu base/strings/string_split.h * chore: iwyu base/strings/pattern.h * chore: iwyu base/json/string_escape.h * chore: iwyu base/json/json_reader.h * chore: iwyu base/memory/singleton.h * chore: iwyu base/observer_list.h * chore: iwyu base/timer/timer.h * fixup! chore: iwyu values.h * chore: iwyu shell/browser/browser.h * chore: iwyu base/stl_util.h * chore: iwyu base/strings/string_util.h * chore: iwyu shell/browser/javascript_environment.h * chore: iwyu base/memory/ref_counted.h * chore: iwyu base/environment.h * chore: iwyu content/public/browser/browser_thread.h * chore: remove unused typedef gin_helper::EventEmitter::ValueArray * chore: iwyu gin/wrappable.h * chore: iwyu shell/common/gin_helper/function_template_extensions.h * chore: iwyu shell/common/gin_converters/login_item_settings_converter.h * chore: iwyu shell/common/gin_helper/arguments.h * chore: iwyu ui/gfx/skia_util.h * chore: iwyu ui/gfx/geometry/rect.h * chore: iwyu ui/gfx/image/image.h * chore: iwyu base/strings/strcat.h * chore: iwyu ui/native_theme/native_theme.h * fixup! chore: iwyu shell/browser/javascript_environment.h * fixup! chore: iwyu gfx/canvas.h * fixup! chore: iwyu content/public/browser/browser_thread.h * fixup! chore: iwyu ui/native_theme/native_theme.h * fixup! chore: iwyu ui/native_theme/native_theme.h	2024-07-22 11:31:32 +02:00
Charles Kerr	780677e00f	chore: remove unused BaseWindow::GetWeakPtr() (#42973 ) last caller removed in `67ba3040` (#37902)	2024-07-22 10:44:34 +02:00
Charles Kerr	8c8a7709e6	chore: remove unused WrappableBase::AfterInit() (#42974 ) last caller removed in `6159066c` (#22916)	2024-07-22 10:44:21 +02:00
Charles Kerr	c72a714dd5	refactor: remove WindowListObserver::OnWindowAdded() (#42979 ) refactor: remove WindowListObserver::OnWindowRemove() these have never been used	2024-07-22 10:44:08 +02:00
Charles Kerr	7a101a1c4b	refactor: remove unused web contents preferences methods (#42947 ) * chore: remove unused WebContentsPreferences::ShouldDisableDialogs() * chore: remove unused WebContentsPreferences::ShouldUseSafeDialogs() caller removed in `85bc005c` * chore: remove unused WebContentsPreferences::GetSafeDialogsMessage() caller removed in `85bc005c` * refactor: WebContentsPreferences::GetPreloadPath() now returns a std::optional<base::FilePath> * refactor: make WebContentsPreferences::last_preference() const	2024-07-19 12:26:57 -05:00
Charles Kerr	5b7ed6097e	chore: remove unused typedef CreateDownloadPathCallback (#42949 ) chore: remove unused typedef ElectronDownloadManagerDelegate::CreateDownloadPathCallback use was removed in `e3c580e9`	2024-07-19 11:49:58 -05:00
Charles Kerr	32a74b0942	chore: remove unused field `ElectronBrowserClient::browser_main_parts_` (#42956 ) chore: remove unused field ElectronBrowserClient::browser_main_parts_ caller removed in `48d0b09a`	2024-07-19 11:48:52 -05:00
Charles Kerr	5773a2dce6	fix: dangling raw_ptr NodeBindings::uv_env_ (#42933 )	2024-07-17 23:30:09 -05:00
Charles Kerr	bc345db351	fix: dangling raw_ptr<views::View> in api::View (#42929 )	2024-07-17 21:31:48 -05:00
arno renevier	81bdba67ec	feat: Implement password delegate for NSS (#41205 ) * feat: Implement password delegate for NSS (#41188) Introduce an app event client-certificate-request-password. It allows the user to display a UI to prompt for the password. An alternative would have been to implement a class similar to CryptoModulePasswordDialogView, to provide the UI. This might have been simpler for the user, comparing to letting them implement the UI. But it seems like electron does not have an i18n framework, so it's not possible to provide a locale aware UI. * fix lint:markdown error * address review comments * use a trampoline handler in JS. The api exposed is now app.setClientCertRequestPasswordHandler * use properties on the Event object instead of positional parameters * remove ChromeNSSCryptoModuleDelegate::OnPassword in favor of args->GetNext(&password_) * address review comments second round - backslash escape parametrized TypeScript - rename hostName param to hostname - use base::ScopedAllowBaseSyncPrimitivesForTesting - and then, rename ChromeNSSCryptoModuleDelegate to ElectronNSSCryptoModuleDelegate * Update docs/api/app.md Co-authored-by: Sam Maddock <samuel.maddock@gmail.com> * Update docs/api/app.md Co-authored-by: Erick Zhao <erick@hotmail.ca> --------- Co-authored-by: Arno Renevier <arnaud@switchboard.app> Co-authored-by: Sam Maddock <samuel.maddock@gmail.com> Co-authored-by: Erick Zhao <erick@hotmail.ca>	2024-07-17 09:48:03 -04:00
wujinli	9023707b9b	fix: crash with creating OffScreenWebContentsView (#42920 ) On the Mac platform, OffScreenWebContentsView uses Automatic Reference Counting (ARC) to handle the lifecycle of offScreenView_. However, this private member variable is not initialized and its value is undefined. In some cases, it is initialized to a garbage value, which may cause ARC to release the value incorrectly, resulting in a crash.	2024-07-17 13:09:32 +02:00
Shelley Vohr	fd907bc0a3	fix: `getUserMedia` needs macOS system permissions check (#42899 ) fix: getUserMedia needs macOS system permissions check Closes https://github.com/electron/electron/issues/42714 Closes https://github.com/electron/electron/issues/29861	2024-07-17 11:30:05 +02:00
Sam Maddock	778d3098a0	feat: customize border radius of Views (#42320 ) * feat: add View#setBorderRadius test: initial setBorderRadius tests fix: robustly set border radius chore: add PAUSE_CAPTURE_TESTS for easier screencap dev feat: add view border radius support test: view border radius refactor: cleanup view code * maybe delay capture to fix tests? * refactor: retry screen captures in an attempt to fix flakiness * refactor: ScreenCapture constructor no longer async * increase screen capture timeout, feels a little short * refactor: move rounded rect util into chromium_src * skip some capture tests on mas	2024-07-16 20:16:25 -04:00
Shelley Vohr	cbd11bb605	fix: `BrowserWindow.setBackgroundColor` should work with transparency (#42824 ) fix: BrowserWindow.setBackgroundColor should work with transparency	2024-07-16 20:11:49 +02:00
Theo Gravity	bab3fcc9ab	feat: add `getPercentComplete` / `getCurrentBytesPerSecond` / `getEndTime` to DownloadItem (#42805 ) feat: getCurrentSpeed / getPercentComplete / getEndTime on DownloadItem	2024-07-15 19:32:44 -04:00
Shelley Vohr	ae1a684d10	fix: iteration issues in hid `RevokeEphemeralDevicePermission` (#42851 ) fix: iteration issues in hid RevokeEphemeralDevicePermission	2024-07-15 10:41:38 -04:00
Robo	1e1dc22e16	fix: crash when resolving proxy due to network service restart (#42878 )	2024-07-15 17:46:24 +09:00
Shelley Vohr	bbd7f4a5ad	fix: File System Access API should remember last picked directory (#42850 )	2024-07-14 18:43:37 +02:00
Calvin	493bc3ac9d	fix: `desktopCapturer` and `screen` display ids should match (#42883 ) * fix: `desktopCapturer` and `screen` display IDs should match * simplify wide-to-utf8 conversion * remove unnecessary include	2024-07-14 09:51:57 +02:00
Shelley Vohr	4e10eeb87e	fix: `desktopCapturer` and `screen` source ids should match screen ids (#42781 ) * fix: desktopCapturer screen source ids should match screen ids * test: add a regression test	2024-07-10 16:32:29 -07:00
Shelley Vohr	fa6ce4f0f8	fix: High Contrast mode not working on Windows (#42853 ) Closes https://github.com/electron/electron/issues/42609 Refs https://chromium-review.googlesource.com/c/chromium/src/+/5324688 Refs https://chromium-review.googlesource.com/c/chromium/src/+/5368321	2024-07-10 15:14:02 -07:00
Charles Kerr	f9d94211bb	refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener (#42806 ) All the listener functions are empty stubs (and have been since `d4e3c39`) so it doesn't seem like we need a listener? SpeechRecognitionManagerDelegate declares this method: > // Checks whether the delegate is interested (returning a non nullptr > // ptr) or not (returning nullptr) in receiving a copy of all sessions > // events. This is called on the IO thread. > virtual SpeechRecognitionEventListener* GetEventListener() = 0; This PR has ElectronSpeechRecognitionManagerDelegate stop subclassing from the Listener and changes GetEventListener() to return nullptr.	2024-07-10 15:32:50 +02:00
Charles Kerr	e9db02948e	fix: multiple move() calls on the same unique_ptr (#42788 )	2024-07-08 11:04:35 -04:00
Charles Kerr	27e3273f0a	refactor: minor electron browser context cleanup (#42789 ) * refactor: make DevicePermissionMap private to electron::ElectronBrowserContext refactor: make PartitionPath private to electron::ElectronBrowserContext * refactor: remove unused forward declarations of v8 classes * chore: forward declare gin::Arguments * refactor: use unique_ptr operator bool	2024-07-08 16:49:41 +02:00
Charles Kerr	5ff91159cd	fix: dangling raw_ptr ElectronBrowserContext::extension_system_ (#42785 ) The extension system is freed by the DestroyBrowserContextServices() call in the destructor, so we need to zero out the pointer to avoid a dangling raw_ptr error.	2024-07-08 12:56:03 +02:00
Charles Kerr	e89da2bad2	fix: dangling raw_ptr<Session> in UserDataLink (#42786 ) * fix: dangling raw_ptr<Session> in UserDataLink * chore: make linter happy	2024-07-08 12:55:48 +02:00
Shelley Vohr	cb2e7f130b	fix: potentially closed webContents in BrowserView (#42633 )	2024-07-08 12:13:53 +02:00
Shelley Vohr	2f4a46f47a	fix: video and audio capture should be separate (#42775 )	2024-07-08 10:11:40 +02:00
Shelley Vohr	ac074a5548	refactor: run Windows `SelectFileDialog` out of process (#42758 ) * refactor: run Windows SelectFileDialog out of process * fix: add missing IS_WIN guard * refactor: use upstream SelectFileDialogFactory * fix: build chrome/services/util_win/public/mojom target	2024-07-05 11:36:44 +02:00
electron-roller[bot]	19e030a6e8	chore: bump chromium to 128.0.6573.0 (main) (#42766 ) * chore: bump chromium in DEPS to 128.0.6573.0 * chore: update patches * 5665092: Remove default arguments on virtual functions in WebContents https://chromium-review.googlesource.com/c/chromium/src/+/5665092 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2024-07-05 09:51:21 +02:00
electron-roller[bot]	07e6b34a07	chore: bump chromium to 128.0.6571.0 (main) (#42749 ) * chore: bump chromium in DEPS to 128.0.6571.0 * 5636652: [4/n] Introduce RenderInputRouterClient and move InputRouterClient implementation to RenderInputRouter. https://chromium-review.googlesource.com/c/chromium/src/+/5636652 * 5655811: Revert "Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al""" https://chromium-review.googlesource.com/c/chromium/src/+/5655811 * 5581006: [tracing] Forward startup tracing config as shmem https://chromium-review.googlesource.com/c/chromium/src/+/5581006 * chore: fixup patch indices * 5608450: [Views AX] Move Image Auto Captioning strings to ui/ https://chromium-review.googlesource.com/c/chromium/src/+/5608450 * 5648900: [Extensions] Move ExtensionAPIEnabledForServiceWorkerScript() https://chromium-review.googlesource.com/c/chromium/src/+/5648900 * 5651681: Remove Web Speech API profanity masking https://chromium-review.googlesource.com/c/chromium/src/+/5651681 * 5651361: `content::RenderFrame::GetBrowserInterfaceBroker`: return a const-ref. https://chromium-review.googlesource.com/c/chromium/src/+/5651361 * 5604943: Start capture of toolbar after gesture end events are received https://chromium-review.googlesource.com/c/chromium/src/+/5604943 * 5624392: [BRP] Enforce raw_ptr/ref in Renderer code https://chromium-review.googlesource.com/c/chromium/src/+/5624392 * 5659259: Portals: Remove WebContentsView::TransferDragSecurityInfo https://chromium-review.googlesource.com/c/chromium/src/+/5659259 * 5230721: Move ComposeStatus to components/compose https://chromium-review.googlesource.com/c/chromium/src/+/5230721 * 5647894: [api] Cleanup usages of v8::ReturnValue<void>::Set[NonEmpty](..) https://chromium-review.googlesource.com/c/v8/v8/+/5647894 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2024-07-03 11:15:35 -04:00
Charles Kerr	cf5fb4505e	refactor: make session::browser_context_ a const raw_ref (#42728 ) Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2024-07-02 17:53:36 -04:00
Shelley Vohr	1729a9868c	fix: use `BlockedRequest` struct to handle `webRequest` data (#42647 ) Fixes an issue where Chromium could crash on a dangling unretained pointer in one of several webRequest functions. This was happening as a result of the fact that we had outstanding blocking requests continue to reference state owned by ProxyingWebsocket and ProxyingURLLoaderFactory after the requests were destroyed. This had been going on for a few years, and was likely leading to some ongoing memory issues. To fix this, we need to ensure that all state is cleaned up in OnRequestWillBeDestroyed. I chose to create a new BlockedRequest struct to do so, which approximates the approach that upstream takes. The complexities of doing so also made our templated approach more trouble than it felt worth, so i pried that apart into separate handlers.	2024-07-02 14:02:49 +02:00
electron-roller[bot]	8a8241163d	chore: bump chromium to 128.0.6558.0 (main) (#42413 ) * chore: bump chromium in DEPS to 127.0.6526.0 * chore: update network_service_allow_remote_certificate_verification_logic.patch manually apply patch due to minor upstream shear Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5598454 * chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch No manual changes; patch applied with fuzz 1 * chore: update refactor_expose_file_system_access_blocklist.patch No manual changes; patch applied with fuzz 2 * chore: update revert_heap_add_checks_position_info.patch No manual changes; patch applied with fuzz 1 * chore: e patches all * chore: bump chromium in DEPS to 127.0.6527.0 * chore: update patches * chore: bump chromium in DEPS to 127.0.6529.0 * chore: bump chromium in DEPS to 127.0.6531.0 * chore: update patches * 5596349: Remove PDF OCR toggle from settings. https://chromium-review.googlesource.com/c/chromium/src/+/5596349 * 5585932: [video-pip] Add minimize button to video picture-in-picture window https://chromium-review.googlesource.com/c/chromium/src/+/5585932 * 5604487: Reland "[api] Deprecate v8::FunctionCallbackInfo::Holder() for real" https://chromium-review.googlesource.com/c/v8/v8/+/5604487 * 5581721: [DEPS] Update clang-format location https://chromium-review.googlesource.com/c/chromium/src/+/5581721 * 5597904: [Windows] Remove ConvertToLongPath from Sandbox Utilities. https://chromium-review.googlesource.com/c/chromium/src/+/5597904 ResolveNTFunctionPtr was removed in this CL. * fix: visibility state specs on macOS Refs https://chromium-review.googlesource.com/c/chromium/src/+/5605407 * Revert "fix: visibility state specs on macOS" This reverts commit 1eee30a33dfafeec86cdd09526a07b01abca2ed6. * temp: disable occlusion checker on macOS * chore: bump chromium in DEPS to 128.0.6535.0 * chore: update patches * [Extensions] Move some scriptings files out of the API directory. Refs https://chromium-review.googlesource.com/c/chromium/src/+/5606682 * fix[node]: do not use soon-to-be-deprecated V8 API * fix: update api_remove_allcan_read_write.patch * chore: update patches * chore: update patches * chore: fix lf mismatch in api_remove_allcan_read_write.patch * chore: update patches * chore: bump chromium in DEPS to 128.0.6538.0 * chore: update v8 patches * chore: update patches * ui/gl/features.gni: Set use_egl=true unconditionally. Refs https://chromium-review.googlesource.com/c/chromium/src/+/5569748 Refs https://issues.chromium.org/issues/344606399 * chore: bump chromium in DEPS to 128.0.6540.0 * chore: bump chromium in DEPS to 128.0.6541.0 * chore: update patches * chore: fix nan read/write patch * chore: bump chromium in DEPS to 128.0.6543.0 * 5626254: Use sandbox_type instead of process_type \| https://chromium-review.googlesource.com/c/chromium/src/+/5626254 * chore: update patches * rework nan patches * 5621488: Apply consistent naming conventions to zoom values \| https://chromium-review.googlesource.com/c/chromium/src/+/5621488 * chore: bump chromium in DEPS to 128.0.6544.0 * 5605693: Remove files from third_party/ninja \| https://chromium-review.googlesource.com/c/chromium/src/+/5605693 * chore: update patches * chore: maybe fix nan patch, part 3 * chore: delete nan patch * chore: re-add nan patch (attempt 2) * chore: add test patch * fixup! add test patch * chore: bump chromium in DEPS to 128.0.6549.0 * chore: bump chromium in DEPS to 128.0.6551.0 * 5637699: Add command line to ASAN Additional Info section \| https://chromium-review.googlesource.com/c/chromium/src/+/5637699 * chore: update patches * chore: bump chromium in DEPS to 128.0.6553.0 * chore: bump chromium in DEPS to 128.0.6555.0 * fix: add property query interceptors * chore: bump chromium in DEPS to 128.0.6557.0 * 5583182: Automatic Fullscreen: Prototype Permissions API query support \| https://chromium-review.googlesource.com/c/chromium/src/+/5583182 * 5613297: Move render input router and related dependencies to //components/input \| https://chromium-review.googlesource.com/c/chromium/src/+/5613297 * chore: update patches * test: skip methodswithdata-test.js nan test * chore: bump chromium in DEPS to 128.0.6558.0 * chore: update patches * build: reference correct ninja cipd ref Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5605693 * update libcxx filenames * refactor: CursorManager moved to //components/input Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5613297 * refactor: spanify mojo Read/WriteData methods Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5619291 * refactor: remove constexpr from KeyboardCodeFromKeyIdentifier Ref: unknown Added TODO to investigate after * chore: update patches * refactor: improve type safety of a11y ids Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5614590 * chore: disable tls node tests that don't apply given boringssl tls configuration Ref: https://boringssl-review.googlesource.com/c/boringssl/+/68487 * chore: add patch to fix nan v8 incompat with NamedPropertyHandlerConfiguration and IndexedPropertyHandlerConfiguration Ref: https://chromium-review.googlesource.com/c/v8/v8/+/5630388 * fix: limit subspan length per feedback * Fix incorrect CalculateInsetsInDIP check * 5645742: Reland "Reland "Add toolchains without PartitionAlloc-Everywhere for dump_syms et al"" https://chromium-review.googlesource.com/c/chromium/src/+/5645742 * chore: more Windows logging * 5617471: Add NPU blocking to chromium blocklist https://chromium-review.googlesource.com/c/chromium/src/+/5617471 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: deepak1556 <hop2deep@gmail.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Alice Zhao <alice@makenotion.com> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2024-07-02 09:51:33 +02:00
Shelley Vohr	32e5012017	feat: enable Windows Control Overlay on Linux (#41769 )	2024-06-27 14:56:36 +02:00
electron-roller[bot]	ec24b51808	chore: bump node to v20.15.0 (main) (#42616 ) * chore: bump node in DEPS to v20.15.0 * doc: Add OpenSSL errors to API docs https://github.com/nodejs/node/pull/34213 * test: crypto-rsa-dsa testing for dynamic openssl https://github.com/nodejs/node/pull/52781 * src: allow preventing debug signal handler start https://github.com/nodejs/node/pull/46681 * cli: allow running wasm in limited vmemory with --disable-wasm-trap-handler https://github.com/nodejs/node/pull/52766 * chore: fixup indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>	2024-06-27 13:34:39 +02:00
Shelley Vohr	2b31d8459d	fix: param passed to `showSaveDialogSync` on Linux (#42652 ) fix: pass correct param to sync functions on Linux	2024-06-27 10:23:18 +02:00
George Xu	ba8ad4716b	feat: expose system preferences to utility process (#42203 ) * chore: expose system preferences to utility process * chore: add tests, doc changes and module-list update * relative link * use @ * fix test * chore: disable linux test * kick * noop on windows utility process	2024-06-20 11:15:57 -04:00
Shelley Vohr	37608933ae	fix: fetch-dependent interfaces in Web Workers (#42579 )	2024-06-20 11:01:50 -04:00
Milan Burda	003c32331d	chore: add/fix interface comments for sections of methods (#42566 )	2024-06-20 10:49:07 +02:00
Shelley Vohr	8e8ea3ee8b	fix: MessagePort closing unexpectedly with non-cloneable objects (#42535 ) * fix: MessagePort closing unexpectedly with non-cloneable objects * fix: handle serialization failure in parentPort	2024-06-19 11:27:07 +02:00
Shelley Vohr	86cf60c3f1	chore: improve error message on failed SMApp register/unregister (#42526 )	2024-06-18 10:51:37 +02:00
Shelley Vohr	6caf9f06f3	fix: don't observe WebUSB for in-memory partitions (#42443 )	2024-06-12 10:59:04 -05:00
Shelley Vohr	4aa9070e6c	fix: missing `fetch`-dependent interfaces in Node.js (#42419 ) fix: missing fetch-dependent interfaces in Node.js	2024-06-11 16:59:53 -05:00
rcombs	d8e4579e3c	feat: add cumulativeCPUUsage to AppMetrics and CPUUsage (#41819 ) This allows apps to measure their CPU usage over any given period without worrying about other calls affecting the output, as they would with `percentCPUUsage`.	2024-06-11 09:38:03 -05:00
Shelley Vohr	f35a755086	fix: bad js-flags shouldn't crash the app (#42414 ) * fix: bad js-flags shouldn't crash the app * Update shell/browser/javascript_environment.cc Co-authored-by: Robo <hop2deep@gmail.com> --------- Co-authored-by: Robo <hop2deep@gmail.com>	2024-06-11 08:32:16 -05:00
Charles Kerr	f2481ed44f	refactor: move impl classes into unnamed namespaces (#42390 ) * refactor: move ReplyChannel into an anonymous namespace * refactor: move ChunkedDataPipeReadableStream into an anonymous namespace * refactor: move linux helpers into an anonymous namespace * refactor: move linux helpers into an anonymous namespace	2024-06-10 17:00:20 -05:00
Shelley Vohr	035b10daf9	fix: multiple selection in `//shell_dialogs` Portal/KDE implementations (#42308 ) * fix: multiple selection in //shell_dialogs portal implementation * fix: allow multiple directory selection in KDE implementation	2024-06-10 09:43:16 -05:00
Shelley Vohr	91205540c4	fix: restore `wasOpenedAtLogin` functionality (#42411 ) fix: restore opened at login functionality	2024-06-10 09:39:56 -05:00
electron-roller[bot]	c3b4cd987c	chore: bump chromium to 127.0.6521.0 (main) (#42118 ) * chore: bump chromium in DEPS to 126.0.6470.0 * 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs \| https://chromium-review.googlesource.com/c/chromium/src/+/5492605 * 5513277: Move subresource-filter-ruleset to GCS \| https://chromium-review.googlesource.com/c/chromium/src/+/5513277 * 5512656: Remove CustomizeChromeSupportsChromeRefresh2023 \| https://chromium-review.googlesource.com/c/chromium/src/+/5512656 * 5516009: Accept mouse events in inactive window for Top Chrome WebUIs \| https://chromium-review.googlesource.com/c/chromium/src/+/5516009 * 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI. \| https://chromium-review.googlesource.com/c/chromium/src/+/5376861 * 5490530: Use partition_alloc PA_BUILDFLAG(...) outside PA. #cleanup \| https://chromium-review.googlesource.com/c/chromium/src/+/5490530 * 5296870: network: Allow trusted loaders to learn the sent request cookies. \| https://chromium-review.googlesource.com/c/chromium/src/+/5296870 * 5453438: Delegate delegated ink trails to RWHI from RWHIER. \| https://chromium-review.googlesource.com/c/chromium/src/+/5453438 * chore: update patches * chore: bump chromium in DEPS to 126.0.6472.0 * chore: bump chromium in DEPS to 126.0.6474.0 * chore: update patches * chore: bump chromium in DEPS to 126.0.6476.0 * chore: bump chromium in DEPS to 126.0.6478.0 * chore: bump chromium in DEPS to 126.0.6478.3 * chore: bump chromium in DEPS to 126.0.6478.8 * update patches * only disable enterprise_cloud_content_analysis * 5403888: [api] support v8::Data in v8::TracedReference and v8::EmbedderGraph https://chromium-review.googlesource.com/c/v8/v8/+/5403888 * chore: bump chromium in DEPS to 127.0.6484.0 * chore: bump chromium in DEPS to 127.0.6485.0 * 5539004: Use NOTREACHED_IN_MIGRATION() in remaining chrome/ \| https://chromium-review.googlesource.com/c/chromium/src/+/5539004 * src: cast to v8::Value before using v8::EmbedderGraph::V8Node \| https://github.com/nodejs/node/pull/52638/files * chore: update patches * chore: update v8 patches * chore: bump chromium in DEPS to 127.0.6486.0 * chore: bump chromium in DEPS to 127.0.6488.0 * chore: bump chromium in DEPS to 127.0.6490.0 * chore: bump chromium in DEPS to 127.0.6492.0 * chore: update patches For some reason, `feat_expose_raw_response_headers_from_urlloader.patch` got messed up in an earlier commit. * chore: update patches printing.patch was updated due to https://chromium-review.googlesource.com/c/chromium/src/+/5535938 * 5527572: Move Connectors prefs files to components/enterprise/connectors/ https://chromium-review.googlesource.com/c/chromium/src/+/5527572 * chore: bump chromium in DEPS to 127.0.6494.0 * chore: bump chromium in DEPS to 127.0.6495.0 * chore: bump chromium in DEPS to 127.0.6496.0 * 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation https://chromium-review.googlesource.com/c/v8/v8/+/5465511 * chore: revert v8 deprecation See patch message for more details. https://chromium-review.googlesource.com/c/v8/v8/+/5526611 * chore: update patches * 5538771: Remove srcdoc else-if block in CalculateOrigin() https://chromium-review.googlesource.com/c/chromium/src/+/5538771 * 5522321: [devtools] Support saving base64 encoded files via host bindings https://chromium-review.googlesource.com/c/chromium/src/+/5522321 * 5376861: Change references to RWHVB in RWHIER and RenderWidgetTargeter to RWHVI. https://chromium-review.googlesource.com/c/chromium/src/+/5376861 * 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum https://chromium-review.googlesource.com/c/chromium/src/+/5530163 * 5463431: iwa: Only create IsolatedWebAppURLLoaderFactory for subresources in IWAs https://chromium-review.googlesource.com/c/chromium/src/+/5463431 * fixup! 5465511: [api] Mark v8::ObjectTemplate::SetAccessor(..) for deprecation https://chromium-review.googlesource.com/c/v8/v8/+/5465511 * 5512176: Remove OnEnvironmentEstimationComplete() https://chromium-review.googlesource.com/c/chromium/src/+/5512176 * 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282 * 5513740: Reland "[Extensions] Restructure extensions::ProcessMap" https://chromium-review.googlesource.com/c/chromium/src/+/5513740 * 5483406: [PEPC] Make PEPC permission subscription take into account device status https://chromium-review.googlesource.com/c/chromium/src/+/5483406 * 5526034: [DoH] Remove kDnsOverHttps feature flag https://chromium-review.googlesource.com/c/chromium/src/+/5526034 The title is a bit misleading. They removed handling for the feature flag and generally intend to remove it but haven't yet. I only changed our code to address the flag that was removed. A quick search on GitHub for `DnsOverHttpsFallback` yielded a few results, but they were all C++ chromium code or patches, 0 app code or discussion results. Since I couldn't find any evidence of this flag being used in developer applications, I've chosen to exclude this change from the breaking changes docs. * chore: revert v8 removal https://chromium-review.googlesource.com/c/v8/v8/+/5497515 See patch message for more details. * chore: cherry-pick Node.js patch for V8 API removal fix Node.js PR: https://github.com/nodejs/node/pull/52996 V8 API Removal CL: https://chromium-review.googlesource.com/c/v8/v8/+/5539888 See the patch description for more details. * 5492183: Extensions: CodeHealth: Give enums some class https://chromium-review.googlesource.com/c/chromium/src/+/5492183 * fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282 * 5514687: Reland "Add a secret handshake to the base::Feature constructor" https://chromium-review.googlesource.com/c/chromium/src/+/5514687 * fixup! 5530163: [media] Use VideoFrame::Plane typed enum instead of nameless enum https://chromium-review.googlesource.com/c/chromium/src/+/5530163 * 5466238: PDF Viewer: add metrics to record if PDF is opened with a11y https://chromium-review.googlesource.com/c/chromium/src/+/5466238 * 5502081: Migrate OnDisplayRemoved to OnDisplaysRemoved https://chromium-review.googlesource.com/c/chromium/src/+/5502081 * 5539888: [api] Remove several APIs deprecated in version 12.6 https://chromium-review.googlesource.com/c/v8/v8/+/5539888 This commit essentially only removes the `only_terminate_in_safe_scope` isolate creation parameter. This undoes some work that was originally done in #35766. * 5498236: Make browser_tests force full async initialization for OSCrypt Async https://chromium-review.googlesource.com/c/chromium/src/+/5498236 * fixup! 5528282: Move Web Speech API .mojom files to //media/mojo/mojom https://chromium-review.googlesource.com/c/chromium/src/+/5528282 * 5545807: Migrate most remaining NOTREACHED() https://chromium-review.googlesource.com/c/chromium/src/+/5545807 I took a systematic approach to modifying all of our uses of `NOTREACHED` that were causing errors: * If there was a `return` or `break` (etc.) immediately after `NOTREACHED`, I removed the control flow instruction and left the `NOTREACHED` unmodified * All other instances were migrated to `NOTREACHED_IN_MIGRATION` We should revisit pretty much all usage of `NOTREACHED` as an upgrade follow-up item. * fixup! 5526034: [DoH] Remove kDnsOverHttps feature flag https://chromium-review.googlesource.com/c/chromium/src/+/5526034 Turns out the feature flags were removed in the `.cc` file, but not the `.h` feature list file. This means that the feature flags are pretty much officially gone. (The leftover symbols in the header are likely an oversight from what I can gather.) We may potentially decide to put this in the breaking changes doc if we decide this feature flag is important enough to highlight. * chore: bump chromium in DEPS to 127.0.6498.3 * chore: bump chromium in DEPS to 127.0.6500.0 * chore: bump chromium in DEPS to 127.0.6502.0 * chore: bump chromium in DEPS to 127.0.6504.0 * chore: bump chromium in DEPS to 127.0.6505.0 * chore: bump chromium in DEPS to 127.0.6508.0 * build: use Sha256Sum in script/sysroots.json Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5506275 * chore: update chore_add_electron_deps_to_gitignores.patch Xref: no manual changes; patch applied with fuzz 2 * chore: update feat_allow_code_cache_in_custom_schemes.patch Xref: no manual changes; patch applied with fuzz 1 * chore: e patches all * fixup! build: use Sha256Sum in script/sysroots.json `sync` succeeds now * chore: replace absl::optional with std::optional Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5253843 * chore: update CalculatePreferredSize() to new upstream semantics Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5459174 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541220 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5514708 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5504212 Xref: https://chromium-review.googlesource.com/516542 * chore: replace absl::optional with std::optional Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5296147 * chore: add kPip to enumeration as a no-op https://chromium-review.googlesource.com/c/chromium/src/+/5546257 * [Autofill] Remove RenderFrame::ElementBoundsInWindow() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5553982 * chore: fix feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch need new header to pick up definition of BLINK_PLATFORM_EXPORT macro Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5463143 * chore: bump chromium in DEPS to 127.0.6510.0 * chore: update patches * chore: fix include path for native_web_keyboard_event.h Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5541976 * chore: add currently-unused should_include_device_status arg to GetPermissionStatusForCurrentDocument() Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5545382 * chore: bump chromium in DEPS to 127.0.6512.0 * chore: update mas_avoid_private_macos_api_usage.patch.patch No manual changes; patch applied with fuzz 1 * chore: update feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch No manual changes; patch applied with fuzz 1 * chore: update webview_fullscreen.patch No manual changes; patch applied with fuzz 1 * chore=: remove cherry-pick-22db6918bac9.patch already present upstream * chore: remove nonexistent patchfiles from .patches * chore: remove cherry-pick-3e037e195e50.patch no longer needed; merged upstream * Update namespace for files moved to //components/input Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5563251 * Require client for InitParams to always specify an ownership mode. Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5532482 Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5578714 * chore: e patches all * fixup! Update namespace for files moved to //components/input * chore: remove profile_keyed_service_factory, profile_selections from chromium_src already being linked in via chrome browser for printing * chore: bump chromium in DEPS to 127.0.6515.0 * chore: bump chromium in DEPS to 127.0.6516.0 * chore: update render_widget_host_view_base.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5547803 patch applied manually due to simple upstream shear * chore: update feat_allow_code_cache_in_custom_schemes.patch No manual changes; patch applied with fuzz 1 * chore: e patches all * Pull RWHIER and RWT to //content/common/input. Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5397681 * chore: bump chromium in DEPS to 127.0.6517.0 * chore: update patches * fixup: Update namespace for files moved to //components/input * Remove 0-arg (default) constructor for views::Widget::InitParams. https://chromium-review.googlesource.com/c/chromium/src/+/5578714 * fixup: only disable enterprise_cloud_content_analysis The original commit `a5480accc2`, was due to this CL 5527572: Move Connectors prefs files to components/enterprise/connectors/ \| https://chromium-review.googlesource.com/c/chromium/src/+/5527572 * chore: bump chromium in DEPS to 127.0.6519.0 * chore: update patches * src: do not use deprecated V8 API https://github.com/nodejs/node/pull/53084 * src: remove dependency on wrapper-descriptor-based cpp heap https://github.com/nodejs/node/pull/53086 * 5344413: [DevTools] Add `getHostConfig` UI binding for sending status of `base::Features` to DevTools https://chromium-review.googlesource.com/c/chromium/src/+/5344413 * 5585788: Extensions: ManifestHandler: Separate Registry like ExtensionRegistry https://chromium-review.googlesource.com/c/chromium/src/+/5585788 * chore: update filenames.libcxx.gni * 5506857: Reland "Migrate clang-format to gcs first class deps" https://chromium-review.googlesource.com/c/chromium/src/+/5506857 * fixup: 5539888: [api] Remove several APIs deprecated in version 12.6 * fixup: 5506857: Reland Migrate clang-format to gcs first class deps * chore: bump chromium in DEPS to 127.0.6521.0 * chore: update patches * spec: update navigator.keyboard should lock the keyboard * Block or allow all MIDI using the existing SysEx permission Refs https://chromium-review.googlesource.com/c/chromium/src/+/5154368 Refs https://chromium-review.googlesource.com/c/chromium/src/+/5499157 * spec: update test/parallel/test-v8-stats * views: remove CalculatePreferredSize() Refs https://chromium-review.googlesource.com/c/chromium/src/+/5504212 * chore: update patches after rebase * 5560288: Re-enable ChromeOS XNNPack on Intel only https://chromium-review.googlesource.com/c/chromium/src/+/5560288 * chore: add nan patches for v8 changes Refs 5539888: [api] Remove several APIs deprecated in version 12.6 \| https://chromium-review.googlesource.com/c/v8/v8/+/5539888 and 5539852: [heap][api] Remove deprecated v8::Isolate::IdleNotificationDeadline \| https://chromium-review.googlesource.com/c/v8/v8/+/5539852 * 5573603: Modularize //chrome/browser/themes https://chromium-review.googlesource.com/c/chromium/src/+/5573603 * 5539888: [api] Remove several APIs deprecated in version 12.6 https://chromium-review.googlesource.com/c/v8/v8/+/5539888 * chore: update patches * test: fixup navigator.keyboard.lock on Windows * chore: remove unneeded profile target --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: Jeremy Rose <nornagon@nornagon.net> Co-authored-by: clavin <clavin@electronjs.org> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: deepak1556 <hop2deep@gmail.com>	2024-06-07 17:18:35 -04:00
Shelley Vohr	25ed286706	fix: `loginService` -> `loginItemService` (#42380 ) fix: loginService -> loginItemService	2024-06-07 11:49:00 +02:00
Shelley Vohr	54c315c9b0	refactor: improve cookie failure rejection messages (#42362 )	2024-06-07 10:06:37 +02:00
Shelley Vohr	7f3dc7d4ce	fix: utilityProcess exit codes (#42297 )	2024-06-07 10:06:00 +02:00
Charles Kerr	791907f0f3	refactor: move WebFrameRenderer into an anonymous namespace (#42369 )	2024-06-05 18:31:52 -05:00
Alice Zhao	406f644d26	feat: duplicate navigation related APIs to `contents.navigationHistory` (#41752 ) * refactor: move navigation related api to navigationHistory * docs: add deprecation messages to old web content methods * fix: add deprecation warnings to webcontents * fix: add deprecation warnings and make existing naviagation apis internal * Update docs/api/web-contents.md Co-authored-by: Sam Maddock <samuel.maddock@gmail.com> * Update docs/api/web-contents.md Co-authored-by: Sam Maddock <samuel.maddock@gmail.com> * Update docs/api/web-contents.md Co-authored-by: Sam Maddock <samuel.maddock@gmail.com> * Update docs/api/web-contents.md Co-authored-by: Sam Maddock <samuel.maddock@gmail.com> * docs: fix links * docs: add breaking change to 31 * docs: move breaking change to 32 * chore: re-run pipeline --------- Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>	2024-06-05 09:34:47 -07:00
Shelley Vohr	39c984e23a	fix: WebUSB should not crash when using in-memory partitions (#42347 )	2024-06-04 15:24:08 +02:00
Krzysztof Halwa	85df2a86dd	feat: Allow WebContentsView to accept webContents object. (#42086 ) feat: Allow WebContentsView to accept webContents object	2024-05-30 12:45:35 -07:00
Charles Kerr	ae0c55c0b1	refactor: inherit Observer classes privately, pt. 2 (#42237 ) * refactor: use private inheritance in PushNotifications * refactor: use private inheritance in electron::api::App * refactor: use private inheritance in electron::api::BrowserWindow * refactor: use private inheritance in electron::api::NativeTheme * refactor: use private inheritance in electron::api::Tray * refactor: use private inheritance in electron::api::Session * refactor: use private inheritance in electron::api::WebContents * refactor: use private inheritance in electron::api::DownloadItem * refactor: use private inheritance in electron::api::MenuBar * refactor: use private inheritance in ClearDataOperation * refactor: use private inheritance in electron::api::Screen * refactor: use private inheritance in electron::ElectronDesktopWindowTreeHostLinux * refactor: use private inheritance in SpellCheckerHolder * refactor: use private inheritance in electron::api::PowerMonitor * refactor: use private inheritance in electron::api::BaseWindow * refactor: use private inheritance in electron::api::AutoUpdater * refactor: use private inheritance in electron::api::Menu * refactor: use private inheritance in electron::api::NativeWindowViews * refactor: use private inheritance in electron::ElectronBrowserClient * refactor: use private inheritance in electron::AutofillPopupView * refactor: use private inheritance in GtkMessageBox * refactor: use private inheritance in electron::OffScreenRenderWidgetHostView * refactor: use private inheritance in electron::InspectableWebContents * refactor: use private inheritance in electron::ElectronUsbDelegate * refactor: use private inheritance in electron::LoginHandler * refactor: use private inheritance in WebFrameRenderer * refactor: use private inheritance in electron::ElectronSerialDelegate * refactor: use private inheritance in electron::ClientFrameViewLinux * refactor: use private inheritance in electron::ElectronHidDelegate * refactor: use private inheritance in IPCRenderer * refactor: use private inheritance in electron::WinCaptionButtonContainer * refactor: use private inheritance in electron::ElectronApiIPCHandlerImpl * refactor: use private inheritance in electron::api::ServiceWorkerContext * refactor: use private inheritance in ui::FileSelectHelper * refactor: use private inheritance in electron::api::WebContentsView * refactor: use private inheritance in electron::api::SimpleURLLoaderWrapper * refactor: use private inheritance in electron::api::InAppPurchase * refactor: use private inheritance in electron::api::Debugger * refactor: use private inheritance in electron::ElectronWebContentsUtilityHandlerImpl * refactor: use private inheritance in electron::OffScreenWebContentsView	2024-05-29 13:07:02 -05:00
Samuel Attard	22ba8b6f01	fix: restore original BrowserWindow.show() behavior (#42300 )	2024-05-28 23:31:11 -07:00
BILL SHEN	3ffa35dc8d	fix: calculate a hash for the Tag property of ToastNotification. (#42239 ) * fix: calculate a hash for the Tag property of ToastNotification. * fix: calculate a hash for the Tag property of ToastNotification. --------- Co-authored-by: bill.shen <shenyb32768@gmail.com>	2024-05-24 21:20:59 +02:00
Charles Kerr	752efddf89	refactor: prefer to inherit observer classes privately (#41360 ) * refactor: use private inheritance in CookieChangeNotifier * refactor: use private inheritance in WebViewGuestDelegate * refactor: use private inheritance in UsbChooserController * refactor: use private inheritance in DesktopCapturer * refactor: use private inheritance in Browser * refactor: use private inheritance in WebContentsZoomController * refactor: use private inheritance in FrameSubscriber * refactor: use private inheritance in AutofillAgent * refactor: use private inheritance in HidChooserController * refactor: use private inheritance in PepperHelper * refactor: use private inheritance in AutofillPopup * refactor: use private inheritance in SerialChooserController * refactor: use private inheritance in MediaCaptureDevicesDispatcher * refactor: use private inheritance in electron::api::View * refactor: use private inheritance in AutofillDriverFactory * refactor: use private inheritance in GPUInfoManager * refactor: use private inheritance in SavePageHandler * refactor: use private inheritance in GlobalShortcut * refactor: use private inheritance in ElectronRenderFrameObserver	2024-05-21 14:21:31 -05:00
Samuel Attard	2e778a98b9	fix: ensure showInactive actually shows (#42226 )	2024-05-20 14:12:05 -07:00
Charles Kerr	c67744a127	refactor: use raw_ref in RootView (#42114 ) * refactor: make RootView::window_ a const raw_ref The Chromium C++ style guide says "prefer const raw_ref<T> whenever the held pointer will never be null," so let's do that. * refactor: make RootView::main_view_ a const raw_ref > The Chromium C++ style guide says "prefer const raw_ref<T> whenever > the held pointer will never be null," so let's do that. * refactor: aggregate RootView::last_focused_view_tracker_ RootView already owns it, so aggregate it	2024-05-15 14:45:47 -04:00
Shelley Vohr	a54afabe04	fix: `win.center()` on Windows (#42195 ) fix: win.center() on Windows	2024-05-15 10:36:24 -07:00
Samuel Attard	435003566d	fix: restore non-panel focus behavior (#42180 )	2024-05-14 15:52:08 -07:00
Fedor Indutny	f2af35182c	fix: fix cast in ElectronDesktopWindowTreeHostLinux (#42179 ) Fix cast in ElectronDesktopWindowTreeHostLinux The frame view of the widget is an `ClientFrameViewLinux` instance only when both `frame` and `client_frame` booleans are set to `true`. Otherwise it is an instance of a different class and thus casting to `ClientFrameViewLinux` is incorrect and leads to crashes. Fix: #41839	2024-05-14 14:26:39 -07:00
Samuel Attard	e19754d7fd	test: add tests for electron fuses (#42129 ) * spec: add tests for electron fuses * spec: fix tests for windows * spec: handle weird crash codes on win32 * spec: disable fuse tests on arm64 windows	2024-05-13 10:48:26 -07:00
Charles Kerr	10fd0ba655	refactor: use base::Value::Take() (#41169 ) perf: avoid temporary strings in Converter<net::HttpRequestHeaders>::FromV8() * perf: take strings instead of copying them in ToResponseHead() * refactor: prefer base::Value::Take*() where appropriate As per the base::Value docs: "prefer over `std::move(value.Get...())` so clang-tidy can warn about potential use-after-move mistakes."	2024-05-13 15:58:52 +02:00
Shelley Vohr	c765d57265	fix: BrowserView autoresizing conversion error (#42056 )	2024-05-13 10:27:01 +02:00
electron-roller[bot]	9b0409f7c9	chore: bump chromium to 126.0.6445.0 (main) (#41868 ) * chore: bump chromium in DEPS to 125.0.6421.0 * chore: bump chromium in DEPS to 125.0.6422.0 * Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows https://chromium-review.googlesource.com/c/chromium/src/+/5434658 * chore: update patches * fixup: Add ENABLE_BASE_TRACING flags for compatibility with enable_base_tracing = false on Windows * chore: bump chromium in DEPS to 126.0.6423.0 * chore: update patches * 5426599: Next generation control of unsafe-buffers-usage plugin https://chromium-review.googlesource.com/c/chromium/src/+/5426599 * chore: bump chromium in DEPS to 126.0.6425.0 * chore: update patches * Roll clang+rust llvmorg-19-init-7229-g315c88c5-2 : llvmorg-19-init-8091-gab037c4f-1 / ceab6128fa48a616bfd3e3adf4bc80133b8ee223-1 : ab71ee7a9214c2793108a41efb065aa77aeb7326-1 https://chromium-review.googlesource.com/c/chromium/src/+/5444328 Also see https://issues.chromium.org/issues/332931387 * 5445074: [Views AX] Move AXEventNotificationDetails to ui/accessibility/ https://chromium-review.googlesource.com/c/chromium/src/+/5445074 Also 5455993: [Views AX] Rename AXEventNotificationDetails to AXUpdatesAndEvents \| https://chromium-review.googlesource.com/c/chromium/src/+/5455993 * Pass IsolationInfo to ContentBrowserClient::WillCreateURLLoaderFactory() https://chromium-review.googlesource.com/c/chromium/src/+/5405301 * chore: bump chromium in DEPS to 126.0.6427.0 * chore: update patches * chore: remove no longer needed patch perfetto is now turned on so this patch is no longer needed. * chore: bump chromium in DEPS to 126.0.6429.0 * chore: bump chromium in DEPS to 126.0.6431.0 * chore: bump chromium in DEPS to 126.0.6433.0 * 5466654: Do not create a console if logging to a handle https://chromium-review.googlesource.com/c/chromium/src/+/5466654 * chore: fixup patch indices * Address Linux NonClientFrameView Changes - https://chromium-review.googlesource.com/c/chromium/src/+/5180720 - https://chromium-review.googlesource.com/c/chromium/src/+/5367794 * chore: bump chromium in DEPS to 126.0.6435.0 * chore: bump chromium in DEPS to 126.0.6437.0 * chore: update patches * chore: bump chromium in DEPS to 126.0.6439.0 * chore: bump chromium in DEPS to 126.0.6441.0 * 5477689: components/crash/content/tools: Format with yapf \| https://chromium-review.googlesource.com/c/chromium/src/+/5477689 * 5485006: Remove enable_print_content_analysis GN flag \| https://chromium-review.googlesource.com/c/chromium/src/+/5485006 * chore: update chromium patches * chore: bump chromium in DEPS to 126.0.6443.0 * 5465608: Convert DCHECKs near RenderWidgetHost, DelegatedFrameHost to CHECK \| https://chromium-review.googlesource.com/c/chromium/src/+/5465608 * 5492605: Migrate TODOs referencing old crbug IDs to the new issue tracker IDs \| https://chromium-review.googlesource.com/c/chromium/src/+/5492605 * chore: update patches * chore: bump chromium in DEPS to 126.0.6445.0 * chore: update patches * 5468588: Fullscreen: Encapsulate ExclusiveAccessBubble params in a struct \| https://chromium-review.googlesource.com/c/chromium/src/+/5468588 * fixup! 5485006: Remove enable_print_content_analysis GN flag \| https://chromium-review.googlesource.com/c/chromium/src/+/5485006 * 5461340: `size_t` in `mojo::DataPipe[Consumer\|Producer]Handle`: /components. \| https://chromium-review.googlesource.com/c/chromium/src/+/5461340 * 5480213: Add an EvictIds struct to FrameEvictorClient \| https://chromium-review.googlesource.com/c/chromium/src/+/5480213 * 4341506: [api] Deprecate Isolate::IdleNotificationDeadline \| https://chromium-review.googlesource.com/c/v8/v8/+/4341506 * 5300826: [v8-tasks] Add source location to v8::TaskRunner, step 4/4. \| https://chromium-review.googlesource.com/c/v8/v8/+/5300826 * partially revert is_newly_created to allow for browser initiated about:blank loads * add dep on app_launch_prefetch Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5420149 * install sysroots from electron not from chrome We should add a new var upstream for `download_sysroots` so that we can skip downloading chromes at all. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5462469 * refactor: make UpdateFrameHints an override Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5473548 * fix ppapi * refactor: update namespace for pwm switches Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617 * 5459367: WebSQL: Restrict WebSQL service creation to Android only \| https://chromium-review.googlesource.com/c/chromium/src/+/5459367 * 5455853: Revert "[Clipboard] Don't add meta charset tag for async write() method on Mac." \| https://chromium-review.googlesource.com/c/chromium/src/+/5455853 * fixup! refactor: update namespace for pwm switches edd9e26 Ref: https://chromium-review.googlesource.com/c/chromium/src/+/5444617 * 5147611: [heap] Add checks for ensuring position info slow path is not used in heap snapshot \| https://chromium-review.googlesource.com/c/v8/v8/+/5147611 * fixup! 5412666: [heap] Also avoid heap allocation for allocation tracked functions \| https://chromium-review.googlesource.com/c/v8/v8/+/5412666 * chore: add websql removal to breaking-changes.md --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: VerteDinde <vertedinde@electronjs.org> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>	2024-05-10 11:21:10 -04:00
Shelley Vohr	3bd807b03e	fix: View reordering on re-addition to same parent (#42085 )	2024-05-10 10:16:33 +02:00
Charles Kerr	e2acdffe58	perf: avoid protocol registry redundant lookup (#41991 ) * perf: avoid redundant map lookup in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL() * perf: avoid redundant map lookup in InspectableWebContents::LoadNetworkResource() * refactor: remove unused ProtocolRegistry::IsProtocolRegistered() refactor: remove unused ProtocolRegistry::IsProtocolIntercepted() * refactor: remove unused ProtocolRegistry::handlers() * refactor: rename ProtocolRegistry::FindIntercepted() refactor: rename ProtocolRegistry::FindRegistered() similar semantics to base::Value::Find() chore: follow Google C++ brace style chore: use same variable names as in main	2024-05-09 09:53:09 -04:00
Shelley Vohr	865b0499bb	refactor: use `//ui/shell_dialogs` on Linux (#42045 ) * refactor: use //ui/shell_dialogs on Linux * fix: add proper filtering * fix: add support for missing dialog features to //shell_dialogs * fix: parent_window could be null * chore: cleanup patch * fix: use a OnceCallback in the sync implementation * chore: remove stray debuglog * Apply suggestions from code review Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: use settings struct * fix: show hidden file property checking * chore: changes from review * fix: multi selection for dialogs --------- Co-authored-by: Charles Kerr <charles@charleskerr.com>	2024-05-09 09:51:42 -04:00
Shelley Vohr	6675f3ae65	fix: CHECK when adding view as its own child (#42067 )	2024-05-09 09:47:47 -04:00
Shelley Vohr	731bc7a334	fix: `BrowserWindow.center()` should center relative to screen (#42048 )	2024-05-08 15:42:20 -07:00
cptpcrd	d5c8f2d6d9	fix: avoid crash after upgrade on Linux (#41046 )	2024-05-07 16:04:50 +02:00
John Kleinschmidt	36310b8729	chore: fixup gn check when enable_pdf_viewer is false (#41990 )	2024-04-30 20:32:11 -04:00
Shelley Vohr	f5fb44eaf8	fix: `requestFullscreen` from `WebContentsView` (#41966 ) fix: requestFullscreen from WebContentsView	2024-04-29 19:09:29 -04:00
Shelley Vohr	441dbda833	fix: recentDocuments on macOS not working (#41978 )	2024-04-29 19:07:14 -04:00
Shelley Vohr	5310b79ffb	fix: `setTitleBarOverlay` should be implemented on `BaseWindow` (#41960 ) fix: setTitleBarOverlay should be implemented on BaseWindow	2024-04-29 11:28:24 -04:00
Charles Kerr	b684a98267	refactor: replace base::EndsWith() with std::ends_with() (#41937 )	2024-04-23 21:13:59 -05:00
Shelley Vohr	d8f8560b1c	refactor: address changes and fix errors in `chrome://accessibility` (#41911 ) refactor: address changes and fix errors in chrome://accessibility	2024-04-23 11:30:47 -04:00
tuanzijiang	46adb0a3a9	fix: offscreen rendering does not paint after gpu process crashed (#41904 ) Co-authored-by: zhangqi.67 <zhangqi.67@bytedance.com>	2024-04-22 09:50:55 -04:00
Charles Kerr	0346e0a8bf	refactor: use `std::erase()` (#41881 ) * refactor: use std::erase() in WebContentsPreferences::~WebContentsPreferences() * refactor: use std::erase() in WindowList::RemoveWindow() * refactor: use std::erase() in ElectronBindings::EnvironmentDestroyed() * refactor: use std::erase() in CleanedUpAtExit::~CleanedUpAtExit() * refactor: use std::erase_if() in ElectronBrowserContext::RevokeDevicePermission() * refactor: use std::erase_if() in UsbChooserController::GotUsbDeviceList() * refactor: move DoesDeviceMatch() out of class into anonymous namespace	2024-04-19 10:55:59 -05:00
Shelley Vohr	39bf441b3b	build: enable Perfetto in Chromium (#41880 ) * build: enable perfetto in Chromium * refactor: delete TracingControllerImpl * fix: TraceObject isn't present when v8_use_perfetto is true * fix: update lib/internal/http for perfetto * chore: remove stray log	2024-04-19 11:07:36 -04:00
JakobDev	07a68c2bf8	fix: don't check for Desktop Environment in unity_service.cc (#41211 ) Don't check for Desktop Environment in unity_service.cc	2024-04-19 09:58:32 -04:00
Jeremy Rose	ed9fec7da4	fix: `nativeImage.createThumbnailFromPath` and `shell.openExternal` in renderer (#41875 ) * fix: nativeImage.createThumbnailFromPath in renderer * also fix shell.openExternal	2024-04-19 09:43:01 -04:00
Jeremy Rose	67ba30402b	refactor: JSify BrowserWindow unresponsive handling (#37902 )	2024-04-18 13:14:07 -07:00
Charles Kerr	b683754c16	chore: remove unused hash function (#41876 ) Unused since `e1e73fa` #24115	2024-04-17 19:04:06 -05:00
James Yuzawa	bf754a3cae	fix: make window.flashFrame(bool) flash continuously on macOS (#41391 ) fix: window.flashFrame to flash continuously on mac This brings the behavior to parity with Windows and Linux. Prior behavior: The first `flashFrame(true)` bounces the dock icon only once (using the [NSInformationalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nsinformationalrequest) level) and `flashFrame(false)` does nothing. New behavior: Flash continuously until `flashFrame(false)` is called. This uses the [NSCriticalRequest](https://developer.apple.com/documentation/appkit/nsrequestuserattentiontype/nscriticalrequest) level instead. To explicitly use `NSInformationalRequest` to cause a single dock icon bounce, it is still possible to use [`dock.bounce('informational')`](https://www.electronjs.org/docs/latest/api/dock#dockbouncetype-macos).	2024-04-17 12:42:34 -04:00
electron-roller[bot]	7120c58297	chore: bump node to v20.12.2 (main) (#41710 ) * chore: bump node in DEPS to v20.12.0 * chore: update build_add_gn_build_files.patch * chore: update patches * chore: bump node in DEPS to v20.12.1 * chore: update patches * build: encode non-ASCII Latin1 characters as one byte in JS2C https://github.com/nodejs/node/pull/51605 * crypto: use EVP_MD_fetch and cache EVP_MD for hashes https://github.com/nodejs/node/pull/51034 * chore: update filenames.json * chore: bump node in DEPS to v20.12.2 * chore: update patches * src: support configurable snapshot https://github.com/nodejs/node/pull/50453 * test: remove test-domain-error-types flaky designation https://github.com/nodejs/node/pull/51717 * src: avoid draining platform tasks at FreeEnvironment https://github.com/nodejs/node/pull/51290 * chore: fix accidentally deleted v8 dep * lib: define FormData and fetch etc. in the built-in snapshot https://github.com/nodejs/node/pull/51598 * chore: rebase on main * chore: remove stray log --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Cheng <zcbenz@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>	2024-04-17 12:39:13 -04:00
Shelley Vohr	b118c70f77	refactor: fold silent print into settings (#41873 ) * refactor: fold silent print into settings * chore: feedback	2024-04-17 12:04:47 -04:00
Charles Kerr	b428315c6d	perf: remove unnecessary `.c_str()` calls (#41869 ) * perf: remove unnecessary c_str() call when invoking promise.RejectWithErrorMessage() RejectWithErrorMessage() takes a std::string_view * perf: remove unnecessary c_str() call when invoking Environment::SetVar() the val arg to Environment::SetVar() takes a const std::string& * refactor: use string_view variant of base::UTF8ToWide() * perf: remove unnecessary c_str() call when instantiating a ScopedHString ScopedHString has always taken a StringPiece * refactor: use simpler invocation of base::make_span() * perf: remove unnecessary c_str() call when calling base::CommandLine::HasSwitch() HasSwitch() already takes a string_piece * perf: remove unnecessary c_str() call when calling net::HttpResponseHeaders::AddHeader() AddHeader() already takes a StringPiece arg * perf: omit unnecessary str -> wstr -> str conversion in DesktopCapturer::UpdateSourcesList() this conversion was made redundant by `c670e38`	2024-04-16 19:48:54 -04:00
electron-roller[bot]	c670e38b4b	chore: bump chromium to 125.0.6412.0 (main) (#41610 ) * chore: bump chromium in DEPS to 124.0.6361.0 * chore: bump chromium in DEPS to 124.0.6363.0 * chore: update patches Manually apply printing.patch w/no code changes due to upstream shear. Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5349263 * chore: bump chromium in DEPS to 124.0.6365.0 * chore: bump chromium in DEPS to 124.0.6367.0 * update patches * 5371735: Rename SystemGeolocationSourceMac to SystemGeolocationSourceApple https://chromium-review.googlesource.com/c/chromium/src/+/5371735 * missed a MAS bit * chore: update windows toolchain 5350823: New toolchain for Windows 11 10.0.22621.2428 SDK \| https://chromium-review.googlesource.com/c/chromium/src/+/5350823 * chore: bump chromium in DEPS to 125.0.6368.0 * fix patches * chore: update patches * 5232401: [PDF] Move generic utils from //chrome to //components/pdf (1/2) https://chromium-review.googlesource.com/c/chromium/src/+/5232401 * revert https://chromium-review.googlesource.com/c/chromium/src/+/5380898 * chore: bump chromium in DEPS to 125.0.6370.0 * build: use updated windows toolchain * fix patches * chore: update patches * more pdf_util to components * 5372414: [Extensions] Remove DispatcherDelegate https://chromium-review.googlesource.com/c/chromium/src/+/5372414 * fix accessibility_ui patch * chore: bump chromium in DEPS to 125.0.6372.0 * chore: bump chromium in DEPS to 125.0.6374.0 * chore: bump chromium in DEPS to 125.0.6376.0 * chore: bump chromium in DEPS to 125.0.6378.0 * chore: bump chromium in DEPS to 125.0.6379.3 * chore: update patches (+ MAS patch changes) * chore: update patches * 5381159: Cleanup media::KeySystemSupportObserver https://chromium-review.googlesource.com/c/chromium/src/+/5381159 * 5382233: Reland "Web `Speech to Text` with SODA backend" https://chromium-review.googlesource.com/c/chromium/src/+/5382233 * chore: update `exclusive_access` patch - 5367497: Add a metric for the website state when Fullscreen API is requested - https://chromium-review.googlesource.com/c/chromium/src/+/5367497 * chore: add build dependency 5367497: Add a metric for the website state when Fullscreen API is requested https://chromium-review.googlesource.com/c/chromium/src/+/5367497 * chore: bump chromium in DEPS to 125.0.6382.0 * chore: update libcxx filenames * chore: update patches * chore: bump chromium in DEPS to 125.0.6384.0 * chore: remove old patch * 5394039: [Extensions] Change "blessed" -> "privileged" in extension feature files https://chromium-review.googlesource.com/c/chromium/src/+/5394039 * fix: remove deprecated errno constants in node/libuv * 5362194: Return expected from ProcessMetrics CPU methods https://chromium-review.googlesource.com/c/chromium/src/+/5362194 * 5383927: Add new Pickle factory functions with explicit ownership https://chromium-review.googlesource.com/c/chromium/src/+/5383927 * 5373340: Simplify app-region/Draggable Region implementation https://chromium-review.googlesource.com/c/chromium/src/+/5373340 * 5386875: Cleanup printing preferences files https://chromium-review.googlesource.com/c/chromium/src/+/5386875 * chore: update libc++ filenames * fix: add enterprise buildflags dep * chore: bump chromium in DEPS to 125.0.6386.0 * chore: add build dep * chore: update patches * chore: bump chromium in DEPS to 125.0.6388.0 * chore: bump chromium in DEPS to 125.0.6390.0 * chore: update patches * 4918014: preloading: Add NewTabPagePageLoadMetricsObserver https://chromium-review.googlesource.com/c/chromium/src/+/4918014 * 5401234: [PDF] Remove `PDFDocumentHelperClient::FindPdfChildFrame` API https://chromium-review.googlesource.com/c/chromium/src/+/5401234 * 5116175: Relocate Windows XPS printing feature helper methods https://chromium-review.googlesource.com/c/chromium/src/+/5116175 * fixup! 5373340: Simplify app-region/Draggable Region implementation https://chromium-review.googlesource.com/c/chromium/src/+/5373340 * fixup! chore: add build dep * chore: remove dead code & dead patch Was dealing with https://chromium-review.googlesource.com/c/chromium/src/+/5402805 when I realized this code is no longer possible to call. It seems like this code became dead in the previous roll (#41514). The patch exposed a `DxdiagDx12VulkanRequested` method on Chromium's `GpuDataManagerImpl`, which we consumed only in our own `GPUInfoManager::NeedsCompleteGpuInfoCollection`. There are no other references to this method, so it and the patch can both be deleted. Yay! * chore: bump chromium in DEPS to 125.0.6392.0 * chore: bump chromium in DEPS to 125.0.6393.0 * chore: update patches * chore: bump chromium in DEPS to 125.0.6394.0 * chore: bump chromium in DEPS to 125.0.6396.0 * chore: bump chromium in DEPS to 125.0.6397.0 * chore: update printing.patch Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5100842 No code changes, but had to apply patch manually due to upstream code shear * chore: update add_maximized_parameter_to_linuxui_getwindowframeprovider.patch No manual changes; patch applied with fuzz 1 * chore: update feat_allow_code_cache_in_custom_schemes.patch No manual changes; patch applied with fuzz 2 * chore: silence "space before tab in indent" git rebase-apply warning * chore: e patches all * build: update all.gn to avoid FTBFS when disabling raw_ptr Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5371737 * Rename PdfService Mojo interface to PdfHost Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5411957 * chore: bump chromium in DEPS to 125.0.6398.0 * chore: update patches * chore: bump chromium in DEPS to 125.0.6400.0 * chore: update patches * [media] Remove unused `GetSupportedKeySystems` from MediaClient Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5420247 * chore: update JSInjection::New call to match upstream change Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5403967 [Extensions] Wire up the renderer for multiple user script worlds * 5362362: Derive display ID from monitor adapter ID instead of szDevice. https://chromium-review.googlesource.com/c/chromium/src/+/5362362 * 5116175: Relocate Windows XPS printing feature helper methods https://chromium-review.googlesource.com/c/chromium/src/+/5116175 * chore: add v8-sandbox.h to electron-node * chore: update patches * chore: update patches * fixup! 5394039: [Extensions] Change blessed -> privileged in extension feature files * chore: bump chromium in DEPS to 125.0.6412.0 * chore: update patches * chore: node script/gen-libc++-filenames.js * [FPF] Create Fingerprinting Protection ruleset service. Refs https://chromium-review.googlesource.com/c/chromium/src/+/5420158 * Add ExclusiveAccessPermissionManager Refs https://chromium-review.googlesource.com/c/chromium/src/+/5273787 * Preserve the PNG colorspace when decoding into a SkBitmap. Refs https://chromium-review.googlesource.com/c/chromium/src/+/5421254 * chore: iwyu * fix: abstract-socket compilation * ci: bump container for node 20 support * fixup! abstract-socket compilation * fix: compiling nan specs * chore: revert winreg version bump accidental bump to 1.2.5 revealed failing app.setasdefaultprotocolclient test suite. Should be revisited separately. * ci: set node 20 for darwin x64 tests * fix: broken patch export * chore: cleanup mas_avoid_private_macos_api_usage.patch.patch Removed code that was inadvertently put back after https://chromium-review.googlesource.com/c/chromium/src/+/5348565 removed it --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Jeremy Rose <jeremya@chromium.org> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: clavin <clavin@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: deepak1556 <hop2deep@gmail.com>	2024-04-15 18:10:32 -04:00
lauren n. liberda	6aa9a003c8	fix: stop using std::vector<const uint8_t> in ProcessingSingleton (#41832 )	2024-04-15 10:32:48 -07:00
Shelley Vohr	2a6ad42113	chore: delete unused PrintPreviewMessageHandler (#41841 )	2024-04-15 11:34:56 -04:00
Mitchell Cohen	05fba85aa3	fix: do not activate app when showing a panel on Mac (#41750 ) * fix: do not activate app when showing or focusing a panel on Mac * restored panel activation test	2024-04-12 14:27:59 +02:00
Shelley Vohr	db11090e58	fix: silent printing default dpi on Windows (#41811 )	2024-04-11 19:56:39 -04:00
Shelley Vohr	344aba0838	feat: implement File System API support (#41419 )	2024-04-10 22:06:47 +02:00
RoboSchmied	41ba963392	fix: typos in comment section of `in_app_purchase.mm` (#41788 ) fix 2 typo Signed-off-by: Michael Seibt <github@roboschmie.de>	2024-04-10 11:54:56 -04:00
Shelley Vohr	43a9f70d19	feat: support `NODE_EXTRA_CA_CERTS` (#41689 ) * feat: support NODE_EXTRA_CA_CERTS * chore: allow disabling NODE_EXTRA_CA_CERTS * chore: call base::Environment::UnSetVar * docs: link to fuses from env vars * chore: update patch to match upstream * docs: note enabled by default * Update environment-variables.md Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> --------- Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>	2024-04-10 10:30:35 -04:00
Shelley Vohr	38ef9a7690	refactor: move PDF viewer to OOPIF (#41728 ) https://issues.chromium.org/issues/40268279	2024-04-09 19:59:48 -04:00
Shelley Vohr	ba3b647fd7	fix: WCO maximize button visibility when non-maximizable (#41793 ) fix: WCO button visibility when non-maximizable	2024-04-09 13:14:29 +02:00
Jeremy Rose	76f7bbb0a8	fix: move BrowserWindow's WebContentsView to be a child of rootview (#41256 )	2024-04-08 10:30:23 -07:00
Bruno Pitrus	22c149812c	build: add missing header for `content::SyntheticGestureTarget` (#41789 ) IWYU: add missing header for `content::SyntheticGestureTarget` GNU libstdc++ does not allow using std::unique_ptr on incomplete types, leading to a compile error.	2024-04-08 18:17:00 +02:00
Calvin	3eb94b72ba	feat: Options parameter for `Session.clearData` API (#41355 ) * feat: Options parameter for `Session.clearData` API * Consolidate & curate data type categories * Update docs for better typing * off-by-one typo * refactor to use `std::shared_ptr` instead of `base::RefCounted` * fix compile errors * std::enable_shared_from_this didn't work 🤷 * Refine docs with defaults	2024-04-01 12:09:01 -04:00
Shelley Vohr	0bf53a3876	fix: `Storage.{get\|set\|clear}Cookies` via CDP not working (#41718 )	2024-03-28 16:09:27 -07:00
Shelley Vohr	61457c9498	feat(serial): allow Bluetooth ports to be requested by service class ID (#41638 ) * feat(serial): allow Bluetooth ports to be requested by service class ID * fix: bluetooth dependency	2024-03-28 18:23:13 +01:00
taoky	4f76fff978	fix: don't do self-destroy in LibnotifyNotification::Dismiss() (#41691 ) Callers of Notification::Dismiss() assume that the notification instance is not deleted after the call, but this was not the case for LibnotifyNotification: - Destroy() would get `this` deleted. - notify_notification_close() in portal environment triggers LibnotifyNotification::OnNotificationClosed(), and finally calls Destroy() This patch removes all Destroy() in Dismiss(), and adds a boolean to tell whether notify_notification_close() is running, to avoid crash under portal environment. Fixes #40461.	2024-03-27 10:53:23 +01:00
Shelley Vohr	32b44aa5c8	fix: crash on extension unload when script validation finishes (#41686 ) https://chromium-review.googlesource.com/c/chromium/src/+/5225796	2024-03-26 14:32:06 +01:00
Shelley Vohr	7032c0d03c	test: add test and `api_feature` definition for `chrome.scripting.globalParams` (#41685 ) chore: add test and api_feature for chrome.scripting.globalParams	2024-03-26 12:33:47 +01:00
Shelley Vohr	8c427253b3	refactor: update `gin_helper/function_template` (#41534 ) * refactor: update gin_helper/function_template * fix: crash in Node.js Worker threads	2024-03-25 10:01:54 +01:00
Piotr Płaczek	90a7e5acae	fix: normalize path before calling `showItemInFolder` and `openPath` (#41642 ) * fix: normalize path before calling ShowItemInFolder * fix: normalize path before calling OpenPath	2024-03-22 10:28:44 -04:00
Shelley Vohr	707b9a58cc	fix: `app.setLoginItemSettings` error getting swallowed by gin conversion (#41647 ) * fix: errors getting swallowed by gin conversion * fix: Windows build * test: re-enable disabled test	2024-03-22 09:00:21 -04:00

1 2 3 4 5 ...

3487 commits