mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: accidental handle copying in a range loop (#43260)

Browse source 
fix: accidental handle copying

Xref: https://github.com/electron/electron/pull/37857
This commit is contained in:
Charles Kerr 2024-08-09 13:38:03 -05:00 • committed by GitHub
parent 346244ef9e
commit c4dfff9844
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
shell/browser/api/message_port.cc
View file

@ -9,6 +9,7 @@
#include <utility>
#include "base/containers/contains.h"
#include "base/containers/to_vector.h"
#include "base/strings/string_number_conversions.h"
#include "base/task/single_thread_task_runner.h"
#include "gin/arguments.h"
@ -250,11 +251,7 @@ std::vector<blink::MessagePortChannel> MessagePort::DisentanglePorts(
}
// Passed-in ports passed validity checks, so we can disentangle them.
std::vector<blink::MessagePortChannel> channels;
channels.reserve(ports.size());
for (auto port : ports)
channels.push_back(port->Disentangle());
return channels;
return base::ToVector(ports, [](auto& port) { return port->Disentangle(); });
}
void MessagePort::Pin() {