Cheng Zhao
88f6f5d1b2
Fix compilation errors for Linux
2017-01-19 09:05:59 +02:00
Cheng Zhao
497f5a1199
Update files for Chrome 54 API changes
2017-01-19 09:05:59 +02:00
Kevin Sawicki
0244a73c49
Fix cpp linter errors
2017-01-16 09:26:07 -08:00
Brian Clifton
9e0547b98f
Fix the rendering for the rounded edges
2017-01-14 01:15:22 -08:00
Brian Clifton
cf6e215a66
Properly handle borders for DPI > 100% on Windows
...
Fixes https://github.com/electron/electron/issues/4573
cc: @zcbenz, @kevinsawicki, @zeke
2017-01-13 00:18:42 -07:00
Kevin Sawicki
222734b5f5
Use correct param ordering in header file
2017-01-09 08:30:13 -08:00
Phil Christensen
2c259990da
fix permissive C++ code (MSVC /permissive-)
...
These were found by the C++ compiler group when doing "Real world code"
build tests using /permissive-. We are sharing these with you to help clean up
your code before the new version of the compiler comes out. For more information on
/permissive- see https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/ .
In paticular, see the "Do not treat copy initialization as direct initialization"
section of the blog.
2017-01-05 09:38:41 -08:00
Kevin Sawicki
8c5f26373b
Add override
2016-12-22 09:33:21 -08:00
Kevin Sawicki
87f09131aa
Observe window and only use it when it is open
2016-12-22 09:33:21 -08:00
Pedro Belo
89e8ad4947
Fix support for dragging urls in Mac
2016-11-19 21:18:24 -08:00
liusi
9e91f319c1
fix linting error
2016-11-15 13:19:34 +08:00
liusi
06cfcd612d
disable accelerator when menu item is disabled
2016-11-14 12:29:27 +08:00
Kevin Sawicki
98387e50cc
Focus window on menu bar click
2016-10-24 11:49:51 +09:00
Kevin Sawicki
9cae04edde
Remove unused ButtonListener
2016-10-03 10:26:18 -07:00
Kevin Sawicki
11684c2c73
Focus submenu buttons when clicked
2016-10-03 10:13:41 -07:00
Kevin Sawicki
b3b9994ce8
Configure ink drops on menu bar buttons ( #7397 )
...
* Add ink drop to menu bar buttons
* Pass background color to submenu button
* Sort includes
2016-09-29 09:15:12 -07:00
Cheng Zhao
cdfcca147a
Fix warning when compiling for win32 ia32 build
2016-09-02 13:59:28 +09:00
Vadim Macagon
c64294cf60
Extend the custom Jump List API
...
Add `app.getJumpListSettings()` and `app.setJumpList(callback)` that
make it possible to fully customize the Jump List of an Electron app.
It is now possible to:
- Add tasks to the standard `Tasks` category.
- Add separators to the standard `Tasks` category.
- Add custom categories containing tasks and file links.
- Add system managed Recent/Frequent categories.
- Remove the custom Jump List.
2016-09-01 09:56:14 +07:00
Kevin Sawicki
3dd5628ded
Include windows.h first
2016-08-26 16:00:05 -07:00
Kevin Sawicki
6285500cdc
Sort includes alphabetically
2016-08-26 15:30:02 -07:00
Cheng Zhao
06d2dfe119
Merge pull request #6788 from electron/felix-progress-enum
...
Use enum to declare ProgressState
2016-08-18 14:35:00 +09:00
Cheng Zhao
56d17a1449
Merge pull request #6829 from electron/fix-thumbar-buttons-vanishing
...
Save the thumbar buttons when setting them to restore later
2016-08-18 14:34:26 +09:00
Kevin Sawicki
4fc4f0ae53
Only call setCanSelectHiddenExtension for save dialogs
2016-08-16 17:22:44 -07:00
Samuel Attard
2fa7aa3c71
Save the thumbar buttons when setting them
...
Then restore the buttons when restoring the taskbar icon
2016-08-13 01:55:42 +10:00
Felix Rieseberg
8b85ee8a20
🔧 Use enum to declare ProgressState
...
As recommended in #6768 , this commit adds an enum for progress states for windows.
2016-08-10 08:56:26 -07:00
Kevin Sawicki
2802d2f3f9
Use gfx::Rect::ToRECT
2016-08-09 08:50:06 -07:00
Kevin Sawicki
5f2a13d01b
Convert dip to screen rect for thumbnail clip
2016-08-09 08:40:38 -07:00
Cheng Zhao
dd79c71302
Style fixes for SetProgressBar
2016-08-09 21:02:14 +09:00
Cheng Zhao
81244c2221
Merge pull request #6768 from electron/felix-set-progress
...
Enable mode indication for setProgressBar
2016-08-09 20:58:07 +09:00
Felix Rieseberg
73c91dae9e
🔧 Enable mode indication for setProgressBar
...
This commit enables setting a mode for the setProgressBar method.
Old behavior is kept intact, usage is entirely optional.
2016-08-08 15:52:20 -07:00
Kevin Sawicki
bcc372568f
Add zoom menu item roles
2016-08-08 11:09:30 -07:00
Kevin Sawicki
59ffe35781
Merge pull request #6765 from miniak/menu-speaking-roles
...
Add macOS specific speaking roles for MenuItem
2016-08-08 11:06:45 -07:00
Milan Burda
a6125c538e
Add BrowserWindow.prototype.setThumbnailToolTip
2016-08-08 12:05:47 +02:00
Milan Burda
edc1a9614c
Add macOS specific speaking roles for MenuItem
2016-08-08 00:02:32 +02:00
Kevin Sawicki
b2f9cce297
Add option to always highlight the tray icon
2016-07-26 13:51:43 -07:00
Cheng Zhao
b57665330c
Merge branch 'master' into chrome52
2016-07-21 05:34:36 -06:00
Cheng Zhao
d186a01815
Merge pull request #6497 from electron/windows-thumbnail
...
Add setThumbnailClip API on Windows
2016-07-15 10:18:39 +09:00
Cheng Zhao
16e43a7f15
Merge pull request #6490 from wilsonpage/add-drop-text-support
...
Add support for dropped text in osx
2016-07-15 09:12:35 +09:00
Kevin Sawicki
86218fe773
win: Add setThumbnailClip window API
2016-07-14 15:50:31 -07:00
Wilson Page
90f8a7e828
Add support for dropped text in osx
2016-07-14 18:25:58 +01:00
Cheng Zhao
7848608198
Replace DialogScope with UnresponsiveSuppressor
...
The latter is global-wide.
2016-07-11 15:29:03 +09:00
Cheng Zhao
fc72df3ba1
win: Use FOS_FORCESHOWHIDDEN for showHiddenFiles
2016-07-11 13:49:51 +09:00
Cheng Zhao
6e0fadbe26
gtk: Set show-hidden property for showHiddenFiles
2016-07-11 13:47:24 +09:00
Cheng Zhao
f08ac07737
mac: Add showHiddenFiles property for showOpenDialog
2016-07-11 13:30:18 +09:00
Haojian Wu
4ac4dacffe
Some manual change to for-ranged loop.
...
Use "const auto&" where possible.
2016-07-10 15:57:51 +02:00
Haojian Wu
55b3f1936f
Modernize to C++11: Use for-range loop.
2016-07-10 13:33:15 +02:00
Kevin Sawicki
cb943cec77
🎨
2016-07-07 14:28:01 -07:00
Kevin Sawicki
10a2454921
Remove unneeded atom:: prefix
2016-07-07 14:25:09 -07:00
Kevin Sawicki
2faf00dc19
Only use default accelerator in Windows/Linux app menu
2016-07-07 11:50:19 -07:00
Cheng Zhao
6381f44f26
mac: Pass useDefaultAccelerator to getAcceleratorForCommandId
2016-07-07 11:50:19 -07:00
Cheng Zhao
381689d3ed
Fix building on Windows
2016-07-05 09:31:29 +09:00
Cheng Zhao
1ba3907038
Update to API changes of Chrome 52
2016-07-04 15:32:43 +09:00
Cheng Zhao
7916f0ea18
win: Use drag_utils::CreateDragImageForFile
2016-07-03 14:44:47 +09:00
Cheng Zhao
63a8961ed1
views: Implement webContents.startDrag
2016-07-03 14:34:35 +09:00
Cheng Zhao
fa468a529b
Support dragging multiple files
2016-07-03 13:58:31 +09:00
Cheng Zhao
13c668f22b
mac: Implement webContents.startDrag
2016-07-03 12:26:43 +09:00
Cheng Zhao
431ea61ff8
Don't use MatchesExtension for matching filters
...
MatchesExtension compares double extensions like .tar.gz, which does not
match the filters.
2016-07-01 22:55:15 +09:00
Kevin Sawicki
45dbbfdfe9
Use nullptr comparisons
2016-06-29 11:52:58 -07:00
Kevin Sawicki
e797eb5ca3
Use set context menu when param is not specified
2016-06-29 11:52:58 -07:00
Florent Delayen
4d55175649
Execute click handlers for top level menu items
2016-06-25 16:51:43 +02:00
Cheng Zhao
4e811fc377
Merge pull request #6169 from electron/map-roles-by-command-id
...
Map roles by command id instead of index
2016-06-22 01:24:20 +00:00
Cheng Zhao
c0aebc9d4f
Merge pull request #6168 from electron/forward-delete
...
Support forward delete menu item accelerator
2016-06-22 01:12:10 +00:00
Kevin Sawicki
812dea9a8b
Add comment about map key/values
2016-06-21 15:28:02 -07:00
Kevin Sawicki
583cc925ac
Map roles by command id
2016-06-21 15:25:14 -07:00
Kevin Sawicki
738edb650d
Make NSDeleteFunctionKey to NSDeleteCharacter
2016-06-21 12:33:02 -07:00
Kevin Sawicki
2536e62fb0
Add togglefullscreen role selector
2016-06-21 09:34:29 -07:00
Kevin Sawicki
67f7b4d4c5
Map quit role to terminate selector
2016-06-21 09:08:13 -07:00
Cheng Zhao
aca37c8974
Update menubar color when theme changes
2016-06-21 18:05:01 +09:00
Cheng Zhao
816b2ea8f2
linux: Disable parent window when showing modal dialogs ( #6160 )
2016-06-21 08:54:55 +00:00
Cheng Zhao
324153d394
win: Use DIP rect for tray icon's bounds
2016-06-21 16:05:28 +09:00
Cheng Zhao
886ef1717c
win: Implement tray.getBounds() API
2016-06-21 15:49:22 +09:00
Cheng Zhao
db98e256f2
mac: Add tray.getBounds() API
2016-06-21 15:40:30 +09:00
Cheng Zhao
5e459b057e
Use fixed ID for app indicators
2016-06-20 17:35:45 +09:00
Cheng Zhao
9aa7291627
linux: Implement win.disable/enable/isEnabled() API
2016-06-20 11:16:41 +09:00
Leonard Lamprecht
67dd19ed0f
Replace OS X and Mac OS with macOS
2016-06-18 15:26:26 +02:00
Vadim Macagon
a6f0fcf89f
Fix typo in atom::TaskbarHost::InitializeTaskbar()
...
`InitailizeTaskbar` -> `InitializeTaskbar`
2016-06-09 12:21:21 +07:00
Daniel Pham
bd1eae86a1
Add 'delete' and 'pasteandmatchstyle' roles
2016-06-05 21:50:37 -04:00
Cheng Zhao
44651656dd
Fix building on Windows
2016-05-23 16:39:19 +09:00
Cheng Zhao
7ba391da7c
Update to API changes of Chrome 51
2016-05-23 10:59:39 +09:00
Cheng Zhao
3182485e68
No need to reference the icon in Tray
2016-05-20 22:44:02 +09:00
Cheng Zhao
9e26e5c121
Load HICON directly in NotifyIcon
2016-05-20 16:55:22 +09:00
Cheng Zhao
e53bfad018
Fix building on Windows
2016-05-16 10:09:41 +09:00
Ben Gotow
54c654530e
Fix linux support
2016-05-15 01:29:13 -05:00
Ben Gotow
6217d497ed
Fix build issues
2016-05-15 01:03:32 -05:00
Ben Gotow
40c531737d
Add buttonLabel param to showOpen/showSave dialogs
2016-05-15 01:03:32 -05:00
Cheng Zhao
e77582baee
Fix compilation warnings introduced by VS 2015
2016-05-13 11:12:01 +09:00
Brian R. Bondy
f93fa53aea
Update linux menu overrides
2016-05-13 11:07:17 +09:00
Brian R. Bondy
732936713a
GetNativeScreen -> GetScreen
2016-05-13 11:07:17 +09:00
Cheng Zhao
b32bc8cf3e
Merge pull request #5502 from anthonyryan1/master
...
Replace gtk_widget_hide_all with gtk_widget_hide
2016-05-12 19:37:25 +09:00
Anthony Ryan
c29b844a97
Replace gtk_widget_hide_all with gtk_widget_hide
...
gtk_widget_hide_all was deprecated in gtk+ 2.24 and was removed
entirely in recent versions. This is a pretty straight forward
replacement.
2016-05-11 15:33:43 -04:00
deepak1556
64718888dd
dialog: resize icon on linux before showing
2016-05-11 22:30:10 +05:30
Daniel Pham
21af03d71a
🍎 Fix converting from windows virtual keycode back to mac keycode
2016-04-26 10:53:26 -04:00
Cheng Zhao
548febfa4c
Fix style issues
2016-04-07 15:23:16 +09:00
Ben Gotow
e0ee60f290
Fix memory leak
2016-04-07 15:21:07 +09:00
Ben Gotow
91457fe739
Support images larger than self.bounds
2016-04-07 15:21:07 +09:00
Ben Gotow
f9644463a9
Fix broken template image support in Tray icon
...
Between Electron `0.30.x` and `0.37.x`, the tray icon stopped automatically inverting template images when highlighted. NSImageView normally uses the correct color for template images magicaly, but I think the addition of event handlers in the container view prevents the image view from determining highlight state.
This PR switches to drawing the image manually. The `drawRect` function decides whether to use `image` or `alternateImage`(pressed image) and then if that image is marked as a template, it fills it with the same color used for the text before drawing it.
2016-04-07 15:21:07 +09:00
Cheng Zhao
c2797e1864
Replace extension with the one in filter
2016-03-14 17:08:32 +09:00
Cheng Zhao
81a16b424f
Add extension to filename automatically for GTK+ save dialog
2016-03-14 16:28:01 +09:00
Cheng Zhao
20466bad8f
Fix cpplint warnings
2016-03-10 17:06:23 +09:00
Paul Betts
f4ec369873
More boring fixups
2016-03-10 17:06:22 +09:00
Paul Betts
1c01e4955f
Modifiers moved under UI
2016-03-10 17:06:22 +09:00
Paul Betts
12e9b7ab88
Use assignment operator since both sides are scoped now
2016-03-10 17:06:22 +09:00
Paul Betts
60a2495b30
Update Get() => get(), Set() => reset()
2016-03-10 17:06:22 +09:00
Cheng Zhao
a31cbd24a1
Final pieces of int16 and .Pass()
2016-03-10 17:06:21 +09:00
Cheng Zhao
5fae63a2f5
Fix compilation errors on OS X
2016-03-10 17:06:21 +09:00
Paul Betts
d2944c62a5
basictypes.h => macros.h
2016-03-10 17:06:21 +09:00
Cheng Zhao
549cccfce4
Merge pull request #4715 from dongjoon-hyun/fix_typos_in_comments
...
Fix typos in comments.
2016-03-08 19:45:05 +09:00
Dongjoon Hyun
0c92d44077
Fix typos in comments.
2016-03-07 20:22:03 -08:00
Machisté N. Quintana
2bfc7aa152
Add mapping for performZoom
2016-03-07 16:01:46 -08:00
Machisté N. Quintana
eae5cc9d2c
🎨 [ci skip]
2016-03-07 15:53:09 -08:00
Machisté N. Quintana
4ded709307
Map selectors for delete and pasteAndMatchStyle to roles
2016-03-07 15:42:32 -08:00
Cheng Zhao
2515425cd5
Remove duplicated keyboard code
2016-03-06 15:04:05 +09:00
Dongjoon Hyun
fee56df400
Rename function FilterAccecelator
to FilterAccelerator
in submenu_button.cc
.
2016-02-24 11:15:21 -08:00
Cheng Zhao
49f995925c
Notify the global menu bar when window is mapped
2016-02-23 15:43:32 +08:00
Kevin Sawicki
756aeffe03
Set icon on NSAlert when specified
2016-02-08 15:18:05 -08:00
Heilig Benedek
61e0219e91
Added documentation, restructured the files to fit better with electron's style and fixed a typo in keyboard_util's name.
2016-01-31 02:27:14 +01:00
Robo
65325dc63f
browser: fix crash when switching to sibling menu from submenus
2016-01-20 10:54:12 +05:30
Cheng Zhao
26bd97d6cf
Fix style issues of #4029
2016-01-11 21:12:07 +08:00
leethomas
fee301e768
follow style guidelines
2016-01-10 19:15:40 -08:00
leethomas
803b06b7de
🏁 support defaultId for dialog boxes on Windows
2016-01-10 15:55:26 -08:00
leethomas
ae5c6add11
rename all references to default_button_index -> default_id to keep consistent with cancel_id
2016-01-10 15:33:27 -08:00
leethomas
dfce803045
🏁 update windows message_box function signatures to accept default_button_index....and do nothing with it
2016-01-08 08:23:06 -08:00
leethomas
22c455175a
🐧 add default button index for linux/gtk
2016-01-08 08:22:10 -08:00
leethomas
f1edd5f26f
🍎 add default button index for osx
2016-01-08 08:21:54 -08:00
leethomas
59eda67ba4
🍎 🐛 make displaying alternate tray image depend on mouse down event instead of highlight state
2016-01-05 09:49:27 -08:00
Cheng Zhao
2b6ac966c0
Do not write our own filter code
...
The Win32 API has done everything for us, there is no need to do this
oursevles.
2016-01-05 13:45:34 +08:00
Cheng Zhao
698700716b
Show menu by clicking the menu button
2016-01-05 12:05:27 +08:00
Cheng Zhao
43bfce26a7
Do not behave like bookmarkbar menu
2016-01-05 11:57:58 +08:00
Cheng Zhao
8aced2c31e
Add comment on why checking empty set
2015-12-31 18:58:16 +08:00
Cheng Zhao
b308cd6f96
Merge pull request #3967 from leethomas/fix-osx-crash-when-extensions-empty
...
🍎 fix #3864 where saving a file causes a crash if file extensio…
2015-12-31 18:51:55 +08:00
leethomas
eac2f6fec3
🍎 only add sub menus to Window when they actually have menu items. fixes #3873
2015-12-30 19:38:14 -08:00
leethomas
ba26a4b4e6
🍎 fix #3864 where saving a file causes a crash if file extension array is empty
2015-12-30 13:26:38 -08:00
Nishanth Shanmugham
2bbf86c524
tray: Support file-drop from OS X Dock
...
A long-standing Apple bug does not call `prepareForDragOperation:sender`
for file drag-and-drop operations from the Dock. So we manually
call our custom `handleDrop:sender` for all drag-and-drop cases (that
is, from the Dock and from Finder).
References to the bug in question:
- http://stackoverflow.com/q/9534543/3309046
- http://openradar.appspot.com/radar?id=1745403
However, we still need to return YES from `prepareForDragOperation:sender`,
otherwise the "drag failed" animation occurs. For the same reason, we also
return YES from `performDragOperation:sender`.
2015-12-29 03:27:59 -06:00
Cheng Zhao
e8b5a6dedf
Merge pull request #3718 from atom/chrome47-linux
...
Port Chrome47 on Linux
2015-12-08 10:14:27 +08:00
Paul Betts
af28900189
Fix up Chrome47 changes
2015-12-07 13:27:05 -08:00
Paul Betts
3931ebb7ef
Fix up Windows build errors
2015-12-07 10:02:06 -08:00
Cheng Zhao
73e7773d84
Update to API changes of Chrome 47
2015-12-07 19:56:23 +08:00
Cheng Zhao
615ce45849
win: Implement menu parameter
2015-12-02 19:58:10 +08:00
Cheng Zhao
3cdd0f35c7
mac: Implement menu parameter
2015-12-02 19:05:22 +08:00
Cheng Zhao
2fba05b5e7
Add menu
parameter for Tray.popUpContextMenu
2015-12-02 18:43:11 +08:00
Cheng Zhao
87546bd4f8
Merge pull request #3479 from bengotow/tray-resizing
...
Fix sizing of Mac OS X tray icon after image change
2015-11-18 18:49:15 +08:00
Ben Gotow
9c69416e32
Fix sizing of Mac OS X tray icon after image change
...
- Consolidate logic that applies view dimensions into a function
- Use `NSVariableStatusItemLength` instead of trying to sync status item width
- Use modern Obj-C syntax `@[], @{}` in a few places
- Recompute view bounds after updating image in `setImage:`
2015-11-17 13:43:55 -08:00
Nishanth Shanmugham
d1e8e71e3f
Tray: Add drag-end and drop events
2015-11-10 10:02:50 -06:00
Nishanth Shanmugham
8a296f82a0
Tray: Remove extra qualification in header
2015-11-05 19:02:24 -06:00
Nishanth Shanmugham
818892d474
Tray: Add drag-entered and drag-exited events
2015-11-05 18:46:49 -06:00
mgarciaisaia
4013b652ff
🏁 🐛 Buffer overflows in tooltips
...
Fixes #3290 .
2015-11-04 15:34:58 +08:00
Cheng Zhao
c9b53a6e8b
Merge pull request #3240 from atom/reland-win-remove-wildcard-extension
...
Reland win remove wildcard extension
2015-10-27 20:52:43 +08:00
Haojian Wu
f69bafd48a
Win: Fix adding '.*' to filename in callback.
2015-10-27 20:15:43 +08:00
Haojian Wu
fa24e15d8b
Win: Remove adding '*.*' to file name in a save dialog.
2015-10-27 20:15:20 +08:00
Cheng Zhao
dacd921a04
Revert "Win: Remove adding default file filter(*.*) in a save dialog."
...
This reverts commit 00493f64b7
.
2015-10-27 14:58:44 +08:00