Cheng Zhao
2be368bded
SetFullScreen should not work at all when not fullscreenable
...
This follows the logic of OS X.
2016-03-05 21:38:06 +09:00
brenca
a06392459e
Making fullsceenable work on Linux
2016-02-27 22:37:42 +01:00
Heilig Benedek
bb42c85df8
resolve update conflicts
2016-02-27 03:23:10 +01:00
Heilig Benedek
bb0ac688b2
Reverted SetFullscreenable disabling maximize button on Windows and removed that from the docs.
2016-02-27 03:07:53 +01:00
Cheng Zhao
49f995925c
Notify the global menu bar when window is mapped
2016-02-23 15:43:32 +08:00
Heilig Benedek
39bb670719
Revert will-enter-full-screen event, matching osx fullscreen: false behaviour on windows instead
2016-02-22 10:23:56 +01:00
Heilig Benedek
a8ae14e94f
Introducing a will-enter-full-screen event that's cancellable
2016-02-09 01:17:05 +01:00
Cheng Zhao
cc560a3900
spec: Fix failing tests on Windows
2016-01-24 14:31:37 +08:00
Cheng Zhao
c41de501cb
spec: Test the -able methods
2016-01-24 14:31:37 +08:00
Cheng Zhao
239bfe970c
Make hasShadow work on Windows/Linux
2016-01-24 14:31:37 +08:00
Cheng Zhao
d704b3f7ba
Reorgnize how attributes work
2016-01-24 14:31:37 +08:00
Cheng Zhao
5372b6cd91
Fullscreenable => FullScreenable
2016-01-24 14:31:36 +08:00
Cheng Zhao
8cabe0f008
Merge pull request #4156 from evgenyzinoviev/windows-pr
...
Improvements in BrowserWindow
2016-01-22 23:42:41 -08:00
evgenyzinoviev
ef51e4e108
maximizable and fullscreenable
2016-01-22 23:21:46 +01:00
Cheng Zhao
21f5e27a5e
Merge pull request #4161 from gabriel/master
...
Support backgroundColor for window on mac
2016-01-21 15:42:21 -07:00
Gabriel Handford
239baa3e9a
Support backgroundColor for window on mac
2016-01-21 11:07:33 -08:00
evgenyzinoviev
fd5c249cb8
fix for windows
2016-01-19 16:58:19 +01:00
evgenyzinoviev
0a79204abb
IsMovable to return true on Linux
2016-01-19 16:44:04 +01:00
evgenyzinoviev
c3049e1e99
docs updated
2016-01-19 16:14:59 +01:00
evgenyzinoviev
2a554cb138
added or/and improved closable, minimizable, movable, resizable features for windows on os x and windows
2016-01-19 16:14:57 +01:00
evgenyzinoviev
64f310168c
code style fix
2016-01-15 17:40:42 +01:00
evgenyzinoviev
b75dccb0be
arguments handing rewritten, doc updated
2016-01-15 17:31:31 +01:00
evgenyzinoviev
2598b00b41
Animate window resizing on OS X
2016-01-15 05:59:58 +01:00
Cheng Zhao
3ca5b0ce23
win: Don't change transparent window's style
...
Close #1952 .
2016-01-06 23:02:33 +08:00
Cheng Zhao
d3d8ab7c66
linux: Fix pressing Alt not toggling window menu bar
2015-12-24 11:43:14 +08:00
Cheng Zhao
73e7773d84
Update to API changes of Chrome 47
2015-12-07 19:56:23 +08:00
Cheng Zhao
860c46b3c1
Separate options from switches
...
On Windows the case sensitivity of command line switches are ignored, so
--nodeIntegraion will become --nodeintegration.
We should separate options from switches so we use "nodeIntegraion" in
options, while passing "--node-integration" in command line.
2015-11-13 14:05:49 +08:00
Cheng Zhao
e36d455d51
Add setBackgroundColor method
2015-10-23 11:35:33 +08:00
Cheng Zhao
4a6134f3f7
win: Set native window's background color
2015-10-23 11:17:14 +08:00
Robo
9411508d3e
browser: option to set window background color
2015-10-22 09:54:29 +05:30
Cheng Zhao
6aec8b092c
views: Fix crash when setSizeConstrains is called early
2015-10-15 16:36:28 +08:00
Cheng Zhao
f607e81fac
views: Make size constraints work immediately after set
2015-10-06 16:16:02 +08:00
Cheng Zhao
e06778178a
linux: Restore size constraints when became sizable
2015-10-06 16:09:03 +08:00
Cheng Zhao
60fb406c61
views: Fix content size constraints in window with menubar
2015-10-06 00:15:47 +08:00
Cheng Zhao
bb49515145
Separate Windows specific code of NativeWindow to another file
2015-10-06 00:13:57 +08:00
Cheng Zhao
857acd2574
win: Fix GetContentSize for minimized window
2015-10-05 21:06:57 +08:00
Cheng Zhao
3b1ee994e2
views: Remove hack on setting min/max size for frameless window
2015-10-05 20:37:08 +08:00
Cheng Zhao
a9b0111c3e
views: Use the quicker way of return content size
...
Converting content size to window size on high DPI systems will lose
percise and have 1px offset sometimes.
2015-10-05 20:07:20 +08:00
Cheng Zhao
a76ea00249
views: Implement NativeWindow::SetSizeConstraints
2015-10-05 20:07:20 +08:00
Cheng Zhao
8577f2b52f
osx: Add NativeWindow::SetSizeConstraints
2015-10-05 20:07:20 +08:00
Cheng Zhao
526cee7ec3
Merge tag 'v0.33.6'
2015-10-05 19:58:47 +08:00
Cheng Zhao
7de3aa3cc1
Fix typo, closes #2990
2015-10-05 19:57:14 +08:00
Cheng Zhao
2b9b4c6789
Merge pull request #2979 from etiktin/fix_calculating_min_max_4_frameless
...
Fix calculating min/max size in frameless view
2015-10-05 15:10:27 +08:00
Cheng Zhao
de24ed7cea
Merge pull request #2985 from etiktin/fix_restore_size_windows
...
[Windows] Fix restore/unmaximize wrong window size
2015-10-05 15:09:24 +08:00
Eran Tiktin
4d02fc58fa
Fix restore/unmaximize wrong window size
...
This resolves #2498 .
2015-10-05 03:29:02 +03:00
Cheng Zhao
791f988aba
linux: Fix pressing Alt not showing menubar
2015-10-04 16:32:08 +08:00
Eran Tiktin
aea1f8aebb
Fix calculating min/max size in frameless views
...
The minimum and maximum size that frameless windows had used, was
incorrect. It included the border, so when it was called it actually
added that to the size, so window increased in size. The fix makes sure
that the view will use the frameless size.
This fixes #2945 and partially fixes #1806 (it also refers to some other
issues with hidpi which might still exist).
2015-10-03 22:09:57 +03:00
Cheng Zhao
8d61531f4e
Revert #2879
2015-10-01 17:46:11 +08:00
Cheng Zhao
83c514001e
Move devtools API to WebContents
2015-10-01 11:25:31 +08:00
Eran Tiktin
ee0f0f6cfc
Fix window state events on Windows
...
This commit fixes the issue we had with window state events not firing
when triggered through Aero Snap.
Instead of listening to command from the system menu (SC_MAXIMIZE etc.),
we use the WM_SIZE event.
This resolves #1381 .
2015-09-29 02:20:09 +03:00
Cheng Zhao
da57a3101f
Call WasShown when showing window
...
Otherwise WebContents would be invisible when window is hidden at first
and then show later.
Refs #2879 .
2015-09-24 18:16:41 +08:00
Cheng Zhao
6e75af5c0f
Move SetOverlayIcon to TaskbarHost
2015-08-06 13:07:00 +08:00
Cheng Zhao
2d6f8350cb
Move SetProgressBar to TaskbarHost
2015-08-06 12:54:00 +08:00
Cheng Zhao
a28f70e85c
Decouple TaskbarHost from NativeWindow
2015-08-06 11:10:34 +08:00
Cheng Zhao
8f8c3aef87
ThumbarHost => TaskbarHost
2015-08-06 10:30:22 +08:00
Cheng Zhao
39af10cc8d
Move thumbar_host_ from TreeHost to NativeWindow
2015-08-06 10:25:50 +08:00
Cheng Zhao
d175a68586
Add MessageHandlerDelegate
2015-08-06 10:15:27 +08:00
Haojian Wu
2f1cb8b52a
Expose NativeWindow.setThumbarButtons API to all platforms.
2015-08-05 22:30:05 +08:00
Haojian Wu
78eac4116c
Polish thumbar code.
...
* Fix a memory leak in thumbar initialization.
* Check the number of thumbar buttons, should be <= 7.
* Correct to check thumbar button click event.
2015-08-05 19:38:12 +08:00
Haojian Wu
dfd076a3e5
Move atom_desktop_window_tree_host_win to atom/browser/ui/win directory.
2015-08-05 13:55:06 +08:00
Haojian Wu
54af048f04
win: Add BrowserWindow.setThumbarButtons API.
2015-08-05 13:55:02 +08:00
Cheng Zhao
bbd6c927b1
Remove a few unused headers
2015-08-05 13:18:41 +08:00
Cheng Zhao
adbb909b39
Move ShouldUseGlobalMenuBar to x_window_utils
2015-08-05 13:16:03 +08:00
Cheng Zhao
58b1172025
Avoid exposing data members to subclass
2015-08-05 12:46:32 +08:00
Cheng Zhao
58c0486236
Remove duplicate UpdateDraggableRegions
2015-08-05 12:32:22 +08:00
Jonathan
9dab6e02ca
Fix typo
2015-07-31 20:14:50 +02:00
Cheng Zhao
73ded9d378
linux: Fix min/max size not working
2015-07-24 16:21:44 +08:00
Haojian Wu
3840a10da6
Fix app-command event always return 'unknown'.
2015-07-24 13:02:11 +08:00
Cheng Zhao
3315e6bda5
Merge pull request #2080 from deepak1556/linux_fullscreen_patch
...
window: use _NET_WM_STATE_FULLSCREEN before window is mapped
2015-07-05 16:44:42 +08:00
Robo
b5c5cce725
window: use _NET_WM_STATE_FULLSCREEN before window is mapped
2015-06-29 19:44:56 +05:30
ankitaggarwal011
1c907ffa36
🐛 Solves issue #2047 [Windows fullscreen bug]
2015-06-29 00:10:51 +05:30
Cheng Zhao
b5ff77ef0d
Small cleanups
2015-06-26 11:20:12 +08:00
Cheng Zhao
bff66caaa6
Only convert command ID on Windows
2015-06-26 11:16:50 +08:00
Paul Betts
794f89abf5
In our widget delegate, signal our Observer
2015-06-25 11:29:21 -06:00
Cheng Zhao
9f52b11761
Remove NativeWindow::GetWebContents
2015-06-25 14:54:00 +08:00
Cheng Zhao
62c44ee47b
Rename CloseWebContents to RequestToClosePage
2015-06-25 13:27:51 +08:00
Cheng Zhao
e41b0d4d2c
Remove NativeWindow::ActivateContents
2015-06-25 13:18:36 +08:00
Cheng Zhao
eb370ba22a
Allowing destroying a closed window
2015-06-25 13:08:11 +08:00
Cheng Zhao
5236b0c067
Don't create WebContents in NativeWindow
2015-06-25 09:47:57 +08:00
Cheng Zhao
19436358fb
win: Fix setContentSize changing window position
...
Close #1934 .
2015-06-18 16:17:13 +08:00
Cheng Zhao
5ae9c633ca
Fix building on Windows, close #1896
2015-06-08 13:19:56 +08:00
Cheng Zhao
5d23b7468e
Allow removing menu bar
2015-06-04 16:10:19 +08:00
Cheng Zhao
c244e83e10
Merge pull request #1633 from deepak1556/window_event_patch
...
window: adding resize and move events
2015-05-27 14:54:36 +08:00
Cheng Zhao
e233eab4f2
HandleMouseDown is deprecated
2015-05-23 11:58:20 +08:00
deepak1556
9a60fde59b
alias move and moved event on OS X
2015-05-22 12:24:12 +05:30
Robo
f46fcd158a
chnage move hook and add details to doc
2015-05-22 12:13:01 +05:30
deepak1556
3a5977e09f
window: adding resize and move events
2015-05-22 12:13:00 +05:30
Cheng Zhao
0d4d2080ca
Implement size and position APIs with bounds API
2015-05-04 12:47:56 +08:00
deepak1556
9ae59e8ac7
removed move utility and replaced with setbounds
2015-05-01 20:10:46 +05:30
deepak1556
ae6a1b409f
window: adding setBounds and getBounds api
2015-05-01 16:20:53 +05:30
deepak1556
20b4cae980
window: supports HTML5 fullscreen api
2015-04-23 12:14:29 +05:30
Cheng Zhao
c5c686fe8c
linux: Fix compilation error
2015-03-29 21:35:40 +08:00
Cheng Zhao
9b68777b4b
Minor fixes of #1309
...
* Line length should <= 80 cols.
* Add missing "s".
2015-03-29 20:40:02 +08:00
Cheng Zhao
3b1be743ef
Merge pull request #1309 from hokein/workspace-visible-api
...
Add workspace visible APIs
2015-03-29 20:37:07 +08:00
Haojian Wu
0342854e25
Update workspace visible APIs.
2015-03-29 10:01:52 +08:00
Cheng Zhao
83024ea509
views: Restore window state when showing window
2015-03-26 16:43:38 +08:00
Haojian Wu
476b61322f
Add SetVisibleOnAllWorkspaces/IsVisibleOnAllWorkspaces API.
...
These two APIs are only available on OS X/Linux platforms.
2015-03-26 14:18:37 +08:00
Cheng Zhao
f0924df68a
Add "type" option to change window type
2015-02-11 12:19:39 +08:00
Paul Betts
86de75deef
Style fixups
2015-02-10 17:14:26 -08:00
Paul Betts
8a7acfc6c0
icon_util is Windows-only
2015-02-07 11:57:00 -08:00
Paul Betts
ef869fb2ff
We need a UTF-16 string here
2015-02-06 17:00:38 -08:00
Paul Betts
1b9649b481
Switch to gfx::Image
2015-02-06 17:00:26 -08:00
Paul Betts
fa6d499a4e
Come correct with line length and constness
2015-02-06 16:32:27 -08:00
Paul Betts
0afac1e05a
Plumb code all the way up
2015-02-06 16:12:32 -08:00
Paul Betts
66f2d18d8b
First hack at setting the window icon overlay
2015-02-06 15:58:49 -08:00
Cheng Zhao
43421aedcf
OVERRIDE macro is now removed
2015-01-27 13:18:30 -08:00
Cheng Zhao
6939567cb4
win: Make transparent window resizable
2014-12-23 17:24:04 -08:00
Cheng Zhao
1a34e09a45
views: Make transparent window work
2014-12-23 16:55:57 -08:00
Cheng Zhao
98127ba13c
linux: Fix building
2014-12-15 17:28:51 -08:00
Cheng Zhao
cb911b19dd
win: Fixes stopping FlashFrame, closes #906
2014-12-15 17:27:58 -08:00
Cheng Zhao
1641caf353
Fix cpplint warnings
2014-12-15 16:57:04 -08:00
Cheng Zhao
23951e6ef3
views: Implement CanMinimize, fixes #918
2014-12-15 16:46:37 -08:00
Cheng Zhao
c9a5c6515c
views: Make it possible to show a window in maximized state
...
Fixes #834 .
2014-12-15 16:38:20 -08:00
Cheng Zhao
0ab32bfe17
win: Reserve border space for maximized frameless window
...
Fixes #732 .
2014-12-15 16:01:11 -08:00
Cheng Zhao
3d30e6ddc4
win: Don't allow maximzing a unresiazble frameless window
...
Fixes #857 .
2014-12-15 12:55:16 -08:00
Cheng Zhao
e3ccb18696
win: Fix calculating window bounds on high DPI display
2014-12-12 09:04:43 -08:00
Cheng Zhao
271eb63083
SetFullscreen => SetFullScreen
2014-11-25 14:34:14 +08:00
Cheng Zhao
28ca883805
win: Implement window state events
2014-11-25 14:28:34 +08:00
Cheng Zhao
588cc3c7ab
Make WindowStateWatcher X11 only
...
On Windows we need to take another way of detecting window state events.
2014-11-25 13:05:04 +08:00
Cheng Zhao
06cc27c6b3
views: Add WindowStateWatcher
2014-11-25 11:46:30 +08:00
Cheng Zhao
cd5007cfa1
linux: Set WM_CLASS for devtools window
2014-11-24 16:04:41 +08:00
Cheng Zhao
172c55d194
linux: Use app's name for WM_CLASS
2014-11-24 15:51:26 +08:00
Cheng Zhao
60bd20872c
linux: Set WM_WINDOW_ROLE correctly
...
WM_WINDOW_ROLE is used to specify the "role" of the window, and all
browser windows in atom-shell should have the same role.
2014-11-24 15:23:02 +08:00
Cheng Zhao
1cd3918494
views: Implement menubar APIs
2014-11-12 20:32:14 +08:00
Cheng Zhao
14d01544d4
Tidy code in CreateNonClientFrameView
2014-11-12 14:33:30 +08:00
Frank Hale
e9636bb87b
Fix CPP formatting
2014-11-12 01:11:25 -05:00
Frank Hale
246a145930
Fix merge conflict with native_window_views.cc
2014-11-12 01:04:51 -05:00
Frank Hale
c9371bceec
Force native window
...
- Force native frame and suppress the Chromium default blue frame. This
resolves issues with Windows systems that are running in VM's and cannot
enable Aero Glass. Atom-Shell was adding the default Chromium blue frame
even when frame was set to false in the BrowserWindow options.
2014-11-12 00:45:21 -05:00
Frank Hale
e0dae4054a
Fix code style to be <= 80 lines
2014-11-11 13:09:54 -05:00
Frank Hale
24f8c51959
Make sure frame is frameless
2014-11-07 13:34:52 -05:00
Frank Hale
4b20ac3dc6
Fix Windows min/max animation on frameless windows
...
- Frameless windows disappeared or appears when minimized and maximized
on Windows. This commit fixes that.
2014-11-07 13:13:12 -05:00
Cheng Zhao
edcae49e52
views: Fix showing menu bar when pressing Alt for a long time
2014-11-07 15:20:16 +08:00
Cheng Zhao
81283db2da
views: Make auto-hide-menu-bar work when NumLock is on, fixes #796
2014-11-07 15:05:55 +08:00
Kevin Sawicki
b6b6fc3bfd
Remove All Rights Reserved after GitHub copyright
...
Closes #762
2014-10-31 11:17:05 -07:00
Cheng Zhao
f82de6528b
linux: Fix detect global menu bar
...
It seems that detecting the bus name "com.canonical.AppMenu.Registrar"
is the most reliable way to detect whether the appmenu is available, see
http://git.io/JmP7Yg for the discussion.
2014-10-21 12:10:31 +08:00
Cheng Zhao
141894aacd
Implement BrowserWindow::ShowInactive
2014-10-17 22:51:20 +08:00
Cheng Zhao
85afa851dd
win: Fix toggling the menubar, closes #681
2014-10-17 16:43:57 +08:00
Cheng Zhao
ae76657e17
Still requires unity for global app menubar
...
Fixes #709 and atom/atom#3854 .
2014-10-17 16:06:45 +08:00
Matthieu Baerts
940b40439f
linux: GlobalMenu: UBUNTU_MENUPROXY with >1 char
...
When testing if $UBUNTU_MENUPROXY is set, we should also check if it
contains more than one character. Avoid cases when $UBUNTU_MENUPROXY is
set to 0 or 1.
2014-10-15 14:17:18 +02:00
Cheng Zhao
51acba594b
Merge pull request #698 from matttbe/master
...
linux: Rename window's class to Atom
2014-10-14 18:58:37 +08:00
Matthieu Baerts
7cd4d35778
linux: GlobalMenu: only if UBUNTU_MENUPROXY is set
...
When checking if we should react differently when GlobalMenu bar is
used, we should check if UBUNTU_MENUPROXY env var is (correctly) set
instead of checking if we're using Unity on a Unity session.
It's better to do that because we can use Compiz on a Unity session
without Unity. Or we can also use Unity in a different session.
2014-10-12 21:16:32 +02:00
Matthieu Baerts
8296178e33
linux: Rename window's class to Atom
...
The window's class should be Atom instead of Atom Shell because the
launcher and the binary to launch Atom are called 'atom' and not 'atom
shell'. This is why currently all Atom's windows will not be linked to
their launcher in a dock (e.g. with Cairo-Dock).
Note that it's not advised to add white-spaces in a window's class
('Atom Shell').
2014-10-12 18:47:49 +02:00
Alexander Neu
6c9769999b
win: Fix total value in SetProgressBar API.
2014-09-29 12:50:51 +02:00
Haojian Wu
d9ce3f0ca3
linux: Implement SetProgressBar API.
2014-09-18 19:26:52 +08:00
Haojian Wu
d8f57a0ecc
Correct code style.
2014-09-18 16:48:00 +08:00
Haojian Wu
b5e82dac6f
win: Implement SetProgressBar API.
2014-09-17 09:42:47 +08:00
Cheng Zhao
bda317b000
views: Set devtools window's icon, fixes #429 .
2014-09-09 15:30:33 +08:00
Cheng Zhao
1199224086
BrowserWindow.show() should not focus window, fixes #609 .
2014-09-08 15:28:34 +08:00
Cheng Zhao
9546120ce4
linux: Fix API changes of Chrome 37.
2014-09-01 20:10:14 +08:00
Cheng Zhao
400d5cef3f
linux: Fix BrowserWindow.setResizable.
2014-08-26 13:37:37 +08:00