Cheng Zhao
4a7c85f43e
fix: use InspectableWebContentsView as content view
2018-07-16 10:20:35 +09:00
John Kleinschmidt
539b554ecc
Merge pull request #13578 from electron/miniak/refactoring
...
refactor: statically link functions available on Windows 7+
2018-07-13 10:52:37 -04:00
Cheng Zhao
77ca5b7d64
fix: don't invoke callback after FrameSubscriber is destroyed ( #13657 )
2018-07-13 19:54:49 +10:00
Milan Burda
adaa32003d
refactor: DwmGetColorizationColor does not have to be dynamically resolved
2018-07-12 22:28:44 +02:00
Felix Rieseberg
deedf6c3f4
feat: Add isCurrentlyAudible() to WebContents ( #13614 )
...
* 🔧 Add isCurrentlyAudible() to WebContents
* ❤️ Implement feedback, use await to wait for event
* 👷 Add missing imports
2018-07-12 21:35:11 +10:00
Cheng Zhao
0ec4ad288d
fix: fallback to FullSizeContentView for frameless window on mac ( #13599 )
...
fix: draggable regions not working on macOS
2018-07-10 11:43:42 +10:00
Andrew MacDonald
7639e4a32a
Actually try building on Windows.
2018-07-03 01:03:05 -07:00
Andrew MacDonald
68541f2ae8
Ensure DirectX capturer is supported.
2018-07-02 21:37:10 -07:00
Samuel Attard
92588be2bd
refactor: add promise helper and change whenReady to be native impl ( #13115 )
...
* Add promise helper and change whenReady to be native impl
* remove commented code
* add GetInner helper to dedupe promise code
* add Promise.reject helper to be consistent with JS
* fix linting
* update promise impl per feedback
* remove param name from unused isolate
* Use non-depreceated resolvers for promises
* Add thread dchecks for promise helper, intiialize promise pointer to nullptr
2018-06-27 16:06:08 -05:00
Jeremy Apthorp
6f91af9343
chore: fix various chromium-style errors in windows ( #13394 )
...
These errors weren't previously picked up because the GN build wasn't running on Windows.
2018-06-25 22:30:00 +02:00
Jeremy Apthorp
3f40e93ba7
chore: fix chromium-style errors in frame_subscriber
...
The chromium-style linter we run in the GN build was throwing errors
about these issues.
2018-06-20 14:14:11 -07:00
Heilig Benedek
f643ce4f66
revert: frame subscriber deprecation and re-enable tests
2018-06-19 19:49:44 +02:00
Justin Guze
137aaf2429
fix: pass down the bool value of enableAutoSize to setSize ( #13282 )
...
* fix: pass the boolean value of enableAutoSize to setSize
The webContents setSize API takes in an optional enableAutoSize boolean.
Looking in the code, if that property is set, regardless if you pass in
true or false, it will always set it to true. This change passes the
appropriate boolean value down properly.
* creating new bool for autosize
2018-06-19 10:38:55 -05:00
Samuel Attard
2720fa751b
Fix windows desktop_capturer build
2018-06-19 15:29:16 +10:00
Samuel Attard
5a28759fea
post all desktop capturer apis to worker threads
2018-06-19 11:49:46 +10:00
Samuel Attard
8200a132be
Re-enable cookie specs and add custom cookie name/url validation
2018-06-19 11:49:46 +10:00
Heilig Benedek
65b8dd48d8
Update OSR code
2018-06-19 11:49:44 +10:00
Heilig Benedek
60ba2013c4
Re-add dirtyOnly to FrameSubscriber and document API change
2018-06-19 11:49:44 +10:00
Heilig Benedek
b9413fe59d
Update FrameSubscriber implementation
2018-06-19 11:49:44 +10:00
Nitish Sakhawalkar
ca8843102a
Fix duplicate RTCDispatcher console error for debug build.
...
The solution was to call CreateScreenCapturer from content, and not link the static library in.
2018-06-19 11:49:44 +10:00
Heilig Benedek
1de1ca906a
Reimplement FrameSubscriber with mojo VideoCapture APIs
2018-06-19 11:49:43 +10:00
deepak1556
c4b8e106c0
Create network_converter for services/network/* types
2018-06-19 11:49:42 +10:00
deepak1556
66058c8cfe
REVIEW: Use RenderWidgetHost api for event routing
...
https://chromium-review.googlesource.com/c/chromium/src/+/836267
2018-06-19 11:49:42 +10:00
deepak1556
d386ec0a2b
Remove unused elements from RWHV::CopyFromSurface() API and dead code.
...
https://chromium-review.googlesource.com/c/chromium/src/+/929874
2018-06-19 11:49:42 +10:00
deepak1556
3ad0639b2e
Surface synchronization: Implement auto-resize for OOPIF/BrowserPlugin
...
https://chromium-review.googlesource.com/c/chromium/src/+/753801
2018-06-19 11:49:42 +10:00
deepak1556
eab4227cbf
Make Origin(const GURL&) constructor private.
...
https://chromium-review.googlesource.com/c/chromium/src/+/729284
2018-06-19 11:49:42 +10:00
deepak1556
11fc8374c0
Move DownloadUrlParameters from content/public to components/download
...
https://chromium-review.googlesource.com/c/chromium/src/+/914232
2018-06-19 11:49:42 +10:00
deepak1556
8968c447f4
Include missing header
2018-06-19 11:49:41 +10:00
deepak1556
7b47d69efe
Remove did-get-response-details and did-get-redirect-request events
...
https://chromium-review.googlesource.com/c/chromium/src/+/805008
https://chromium-review.googlesource.com/c/chromium/src/+/786320
2018-06-19 11:49:41 +10:00
deepak1556
2ea26cd4d7
Add MediaStoppedReason to WCO
...
https://chromium-review.googlesource.com/c/chromium/src/+/758583
2018-06-19 11:49:41 +10:00
deepak1556
100291ec42
OOPIF-ize hung renderers
...
https://chromium-review.googlesource.com/c/chromium/src/+/896343
2018-06-19 11:49:41 +10:00
Aleksei Kuzmin
c75f6f408e
DevTools: remove the 'forced' attribute from the AgentHostClosed in DevToolsAgentHost.
...
https://chromium-review.googlesource.com/745301
2018-06-19 11:49:41 +10:00
deepak1556
409ff41c03
Remove SetCookieWithDetailsAsync API in favor of SetCanonicalCookieAsync.
...
https://chromium-review.googlesource.com/c/chromium/src/+/777954
2018-06-19 11:49:41 +10:00
deepak1556
23f7ccbdda
Remove old cookie enum values
...
https://chromium-review.googlesource.com/c/chromium/src/+/877515
2018-06-19 11:49:41 +10:00
Aleksei Kuzmin
343c42e4ef
Remove redundant device::PowerSaveBlocker enums.
...
https://chromium-review.googlesource.com/754169
services/device: Fix enum naming in wake_lock.mojom.
https://chromium-review.googlesource.com/755884
2018-06-19 11:49:41 +10:00
Aleksei Kuzmin
37168c0a95
Move ResourceRequestBody to services/network in preparation of moving content/network.
...
https://chromium-review.googlesource.com/864422
2018-06-19 11:49:41 +10:00
deepak1556
bb36a26950
update native-mate ref
2018-06-19 11:49:41 +10:00
Aleksei Kuzmin
6b77fa5b3b
[desktop capture] remove dependencies on webrtc/desktop_capture from /chrome
...
https://chromium-review.googlesource.com/876723
2018-06-19 11:49:41 +10:00
Aleksei Kuzmin
160b165358
move DownloadInterruptReasons from content/ to components/download
...
https://chromium-review.googlesource.com/897967
2018-06-19 11:49:40 +10:00
Aleksei Kuzmin
7fc8814d13
move some files from content/public/browser to components/download/public/core
...
https://chromium-review.googlesource.com/891686
2018-06-19 11:49:40 +10:00
Aleksei Kuzmin
4e580d5b39
Move download_item.h from content/public to components/download
...
https://chromium-review.googlesource.com/907687
2018-06-19 11:49:40 +10:00
deepak1556
e3c580e905
Move away from BrowserThread::FILE
...
* Migrate TtsPlatformImplLinux away from using BrowserThread::FILE.
https://chromium-review.googlesource.com/c/chromium/src/+/570022
* Move PdfConverter off the FILE thread.
https://chromium-review.googlesource.com/c/chromium/src/+/592393
* https://chromium.googlesource.com/chromium/src/+/master/docs/task_scheduler_migration.md
2018-06-19 11:49:40 +10:00
deepak1556
6d241e972b
Clean up net::HttpAuthPreferences.
...
https://chromium-review.googlesource.com/c/chromium/src/+/727399
2018-06-19 11:49:40 +10:00
deepak1556
8e125b2953
REVIEW: Remove the notification close-closure in favour of an explicit method
...
https://chromium-review.googlesource.com/c/chromium/src/+/744205
2018-06-19 11:49:40 +10:00
deepak1556
bf55d856d2
Cookie Store: Extract change notifications to separate classes.
...
https://chromium-review.googlesource.com/c/chromium/src/+/919159
2018-06-19 11:49:40 +10:00
deepak1556
806acbdf12
Move content/network to services/network.
...
https://chromium-review.googlesource.com/891646
2018-06-19 11:49:40 +10:00
Aleksei Kuzmin
fba2ab0996
Move throttling to network service
...
https://chromium-review.googlesource.com/703674
2018-06-19 11:46:59 +10:00
Aleksei Kuzmin
7c95100180
Rename ProxyService class to ProxyResolutionService
...
https://chromium-review.googlesource.com/857421
2018-06-19 11:46:59 +10:00
Aleksei Kuzmin
408b62bcc2
Move net/proxy to net/proxy_resolution
...
https://chromium-review.googlesource.com/868176
Also includes changes from:
Rename files relating to PAC (proxy auto config).
https://chromium-review.googlesource.com/836927
2018-06-19 11:46:58 +10:00
Zhuo Lu
ab24a1e36d
feat: netLog API for dynamic logging control ( #13068 )
...
* Introduce `net.{start|stop}Logging()`
- Slight regression right now as Electron won't automatically start logging net-logs at launch, will soon be fixed
- To implement callback for async controls
* Add `net.isLogging` & optional callback param for `net.stopLogging()`
* Fix small regression on --log-net-log
--log-net-log should work again
* Error on empty file path
* Only start with valid file path
* Remove unused var
* Allow setting log file path before URLRequestContextGetter starts logging
* Add net log tests
* Remove redundant checks
* Use brightray::NetLog
* Clean up code
* Should automatically stop listening
* 🎨 Attempt to fix styles
* Only run non-null callback
* Dump file to tmpdir
* Simplify net log spec
Spawned Electron process on Linux CI can fail to launch
* Separate netLog module
* Remove net logging test from net spec
* Add tests for netLog
* Fix header guard
* Clean up code
* Add netLog.currentlyLoggingPath
* Callback with filepath
* Add test for case when only .stopLogging() is called
* Add docs
* Reintroduce error on invalid arg
* Update copyright
* Update error message
* Juggle file path string types
2018-06-19 11:45:58 +10:00
Heilig Benedek
90911a423a
Fix autofill popup position when the popup is spawned from a webview ( #13184 )
2018-06-18 10:15:37 -05:00
Cheng Zhao
a11182ca84
feat: add SetText for TextField
2018-06-18 16:51:36 +09:00
Cheng Zhao
70e17b5f8f
feat: add LabelButton API
2018-06-18 16:51:36 +09:00
Cheng Zhao
c8e8cb86ce
feat: add Button API
2018-06-18 16:51:36 +09:00
Cheng Zhao
ba3700141f
feat: add TextField API
2018-06-18 16:51:36 +09:00
Milan Burda
2eb5b751f3
exit HTML fullscreen when window leaves fullscreen ( #13090 )
2018-06-18 16:48:20 +09:00
Milan Burda
28fd571d0c
refactoring: use std::make_unique<T> ( #13245 )
2018-06-18 16:32:55 +09:00
Thiago de Arruda
6ff111a141
perf: don't use JSON to send the result of ipcRenderer.sendSync
. ( #8953 )
...
* Don't use JSON to send the result of `ipcRenderer.sendSync`.
- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
to wrap/unwrap return values to/from array, instead of
serializing/deserializing JSON.
This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).
A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory. This difference
tends increases with larger buffers.
* Don't base64 encode Buffers
* Don't allocate V8ValueConverter on the heap
* Replace hidden global.sandbox with NodeBindings::IsInitialized()
* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter
* Refactor problematic test to make it more reliable
* Add tests for NaN and Infinity
2018-06-13 17:38:31 +10:00
Charles Kerr
b89fe86fa1
Merge pull request #13050 from electron/3.0.0-deprecations
...
chore: removal of 3.0.0 deprecations
2018-05-30 09:25:36 +02:00
Charles Kerr
6935addd38
fix: remove unused variable
2018-05-29 16:14:21 +02:00
Milan Burda
45e78728bd
chore: move more constants to options_switches.h/cc ( #13093 )
...
* Add options::kNativeWindowOpen
* Add options::kSandbox
* Add options::kPlugins
* Add options::kWebSecurity
* Add options::kAllowRunningInsecureContent
* Add options::kOffscreen
2018-05-29 03:09:51 -05:00
Cheng Zhao
0f7c25fc63
Put View APIs under a build flag
2018-05-24 15:44:07 +09:00
Cheng Zhao
2c8dc9e0bd
Add View.addChildView API
2018-05-24 15:36:29 +09:00
Cheng Zhao
322bde526c
Add LayoutManager/BoxLayout APIs
2018-05-24 15:36:29 +09:00
Shelley Vohr
bc10be3de6
rename exposed session method to setCertificateVerifyProc
2018-05-23 13:51:28 -07:00
Shelley Vohr
4a90056462
remove webContents.openDevTools() deprecation
2018-05-23 09:30:15 -07:00
Shelley Vohr
003a5a0160
remove tray.setHighlightMode() deprecation
2018-05-23 09:20:39 -07:00
Shelley Vohr
72c63a10ee
remove screen.getMenuBarHeight() deprecation
2018-05-23 09:11:48 -07:00
Milan Burda
2337237d58
Refactoring: use C++11 class member variable initialization
2018-05-22 00:18:38 +02:00
Cheng Zhao
595b0663b2
WebContents may be managed by multiple owners
2018-05-21 10:53:09 +09:00
Cheng Zhao
3b81312cf7
clear pointer when WebContents is closed
2018-05-21 10:53:09 +09:00
Cheng Zhao
51db1efb8a
prevent double-adding a WebContents to view
2018-05-21 10:53:09 +09:00
Cheng Zhao
fd4a0626c5
destroy WebContents when view is destroyed
2018-05-21 10:53:08 +09:00
Zhuo Lu
d2653e8192
Fix: Prevent menu update while it's open ( #12809 )
...
* Update application menu on default runloop
Menu change should be prevented while the menu is open
* Fix code style
* Memory safety
2018-05-17 11:19:28 +10:00
Jeremy Apthorp
da0fd10423
refactor: chromium-style warnings in linux code ( #12949 )
2018-05-16 14:12:45 -05:00
John Kleinschmidt
9488ef4867
Merge pull request #12496 from mikeykhalil/8952-ignore-tray-double-click-events
...
8952 option to ignore tray double click events
2018-05-16 10:17:36 -04:00
Milan Burda
211d7825d3
feat: DIP <-> screen coordinate conversions ( #12879 )
2018-05-16 18:34:09 +09:00
Cheng Zhao
bb2715e7a5
feat: add TopLevelWindow.setContentView API
2018-05-15 14:12:47 +09:00
Cheng Zhao
2b24b26e59
refactor: do not pass WebContents to NativeWindow
2018-05-15 14:03:21 +09:00
Cheng Zhao
640877ebf8
attach native view after widget is created
2018-05-15 14:03:21 +09:00
Cheng Zhao
5a320222e2
feat: add WebContentsView API
2018-05-15 14:03:21 +09:00
Cheng Zhao
e058d11657
feat: add View API
2018-05-15 14:03:21 +09:00
Jeremy Apthorp
cc386f2345
Merge pull request #12884 from nornagon/views-defines
...
Require !OS_MACOSX as well as TOOLKIT_VIEWS for views code
2018-05-10 14:13:19 -07:00
Jeremy Apthorp
72057bf7ef
clang-format atom_api_web_contents.cc
2018-05-10 14:11:19 -07:00
Jeremy Apthorp
87d0175c76
Require !OS_MACOSX as well as TOOLKIT_VIEWS for views code
2018-05-10 14:11:19 -07:00
Jeremy Apthorp
73ac019882
Fix up #includes to work with both GYP and GN
2018-05-10 13:38:40 -07:00
Samuel Attard
5b5c161601
feat: new makeSingleInstance API ( #12782 )
...
* Refactor app.makeSingleInstance
* new API `app.isPrimaryInstance()`
* new API `app.isSingleInstance()`
* new event `app.on('second-instance')`
* deprecated old syntax `app.makeSingleInstance(cb)`
* deprecated old syntax of `app.makeSingleInstance() --> bool` in favor
of `app.isPrimaryInstance()`
* Fix spec, we don't need process.nextTick hacks any more
* Make deprecation TODO for the return value of makeSingleInstance
* Refactor makeSingleInstance to requestSingleInstanceLock and add appropriate deprecation comments
* I swear this isn't tricking the linter
* Make const
* Add deprecation warnings for release, and add to planned-breaking-changes
BREAKING CHANGE
2018-05-08 01:29:18 +10:00
Jeremy Apthorp
b280ea5579
chromium-style fixes ( #12826 )
2018-05-03 23:45:12 -07:00
mikeykhalil
94ffd4bfc0
add getter for ignoreDoubleClickEvents field
2018-05-03 13:49:33 -07:00
mikeykhalil
208374afa4
clean up ignore double click event implementation
2018-05-03 13:49:33 -07:00
mikeykhalil
1f29124d11
updated Tray API to ignore double click events on macOS ( #8952 )
2018-05-03 13:49:32 -07:00
Jeremy Apthorp
cdc5022305
Fix chromium-style errors ( #12802 )
2018-05-03 09:04:22 -05:00
bughit
55a7f6f0ce
add did-frame-navigate event to WebContents ( #12723 )
...
* add did-frame-navigate event to WebContents, pass http response code to it and did-navigate
* docs for frame routing id related api changes on WebFrame and WebContents
2018-05-01 13:34:41 +09:00
Samuel Attard
338a816ffd
Screen Lock / Unlock events ( #12714 )
...
* initial lock-screen and unlock-screen event implementation for macOS
* Implementation of lock-screen and unlock-screen on windows
2018-05-01 02:04:27 +10:00
Zeke Sikelianos
cc98bd6b6d
Merge pull request #12662 from electron/prevent-default
...
Stop overwriting prevent_default if default wasn't prevented
2018-04-26 12:12:18 -07:00
bughit
4fcd178c36
expose WebFrame#routingId ( #12614 )
...
* expose WebFrame#routingId and pass it to WebContents frame specific events along with frameProcessId; add WebContets.did-start-navigation event
* fix compilation error on ia32 Windows
2018-04-26 19:17:55 +09:00
Nitish Sakhawalkar
2579071b98
Deprecate did-get-response-details and did-get-redirect-request ( #12615 )
...
* Deprecate webContents events did-get-response-details and did-get-redirect-request.
* Update guest view files
* Update webview tag docs and update specs
* Update deprecate.event function
* Update comment
* Update more
* Update documentation for other deprecated event
2018-04-23 14:46:12 -05:00
Shelley Vohr
12a57ff1c2
clang-format objc files ( #12673 )
2018-04-20 11:47:04 -07:00
Robo
ff571f3b5d
Part I: Move from base::Bind to base::BindOnce and remove unneeded base::Passed ( #12661 )
2018-04-20 19:55:05 +09:00
deepak1556
30f1d0991b
enable chromium style checker plugin for electron and brightray targets
2018-04-19 11:12:58 -07:00