Jeremy Apthorp
7c6cedb119
test: de-flake getAllWebContents test by moving it to spec-main ( #17610 )
2019-04-01 18:28:11 -07:00
Jeremy Apthorp
eb27e9b055
refactor: move //electron/manifests:manifests target into main BUILD.gn ( #17611 )
2019-04-01 18:25:19 -07:00
Samuel Attard
75442b794f
fix: make devtools extensions load correctly ( #17614 )
2019-03-30 17:36:13 -07:00
Milan Burda
d597a0e8b0
refactor: expose ipcRendererInternal to the main world for window-setup using the content script world pattern ( #17591 )
2019-03-29 18:10:21 -07:00
Samuel Attard
b8dbe4bc15
spec: add tests for the autoUpdater on macOS that actually test if it works ( #17442 )
...
* spec: add tests for the autoUpdater on macOS that actually test if it works
* spec: add express as dep
* spec: add logic to auto-trust self-signed certificate and not run autoupdate specs on MAS
* build: fix the step name for importing the codesign cert
* chore: update updater spec PR as per feedback
* fix: s/atomBinding/electronBinding
* build: use spawn instead of exec
2019-03-29 17:32:52 -07:00
Roller Bot
5045b0a962
chore: bump chromium in DEPS to 74.0.3729.48 ( #17606 )
2019-03-29 13:44:19 -07:00
Samuel Attard
953d1ea635
fix: ensure dots in content script patterns aren't used as wildcards ( #17593 )
...
* fix: ensure dots in content script patterns aren't used as wildcards
* chore: sanitise all regexp special chars
* chore: extract to helper
* chore: fixup helper
2019-03-28 14:03:37 -07:00
Samuel Attard
32c9597cbc
build: ensure we use objc regexps for export-patches ( #17598 )
...
* build: ensure we use objc regexps for export-patches
* build: also use objc for *.m
Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>
2019-03-28 14:01:43 -07:00
Shelley Vohr
808783a5e4
fix: crashReporter.getParameters() takes no params ( #17459 )
2019-03-28 15:04:16 -04:00
Roller Bot
69d4c91895
chore: bump chromium in DEPS to 74.0.3729.45 ( #17589 )
2019-03-28 11:16:45 -07:00
Heilig Benedek
7a47e64e65
fix: update patch to make Windows key work with global shortcuts ( #17565 )
2019-03-28 11:15:22 -07:00
Samuel Attard
3475cd168e
fix: handle a race condition between preload scripts executing and ( #17577 )
...
navigations
There is a race condition between DidCreateScriptContext and another
navigation occuring in the main process. If the navigation occurs while
the preload script is running, the same process is re-used. This
ensures that any pending navigations are completely removed / ignored
when we trigger a new navigation.
Fixes #17576
2019-03-28 11:13:05 -07:00
John Kleinschmidt
7eaa57b116
build: remove native mksnapshot for arm/arm64 ( #17561 )
...
* build: remove native mksnapshot for arm/arm64
2019-03-28 11:05:43 -04:00
Milan Burda
8cf15cc931
feat: only allow bundled preload scripts ( #17308 )
2019-03-28 11:38:51 +01:00
Richard Townsend
3d307e5610
fix: correct crash reporter for Windows on Arm ( #17533 )
...
ARM64 cleans up and moves around RUNTIME_FUNCTION structure fields.
With this patch applied, electron should build cleanly for Windows on Arm.
2019-03-27 11:30:11 -07:00
Samuel Attard
f4434763fe
fix: use file path as key for safeDialogs on filesystem ( #17546 )
2019-03-27 11:21:10 -07:00
Samuel Attard
2188a6ea99
fix: set default_id and cancel_id correctly on confirm dialogs ( #17547 )
2019-03-27 11:15:58 -07:00
Shelley Vohr
4e57a732a8
feat: allow windows to be excluded from the windows menu ( #17404 )
...
* feat: allow windows to be excluded from the windows menu
* excludedfromWindowsMenu => excludedFromShownWindowsMenu
* implement no-op for win & linux
2019-03-27 08:10:23 -04:00
Samuel Attard
ec5e0ef06e
build: speed up windows download of external binaries ( #17559 )
2019-03-26 20:22:54 -05:00
Roller Bot
75b4db60cf
chore: bump chromium in DEPS to 74.0.3729.38 ( #17555 )
2019-03-26 13:26:36 -07:00
Shelley Vohr
34eb5d0815
fix: correctly return properties on the netLog module ( #17525 )
2019-03-25 22:40:38 -04:00
Milan Burda
336db33d18
refactor: use ipcMainUtils.invokeInWebContents / ipcRendererUtils.handle helpers for Chrome APIs ( #17417 )
2019-03-26 11:38:35 +09:00
Milan Burda
546466b209
feat: add <webview>.getWebContentsId() ( #17407 )
2019-03-26 10:57:27 +09:00
Samuel Attard
9e26dfaa06
build: use async remove method to handle errors better ( #16917 )
...
On windows removeSync randomly seems to fail with DIRNOTEMPTY. By using
the async version fs-extra will do some back-off-retry logic to
hopefully get this dir deleted
2019-03-26 10:34:03 +09:00
Milan Burda
cbd884060e
fix: validate sender for replies in ipcMainInternalUtils.invokeInWebContents() ( #17416 )
2019-03-26 10:15:51 +09:00
Milan Burda
95df531b33
fix: add missing buffer size check in nativeImage ( #17465 )
2019-03-26 10:13:39 +09:00
Robo
6c20c6e668
refactor: Enable network service (Part 1) ( #17431 )
...
* Convert InspectableWebContentsImpl::LoadNetworkResource to SimpleURLLoader
https://bugs.chromium.org/p/chromium/issues/detail?id=721408
* Plumb creation of network context with the service
2019-03-26 10:10:48 +09:00
Shelley Vohr
4ec2f8b67b
chore: remove some bot config options ( #17506 )
2019-03-22 19:29:23 -05:00
Shelley Vohr
a5febe392c
chore: update issue templates with guidelines ( #17505 )
2019-03-22 16:56:52 -07:00
Cheng Zhao
49f13e38f9
fix: close context menu before popup ( #17474 )
2019-03-21 21:56:22 -07:00
Samuel Attard
d2ad8efef4
build: pass through value of unknown flag as well as the flag to make --grep work again ( #17485 )
2019-03-21 12:24:07 -07:00
Nitish Sakhawalkar
a16dc13f85
chore: Update node commit sha ( #17486 )
...
No changes made to node canary, just rebased with fixups.
This change updates to the new commit of `electron-node-canary`.
2019-03-21 14:19:49 -05:00
Samuel Attard
784f9742bc
build: auto-fix whitespace in docs in pre-commit hook ( #17490 )
2019-03-21 12:15:55 -07:00
Jeremy Apthorp
6555be2636
chore: bump chromium to 74.0.3729.27 (master) ( #17345 )
...
* chore: bump chromium to 74.0.3729.5 (master)
* Remove ScopedBlockingCall constructor without location
https://chromium-review.googlesource.com/c/chromium/src/+/1496560
* Use XCode 9.4.1 for Mac SDK 10.13
* chore: roll chromium 74.0.3729.27
2019-03-21 11:45:22 -04:00
Milan Burda
07b02653ba
docs: update sandbox-option.md ( #17468 )
...
* docs: update sandbox-option.md
* Update docs/api/sandbox-option.md
Co-Authored-By: miniak <milan.burda@gmail.com>
2019-03-21 14:41:53 +01:00
Shelley Vohr
b25279df89
docs: clarify documentation for getLastCrashReport ( #17458 )
...
* docs: clarify documentation for getLastCrashReport
* address feedback
2019-03-20 15:34:21 -07:00
Shelley Vohr
b140a82fe8
fix: take foreground visibility into account for isVisible on macOS ( #17463 )
2019-03-20 15:33:59 -07:00
Milan Burda
a82bbd010e
build: strip trailing whitespace in docs ( #17488 )
2019-03-20 13:12:47 -07:00
Klaus Sinani
1c7b3026a6
docs: Use correct image URL on docs/tutorial/windows-taskbar.md
( #17467 )
2019-03-20 10:01:28 -07:00
Samuel Attard
45d90e77b7
fix: use a more unique identifier for NSUserNotification instances ( #17469 )
...
So although apple has it documented that notifications with duplicate identifiers in the same session won't be presented. They apparently forgot to mention that macOS also non-deterministically and without any errors, logs or warnings will also not present some notifications in future sessions if they have a previously used identifier.
As such, we're going to truly randomize these identifiers so they are
unique between apps and sessions. The identifier now consists of a
randomly generated UUID and the app bundle id.
2019-03-20 09:53:20 -07:00
Milan Burda
de1bacddd9
docs: process.getProcessMemoryInfo() returns a Promise ( #16593 )
...
* docs: process.getProcessMemoryInfo() returns a Promise
* chore: bump electron-typescript-definitions to get Promise<T> fix
2019-03-20 17:26:57 +01:00
Cheng Zhao
671533f7d2
fix: check the result when calling js function ( #17443 )
...
* fix: check the result when calling js function
* test: should not crash when callback returns nothing
2019-03-20 08:27:06 -07:00
Samuel Attard
1571461bae
build: add a workaround for circleci known_hosts issue ( #17471 )
2019-03-19 19:37:52 -07:00
Shelley Vohr
1d93bc76cd
feat: expose colorSpace to display object ( #17405 )
...
* feat: expose colorSpace to display object
* update doc
* add a spec
2019-03-19 15:12:03 -07:00
Milan Burda
4c51fa93f5
feat: add systemPreferences.getAnimationSettings() ( #17382 )
2019-03-19 12:15:40 -07:00
Milan Burda
4d8e024b6d
spec: fix isEmpty() checks in nativeImage tests ( #17441 )
2019-03-19 12:13:15 -07:00
Zachary
9b359c6a75
docs: correction to ipc-main-event.md 'frane' to 'frame' ( #17424 )
2019-03-19 12:07:30 -07:00
Milan Burda
7389dfca59
fix: report module name when require fails in sandboxed renderers ( #17413 )
2019-03-19 12:00:41 -07:00
Milan Burda
06a4594435
chore: remove special handling for dialog methods in remote module ( #17412 )
...
* chore: remove special handling for dialog methods in remote module
* refactor: remove callFunction helper
2019-03-19 11:59:33 -07:00
Benny Neugebauer
f4c3151815
docs: fix typo in webview.md ( #17454 )
2019-03-19 11:43:19 -07:00