* Avoid copies of large objects in range-based for-loops.
Xref: 6527689
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* Avoid copies of large objects in range-based for-loops in Browser::ShowAboutPanel()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Use base::MakeFixedFlatSet()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: extract-constant for registry key in GetProcessExecPath()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: extract-constant for registry key in Browser::SetLoginItemSettings()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: extract-constant for registry key in Browser::SetLoginItemSettings()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: extract-constant for registry key in Browser::GetLoginItemSettings()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: document the symbolic constants
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: prefer base::wcstring_view::c_str() to data() to make zero-termination clearer
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: local functions GetPrivate(), SetPrivate() now take std::string_views
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: make local keys std::string_views instead of C-style char arrays
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: make local keys constexpr
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move local keys into local anonymous namespace
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* build: rewrite push-patch to use the github API instead of local git commits to ensure commits are signed
* again
(cherry picked from commit a21afc3e45d15f88c1f754d5990908f248909b41)
* use pr head ref
(cherry picked from commit 0edcc985fadcce64f01fb77b1c15653d5e66e864)
* chore: bump chromium in DEPS to 139.0.7205.0
* 6543986: Mac: decouple deserializing and applying sandbox policy
Refs 6543986
* 6580079: Reland 'Remove the third-party blocking feature'
Refs 6580079
* 6505716: guest-contents: Add components/guest_contents
Refs 6505716
* 6572556: Move LogMessageManager out of gpu_service_impl.cc.
Refs 6572556
* 6566111: Change UtilityProcessHost to manage its instance internally
Refs 6566111
* 6550237: Rename ReconnectEventObserver to ConnectionChangeObserverClient
Refs 6550237
* 6565918: Validate path is valid UTF8 in SelectFileDialogLinuxPortal
Refs 6565918
* 6579713: Remove base::NotFatalUntil::M130 usage
6566111: Change UtilityProcessHost to manage its instance internally
Refs
65797136566111
* chore: update chromium patches
* chore: update remaining patches
* fixup! 6566111: Change UtilityProcessHost to manage its instance internally Refs 6566111
* 6577970: Remove superfluous includes for base/strings/stringprintf.h in headers
Refs 6577970
* 6568811: Add FunctionCall structured metrics event for DevTools
Refs 6568811
* [PDF Ink Signatures] Support PdfAnnotationsEnabled policy
6558970
* build: disable libcxx modules for rbe
* chore: bump chromium in DEPS to 139.0.7217.0
* chore: bump chromium in DEPS to 139.0.7218.0
* chore: update patches
fix_use_delegated_generic_capturer_when_available.patch was updated to handle a small change:
6582142: Use content::Create*Capturer in DesktopCaptureDevice. | 6582142
* chore: bump chromium in DEPS to 139.0.7219.0
* chore: update patches
* 6594615: Change Chromium's deployment target to macOS 12
6594615
Updated the assertion message to match the docs structure now too. I removed the callout to the supported versions doc because it has moved and doesn't contain minimum platform version information.
* 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_
6606232
|NativeWindow::GetContentMinimumSize| and |NativeWindow::GetContentMaximumSize| may be good opportunities for a refactor now.
* add squirrel.mac patch for removed function
This was triggered by the macOS 12.0 deployment upgrade change.
See: https://developer.apple.com/documentation/coreservices/1444079-uttypeconformsto?language=objc
* 6582142: Use content::Create*Capturer in DesktopCaptureDevice.
6582142
* 6579732: Two minor API "quality of life" cleanups in OSCrypt Async
6579732
* chore: add include for base::SingleThreadTaskRunner
Not sure what change caused this, I expect it would be a removed include somewhere else, but it's likely not important to track down.
* chore: update libcxx filenames
* chore: update CI build-tools commit target for macOS SDK 15.4
The following change uses an API that was added in the macOS 15.4 SDK. Support for that SDK version was added later than the current build-tools commit target.
6575804: Use a quick-and-dirty solution to avoid glitching with paste-and-go | 6575804
See: https://developer.apple.com/documentation/appkit/nspasteboard/accessbehavior-swift.enum?language=objc
* fixup! 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_ 6606232
* chore: bump chromium in DEPS to 139.0.7220.0
* chore: update patches
Minor changes due to:
6613978: pwa: let events fall through in the transparent area of TopContainerView | 6613978
6614778: Refactor auto pip tab observer for Android support | 6614778
* 6543986: Mac: decouple deserializing and applying sandbox policy
6543986
The DecodeVarInt and DecodeString functions look benign from a MAS perspective. I suspect they were patched out to avoid "unused function" errors. Their complements for encoding are unpatched, supporting this idea.
The code that uses these functions was refactored out of the section that we patch out. Instead of patching out that new function, I decided to treat it the same as the serialization function that is unpatched.
* chore: bump chromium in DEPS to 139.0.7222.0
* chore: bump chromium in DEPS to 139.0.7224.0
* chore: bump chromium in DEPS to 139.0.7226.0
* chore: bump chromium in DEPS to 139.0.7228.0
* chore: update patches
* Don't use static variable for UseExternalPopupMenus
6534657
* Reland "Roll libc++ from a01c02c9d4ac to a9cc573e7c59
6607589
* chore: bump chromium in DEPS to 139.0.7219.0
* chore: update patches
* revert Don't use static variable for UseExternalPopupMenus
* tls: remove deprecated tls.createSecurePair and SecurePair
https://github.com/nodejs/node/pull/57361
* Revert "Reland "Roll libc++ from a01c02c9d4ac to a9cc573e7c59"
This reverts commit 33e1436a0c598ffa8cd308d08de481ed9cd22168.
* test: cleanup api-desktop-capturer-spec.ts
* test: more cleanup of api-desktop-capturer-spec.ts
* chore: debug dcheck error in webrtc on linux
* fixup patch
* add debugging to desktop capturer spec
* test: fixup api-desktop-capturer-spec.ts for linux
* chore: remove debugging patch
* Revert "fixup! 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_ 6606232"
This reverts commit 32e75651c14512572d322e819c98ab1469663bb6.
* Revert "6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_"
This reverts commit 89c51aa1c7771fd7f1d634486bc77f493f1d2ea9.
* [views] Remove DesktopWindowTreeHostWin::window_enlargement_
6606232
Reverting as we need this functionality for now.
* fixup: remove patch that was accidentally added back
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
* fixup! refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
Refs https://github.com/electron/.permissions/pull/293
The repo was renamed to `minimal-repro` and is no longer intended to be used as a way to start new projects (see PR above).
Since we really want bugs in `electron/electron` to be reported with a Fiddle gist instead of a standalone repo (makes reproducing and bisecting sooo much easier and safer!), I removed the repo from the README completely instead of mentioning as an issue reproduction starting point.
