mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 2

refactor: simplify titlebar overlay initialization (#47480)

Browse source
This commit is contained in:
Charles Kerr 2025-06-23 04:24:05 -05:00 • committed by GitHub
commit bb22eaccec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

20
shell/browser/native_window.cc
View file

@ -114,20 +114,12 @@ NativeWindow::NativeWindow(const gin_helper::Dictionary& options,
options.Get(options::kVibrancyType, &vibrancy_);
#endif
v8::Local<v8::Value> titlebar_overlay;
if (options.Get(options::ktitleBarOverlay, &titlebar_overlay)) {
if (titlebar_overlay->IsBoolean()) {
options.Get(options::ktitleBarOverlay, &titlebar_overlay_);
} else if (titlebar_overlay->IsObject()) {
titlebar_overlay_ = true;
auto titlebar_overlay_dict =
gin_helper::Dictionary::CreateEmpty(options.isolate());
options.Get(options::ktitleBarOverlay, &titlebar_overlay_dict);
int height;
if (titlebar_overlay_dict.Get(options::kOverlayHeight, &height))
titlebar_overlay_height_ = height;
}
if (gin_helper::Dictionary dict;
options.Get(options::ktitleBarOverlay, &dict)) {
titlebar_overlay_ = true;
titlebar_overlay_height_ = dict.ValueOrDefault(options::kOverlayHeight, 0);
} else if (bool flag; options.Get(options::ktitleBarOverlay, &flag)) {
titlebar_overlay_ = flag;
}
WindowList::AddWindow(this);