* docs: remove confusing notes on Node
* Update docs/tutorial/first-app.md
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* feat: Add Secure Keyboard Entry APIs in macOS
Add methods:
- app.isSecureInputEnabled()
- app.setSecureInputEnabled(enabled)
These enable to prevent other process listens keyboard input events.
* fix: lint error in app.md for #20678
* fix: crash app.setSecureInputEnabled() in password textfield
* fix: export Secure keyboard Entry API to only macOS
* fix: lint error in browser_mac.mm for #20678
* test: add test for app.setSecureKeyboardEntryEnabled in macOS
In order for `badgeCount` to properly update the dock icon on
macOS, the application needs to have the permissions to display
notifications.
Cross-refs #22715.
* docs: `newGuest` in `WebContents` and `webContents` in `BrowsweWindow`
According to the example codes in the documentation of `new-window`
event in `WebContents`, `webContents` in `BrowsweWindow` constructor
options and `newGuest` in `event` argument of `new-window` handler are
both existing but documented. This patch is for adding the related
documentations. Also, it provides typescript-definitations for these
two properties.
* Remove the documnent of `webContents` in BrowserWindow constructor option.
In some situations, we can't use auto update to communicate with our update server directly, and proxies can be tricky to get working. I spent a loooong time exploring a lot of options before coming across the comment I linked, so It thought it could be beneficial to people like me of the future.
* docs: Improve the codesigning docs
* docs: Clarify builder notarization
* Update docs/tutorial/code-signing.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/code-signing.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/code-signing.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/code-signing.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/code-signing.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/code-signing.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/code-signing.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/code-signing.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/code-signing.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* Update docs/tutorial/code-signing.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* fix: don't assign NSAlert to window which is not visible
Without this change it's possible to create message box which can't
be dismissed on mac.
* fixup! fix: don't assign NSAlert to window which is not visible
* fixup! fix: don't assign NSAlert to window which is not visible
* docs: Update the "Electron vs NW.js" document
* Update docs/development/electron-vs-nwjs.md
Co-Authored-By: Charles Kerr <ckerr@github.com>
* Update docs/development/electron-vs-nwjs.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* Update docs/development/electron-vs-nwjs.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Charles Kerr <ckerr@github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* feat: expose the sameSite value for cookies
* Apply suggestions from code review
Co-Authored-By: Charles Kerr <ckerr@github.com>
* Apply suggestions from code review
Align with cookie samesite values for the extensions API
https://developer.chrome.com/extensions/cookies#type-SameSiteStatus
* chore: add tests for sameSite cookies get/set
* chore: update docs parser
* chore: update docs for MessageChannel and MessagePort to have correct process information
* chore: remove LOG warning
* chore: throw error if the string->samesite conversion fails
Co-authored-by: Charles Kerr <ckerr@github.com>
* docs: document what experimental means explicitly
* Apply suggestions from code review
Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org>
* Update experimental.md
Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
* docs: fix minor grammar error 'punctuations'
* docs: fix minor grammar error pluralizing Chromium
* docs: fix typo 'updateCurrentActiviy'
* docs: use consistent spelling of 'behavior'
* docs: use 'macOS' instead of 'Mac OS' or 'OS X'.
* docs: use 'GTK' instead of 'GTK+'
https://mail.gnome.org/archives/gtk-devel-list/2019-February/msg00000.html
* docs: minor capitalization: use 'TCP' not 'tcp'
* Update docs/development/build-instructions-linux.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
* feat: default gtk darkTheme option to nativeTheme.shouldUseDarkColors for better platform support
* chore: update syntax for PR feedback
* refactor: only define SetGTKDarkThemeEnabled when needed
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
* docs: update type and description of IncomingMessage.headers
Fixes#22521
Updates the docs for IncomingMessage.headers to match the changes made in #17517
* Update docs/api/incoming-message.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Cheng Zhao <zcbenz@electronjs.org>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* docs: Added a note about chromium logs on the debugging page
* docs: Point at existing documentation for environment variables
* chore: remove trailing whitespace
Co-authored-by: Cheng Zhao <zcbenz@electronjs.org>
* docs: clarify that we support the latest minor for the stable lines we support
* Update docs/tutorial/support.md
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* docs: clean up systemPreferences.effectiveAppearance text
* Grammar fixes
* Add links for Electron Packager & Electron Forge
* Update Packager API links, given https://github.com/electron/electron-packager/pull/1131
* docs: clean up Dark Mode guide
* Grammar fixes
* Add links for Electron Packager & Electron Forge
* docs: adjust based on Electron 8 using 10.14 SDK
* build: we moved goma to build-tools
* Apply suggestions from code review
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
* build: do not use goma.gn
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
