Samuel Attard
5790869a3f
chore: refactor browser IPC into TS and app API into TS ( #16921 )
...
* chore: refactor browser IPC into typescript
* chore: refactor app.ts into Typescript
* Refactors app.dock into cpp
* Removes app.launcher which has not existed for 3 years
* Removes 2 deprecated APIs (that have been deprecated for more than one
major)
* Refactors deprecate.ts as well
2019-02-14 14:29:20 -08:00
Shelley Vohr
fed5b99a9f
feat: promisify contentTracing.getTraceBufferUsage() ( #16600 )
...
* feat: promsify contentTracing.getTraceBufferUsage()
* deprecate getTraceBufferUsage
* address feedback from review
* properly deprecate
2019-02-13 13:24:57 -08:00
Shelley Vohr
e790dbd737
chore: add standalone function deprecation helper ( #16782 )
2019-02-08 09:50:11 -08:00
Shelley Vohr
9ebba76c03
chore: improve existing error preservation in promisify ( #16815 )
...
This PR better preserves existing behavior in `deprecate.promisify()` in the cases where the promise fails. Previously, if a callback was only called with `data` instead of `err, data` and the promise was rejected, `data` would be populated with `err`, which could be confusing to users. This makes it such that `err` is called back on promise rejection if a callback is called with `err, data` a la Node.js.
2019-02-07 10:25:20 -08:00
Shelley Vohr
5a35c3a279
chore: fix promisify helper ( #16544 )
...
* chore: fix promise deprecation helper
* fix deprecations
* update deprecation tests
2019-01-25 14:23:24 -08:00
Shelley Vohr
4b18a38e9f
chore: simplify promisify helper ( #15952 )
...
chore: simplify promisify helper
2018-12-10 08:13:09 -08:00
Milan Burda
d561c5531b
feat: deprecate modules internally using remote.require in sandboxed renderer context ( #15145 )
2018-12-05 10:34:09 +01:00
Shelley Vohr
41c2685204
feat: promisify win.capturePage() ( #15743 )
...
* feat: promisify win.capturePage
* mark optional arg correctly
* Add to breaking changes doc
* properly deprecate win.capturePage
* remove change from api-contract
* document both callback and promise versions
* address docs feedback
* update promisification progress doc
2018-11-27 23:50:53 -05:00
Shelley Vohr
0a5f8611e8
chore: add promise api runtime flag ( #15841 )
...
* chore: add promise api runtime flag
* add promisification plan document
* fix process.md typo
2018-11-26 16:00:46 -05:00
Shelley Vohr
a45d5960d7
chore: allow for callback => promise deprecation ( #15758 )
...
* chore: allow for callback => promise deprecation
* cb type check is sufficient
* migrate warn to always trigger
2018-11-19 12:56:26 -05:00
Charles Kerr
a3f7e298cf
refactor: remove unused, duplicated code in deprecate module ( #14579 )
...
* remove obsolete tests
* remove unused deprecate API
* make a warnOnce helper for the deprecate methods
* misc. copyediting, e.g. variable names, whitespace
* test that any deprecation warns once at most
* use strict
2018-09-12 17:13:22 -05:00
Shelley Vohr
a8a610cb34
chore: remove only on deprecations api spec ( #14564 )
...
* chore: remove only
* add option to ignore missing properties
2018-09-11 23:00:41 -07:00
Shelley Vohr
2157d09956
chore: refactor deprecation apis ( #14495 )
2018-09-11 11:16:49 -07:00
Shelley Vohr
9bf1fb323b
chore: add removeFunction to deprecate module ( #14468 )
...
* chore: add removeFunction function to deprecate api
* re-comment deprecate.member
2018-09-05 21:55:28 -07:00
Samuel Attard
1b7418fb7b
Revert "sec: deprecate some webPreference defaults to be secure-by-default ( #14284 )" ( #14380 )
...
This reverts commit 66d6ba8689
2018-08-30 09:57:49 +12:00
Samuel Attard
66d6ba8689
sec: deprecate some webPreference defaults to be secure-by-default ( #14284 )
...
* feat: deprecate default value of nodeIntegration
* Use DeprecationStatus::Stable as the default instead of shadowing
* change wording of deprecations
* chore: also deprecate kWebviewTag and kContextIsolation
* chore: do as we preach, lets be secure-by-default in the default app
2018-08-29 13:14:04 -05:00
Shelley Vohr
f9e2ec43d0
fix: deprecate properties in app.getAppMetrics() ( #13446 )
...
* fix: deprecate properties in app.getAppMetrics()
* address feedback from review
* fix deprecated property location
* simplify test
2018-06-26 23:47:01 -07:00
Charles Kerr
2275625e1a
feat: warn if deprecated property is already set
2018-05-29 15:58:02 +02:00
Charles Kerr
0a614217ce
feat: re-add deprecate.property()
2018-05-29 15:40:19 +02:00
Nitish Sakhawalkar
2579071b98
Deprecate did-get-response-details and did-get-redirect-request ( #12615 )
...
* Deprecate webContents events did-get-response-details and did-get-redirect-request.
* Update guest view files
* Update webview tag docs and update specs
* Update deprecate.event function
* Update comment
* Update more
* Update documentation for other deprecated event
2018-04-23 14:46:12 -05:00
Shelley Vohr
7904be8763
comment out unused methods
2017-11-20 15:12:34 +01:00
Shelley Vohr
dc410efa36
rename and fix assoc. test
2017-11-14 14:56:16 -05:00
Shelley Vohr
99d35f7786
a few more updates to tests
2017-11-14 13:33:38 -05:00
Shelley Vohr
d05a1f8053
first pass at deprecation spec updates
2017-11-13 20:21:57 -05:00
Kevin Sawicki
cc7395eea8
Remove returns from event listeners
2016-05-19 15:28:08 -07:00
Zeke Sikelianos
e6698102c9
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
c845ea8372
autoformat more easy files
2016-03-30 17:00:31 -07:00
Kevin Sawicki
8889c29866
Use rest parameters
2016-03-18 11:51:02 -07:00
Kevin Sawicki
70aa9b06ee
Move JavaScript to root lib/ folder
2016-03-08 11:14:21 -08:00
