Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings ( #14583 )
...
* chore: fix cpplint 'include_what_you_use' warnings
Typically by including <memory>, <utility> etc.
* chore: fix 'static/global string constant' warning
Use C style strings instead of std::string.
Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
/home/charles/electron/electron-gn/src/electron/script/cpplint.js
* refactor: remove global string variables.
Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.
The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
* fix: initializer error introduced in last commit
* fix: remove WIP file that was included by accident
* fix: include order
* fix: include order
* fix: include order
* fix: include order, again
2018-09-12 19:25:56 -05:00
Shelley Vohr
49c8c31220
format previously misses .cc files
2018-04-17 21:56:12 -04:00
Cheng Zhao
0cce6b3d21
Fix cpplint warning
2018-01-03 17:32:18 +09:00
Cheng Zhao
d6068759b6
win: Fix assertion when creating Notification
2018-01-03 17:25:19 +09:00
Felix Rieseberg
75cdd9ec70
🔧 Linter's gotta lint
2017-12-13 16:31:02 -08:00
Felix Rieseberg
8a8aaaf16c
🔧 Allow notifications debugging (Windows)
2017-12-13 16:25:49 -08:00
Samuel Attard
ef40bd4786
Remove dead header file for notification delegate
2017-11-24 10:58:17 +09:00
Felix Rieseberg
741dc1eb0b
🔧 Ensure correct path
2017-09-25 13:51:16 -07:00
Kevin Sawicki
d7321ed980
Add brightray prefix to include paths from within brightray
2017-05-19 08:46:15 -07:00
Kevin Sawicki
f193b2b2a6
Fix build/include_what_you_use linter violations in brightray
2017-05-19 08:46:15 -07:00
Ales Pergl
fbe3b27409
Addressed review feedback
2017-04-05 14:30:17 +02:00
Ales Pergl
0bba5b9b41
Address cpplint issue "Lines should be <= 80 characters long [whitespace/line_length] [2]"
2017-04-05 14:30:15 +02:00
Ales Pergl
0fa6c82b3f
Use NotificationPresenterWin7 on Windows 7
2017-04-05 14:30:15 +02:00
Ales Pergl
e6a30388da
Make Notification factory function a member of NotificationPresenter so that we can create different types of notifications based on runtime conditions.
2017-04-05 14:30:15 +02:00
Kevin Sawicki
2ece711c2e
Format line length to 80 instead of 100
2017-03-23 15:47:30 -07:00
Kevin Sawicki
be0c0e278a
Remove cpplint errors
2017-03-23 12:48:27 -07:00
Cheng Zhao
a749a3dd2a
Fix Debug building on Windows
2017-01-26 16:09:45 +09:00
Cheng Zhao
851ef398fb
Adapt to changes of Chrome 51 API changes
2016-05-23 10:59:07 +09:00
Cheng Zhao
b091f27abf
win: Adapt to new Notification style
2015-12-25 11:05:48 +08:00
Cheng Zhao
513b6ae0d6
Do not use icon url when showing notification
2015-12-24 20:03:54 +08:00
Cheng Zhao
087eeedab8
Use application name when app user model ID is not available
2015-11-24 15:11:43 +08:00
Cheng Zhao
c060539562
Only create NotificationPresenter when succeeded to initailize toast manager
...
This fix crash when we failed to initailize toast manager.
2015-11-24 14:40:58 +08:00
Cheng Zhao
aa8d164036
Use AppUserModelID as app id
2015-11-20 13:28:37 +08:00
Felix Rieseberg
2c84d70f8f
Delay Load WinRT Libraries
2015-11-10 18:04:09 -08:00
Cheng Zhao
f9f8a289d9
Simplify the management of objects
2015-11-10 20:23:08 +08:00
Cheng Zhao
4f73de0930
Make the toast type really work
2015-11-10 20:07:12 +08:00
Cheng Zhao
6b9371c4cd
Use smart pointer for everything
2015-11-10 19:50:38 +08:00
Cheng Zhao
1b9c9e40e3
Code cleanup with Chromium's coding style
2015-11-10 18:30:58 +08:00
Jason Poon
8dbeca8c7f
Windows Toasts: Hide(), Runtime Check, Header Cleanup
2015-11-09 12:00:50 +01:00
Felix Rieseberg
86ea0759d8
Windows Toasts: Icons, Events, Cleanup, Documentation
...
- Enable documentations
- Add a small usage example to the header
- Final cleanups
2015-11-09 12:00:49 +01:00
Jason Poon
498bff9e5a
Windows Toasts: Enable Basic Notifications
...
To test this puppy out, build and open up the Chromium Dev Tools.
Then, run `new Notification("Test title", {body: "Test body"});`
2015-11-09 12:00:21 +01:00
