Charles Kerr
4fbf18a021
refactor: move impl functions into private namespace ( #43372 )
2024-08-21 15:26:06 -05:00
Charles Kerr
93a6f3e607
refactor: NodeBindings::Create() returns a unique_ptr ( #43361 )
...
* refactor: NodeBindings::Create() returns a unique_ptr
* empty commit
2024-08-20 15:34:59 -04:00
Charles Kerr
a2de94dda1
chore: remove unused ConvertableToTraceFormatWrapper ( #43356 )
...
* chore: remove unused ConvertableToTraceFormatWrapper
Last use removed in Apr 2024 (39bf441b#41880 )
* fixup! chore: remove unused ConvertableToTraceFormatWrapper
remove now-unused trace_event.h header, too
2024-08-20 15:21:43 -04:00
electron-roller[bot]
2cc14c6e8f
chore: bump chromium to 129.0.6668.0 (main) ( #43368 )
...
* chore: bump chromium in DEPS to 129.0.6668.0
* 5787687: [Extensions] Remove EventRouterForwarder from BrowserProcess
https://chromium-review.googlesource.com/c/chromium/src/+/5787687
* 5788808: Resolve Blob URL's origin using info from browser process
https://chromium-review.googlesource.com/c/chromium/src/+/5788808
* chore: fixup patch indices
* 5786747: Remove "int WriteFile"
https://chromium-review.googlesource.com/c/chromium/src/+/5786747
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-20 16:54:27 +02:00
Charles Kerr
3186c2f0ef
refactor: remove unused SetWMSpecState ( #43347 )
...
last use removed in Aug 2022 by 53cd2315#35179
2024-08-19 17:15:19 -04:00
Charles Kerr
44e4e4521c
chore: remove unused method Erase() ( #43348 )
...
Last use removed in Mar 2018 by 4b39d17e
2024-08-19 17:14:57 -04:00
Vít Černý
189675575c
feat: extend navigationHistory API ( #42014 )
...
* feat: extend navigationHistory API
* refactor: simplify index checking
* refactor: rename 'getHistory' and 'replaceHistory' methods of navigationHistory
* refactor: rename delete*() methods to remove*()
* feat: remove navigationHistory.replaceHistory()
* tests: add tests for removeEntryAtIndex and getAllEntries
2024-08-19 15:46:04 -04:00
electron-roller[bot]
4c3014944c
chore: bump chromium to 129.0.6664.0 (main) ( #43329 )
...
* chore: bump chromium in DEPS to 129.0.6657.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6658.0
* chore: update patches
* 5743786: [ServiceWorker] Populate service worker start token to WorkerId.
https://chromium-review.googlesource.com/c/chromium/src/+/5743786
* 5784424: [Extensions] Move ownership of Dispatcher to ExtensionsRendererClient
https://chromium-review.googlesource.com/c/chromium/src/+/5784424
* chore: bump chromium in DEPS to 129.0.6659.0
* chore: bump chromium in DEPS to 129.0.6660.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6662.0
* chore: bump chromium in DEPS to 129.0.6664.0
* 5789627: [Partitioned Popins] (3) `popin` feature triggers third-party storage partitioning
https://chromium-review.googlesource.com/c/chromium/src/+/5789627
* 5791367: Remove some chrome:: namespace from chrome/browser/app_mode/*
https://chromium-review.googlesource.com/c/chromium/src/+/5791367
* 5791522: [SCK] Skip redundant getShareableContentWithCompletionHandler
https://chromium-review.googlesource.com/c/chromium/src/+/5791522
* 5761330: Send refresh rate prefs b/w RefreshRateController and DisplayPrivate
https://chromium-review.googlesource.com/c/chromium/src/+/5761330
* chore: fixup patch indices
* 5793591: Remove unused GetHeader overload
https://chromium-review.googlesource.com/c/chromium/src/+/5793591
* 5787624: [Extensions] Simplify ExtensionsRendererClient::RenderThreadStarted()
https://chromium-review.googlesource.com/c/chromium/src/+/5787624
* 5721709: Fix Incorrect last_accessed_time Tracking for Tabs
https://chromium-review.googlesource.com/c/chromium/src/+/5721709
* 5789215: [Extensions] Add a //chrome/common/extensions build target
https://chromium-review.googlesource.com/c/chromium/src/+/5789215
* Roll V8 from 48f669a0758c to eee3eb91d01c
48f669a075..eee3eb91d0
2024-08-19 14:52:53 -04:00
Shelley Vohr
4801a54d08
refactor: migrate deprecated platform_util_mac calls ( #43161 )
...
refactor: migrate deprecated platform_util_mac calls
2024-08-15 10:53:38 -04:00
electron-roller[bot]
a7c52f1fb2
chore: bump chromium to 129.0.6656.0 (main) ( #43323 )
...
* chore: bump chromium in DEPS to 129.0.6656.0
* chore: update patches
* 5750664: Introduce Signin.NumberOfActiveAccounts.* metrics
https://chromium-review.googlesource.com/c/chromium/src/+/5750664
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-08-14 16:47:37 -04:00
Shelley Vohr
286384258b
fix: blank page when printing pdf ( #43309 )
2024-08-14 15:47:47 -04:00
Robo
9b166b3ed4
feat: support app#login event for utility process net requests ( #42631 )
...
* feat: support app#login event for utility process net requests
* chore: address review feedback
* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
2024-08-14 11:36:47 +09:00
Charles Kerr
bba31189a0
feat: accept-encoding zstd ( #43150 )
...
* fix: accept-encoding zstd
* Update shell/browser/net/system_network_context_manager.cc
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
* chore: make lint happy
---------
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
2024-08-12 10:00:04 -04:00
Shelley Vohr
d294871980
chore: deprecate textured BrowserWindow type option on macOS ( #43133 )
2024-08-12 10:32:35 +02:00
electron-roller[bot]
c9b7806418
chore: bump chromium to 129.0.6650.0 (main) ( #43266 )
...
* chore: bump chromium in DEPS to 129.0.6645.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6646.0
* refactor: remove ppapi dependency
PPAPI removal - https://issues.chromium.org/issues/40511450
PDF viewer migration - https://issues.chromium.org/issues/40511452
* chore: update patches
* chore: enable `content_enable_legacy_ipc`
We were indirectly relying on this via `enable_ppapi=true`, with
633a57d9b62da7850ef7946f6b101ed440d04cdd ppapi is now disabled and
this commit makes the dependency explicit.
* fix: gn check
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-08-12 10:28:33 +02:00
Charles Kerr
23bcca3ffc
refactor: put empty virtual function definitions in header ( #43285 )
...
* refactor: in FramelessView, move empty function decls to header
* refactor: in electron::api::WebContents, move empty function decls to header
* refactor: in electron::api::NativeWindow, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::OffScreenRenderWidgetHostView, move empty function decls to header
* refactor: in auto_updater::AutoUpdater, move empty function decls to header
* refactor: in electorn::api::FrameSubscriber, move empty function decls to header
* refactor: in electorn::api::SimpleURLLoaderWrapper, move empty function decls to header
* refactor: in electorn::InspectableWebContents, move empty function decls to header
* refactor: in electorn::OffScreenVideoConsumer, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::TrayIcon, move empty function decls to header
* refactor: in electron::ViewsDelegate, move empty function decls to header
* refactor: in electron::MediaCaptureDevicesDispatcher, move empty function decls to header
* refactor: in electron::UsbChooserContext::DeviceObserver, move empty function decls to header
* refactor: in electron::ProxyingWebSocket, move empty function decls to header
* refactor: in electron::Notification, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* Revert "refactor: in electron::PlatformNotificationService, move empty function decls to header"
This reverts commit 9103750d03b9ba1ceccba43d11dfdc2404ff6191.
* refactor: in electron::ElectronPDFDocumentHelperClient, move empty function decls to header
* refactor: in electron::api::SpellCheckClient, move empty function decls to header
* refactor: in electron::ElectronExtensionHostDelegate, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* refactor: in electron::NativeWindowViews, move empty function decls to header
* chore: move SetTouchBar() back to cc
* Revert "refactor: in auto_updater::AutoUpdater, move empty function decls to header"
This reverts commit c43d6862d32c74f63f82700a7546a732ac05ecb8.
2024-08-12 09:56:51 +02:00
Charles Kerr
bff298987f
chore: remove unused Notification fields icon_path_, has_icon_ ( #43286 )
...
Last use of `icon_path_` was removed on May 29, 2017 (c741b5845048425e
2024-08-12 09:55:54 +02:00
Shelley Vohr
6d13c503c5
refactor: update chrome.scripting extensions api impls ( #43205 )
2024-08-11 21:31:37 +02:00
Charles Kerr
7721fdf886
chore: remove unused method ElectronDesktopWindowTreeHostLinux::UpdateClientDecorationHints() ( #43283 )
...
Xref: dff980c9c2#41868
2024-08-10 18:55:10 -05:00
Charles Kerr
c35739d60d
refactor: use url::DomainIs() to check cookie domains ( #43262 )
...
* test: add tests to exercise pre-exsiting cookie domain matching behavior
* refactor: use url::DomainIs() to match cookie domains
* docs: fix typo
2024-08-09 18:35:18 -05:00
Charles Kerr
c4dfff9844
fix: accidental handle copying in a range loop ( #43260 )
...
fix: accidental handle copying
Xref: https://github.com/electron/electron/pull/37857
2024-08-09 13:38:03 -05:00
Shelley Vohr
f49f6ff68b
fix: check screen capture permissions in desktopCapturer ( #43080 )
...
fix: check screen capture permissions in desktopCapturer
2024-08-09 10:08:49 +02:00
Shelley Vohr
0718c2b9ee
fix: system-context-menu with frameless BrowserWindows ( #43243 )
2024-08-09 10:08:01 +02:00
Shelley Vohr
70dda694e2
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled ( #43206 )
...
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled
2024-08-07 14:51:38 +02:00
Charles Kerr
6293bbced0
perf: avoid redundant calls to GetView() ( #43216 )
...
* perf: avoid double-calls to GetView()
There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:
if (auto* view = foo->GetView())
view->DoSomething();
* perf: avoid discarded GetView() call
2024-08-06 11:25:59 -05:00
Charles Kerr
3d766e9ccb
perf: don't build unused vectors in HidChooserContext ( #43192 )
...
* refactor: remove unused code in HidChooserContext::DeviceRemoved()
* refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError()
* refactor: use structured bindings for readability
2024-08-05 15:31:58 +02:00
Charles Kerr
6877671390
fix: gin_helper::MicrotasksScope instantiation ( #43185 )
2024-08-05 08:24:27 -05:00
Shelley Vohr
e64302cc91
refactor: simplify window moveAbove/moveTop impl on macOS ( #43157 )
...
refactor: simplify window moveAbove/moveTop impl on macOS
2024-08-05 09:57:16 +02:00
Shelley Vohr
2a613cabaa
refactor: migrate electron_login_helper to non-deprecated API ( #43182 )
...
refactor: migrate electron_login_helper to non-deprecated API
2024-08-05 09:56:18 +02:00
electron-roller[bot]
20e77afe0f
chore: bump chromium to 129.0.6634.0 (main) ( #43189 )
...
* chore: bump chromium in DEPS to 129.0.6634.0
* chore: update chore_add_electron_deps_to_gitignores.patch
no manual changes. patch applied with fuzz 1.
* chore: e patches all
* chore: update call to gfx::Image::CreateFrom1xPNGBytes()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5743597
The call now takes a base::span
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-04 07:31:31 -05:00
Charles Kerr
5a809a6694
refactor: prefer std::ranges over base::ranges ( #43172 )
...
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5668999
Xref: https://groups.google.com/a/chromium.org/g/cxx/c/ZnIbkfJ0Glw
2024-08-02 21:21:59 -05:00
Charles Kerr
5b18cc46bc
chore: bump chromium to 129.0.6630.0 (main) ( #43087 )
...
* chore: bump chromium in DEPS to 129.0.6623.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
remove the changes to media/audio/mac/audio_manager_mac.cc,
since upstream has also made this change now.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5738654
* chore: update fix_disable_scope_reuse_associated_dchecks.patch
We had been removing a couple of `DCHECK`. Upstream changed their
code to limit when these `DCHECK`s get called, so let's see if our
change is still needed.
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5739076
* chore: e patches all
* Bump the Chrome macOS deployment target to 11.0
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5734361
BREAKING CHANGE: Bump the Chrome macOS deployment target to 11.0
* src: stop using deprecated fields of `v8::FastApiCallbackOptions`
Xref: d0000b118dhttps://chromium-review.googlesource.com/c/v8/v8/+/5741336
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5741199
* fixup! chore: update fix_disable_scope_reuse_associated_dchecks.patch
chore: re-disable DCHECKs
yep, it is still needed
* refactor use non-deprecated variant of openApplicationAtURL
old version is deprecated now in macOS 11
Xref: https://developer.apple.com/documentation/appkit/nsworkspace/1534810-launchapplicationaturl
Xref: https://developer.apple.com/documentation/appkit/nsworkspace/3172700-openapplicationaturl
* chore: bump chromium in DEPS to 129.0.6626.0
* chore: e patches all
* chore: disable NSUserNotification deprecation errors
* chore: disable NSWindowStyleMaskTexturedBackground deprecation errors
Xref: https://github.com/electron/electron/issues/43125
* chore: disable deprecation errors in platform_util_mac.mm
* chore: disable launchApplication deprecation errors
* chore: bump chromium in DEPS to 129.0.6630.0
* chore: update refactor_expose_file_system_access_blocklist.patch
apply patch manually due to context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5745444
* chore: update deps_add_v8_object_setinternalfieldfornodecore.patch
no manual changes. patch applied with fuzz 1 (offset -5 lines)
* chore: e patches all
* fix: add clang_x64_v8_arm64/snapshot_blob.bin to the zip manifest
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5746173
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2024-08-02 09:02:11 -05:00
Charles Kerr
e7ca92a574
chore: remove unused internal env.unSetVar() ( #43148 )
...
chore: remove unused unSetVar JS binding
Added in Oct 2020 (b33f2260#25623 ) but never used
2024-08-01 18:41:41 -05:00
Shelley Vohr
3a07bd8821
fix: take bluetooth serial ports into account in serial.getPorts() ( #43101 )
...
* fix: take bluetooth serial ports into account in serial.getPorts()
* chore: remove port.path.LossyDisplayName()
2024-08-01 11:13:31 -05:00
cptpcrd
2337d8676d
fix: handle failing to enter fullscreen on macOS ( #43112 )
...
* fix: handle failing to enter/exit fullscreen on macOS
On macOS, failing to enter/exit fullscreen can fail. If this happens,
properly restore the original window state.
* refactor: remove fail to exit fullscreen handlers
Seem to be unnecessary since the window exits fullscreen anyway.
2024-08-01 12:13:13 +02:00
Charles Kerr
45e5ccc55e
chore: remove unused KeyWeakMap JS bindings ( #43111 )
...
The last three pieces of code that used it were removed in:
- Oct 2020 (8df4faa8#25711 )
- Jun 2020 (e1e73fa5#24115 )
- Jun 2020 (c0182bca#24116 ).
2024-07-31 16:37:04 -05:00
Shelley Vohr
ed3242adc1
fix: vibrant view is inserted into Views API hierarchy ( #43078 )
...
* fix: vibrant view is inserted into Views API hierarchy (#42263 )
* Update shell/browser/native_window_mac.mm
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-30 18:21:20 -05:00
Charles Kerr
1bcc566ad8
chore: remove unused & undocumented function v8Util.deleteHiddenValue() ( #43090 )
...
chore: remove unused v8Util.deleteHiddenValue()
Its last use was removed in Nov 2020 by c8d77cae4a#26659 )
2024-07-30 15:25:37 -05:00
Charles Kerr
47dde3b6e2
chore: remove unused class electron::ObjectLifeMonitor ( #43089 )
...
* chore: remove unused electron::ObjectLifeMonitor
The last users were removed in June 2020 e1e73fa5f#24115 )
and May 2020 9d7ba982#23592 ).
* fixup! chore: remove unused electron::ObjectLifeMonitor
fix: oops
2024-07-30 08:25:28 -05:00
Shelley Vohr
d09a2e513c
fix: showInactive window not showing ( #43079 )
...
fix: showInactive window not showing
Refs https://github.com/electron/electron/pull/42226 and https://github.com/electron/electron/pull/43033
2024-07-30 12:37:27 +02:00
Charles Kerr
7e9eb9e3f1
perf: avoid duplicate calculations in gin_helper::Dictionary getters ( #43073 )
...
* perf: cache the dictionary handle
* refactor: prefer result.IsJust() over !result.IsNothing()
for consistency
* refactor: prefer maybe.FromMaybe() over maybe.IsJust() && maybe.FromJust()
the inlined code is simpler
* refactor: simplify Get() impl
* refactor: add private helper Dictionary::MakeKey()
refactor: add private helper Dictionary::MakeHiddenKey()
2024-07-29 12:43:28 -05:00
Charles Kerr
e70ce89235
chore: more iwyu ( #43063 )
...
* chore: iwyu shell/browser/electron_pdf_document_helper_client.h
* chore: iwyu shell/browser/hid/electron_hid_delegate.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/usb/electron_usb_delegate.h
* chore: iwyu shell/browser/browser_observer.h
* chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h
* chore: iwyu shell/browser/serial/electron_serial_delegate.h
* chore: iwyu shell/browser/api/frame_subscriber.h
* chore: iwyu mojo/public/cpp/bindings/
* chore: iwyu components/
* chore: iwyu extensions/
* chore: iwyu shell/common/gin_helper/
* chore: iwyu v8/
* chore: iwyu base/containers/linked_list.h
* chore: iwyu shell/browser/native_window.h
* chore: iwyu shell/browser/api/electron_api_base_window.h
* chore: iwyu shell/common/node_includes.h
* chore: iwyu gin/handle.h
* chore: iwyu base/functional/callback.h
* chore: iwyu ui/gfx/
* chore: iwyu content/public/browser/render_frame_host.h
* fix: mac
* fix: mac
* fix: win
* chore: iwyu base/files/file_path.h
* chore: iwyu base/unguessable_token.h
* chore: iwyu ui/display/screen.h
* chore: iwyu chrome/browser/predictors/preconnect_manager.h
* chore: iwyu base/observer_list_types.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h
* chore: iwyu shell/browser/ui/inspectable_web_contents.h
* chore: iwyu content/public/browser/keyboard_event_processing_result.h
* chore: iwyu net/cookies/canonical_cookie.h
* chore: iwyu net/base/address_list.h
* chore: iwyu net/cert/x509_certificate.h
* chore: iwyu net/cookies/cookie_change_dispatcher.h
* chore: iwyu net/dns/public/host_resolver_results.h
* fix: mac
* Revert "chore: iwyu net/cert/x509_certificate.h"
This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.
2024-07-29 12:42:57 -05:00
electron-roller[bot]
92496c1930
chore: bump chromium to 129.0.6616.0 (main) ( #43012 )
...
* chore: bump chromium in DEPS to 128.0.6613.0
* chore: 5725076: Update EventType names | https://chromium-review.googlesource.com/c/chromium/src/+/5725076
* chore: export patches
* chore: 5725076: Update EventType names | https://chromium-review.googlesource.com/c/chromium/src/+/5725076 for windows
* chore: bump chromium in DEPS to 129.0.6614.0
* 5725672: Add a feature to limit the number of preconnect in LoadingPredictor | https://chromium-review.googlesource.com/c/chromium/src/+/5725672
* chore: bump chromium in DEPS to 129.0.6616.0
* chore: e patches all and resolve conflict in patches/v8/fix_disable_scope_reuse_associated_dchecks.patch
* 5730656: Show an error dialog when UpdatePrintSettings() fails | https://chromium-review.googlesource.com/c/chromium/src/+/5730656
* chore: gen-libc++-filenames
* 5729956: Finally remove string_piece.h | https://chromium-review.googlesource.com/c/chromium/src/+/5729956
* chore: replace all references of base::StringPiece with std::string_view
* chore: remove more references of stringPiece in favor of string_view
* chore: rename string_piece variables to string_view
* 5508795: Remove the NotificationService | https://chromium-review.googlesource.com/c/chromium/src/+/5508795
* 5734053: Revert Rename GlobalFeatures to GlobalDesktopFeatures. | https://chromium-review.googlesource.com/c/chromium/src/+/5734053
* chore: resolve conflict with main without merge
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
2024-07-29 09:37:35 -04:00
Fedor Indutny
55e7a47d70
fix: always terminate active Node Streams ( #43056 )
...
`.destroy()` is an important method in the lifecycle of a Node.js
Readable stream. It is typically called to reclaim the resources
(e.g., close file descriptor). The only situations where calling
it manually isn't necessary are when the following events are
emitted first:
- `end`: natural end of a stream
- `error`: stream terminated due to a failure
Prior to this commit the ended state was incorrectly tracked together
with a pending internal error. It led to situations where the request
could get aborted during a read and then get marked as ended (having
pending error).
With this change we disentangle pending "error" and "destroyed" cases to
always properly terminate an active Node.js Readable stream.
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
2024-07-27 12:25:43 -05:00
Keeley Hammond
8db1563d73
fix: remove InspectableWebContentsViewMac ( #43033 )
...
* Revert "refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )"
This reverts commit e67ab9a93dhttps://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fix: contents_web_view_ -> contents_view_
* chore: remove extraneous includes
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-27 11:44:22 -05:00
BILL SHEN
77ba40bc01
chore: avoid crash while notification removal ( #43040 )
...
* avoid crash of operation on an invalid entry while erase set iterator.
* fix notification removal crash due to the nullptr presenter
---------
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-07-26 15:34:40 +02:00
Keeley Hammond
2fd04a78a1
fix: revert BrowserWindow unresponsive handling refactor ( #43034 )
...
* Revert "refactor: JSify BrowserWindow unresponsive handling (#37902 )"
This reverts commit 67ba30402b
2024-07-25 13:02:02 -07:00
Charles Kerr
660872c048
refactor: move safe_storage functions into anonymous namespace ( #43032 )
2024-07-25 13:18:13 -05:00
Shelley Vohr
976f5d1b75
fix: File System API permissions should reset on WebContents destruction ( #43009 )
...
fix: active File System API permissions should reset on WebContents destruction
2024-07-25 09:53:30 -04:00
Charles Kerr
aa23198ad8
chore: remove more unused #include calls ( #43000 )
...
* chore: in shell/renderer/renderer_client_base.h, remove include media/base/key_systems_support_registration.h
last use removed in c670e38b
2024-07-25 11:25:45 +02:00
