Cheng Zhao
4c7b48e596
mac: Window's native view should be its content view
2018-03-06 16:20:37 +09:00
Cheng Zhao
1681ee35db
Set WebContents background color in BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
7b8890a4c9
web_contents can't be null
2018-03-06 16:20:37 +09:00
Cheng Zhao
2eaa6d0874
Move StoreFocus/RestoreFocus to BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
cad3d694ab
mac: Remove access to webContents in windowWillUseStandardFrame
2018-03-06 16:20:37 +09:00
Cheng Zhao
ca42325ade
Make OnMessageBoxCallback a method since it is accessing members
2018-03-06 11:35:53 +09:00
Cheng Zhao
7516b059fe
Code style fixes
2018-03-06 11:31:56 +09:00
Samuel Attard
7dec3c9320
Fixup cpplint
2018-03-06 11:19:15 +09:00
Samuel Attard
731240e0e9
Use USER_WANTS_NO_MORE_DIALOGS constant for -1 magic number
2018-03-06 11:19:15 +09:00
Charles Kerr
a5a068b2ee
fix cpplint errors
...
atom/browser/atom_javascript_dialog_manager.cc:39: Lines should be <= 80 characters long [whitespace/line_length] [2]
atom/browser/atom_javascript_dialog_manager.cc:39: If/else bodies with multiple statements require braces [readability/braces] [4]
atom/browser/atom_javascript_dialog_manager.cc:62: Lines should be <= 80 characters long [whitespace/line_length] [2]
atom/browser/atom_javascript_dialog_manager.cc:89: If/else bodies with multiple statements require braces [readability/braces] [4]
2018-03-06 11:19:15 +09:00
Charles Kerr
2435ffaf09
fix cpplint error
...
atom/browser/atom_javascript_dialog_manager.h:9: Include "map" not in alphabetical order [build/include_alpha] [4]
2018-03-06 11:19:15 +09:00
Samuel Attard
795447f61a
Implement dialog (alert/confirm) blocking as a user switch after the first dialog
...
* This is to enable more browser-like behavior so that users who run third-party code
will not be DOS'ed with alerts and confirms. This is already handled like this
in most major browsers so this will greatly help these developers
2018-03-06 11:19:15 +09:00
Shelley Vohr
199cf31b9e
deprecate screen.getMenuBarHeight
2018-03-05 19:45:51 -05:00
Aleksei Kuzmin
52c0864cb8
Use version 0.0.0-dev everywhere
2018-03-05 16:24:48 +01:00
Shelley Vohr
bf491de9fe
fix styling and add spec
2018-02-28 00:22:42 -08:00
Shelley Vohr
2abc69780e
move native-mate back into the api layer
2018-02-27 13:00:42 -08:00
Shelley Vohr
837a2d4bbd
appease the linter
2018-02-26 22:25:09 -08:00
Samuel Attard
b722150d87
Don't cast manually for NativeWindow*
2018-02-27 16:13:17 +11:00
Samuel Attard
5336b4a89c
Pass arguments instance through the chain in order to throw error
2018-02-27 16:11:58 +11:00
Shelley Vohr
e84d7c0cda
add warning when addTabbedWindow is called on self
2018-02-26 14:47:36 -08:00
Cheng Zhao
53229e3d6c
Fix network delegate race condition ( #12044 )
...
* Fix race condition when getting network delegate
* Remove the evil URLRequestContextGetter::network_delegate
* Move the arguments instead of const referrencing
Safer and more efficient.
2018-02-26 06:23:59 -08:00
Cheng Zhao
fdd66bd76d
Merge pull request #11607 from bughit/frame_navigation_api
...
frame navigation API
2018-02-26 15:50:11 +09:00
Cheng Zhao
ccf30e0934
Coding style fixes
2018-02-26 15:19:44 +09:00
Cheng Zhao
f7786a9e48
Merge pull request #11230 from electron/upgrade-to-chromium-62
...
Upgrade to Chromium 62
2018-02-26 14:20:21 +09:00
kaylie
da9f12d1e2
restore old cb
2018-02-25 14:19:40 -08:00
Cheng Zhao
b9ab2fe0fb
Disable stack dumping for 32bit ARM
2018-02-23 10:22:00 +09:00
Cheng Zhao
39e0433570
Fix build error after rebasing
2018-02-23 10:22:00 +09:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
Aleksei Kuzmin
f5d207f8f0
Improve process launch handle sharing API.
...
https://codereview.chromium.org/2950153002
2018-02-23 10:21:24 +09:00
deepak1556
5eb0a89579
REVIEW: let browser context manage cookie change sub list
2018-02-23 10:21:24 +09:00
Aleksei Kuzmin
9fa08fdbc0
Merge views::CustomButton into views::Button.
...
https://chromium-review.googlesource.com/617407
2018-02-23 10:21:24 +09:00
Aleksei Kuzmin
6f00e4a014
REVIEW: Implements core logic for Pixel Canvas
...
https://codereview.chromium.org/2877483003
2018-02-23 10:21:24 +09:00
deepak1556
d846c9006e
Replace somemore uses of SetStringWithoutPathExpansion
2018-02-23 10:21:24 +09:00
deepak1556
69ca6ccdc1
Remove chrome_utility_messages.h, it's unused
2018-02-23 10:21:23 +09:00
deepak1556
25d966110e
FIXME: PDF component IPC should be converted to Mojo.
...
https://codereview.chromium.org/2455543002
2018-02-23 10:21:23 +09:00
deepak1556
e03f7baa60
gfx::Image::SwapRepresentations is removed in favor of std::move
...
https://chromium-review.googlesource.com/c/chromium/src/+/588033
2018-02-23 10:21:23 +09:00
deepak1556
62635f43f4
base::LaunchOptions fds_to_remap is no longer a pointer
...
https://codereview.chromium.org/2950153002
2018-02-23 10:21:23 +09:00
deepak1556
248d572077
REVIEW: Subscribe to cookie store for changes in place of CookieMonsterDelegate
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
b02edd014a
Rename CompositionUnderline to ImeTextSpan
...
https://chromium-review.googlesource.com/609524
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
412b9e9ad8
Move IDMap to base namespace.
...
https://chromium-review.googlesource.com/618801
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
8f78bd3307
Remove was_ignored_by_handler from frame_messages.h
...
https://chromium-review.googlesource.com/587701
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
91a339b625
viz: Move BeginFrame(Args|Ack) to components/viz/common/frame_sinks
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
1a9b056e93
Move CompositorFrameSink and FrameSinkManager mojom from cc to viz
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
abc6003640
viz: Move BeginFrameSource to components/viz/common/frame_sinks
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
76683c0af5
viz: Move CopyOutput(Request|Result)=> components/viz/common/quads
2018-02-23 10:21:23 +09:00
Shelley Vohr
128cb7f5b2
updates to build flags and comp errors
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
8c0c1e4ded
media: Replace ENABLE_PEPPER_CDMS buildflag with ENABLE_LIBRARY_CDMS
...
https://chromium-review.googlesource.com/582309
2018-02-23 10:21:23 +09:00
deepak1556
75c17cf846
Use generic base::Value::SetKey
...
Remove base::Value::SetDoubleWithoutPathExpansion
https://chromium-review.googlesource.com/591654
Remove base::Value::SetStringWithoutPathExpansion
https://chromium-review.googlesource.com/592368
Remove base::Value::SetIntegerWithoutPathExpansion
https://chromium-review.googlesource.com/591655
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
5783ce0b3c
Update chrome_version.h
2018-02-23 10:21:23 +09:00
Cheng Zhao
3be92f550c
Better clarity and fix typo
2018-02-23 09:15:13 +09:00
Cheng Zhao
816a96c2cc
Update font settings in api::WebContents
2018-02-22 19:01:45 +09:00
Cheng Zhao
c87fc2426d
Handle transparent WebContents in api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
c611eb061d
Move InputEventObserver to api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
aa3eafcea1
Move closing logic to api::BrowserWindow
...
Closing a BrowserWindow is essentially closing a WebContents, the logic
should not be in NativeWindow.
2018-02-22 19:01:45 +09:00
Cheng Zhao
66fab65a1a
Add NativeWindowObserver::OnCloseButtonClicked
2018-02-22 19:01:45 +09:00
Cheng Zhao
a25b49a127
Add ExtendedWebContentsObserver
2018-02-22 19:01:45 +09:00
Cheng Zhao
a3124e8873
Use observer to provide OnRendererUnresponsive
2018-02-22 19:01:45 +09:00
Cheng Zhao
bffb31c337
Remove OnMessageReceived from NativeWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
44e7282b4b
The UpdateDraggableRegions does not share implementations
2018-02-22 19:01:45 +09:00
Cheng Zhao
c2aa312e0c
Check weak ptr before using it
2018-02-22 19:01:45 +09:00
Cheng Zhao
384b03d49b
UpdateDraggableRegionViews is redundant
2018-02-22 19:01:45 +09:00
Cheng Zhao
6650a06339
Move RenderViewCreated logic to api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
c256a43139
Move ready-to-show to api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
0d9a157914
Turn api::Window into a WebContentsObserver
2018-02-22 19:01:45 +09:00
Cheng Zhao
973647eaa2
Rename api::Window to api::BrowserWindow
2018-02-22 12:50:47 +09:00
bughit
88b887fe47
frame navigation API
2018-02-21 18:50:15 -05:00
Cheng Zhao
f7ec346e9f
Merge pull request #11956 from brenca/transparent-window-devtools-fix
...
Fix transparent windows losing transparency when devtools detaches
2018-02-21 19:54:35 +09:00
Heilig Benedek
6f2609f9d2
Remove outdated comments
2018-02-21 11:28:53 +01:00
shelley vohr
193febd18c
deprecate boolean highlightMode param ( #11993 )
...
* deprecate boolean highlightMode param
* add process.noDeprecations check
* fix native method override
* add todo
2018-02-20 22:30:32 -06:00
shelley vohr
c2575c4944
remove app.getAppMemoryInfo ( #11985 )
...
* remove app.getMemoryInfo
* semicolons are important
2018-02-20 18:52:33 -06:00
John Kleinschmidt
dcaff20cfd
Merge pull request #11981 from electron/set-tray-highlightmode
...
no longer support bool param for setHighlightMode
2018-02-20 12:57:52 -05:00
shelley vohr
846be03f1d
remove support for hidden-inset ( #11975 )
2018-02-20 11:09:54 -06:00
shelley vohr
7bcccdec41
remove atom-shell process name ( #11979 )
2018-02-20 10:33:38 -06:00
shelley vohr
6a3fde6e20
Merge pull request #11973 from electron/remove-clipboard-methods
...
Remove html/rtf methods marked for 2.0
2018-02-20 11:21:10 -05:00
Charles Kerr
8d086a43cb
Fix brightray::GetApplicationName(), ..Version() on Linux ( #11980 )
...
* add brightray API to override app version
* in atom browser, use brightray app version API
* on Linux, have GetApplicationVersion() use brightray version API
* on Linux, implement brightray::GetApplicationName()
* fix typo in brightray API
* make browser.GetName() logic follow GetVersion() logic
* improve variable name in OverrideApplicationVersion declaration
* fix typo in brightray impl
2018-02-20 10:16:51 -06:00
Cheng Zhao
dc62e51ba4
Fix the cyclic reference in menu delegate ( #11967 )
...
* Fix the cyclic reference in menu delegate
* Fix menu tests due to delegate change
2018-02-20 10:11:35 -06:00
shelley vohr
8d4bf3e29a
Merge pull request #11974 from electron/remove-setZoomLevelLimits
...
remove setZoomLevelLimits
2018-02-20 10:51:41 -05:00
shelley vohr
a2856db982
Remove nativeImage deprecated methods ( #11978 )
...
* remove deprecated nativeimage methods
* remove .only from spec
2018-02-20 09:15:27 -06:00
Shelley Vohr
57738e6981
no longer support bool param for setHighlightMode
2018-02-20 10:06:59 -05:00
Shelley Vohr
211b542ae4
remove setZoomLevelLimits
2018-02-20 08:57:48 -05:00
Shelley Vohr
e4e20d667b
remove html/rtf methods marked for 2.0
2018-02-20 08:41:58 -05:00
Shelley Vohr
fc025064f7
remove setExtraParameter for 2.0
2018-02-20 08:26:10 -05:00
Heilig Benedek
d31d2087a3
use SK_ColorTRANSPARENT as the default color to fix issue with transparent window devtools detach
2018-02-19 15:07:28 +01:00
Charles Kerr
56859531cd
fix floating reference glib warning ( #11948 )
...
use gtk_widget_destroy() rather than g_object_unref() on the floating temporary menubar widget that we use to calculate colors
2018-02-19 00:12:54 -06:00
Thiago de Arruda
bc76f35691
Fix protocol filtering of net.request
...
net::URLRequest inherits from base::SupportsUserData, which allows
associating arbitrary data with the request. Use this mechanism as a
condition for filtering requests from custom protocols.
Close #11657
2018-02-16 13:03:53 -05:00
John Kleinschmidt
78ccfa0612
Merge pull request #11879 from electron/fix-gtk-deprecations
...
Fix GTK+ 3 deprecations
2018-02-16 10:01:01 -05:00
Cheng Zhao
67fa13d7cf
Merge pull request #11925 from electron/squirrel-mac-cdn
...
Update to use Squirrel.Mac that supports CDN releases
2018-02-16 15:28:39 +09:00
Samuel Attard
549042160f
requestHeaders --> headers
2018-02-16 13:41:21 +11:00
Charles Kerr
5e7a5ce3a9
run clang-format on changed sources
2018-02-15 15:20:55 -06:00
Charles Kerr
381ed2e2b2
remove GTK+ 2 specific code
2018-02-15 14:57:45 -06:00
Cheng Zhao
af92b04eb9
Merge pull request #11654 from sethlu/set-notification-close-button-text
...
feat: Set macOS notification close button title
2018-02-15 16:01:30 +09:00
Samuel Attard
6318cd781d
Update to use Squirrel.Mac that supports CDN releases
2018-02-15 14:00:46 +11:00
Shelley Vohr
31b074ff0e
change to return emit
2018-02-14 09:28:21 -05:00
Shelley Vohr
c3d11a51cc
emit console-message in OSR mode
2018-02-14 09:09:45 -05:00
Charles Kerr
402201ac39
Fix cppcheck warnings ( #11883 )
...
* remove unused variable
* limit scope of variable 'ret'
* pass shared_ptr<SkBitmap> by reference
* silence warning: value reassign before read
* fix oops
* don't refer to 'response' after std::move()ing it
* make the linter happy
2018-02-14 02:21:46 -06:00
shelley vohr
a55fd06aa2
Revert "Merge pull request #11737 from kwonoj/feat-cache-capacity" ( #11906 )
...
This reverts commit 181169b743
, reversing
changes made to baced3152f
.
2018-02-13 10:49:27 -05:00
Cheng Zhao
affa21600c
Remove unnecessary methods on WebContentsPreferences
2018-02-13 15:57:54 +09:00
Emmanuel Kimmerlin
9c1b47361f
Add an "affinity" option to webPreferences
2018-02-13 15:18:55 +09:00
Samuel Attard
9bd7d53cf8
Handle empty handles ( #11598 )
...
* Handle empty handles
* Close and dispose window at end of void test
* Dispose of existing window before running void 0 spec
2018-02-12 14:46:29 -05:00
Samuel Attard
181169b743
Merge pull request #11737 from kwonoj/feat-cache-capacity
...
feat(webframe): export set cache capacity interface
2018-02-13 06:02:25 +11:00