Cheng Zhao
459a2304b4
fix: emit focus/blur events for webview ( #14344 )
...
* fix: emit focus/blur events for webview
* test: webview can emit focus event
2018-08-28 13:35:44 -05:00
Robo
edd5c4b9bb
fix: use OS process handle to clear object registry ( #14324 )
...
RenderProcessHost switch can happen between ipc calls when
speculative process are invvolved, which will lead to deletion
of entries on current context. Use OS process handles to
uniquely associate a destruction handler for a render process.
2018-08-28 13:32:46 -05:00
John Kleinschmidt
98b7a9ce9c
Merge pull request #14107 from electron/channel_id_patch
...
fix: create persistent channel ID store when cookie store is persistent
2018-08-28 14:10:04 -04:00
Alexey Kuzmin
7edd37bca1
build: add missing enable_view_api flag ( #14351 )
...
* build: add missing enable_view_api flag
Fixes #14340 .
* fix: properly pass a pointer to a SetLayoutManager() call
2018-08-28 10:55:31 -07:00
Robo
07d017dc01
fix: crash when tray is destroyed ( #14347 )
...
Release the view of status item before destroying it,
gives chance to perform cleanup on the view.
2018-08-28 10:45:24 -07:00
Roller Bot
85ea0518c5
chore: bump libcc (master) ( #14353 )
...
* chore: bump libcc submodule to 5db50d4918b667ecba5a67cf48cf0e261d7581fa
* chore: bump libcc in DEPS to 5db50d4918b667ecba5a67cf48cf0e261d7581fa
2018-08-28 10:22:17 -07:00
Samuel Attard
68da311ed1
feat: add session.setPermissionCheckHandler ( #13925 )
...
* feat: add session.setPermissionCheckHandler to handle syncornous permission checks vs requests
* spec: add tests for session.setPermissionCheckHandler
* docs: add docs for session.setPermissionCheckHandler
* feat: add mediaType to media permission checks
* chore: cleanup check impl
2018-08-28 09:05:08 -05:00
Siddharth Dalal
afdb6c5f90
feat: 'will-move' event for windows. ( #14283 )
...
* feat: 'will-resize' window event (Windows only)
* documentation for 'will-move' event
* comment and line break fix in docs
2018-08-28 08:44:10 -05:00
Milan Burda
f1fe485768
fix: don't expose desktopCapturer in sandboxed renderers if the feature is disabled ( #14310 )
2018-08-27 13:16:52 -05:00
Samuel Attard
a43a292d18
fix: dont parse arguments after a -- in the inspector ( #14297 )
2018-08-27 10:50:23 -07:00
Roller Bot
61462bdba2
chore: bump libcc (master) ( #14317 )
...
* chore: bump libcc submodule to 99c3a9966a9bef4a54b1740d9fed30ce78b4c421
* chore: bump libcc in DEPS to 99c3a9966a9bef4a54b1740d9fed30ce78b4c421
2018-08-27 10:21:20 -07:00
Milan Burda
a08ca9defb
fix: don't crash on tray.setContextMenu(null) ( #14322 )
2018-08-27 11:58:47 -05:00
John Kleinschmidt
fd27d75129
Merge pull request #14314 from electron/disable-a-test
...
test: disable "app moduele > app.exit(exitCode) > closes all windows"
2018-08-27 11:29:27 -04:00
Alexey Kuzmin
c8705625c9
build: windows gn linker fix ( #14281 )
...
* Fix to gn build linking
* chore: update node ref
* build: [gn win] add dependency on desktop_capture source_set in component build
* build: [gn] update definitions for node shared mode
* chore: update node ref
* chore: update node ref
2018-08-27 11:17:23 -04:00
Aleksei Kuzmin
4943f9fc14
tests: disable "app moduele > app.exit(exitCode) > closes all windows"
2018-08-27 16:21:12 +02:00
Milan Burda
edd1eaee5c
fix: don't expose view APIs when not enabled ( #14312 )
2018-08-27 08:03:46 +09:00
Aleksei Kuzmin
1293b463ba
tests: refactor "app module" tests
2018-08-26 16:54:51 +03:00
Samuel Attard
90545bda95
docs: explain "worldId" in the web frame docs ( #14309 )
...
Fixes #14288
2018-08-25 12:48:57 -07:00
Milan Burda
2a253c73db
refactor: use std::string instead of base::string16 for IPC channel names (ipcRenderer.sendTo) ( #14302 )
2018-08-24 15:30:10 -07:00
Emmanuel Kimmerlin
5f6706ac33
feat: BrowserWindow.getNormalBounds() ( #13290 )
...
* First commit
* Add Mac support (1st attempt)
* Add Mac support (2nd attempt)
* Simplify tests
* Restore window state !
* Looking at other tests, seems minimize, maximize, fullscreen are skipped when in CI
* Fix Mac tests
* Restore tests in CI
* Fix typo
* widget getRestoredBounds not working on Mac !!
* widget getRestoredBounds not working on Mac !!
* Add IsNormal function
* Add IsNormal
* IsNormal => isNormal
* Deactivate fullscreen on Mac. Do not receive leave-fullscreen event
* Set default original_frame_
* Set default original_frame_
* Fix Mac
2018-08-24 14:33:27 -07:00
Felix Rieseberg
872890ea5c
docs: Developer instructions for native Node addons ( #13121 )
...
* docs: Developer instructions for native Node addons
Credits for actually finding this easy method goes to @nornagon.
* 📝 Of course there's a typo
2018-08-24 14:28:11 -07:00
Leo MG Nesfield (LMGN)
519b57838a
Fix broken link ( #14301 )
2018-08-24 14:25:15 -07:00
Jeremy Apthorp
c452be02b9
refactor: properly report on skipped native modules tests ( #13894 )
2018-08-24 14:24:24 -07:00
Robin Andersson
4cf264f87a
fix: Brought win speechSynthesis up-to-speed ( #14070 )
...
The implementation was brought up-to-speed with Chromium 70.0.3522.1 (https://chromium.googlesource.com/chromium/src.git/+/70.0.3522.1/chrome/browser/speech/tts_win.cc ).
This to solve issues with Windows not returning voices (#11585 ).
2018-08-24 14:16:39 -07:00
Milan Burda
c23e7fa101
refactor: implement ipcRenderer.sendTo in native code for better performance ( #14285 )
2018-08-24 14:14:39 -07:00
Milan Burda
e6e3ccfc50
refactor: use std::string instead of base::string16 for IPC channel names ( #14286 )
2018-08-24 10:30:37 -05:00
John Kleinschmidt
605a4570c1
ci:Split out appveyor gn builds into separate jobs ( #14282 )
...
* Split out appveyor gn into separate jobs
2018-08-24 10:49:01 -04:00
Electron Bot
ef4ae27b52
Bump v4.0.0-nightly.20180823
2018-08-23 21:23:50 -07:00
Robo
bce5bd87a8
fix: opt into location services once device service has been started ( #14253 )
...
* fix: opt into location services once device service has been started
* refactor: provide fake location provider to mock geolocation reponses
* chore: add spec for navigator.geolocation api using fake location provider
2018-08-23 08:51:46 -07:00
Robo
c8f506a8aa
fix: add method and referrer properties to app login event ( #14231 )
...
* refactor: remove brightray/network_delegate.{cc|h}
* refactor: respond to http requests through network delegate
2018-08-23 18:55:13 +09:00
Cheng Zhao
6736d4ef29
fix: do not bubble up resize event from webview ( #14271 )
2018-08-23 15:42:35 +09:00
Cheng Zhao
cd8bb1d3b4
chore: print error when removed webview attribute is used ( #14230 )
...
* chore: print error when removed webview attribute is used
* docs: document removed webview features
2018-08-23 10:45:43 +09:00
Roller Bot
82b75f863d
chore: bump libcc (master) ( #14263 )
...
* chore: bump libcc submodule to c85470a1c379b1c4bedb372c146521bc4be9b75d
* chore: bump libcc in DEPS to c85470a1c379b1c4bedb372c146521bc4be9b75d
2018-08-22 19:44:13 -05:00
Robo
2d1b16b174
build: [gn] fix node header generation target in appveyor ( #14218 )
...
* build: [gn] fix node header generation target in appveyor
* build: fix tests run on AppVeyor
* build: [gn win] copy node.lib to node_headers on appveyor
* Fix verify-ffmpeg paths
2018-08-22 15:37:22 -04:00
Samuel Attard
7a514d26bb
fix: inheritance of webPreferences sub properties
2018-08-22 11:16:46 -05:00
John Kleinschmidt
5a72441b2a
build: build ffmpeg and native_mksnapshot for GN release builds ( #14240 )
...
* build ffmpeg and native_mksnapshot for GN release builds
* Test ffmpeg via verify-ffmpeg.py
* remove sccache from Windows builds
2018-08-22 11:41:25 -04:00
Charles Kerr
a2a7c6b062
chore: ask for specific info in bug templates ( #14229 )
...
* chore: ask for specific info in bug templates
* fix: change how version is asked for in bug template
2018-08-22 08:21:54 -07:00
Electron Bot
79eac1fdcb
Bump v4.0.0-nightly.20180821
2018-08-21 13:34:20 -07:00
Samuel Attard
4b33d083b2
chore: retry for the meta dumper a few times ( #14241 )
2018-08-21 13:29:44 -07:00
Samuel Attard
20423df112
Revert "Bump v4.0.0-nightly.20180821"
...
This reverts commit 73c43eaea7
.
2018-08-21 13:14:37 -07:00
Charles Kerr
e315e4d308
build: use electron-frameworks sccache ( #14171 )
...
* build: update-external-binaries fetches sccache
* build: add util.add_exec_bit in scripts/
* build: use util.add_exec_bit in create-dist
* build: use util.add_exec_bit in update-external-binaries
this is needed to work around a bug in python's zipfile module that doesn't preserve the exec bit
https://bugs.python.org/issue18262
* fix: linting errors
* build: vsts, circleci use patched sccache
* build: always look for the x64 sccache
as it's the only arch we have it on
* fix: windows-specific errors in updaste-external-binaries
* fix: tyop
* fix: set SCCACHE_BUCKET, SCCACHE_TWO_TIER on circleci
* fix: syntax error in circleci yaml
* fix: keep churning
* chore: add tracer to file downloader
* docs: add sccache instructions for GN builds
* build: pull down the darwin sccache on mas builds
* build: use gn sync verbosely on circleci and vsts
* docs: copyediting
* build: remove unnecessary cache-dir arg
* docs: fix shell quoting in gn build instructions
* fix: invoke gclient without -verbose in circleci
* refactor: remove debug tracer
* fix: invoke gclient without -verbose in appveyor
* fix: invoke gclient without -verbose in vsts
* fix: pull add_exec_bit from correct source
* fix: remove 'SCCACHE_TWO_TIER' from CI scripts
* refactor: remove SCCACHE_BUCKET from ci scripts
this environment variable will be set via the CI UI instead
* refactor: clarify log message
* fix: set SCCACHE_PATH correctly for Windows CI
2018-08-21 15:40:06 -04:00
Electron Bot
73c43eaea7
Bump v4.0.0-nightly.20180821
2018-08-21 11:55:32 -07:00
Samuel Attard
5d06c77bf1
Revert "Bump v4.0.0-nightly.20180821"
...
This reverts commit d2cd641381
.
2018-08-21 11:44:51 -07:00
Samuel Attard
776943218a
ci: add better logging around request failures for releasing ( #14239 )
2018-08-21 11:39:51 -07:00
Electron Bot
d2cd641381
Bump v4.0.0-nightly.20180821
2018-08-21 11:15:56 -07:00
Milan Burda
fc85d02786
feat: expose missing process APIs in sandboxed renderers ( #13505 )
2018-08-21 11:05:45 -07:00
Jeremy Apthorp
f82f89b2a3
build: [gn] add distributable zip target ( #14093 )
...
* build: [gn] add distributable zip target
* build: update the CircleCI config
- enable debug and testing builds on Mac
- run Mac release builds nightly
- run test for Mac release builds
- use shared build machines configs
* Add resources dir to zip on non mac platforms.
2018-08-21 13:06:28 -04:00
Milan Burda
7253c7f843
refactor: move SpecialStoragePolicy from brightray to atom ( #13944 )
2018-08-21 08:51:04 -07:00
Robo
fc730cc705
build: [gn mac] copy ffmpeg lib to framework bundle ( #14225 )
...
* build: [gn mac] copy ffmpeg lib to framework bundle
* Pull build config from enviroment variable
* build: use component ffmpeg in testing mode
2018-08-20 17:02:52 -04:00
Shelley Vohr
26925e6d48
chore: remove autorelease check logic ( #14220 )
2018-08-20 10:55:38 -07:00